Skip to content
This repository was archived by the owner on Jul 8, 2025. It is now read-only.

fix: implement server side pagination in frontend - #368

Merged
lxmcgvrn merged 17 commits into
mainfrom
fix/server-side-pagination
Mar 11, 2025
Merged

fix: implement server side pagination in frontend#368
lxmcgvrn merged 17 commits into
mainfrom
fix/server-side-pagination

Conversation

@lxmcgvrn

@lxmcgvrnlxmcgvrn commented Mar 4, 2025

Copy link
Copy Markdown
Contributor

Handles the API changes from:

Relates to stacklok/codegate#1020

Something important to call out is the backend doesn't support search/filtering by substring — I'm tracking this separately: [Task]: Investigate feasability of filtering workspace messages by substring in prompt

There is also some extra testing that can be done around the pagination UX, also tracked separately: [Task]: Follow up integration tests for messages pagination

@lxmcgvrnlxmcgvrn changed the title fix: server side paginationfix: implement server side pagination in frontendMar 4, 2025
@lxmcgvrn
lxmcgvrn marked this pull request as ready for review March 5, 2025 11:58
@coveralls

coveralls commented Mar 5, 2025

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 13786985073

Details

  • 107 of 164(65.24%) changed or added relevant lines in 20 files are covered.
  • 13 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-3.4%) to 66.498%

Changes Missing CoverageCovered LinesChanged/Added Lines%
src/api/generated/sdk.gen.ts91464.29%
src/features/dashboard-messages/hooks/use-messages-filter-search-params.ts61154.55%
src/features/dashboard-messages/components/table-messages-pagination.tsx51338.46%
src/api/generated/@tanstack/react-query.gen.ts246338.1%
Files with Coverage ReductionNew Missed Lines%
src/api/generated/sdk.gen.ts166.9%
src/constants/empty-state-strings.ts125.0%
src/mocks/msw/handlers.ts174.07%
src/api/generated/@tanstack/react-query.gen.ts459.5%
src/features/dashboard-messages/hooks/use-messages-filter-search-params.ts651.35%
TotalsCoverage Status
Change from base Build 13766424035:-3.4%
Covered Lines:896
Relevant Lines:1276

💛 - Coveralls

@lxmcgvrn
lxmcgvrn merged commit b730c4a into mainMar 11, 2025
@lxmcgvrn
lxmcgvrn deleted the fix/server-side-pagination branch March 11, 2025 11:36
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@lxmcgvrn@coveralls@peppescg