Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Enable provider model updating when updating provider itself - #1014
Merged
Conversation
This now calls the model updating logic when updating the provider itself. Thus allowing us to have a way to update the model list. Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
aponcedeleonch
suggested changes
Feb 12, 2025
aponcedeleonch
left a comment
Member
There was a problem hiding this comment.
We still need to update the models of a provider at server startup, i.e. in function initialize_provider_endpoints. Right now, if the provider already exists it will not try to get its models.
JAORMX
commented
Feb 12, 2025
ContributorAuthor
Mind if I do that in a separate PR? |
aponcedeleonch
approved these changes
Feb 12, 2025
aponcedeleonch
left a comment
Member
There was a problem hiding this comment.
Approved. The remaining functionality will be done in a separate PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This now calls the model updating logic when updating the provider
itself. Thus allowing us to have a way to update the model list.
Signed-off-by: Juan Antonio Osorio ozz@stacklok.com