Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

feat: remove not needed encryption of secrets - #1123

Merged
yrobla merged 9 commits into
mainfrom
issue-929
Mar 4, 2025
Merged

feat: remove not needed encryption of secrets#1123
yrobla merged 9 commits into
mainfrom
issue-929

Conversation

@yrobla

Copy link
Copy Markdown
Contributor

Instead use an uuid generator as we do for pii, and reuse same session store mechanism

Closes: #929

@yrobla
yrobla marked this pull request as draft February 20, 2025 10:49
@yrobla
yrobla marked this pull request as ready for review February 21, 2025 10:41
@yrobla
yrobla requested review from aponcedeleonch, jhrozek and lukehinds and removed request for aponcedeleonch and lukehindsFebruary 21, 2025 10:43

@blktblkt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments.

Comment threadsrc/codegate/pipeline/base.py
Comment threadsrc/codegate/pipeline/sensitive_data/manager.py Outdated
Comment threadsrc/codegate/pipeline/pii/pii.py Outdated
Comment threadsrc/codegate/pipeline/pii/pii.py Outdated
Comment threadsrc/codegate/pipeline/pii/pii.py Outdated
Comment threadsrc/codegate/pipeline/sensitive_data/manager.py Outdated
Comment threadsrc/codegate/pipeline/sensitive_data/manager.py Outdated
@yrobla
yrobla requested review from blkt and jhrozekFebruary 24, 2025 08:53
@yrobla
yroblaforce-pushed the issue-929 branch 6 times, most recently from da2f6a8 to 0861a59CompareFebruary 24, 2025 09:32
Comment threadsrc/codegate/pipeline/pii/pii.py Outdated
@yrobla
yrobla requested a review from jhrozekMarch 4, 2025 13:01
@yrobla
yrobla merged commit 58132ba into mainMar 4, 2025
@yrobla
yrobla deleted the issue-929 branch March 4, 2025 13:58
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor redaction mechanism to a single interface

3 participants

@yrobla@blkt@jhrozek