Uh oh!
There was an error while loading. Please reload this page.
shareable workspaces pt. 2 - #1233
Conversation
…get-full-workspace-config
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…get-full-workspace-config
…github.com:stacklok/codegate into endpoint-to-get-full-workspace-config
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
JAORMX
left a comment
There was a problem hiding this comment.
The main thing is the db schema changes
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…acklok/codegate into endpoint-to-get-full-workspace-config
…acklok/codegate into endpoint-to-get-full-workspace-config
lukehinds
left a comment
There was a problem hiding this comment.
Overall lgtm , do we need a db migration for the changes to db/models?
lxmcgvrn
commented
Mar 17, 2025
There were DB schema changes in a previous iteration, but we decided they were unnecessary, the only change to a DB model is this one: class ProviderModel(BaseModel):
provider_endpoint_id: str
+ provider_endpoint_type: str
provider_endpoint_name: Optional[str] = None
name: strWhich is populated via a JOIN — it's not the cleanest, but "it works"™️ |
Second part of #1067 — this adds a new endpoint
GET /api/v1/workspaces/:workspace_namethat returns a full workspace config.With this we have the prerequisites for a upload/download flow on a per-workspace basis.
These changes are integrated into the frontend in this PR: stacklok/codegate-ui#379
provider_endpoint_nameandprovider_endpoint_typeto themuxestableMuxRulemodel used by the API to includeprovider_typeandprovider_nameand removesprovider_idMuxRuleWithProviderIdmodel used internally for transportingmux rules
they don't require knowledge of the provider ID
GET /api/v1/workspaces/:provider_idwas already in use for listing providers in use by a workspace, but after speaking with @JAORMX we decided to move this elsewhere. You can achieve the same thing withGET /api/v1/workspaces?provider_name={ID}now insteaddealt with in a separate PR