Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Polish errors and miscelaneous fixes for workspaces - #649

Merged
JAORMX merged 5 commits into
stacklok:mainfrom
JAORMX:exceptions-workspace-activate
Jan 20, 2025
Merged

Polish errors and miscelaneous fixes for workspaces#649
JAORMX merged 5 commits into
stacklok:mainfrom
JAORMX:exceptions-workspace-activate

Conversation

@JAORMX

Copy link
Copy Markdown
Contributor

This raises specific errors which are then handled excplicitly. Thus
giving us more detailed error messages.

Signed-off-by: Juan Antonio Osorio ozz@stacklok.com

@JAORMX
JAORMX requested review from aponcedeleonch and lxmcgvrn and removed request for aponcedeleonchJanuary 20, 2025 08:33
@JAORMX
JAORMXforce-pushed the exceptions-workspace-activate branch from 3865dc1 to e449357CompareJanuary 20, 2025 08:43
This raises specific errors which are then handled excplicitly. Thus
giving us more detailed error messages.
Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
@JAORMX
JAORMXforce-pushed the exceptions-workspace-activate branch from e449357 to 263ec0cCompareJanuary 20, 2025 08:53
Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
@JAORMXJAORMX changed the title Polish errors in workspace activationPolish errors and miscelaneous fixes for workspacesJan 20, 2025

@aponcedeleonchaponcedeleonch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@JAORMX
JAORMX merged commit b78c6d9 into stacklok:mainJan 20, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@JAORMX@aponcedeleonch