Skip to content

Clarify lazy-mode deferred-login message - #5429

Merged
ChrisJBurns merged 1 commit into
mainfrom
chris/llm-lazy-message-wording
Jun 3, 2026
Merged

Clarify lazy-mode deferred-login message#5429
ChrisJBurns merged 1 commit into
mainfrom
chris/llm-lazy-message-wording

Conversation

@ChrisJBurns

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #5427 addressing review feedback (comment).

The thv llm setup --lazy message told the user they'd be "signed in automatically the first time a configured tool accesses the LLM gateway". As @jerm-dro noted, "signed in automatically" isn't quite accurate — the deferred login still opens a browser for the user to complete on the first request. This rewords the message so it accurately describes when login happens.

Before:

Lazy mode: skipping OIDC login. You'll be signed in automatically
the first time a configured tool accesses the LLM gateway.

After:

Lazy mode: skipping OIDC login. You'll be signed in on the first
request a configured tool makes to the LLM gateway.

Type of change

  • Documentation (user-facing message wording; no behavior change)

Test plan

  • Unit tests (task test) — pkg/llm, cmd/thv/app pass (updated the lazy-message assertion in setup_test.go)
  • task build passes
  • Manual: thv llm setup --lazy prints the reworded message

Does this introduce a user-facing change?

Yes — the wording of the thv llm setup --lazy informational message changes. No behavior change.

Generated with Claude Code

The lazy setup message said the user would be "signed in automatically",
which oversells it: the deferred login still opens a browser for the user
to complete on the first gateway request. Reword to "signed in on the
first request a configured tool makes to the LLM gateway" so the message
accurately describes when (and that) login happens.
Addresses review feedback on #5427.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ChrisJBurns
ChrisJBurns requested a review from JAORMX as a code ownerJune 3, 2026 16:31
@github-actionsgithub-actionsBot added the size/XS Extra small PR: < 100 lines changed label Jun 3, 2026
@codecov

codecovBot commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.85%. Comparing base (6ebadaf) to head (261bab5).

Additional details and impacted files
@@ Coverage Diff @@## main #5429 +/- ##
==========================================
- Coverage 68.86% 68.85% -0.02% 
==========================================
Files 634 634 Lines 64437 64437 ==========================================
- Hits 44377 44369 -8 - Misses 16782 16791 +9 + Partials 3278 3277 -1 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChrisJBurns
ChrisJBurns merged commit a785995 into mainJun 3, 2026
44 of 45 checks passed
@ChrisJBurns
ChrisJBurns deleted the chris/llm-lazy-message-wording branch June 3, 2026 17:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XSExtra small PR: < 100 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ChrisJBurns@jerm-dro