Use TerminableInterface

[jeromemacias]

Add UrlMap::terminate() method.

[jeromemacias]

Waiting for stackphp/CallableHttpKernel#3 to add missing tests.

[davedevelopment]

Do we need to terminate them based on them being matched? I'm not sure, related to stackphp/builder#14

[jeromemacias]

The goal of UrlMap stack is to manage only one matching app, so I think we should apply the same logic in handle() and terminate(), and ignore all non matching apps.

[davedevelopment]

But it's one matching app per request, the HttpCache middleware could and would fire multiple requests through the app before terminate happens.

[jeromemacias]

Good point ;) I updated the PR accordingly.

[jeromemacias]

I tested the UrlMap on a Silex project, with the WebProfiler provider which use the terminate kernel event. All seems good.

[davedevelopment]

Just thought of a really minor thing, perhaps we should keep track of the apps that have been terminated, something like:

$terminated = [];
foreach ($this->mapas$path => $app) {
if ($appinstanceof TerminableInterface && !in_array($app, $terminated, true)) {
$app->terminate($request, $response);
$terminated[] = $app;
}
}

Not sure if that would be overkill. I personally think terminate should be idempotent, so shouldn't matter.

[davedevelopment]

Other than that, let's

[igorw]

this should no longer be needed

[CHH]

Thanks!