Skip to content

Include openshift-4.12 schema - #201

Merged
mclasmeier merged 3 commits into
mainfrom
mc/openshift-4.12-schema
Apr 9, 2026
Merged

Include openshift-4.12 schema#201
mclasmeier merged 3 commits into
mainfrom
mc/openshift-4.12-schema

Conversation

@mclasmeier

@mclasmeiermclasmeier commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

This is coming from the most recent 4.12.z release (currently 4.12.87).
OpenShift 4.12 is currently in the extended support phase in its lifecycle.

Generated using

 oc get --raw /openapi/v2 | jq --sort-keys 'del(.parameters, .paths[], .security, .securityDefinitions)' | \
sed -Ee 's/(Authorization: Bearer sha256)~[^ ]*/\1~REDACTED/;'

Note, the sed part was required because otherwise the pre-commit check would have caught an example token in the included documentation.

This is coming from the most recent 4.12.z release (currently 4.12.87).
Generated using
oc get --raw /openapi/v2 | jq --sort-keys 'del(.parameters, .paths[], .security, .securityDefinitions)' | sed -Ee 's/(Authorization: Bearer sha256)~[^ ]*/\1~REDACTED/;'
@mclasmeier
mclasmeier requested a review from a team as a code ownerApril 8, 2026 10:06
@mclasmeier
mclasmeier requested review from porridge and removed request for a teamApril 8, 2026 10:06
@porridge

porridge commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Since this is not released yet, we probably should force push master to f48c059 to remove the uncompressed file so we don't drag it around in the history forever.

Comment threadinternal/schemas/openapi-schemas/README.md
@porridgeporridge mentioned this pull request Apr 8, 2026
@mclasmeiermclasmeier changed the title Mc/openshift 4.12 schema: Forgot to compress the fileInclude openshift-4.12 schemaApr 8, 2026
@mclasmeier
mclasmeier requested a review from porridgeApril 8, 2026 12:01
mclasmeier added a commit to stackrox/stackrox that referenced this pull request Apr 8, 2026
This temporarily points to stackrox/helmtest PR #201 which adds
the openshift-4.12 schema needed for the updated tests.
Reference: stackrox/helmtest#201
mclasmeier added a commit to stackrox/stackrox that referenced this pull request Apr 8, 2026
This temporarily points to stackrox/helmtest PR #201 which adds
the openshift-4.12 schema needed for the updated tests.
Reference: stackrox/helmtest#201
mclasmeier added a commit to stackrox/stackrox that referenced this pull request Apr 8, 2026
This temporarily points to stackrox/helmtest PR #201 which adds
the openshift-4.12 schema needed for the updated tests.
Reference: stackrox/helmtest#201
mclasmeier added a commit to stackrox/stackrox that referenced this pull request Apr 8, 2026
This temporarily points to stackrox/helmtest PR #201 which adds
the openshift-4.12 schema needed for the updated tests.
Reference: stackrox/helmtest#201
mclasmeier added a commit to stackrox/stackrox that referenced this pull request Apr 8, 2026
This temporarily points to stackrox/helmtest PR #201 which adds
the openshift-4.12 schema needed for the updated tests.
Reference: stackrox/helmtest#201

@vladbologavladbologa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the uncompressed internal/schemas/openapi-schemas/openshift-4.12.json added in #200 be removed?

@mclasmeier

Copy link
Copy Markdown
ContributorAuthor

Shouldn't the uncompressed internal/schemas/openapi-schemas/openshift-4.12.json added in #200 be removed?

Not necessary -- @porridge did some magic on the repo so that the uncompressed file is gone entirely, not even tracked in history.

@mclasmeier
mclasmeier merged commit b92b50e into mainApr 9, 2026
2 checks passed
@mclasmeier
mclasmeier deleted the mc/openshift-4.12-schema branch April 9, 2026 06:22
mclasmeier added a commit to stackrox/stackrox that referenced this pull request Apr 9, 2026
This temporarily points to stackrox/helmtest PR #201 which adds
the openshift-4.12 schema needed for the updated tests.
Reference: stackrox/helmtest#201
mclasmeier added a commit to stackrox/stackrox that referenced this pull request Apr 9, 2026
This temporarily points to stackrox/helmtest PR #201 which adds
the openshift-4.12 schema needed for the updated tests.
Reference: stackrox/helmtest#201
mclasmeier added a commit to stackrox/stackrox that referenced this pull request Apr 9, 2026
This temporarily points to stackrox/helmtest PR #201 which adds
the openshift-4.12 schema needed for the updated tests.
Reference: stackrox/helmtest#201
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mclasmeier@porridge@vladbologa