Skip to content

ROX-35590: Expose gcp-project as parameter for gke-default flavor - #1893

Draft
tommartensen wants to merge 1 commit into
masterfrom
tm/ROX-35590-gke-project
Draft

ROX-35590: Expose gcp-project as parameter for gke-default flavor#1893
tommartensen wants to merge 1 commit into
masterfrom
tm/ROX-35590-gke-project

Conversation

@tommartensen

@tommartensentommartensen commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@tommartensentommartensen self-assigned this Jul 27, 2026
@coderabbitai

coderabbitaiBot commented Jul 27, 2026•
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: ce7287c6-3d2f-4596-8c84-4f9db3a0393c

📥 Commits

Reviewing files that changed from the base of the PR and between 299a1d6 and e7c92a4.

📒 Files selected for processing (4)
  • chart/infra-server/static/flavors.yaml
  • chart/infra-server/static/janitor-delete-gke-default.yaml
  • chart/infra-server/static/test-gke-lite.yaml
  • chart/infra-server/static/workflow-gke-default.yaml
🚧 Files skipped from review as they are similar to previous changes (3)
  • chart/infra-server/static/test-gke-lite.yaml
  • chart/infra-server/static/workflow-gke-default.yaml
  • chart/infra-server/static/janitor-delete-gke-default.yaml
📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • Added an optional gcp-project setting for GKE deployment workflows.
    • The default GKE configuration uses acs-team-temp-dev when no project is specified.
    • Create, test, and cleanup workflows now use the selected Google Cloud project.
    • Testing workflows can accept the project as an input instead of relying on a fixed value.

Walkthrough

Changes

The GKE flavors now expose a configurable gcp-project parameter, and related workflows pass it to GKE create and destroy commands instead of using a hardcoded project.

GKE project parameterization

Layer / File(s)Summary
Project parameter contract
chart/infra-server/static/flavors.yaml		Adds optional gcp-project parameters with default value acs-team-temp-dev to the GKE-related flavors.
Workflow project wiring
chart/infra-server/static/janitor-delete-gke-default.yaml, chart/infra-server/static/test-gke-lite.yaml, chart/infra-server/static/workflow-gke-default.yaml		Adds workflow inputs and passes them to GKE create and destroy commands.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers:bradlugo, davdhacs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check nameStatusExplanationResolution
Description check❓ InconclusiveNo pull request description was provided, so there is nothing to assess for relatedness.Add a short description summarizing the workflow and flavor parameter changes.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title matches the main change: making gcp-project configurable for the gke-default flavor.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tm/ROX-35590-gke-project

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitaiBot reviewed Jul 27, 2026
View reviewed changes

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@chart/infra-server/static/flavors.yaml`:
- Around line 187-191: The GKE janitor and test workflows lack the gcp-project
contract and do not propagate the project value. In
chart/infra-server/static/flavors.yaml lines 187-191, add matching gcp-project
parameters to janitor-delete-gke-default and test-gke-lite; in
chart/infra-server/static/janitor-delete-gke-default.yaml lines 12-13 and 36,
receive the flavor value and pass it to destroy; in
chart/infra-server/static/test-gke-lite.yaml lines 21-22, 77, and 100, receive
the value and pass it to create and destroy.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 495eb4b4-a7f7-4c65-90df-b1d746b67dbc

📥 Commits

Reviewing files that changed from the base of the PR and between c3d91a7 and 299a1d6.

📒 Files selected for processing (4)
  • chart/infra-server/static/flavors.yaml
  • chart/infra-server/static/janitor-delete-gke-default.yaml
  • chart/infra-server/static/test-gke-lite.yaml
  • chart/infra-server/static/workflow-gke-default.yaml

Comment threadchart/infra-server/static/flavors.yaml
@rhacs-bot

rhacs-bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

A single node development cluster (infra-pr-1893) was allocated in production infra for this PR.

CI will attempt to deploy quay.io/rhacs-eng/infra-server: to it.

🔌 You can connect to this cluster with:

gcloud container clusters get-credentials infra-pr-1893 --zone us-central1-a --project acs-team-temp-dev

🛠️ And pull infractl from the deployed dev infra-server with:

nohup kubectl -n infra port-forward svc/infra-server-service 8443:8443 &
make pull-infractl-from-dev-server

🔓 You must go to to export an . Your token from the prod infra instance will not work with dev environments.

🚲 You can then use the dev infra instance e.g.:

bin/infractl -k -e localhost:8443 whoami

⚠️Any clusters that you start using your dev infra instance should have a lifespan shorter then the development cluster instance. Otherwise they will not be destroyed when the dev infra instance ceases to exist when the development cluster is deleted.⚠️

Further Development

☕ If you make changes, you can commit and push and CI will take care of updating the development cluster.

🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with:

make helm-deploy

Logs

Logs for the development infra depending on your @redhat.com authuser:

Or:

kubectl -n infra logs -l app=infra-server --tail=1 -f

@tommartensen
tommartensenforce-pushed the tm/ROX-35590-gke-project branch from 299a1d6 to e7c92a4CompareJuly 27, 2026 13:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@rhacs-botrhacs-botAwaiting requested review from rhacs-botrhacs-bot will be requested when the pull request is marked ready for reviewrhacs-bot is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@tommartensentommartensen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tommartensen@rhacs-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
ROX-35590: Expose gcp-project as parameter for gke-default flavor by tommartensen · Pull Request #1893 · stackrox/infra · GitHub
Skip to content
ROX-35590: Expose gcp-project as parameter for gke-default flavor - #1893
Draft
tommartensen wants to merge 1 commit into
masterfrom 
tm/ROX-35590-gke-project
Draft
ROX-35590: Expose gcp-project as parameter for gke-default flavor#1893
tommartensen wants to merge 1 commit into
masterfrom 
tm/ROX-35590-gke-project
Conversation
@tommartensen
@tommartensentommartensen
commented
Jul 27, 2026

Copy link


Copy Markdown

Contributor
 No description provided. 
@tommartensentommartensen
self-assigned this
Jul 27, 2026
@coderabbitai
coderabbitaiBot
commented
Jul 27, 2026•

edited

Loading

Copy link


Copy Markdown

Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: ce7287c6-3d2f-4596-8c84-4f9db3a0393c
📥 Commits
Reviewing files that changed from the base of the PR and between 299a1d6 and e7c92a4.
📒 Files selected for processing (4)
  • chart/infra-server/static/flavors.yaml
  • chart/infra-server/static/janitor-delete-gke-default.yaml
  • chart/infra-server/static/test-gke-lite.yaml
  • chart/infra-server/static/workflow-gke-default.yaml
🚧 Files skipped from review as they are similar to previous changes (3)
  • chart/infra-server/static/test-gke-lite.yaml
  • chart/infra-server/static/workflow-gke-default.yaml
  • chart/infra-server/static/janitor-delete-gke-default.yaml
📝 Walkthrough
Summary by CodeRabbit
  • New Features
    • Added an optional gcp-project setting for GKE deployment workflows.
    • The default GKE configuration uses acs-team-temp-dev when no project is specified.
    • Create, test, and cleanup workflows now use the selected Google Cloud project.
    • Testing workflows can accept the project as an input instead of relying on a fixed value.
Walkthrough
Changes
The GKE flavors now expose a configurable gcp-project parameter, and related workflows pass it to GKE create and destroy commands instead of using a hardcoded project.
GKE project parameterization
Layer / File(s)Summary
Project parameter contract
chart/infra-server/static/flavors.yaml		Adds optional gcp-project parameters with default value acs-team-temp-dev to the GKE-related flavors.
Workflow project wiring
chart/infra-server/static/janitor-delete-gke-default.yaml, chart/infra-server/static/test-gke-lite.yaml, chart/infra-server/static/workflow-gke-default.yaml		Adds workflow inputs and passes them to GKE create and destroy commands.
Estimated code review effort: 2 (Simple) | ~10 minutes
Suggested reviewers:bradlugo, davdhacs
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check nameStatusExplanationResolution
Description check❓ InconclusiveNo pull request description was provided, so there is nothing to assess for relatedness.Add a short description summarizing the workflow and flavor parameter changes.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title matches the main change: making gcp-project configurable for the gke-default flavor.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch tm/ROX-35590-gke-project
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
coderabbitai[bot]
coderabbitaiBot
reviewed
Jul 27, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@chart/infra-server/static/flavors.yaml`:
- Around line 187-191: The GKE janitor and test workflows lack the gcp-project
contract and do not propagate the project value. In
chart/infra-server/static/flavors.yaml lines 187-191, add matching gcp-project
parameters to janitor-delete-gke-default and test-gke-lite; in
chart/infra-server/static/janitor-delete-gke-default.yaml lines 12-13 and 36,
receive the flavor value and pass it to destroy; in
chart/infra-server/static/test-gke-lite.yaml lines 21-22, 77, and 100, receive
the value and pass it to create and destroy.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 495eb4b4-a7f7-4c65-90df-b1d746b67dbc
📥 Commits
Reviewing files that changed from the base of the PR and between c3d91a7 and 299a1d6.
📒 Files selected for processing (4)
  • chart/infra-server/static/flavors.yaml
  • chart/infra-server/static/janitor-delete-gke-default.yaml
  • chart/infra-server/static/test-gke-lite.yaml
  • chart/infra-server/static/workflow-gke-default.yaml
Comment threadchart/infra-server/static/flavors.yaml
@rhacs-bot
rhacs-bot
commented
Jul 27, 2026

Copy link


Copy Markdown

Contributor
A single node development cluster (infra-pr-1893) was allocated in production infra for this PR.
CI will attempt to deploy quay.io/rhacs-eng/infra-server: to it.
🔌 You can connect to this cluster with:
gcloud container clusters get-credentials infra-pr-1893 --zone us-central1-a --project acs-team-temp-dev

🛠️ And pull infractl from the deployed dev infra-server with:
nohup kubectl -n infra port-forward svc/infra-server-service 8443:8443 &
make pull-infractl-from-dev-server

🔓 You must go to to export an . Your token from the prod infra instance will not work with dev environments.
🚲 You can then use the dev infra instance e.g.:
bin/infractl -k -e localhost:8443 whoami

⚠️Any clusters that you start using your dev infra instance should have a lifespan shorter then the development cluster instance. Otherwise they will not be destroyed when the dev infra instance ceases to exist when the development cluster is deleted.⚠️
Further Development
☕ If you make changes, you can commit and push and CI will take care of updating the development cluster.
🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with:
make helm-deploy

Logs
Logs for the development infra depending on your @redhat.com authuser:
Or:
kubectl -n infra logs -l app=infra-server --tail=1 -f

@tommartensen
tommartensenforce-pushed
the
tm/ROX-35590-gke-project
branch
from
299a1d6 to
e7c92a4CompareJuly 27, 2026 13:53
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@rhacs-botrhacs-botAwaiting requested review from rhacs-botrhacs-bot will be requested when the pull request is marked ready for reviewrhacs-bot is a code owner

At least 1 approving review is required to merge this pull request.


Assignees

@tommartensentommartensen

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tommartensen@rhacs-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
ROX-35590: Expose gcp-project as parameter for gke-default flavor by tommartensen · Pull Request #1893 · stackrox/infra · GitHub
Skip to content
ROX-35590: Expose gcp-project as parameter for gke-default flavor - #1893
Draft
tommartensen wants to merge 1 commit into
masterfrom 
tm/ROX-35590-gke-project
Draft
ROX-35590: Expose gcp-project as parameter for gke-default flavor#1893
tommartensen wants to merge 1 commit into
masterfrom 
tm/ROX-35590-gke-project
Conversation
@tommartensen
@tommartensentommartensen
commented
Jul 27, 2026

Copy link


Copy Markdown

Contributor
 No description provided. 
@tommartensentommartensen
self-assigned this
Jul 27, 2026
@coderabbitai
coderabbitaiBot
commented
Jul 27, 2026•

edited

Loading

Copy link


Copy Markdown

Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: ce7287c6-3d2f-4596-8c84-4f9db3a0393c
📥 Commits
Reviewing files that changed from the base of the PR and between 299a1d6 and e7c92a4.
📒 Files selected for processing (4)
  • chart/infra-server/static/flavors.yaml
  • chart/infra-server/static/janitor-delete-gke-default.yaml
  • chart/infra-server/static/test-gke-lite.yaml
  • chart/infra-server/static/workflow-gke-default.yaml
🚧 Files skipped from review as they are similar to previous changes (3)
  • chart/infra-server/static/test-gke-lite.yaml
  • chart/infra-server/static/workflow-gke-default.yaml
  • chart/infra-server/static/janitor-delete-gke-default.yaml
📝 Walkthrough
Summary by CodeRabbit
  • New Features
    • Added an optional gcp-project setting for GKE deployment workflows.
    • The default GKE configuration uses acs-team-temp-dev when no project is specified.
    • Create, test, and cleanup workflows now use the selected Google Cloud project.
    • Testing workflows can accept the project as an input instead of relying on a fixed value.
Walkthrough
Changes
The GKE flavors now expose a configurable gcp-project parameter, and related workflows pass it to GKE create and destroy commands instead of using a hardcoded project.
GKE project parameterization
Layer / File(s)Summary
Project parameter contract
chart/infra-server/static/flavors.yaml		Adds optional gcp-project parameters with default value acs-team-temp-dev to the GKE-related flavors.
Workflow project wiring
chart/infra-server/static/janitor-delete-gke-default.yaml, chart/infra-server/static/test-gke-lite.yaml, chart/infra-server/static/workflow-gke-default.yaml		Adds workflow inputs and passes them to GKE create and destroy commands.
Estimated code review effort: 2 (Simple) | ~10 minutes
Suggested reviewers:bradlugo, davdhacs
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check nameStatusExplanationResolution
Description check❓ InconclusiveNo pull request description was provided, so there is nothing to assess for relatedness.Add a short description summarizing the workflow and flavor parameter changes.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title matches the main change: making gcp-project configurable for the gke-default flavor.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch tm/ROX-35590-gke-project
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
coderabbitai[bot]
coderabbitaiBot
reviewed
Jul 27, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@chart/infra-server/static/flavors.yaml`:
- Around line 187-191: The GKE janitor and test workflows lack the gcp-project
contract and do not propagate the project value. In
chart/infra-server/static/flavors.yaml lines 187-191, add matching gcp-project
parameters to janitor-delete-gke-default and test-gke-lite; in
chart/infra-server/static/janitor-delete-gke-default.yaml lines 12-13 and 36,
receive the flavor value and pass it to destroy; in
chart/infra-server/static/test-gke-lite.yaml lines 21-22, 77, and 100, receive
the value and pass it to create and destroy.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 495eb4b4-a7f7-4c65-90df-b1d746b67dbc
📥 Commits
Reviewing files that changed from the base of the PR and between c3d91a7 and 299a1d6.
📒 Files selected for processing (4)
  • chart/infra-server/static/flavors.yaml
  • chart/infra-server/static/janitor-delete-gke-default.yaml
  • chart/infra-server/static/test-gke-lite.yaml
  • chart/infra-server/static/workflow-gke-default.yaml
Comment threadchart/infra-server/static/flavors.yaml
@rhacs-bot
rhacs-bot
commented
Jul 27, 2026

Copy link


Copy Markdown

Contributor
A single node development cluster (infra-pr-1893) was allocated in production infra for this PR.
CI will attempt to deploy quay.io/rhacs-eng/infra-server: to it.
🔌 You can connect to this cluster with:
gcloud container clusters get-credentials infra-pr-1893 --zone us-central1-a --project acs-team-temp-dev

🛠️ And pull infractl from the deployed dev infra-server with:
nohup kubectl -n infra port-forward svc/infra-server-service 8443:8443 &
make pull-infractl-from-dev-server

🔓 You must go to to export an . Your token from the prod infra instance will not work with dev environments.
🚲 You can then use the dev infra instance e.g.:
bin/infractl -k -e localhost:8443 whoami

⚠️Any clusters that you start using your dev infra instance should have a lifespan shorter then the development cluster instance. Otherwise they will not be destroyed when the dev infra instance ceases to exist when the development cluster is deleted.⚠️
Further Development
☕ If you make changes, you can commit and push and CI will take care of updating the development cluster.
🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with:
make helm-deploy

Logs
Logs for the development infra depending on your @redhat.com authuser:
Or:
kubectl -n infra logs -l app=infra-server --tail=1 -f

@tommartensen
tommartensenforce-pushed
the
tm/ROX-35590-gke-project
branch
from
299a1d6 to
e7c92a4CompareJuly 27, 2026 13:53
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@rhacs-botrhacs-botAwaiting requested review from rhacs-botrhacs-bot will be requested when the pull request is marked ready for reviewrhacs-bot is a code owner

At least 1 approving review is required to merge this pull request.


Assignees

@tommartensentommartensen

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tommartensen@rhacs-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
ROX-35590: Expose gcp-project as parameter for gke-default flavor by tommartensen · Pull Request #1893 · stackrox/infra · GitHub
Skip to content
ROX-35590: Expose gcp-project as parameter for gke-default flavor - #1893
Draft
tommartensen wants to merge 1 commit into
masterfrom 
tm/ROX-35590-gke-project
Draft
ROX-35590: Expose gcp-project as parameter for gke-default flavor#1893
tommartensen wants to merge 1 commit into
masterfrom 
tm/ROX-35590-gke-project
Conversation
@tommartensen
@tommartensentommartensen
commented
Jul 27, 2026

Copy link


Copy Markdown

Contributor
 No description provided. 
@tommartensentommartensen
self-assigned this
Jul 27, 2026
@coderabbitai
coderabbitaiBot
commented
Jul 27, 2026•

edited

Loading

Copy link


Copy Markdown

Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: ce7287c6-3d2f-4596-8c84-4f9db3a0393c
📥 Commits
Reviewing files that changed from the base of the PR and between 299a1d6 and e7c92a4.
📒 Files selected for processing (4)
  • chart/infra-server/static/flavors.yaml
  • chart/infra-server/static/janitor-delete-gke-default.yaml
  • chart/infra-server/static/test-gke-lite.yaml
  • chart/infra-server/static/workflow-gke-default.yaml
🚧 Files skipped from review as they are similar to previous changes (3)
  • chart/infra-server/static/test-gke-lite.yaml
  • chart/infra-server/static/workflow-gke-default.yaml
  • chart/infra-server/static/janitor-delete-gke-default.yaml
📝 Walkthrough
Summary by CodeRabbit
  • New Features
    • Added an optional gcp-project setting for GKE deployment workflows.
    • The default GKE configuration uses acs-team-temp-dev when no project is specified.
    • Create, test, and cleanup workflows now use the selected Google Cloud project.
    • Testing workflows can accept the project as an input instead of relying on a fixed value.
Walkthrough
Changes
The GKE flavors now expose a configurable gcp-project parameter, and related workflows pass it to GKE create and destroy commands instead of using a hardcoded project.
GKE project parameterization
Layer / File(s)Summary
Project parameter contract
chart/infra-server/static/flavors.yaml		Adds optional gcp-project parameters with default value acs-team-temp-dev to the GKE-related flavors.
Workflow project wiring
chart/infra-server/static/janitor-delete-gke-default.yaml, chart/infra-server/static/test-gke-lite.yaml, chart/infra-server/static/workflow-gke-default.yaml		Adds workflow inputs and passes them to GKE create and destroy commands.
Estimated code review effort: 2 (Simple) | ~10 minutes
Suggested reviewers:bradlugo, davdhacs
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check nameStatusExplanationResolution
Description check❓ InconclusiveNo pull request description was provided, so there is nothing to assess for relatedness.Add a short description summarizing the workflow and flavor parameter changes.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title matches the main change: making gcp-project configurable for the gke-default flavor.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch tm/ROX-35590-gke-project
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
coderabbitai[bot]
coderabbitaiBot
reviewed
Jul 27, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@chart/infra-server/static/flavors.yaml`:
- Around line 187-191: The GKE janitor and test workflows lack the gcp-project
contract and do not propagate the project value. In
chart/infra-server/static/flavors.yaml lines 187-191, add matching gcp-project
parameters to janitor-delete-gke-default and test-gke-lite; in
chart/infra-server/static/janitor-delete-gke-default.yaml lines 12-13 and 36,
receive the flavor value and pass it to destroy; in
chart/infra-server/static/test-gke-lite.yaml lines 21-22, 77, and 100, receive
the value and pass it to create and destroy.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 495eb4b4-a7f7-4c65-90df-b1d746b67dbc
📥 Commits
Reviewing files that changed from the base of the PR and between c3d91a7 and 299a1d6.
📒 Files selected for processing (4)
  • chart/infra-server/static/flavors.yaml
  • chart/infra-server/static/janitor-delete-gke-default.yaml
  • chart/infra-server/static/test-gke-lite.yaml
  • chart/infra-server/static/workflow-gke-default.yaml
Comment threadchart/infra-server/static/flavors.yaml
@rhacs-bot
rhacs-bot
commented
Jul 27, 2026

Copy link


Copy Markdown

Contributor
A single node development cluster (infra-pr-1893) was allocated in production infra for this PR.
CI will attempt to deploy quay.io/rhacs-eng/infra-server: to it.
🔌 You can connect to this cluster with:
gcloud container clusters get-credentials infra-pr-1893 --zone us-central1-a --project acs-team-temp-dev

🛠️ And pull infractl from the deployed dev infra-server with:
nohup kubectl -n infra port-forward svc/infra-server-service 8443:8443 &
make pull-infractl-from-dev-server

🔓 You must go to to export an . Your token from the prod infra instance will not work with dev environments.
🚲 You can then use the dev infra instance e.g.:
bin/infractl -k -e localhost:8443 whoami

⚠️Any clusters that you start using your dev infra instance should have a lifespan shorter then the development cluster instance. Otherwise they will not be destroyed when the dev infra instance ceases to exist when the development cluster is deleted.⚠️
Further Development
☕ If you make changes, you can commit and push and CI will take care of updating the development cluster.
🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with:
make helm-deploy

Logs
Logs for the development infra depending on your @redhat.com authuser:
Or:
kubectl -n infra logs -l app=infra-server --tail=1 -f

@tommartensen
tommartensenforce-pushed
the
tm/ROX-35590-gke-project
branch
from
299a1d6 to
e7c92a4CompareJuly 27, 2026 13:53
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@rhacs-botrhacs-botAwaiting requested review from rhacs-botrhacs-bot will be requested when the pull request is marked ready for reviewrhacs-bot is a code owner

At least 1 approving review is required to merge this pull request.


Assignees

@tommartensentommartensen

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tommartensen@rhacs-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
ROX-35590: Expose gcp-project as parameter for gke-default flavor by tommartensen · Pull Request #1893 · stackrox/infra · GitHub
Skip to content
ROX-35590: Expose gcp-project as parameter for gke-default flavor - #1893
Draft
tommartensen wants to merge 1 commit into
masterfrom 
tm/ROX-35590-gke-project
Draft
ROX-35590: Expose gcp-project as parameter for gke-default flavor#1893
tommartensen wants to merge 1 commit into
masterfrom 
tm/ROX-35590-gke-project
Conversation
@tommartensen
@tommartensentommartensen
commented
Jul 27, 2026

Copy link


Copy Markdown

Contributor
 No description provided. 
@tommartensentommartensen
self-assigned this
Jul 27, 2026
@coderabbitai
coderabbitaiBot
commented
Jul 27, 2026•

edited

Loading

Copy link


Copy Markdown

Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: ce7287c6-3d2f-4596-8c84-4f9db3a0393c
📥 Commits
Reviewing files that changed from the base of the PR and between 299a1d6 and e7c92a4.
📒 Files selected for processing (4)
  • chart/infra-server/static/flavors.yaml
  • chart/infra-server/static/janitor-delete-gke-default.yaml
  • chart/infra-server/static/test-gke-lite.yaml
  • chart/infra-server/static/workflow-gke-default.yaml
🚧 Files skipped from review as they are similar to previous changes (3)
  • chart/infra-server/static/test-gke-lite.yaml
  • chart/infra-server/static/workflow-gke-default.yaml
  • chart/infra-server/static/janitor-delete-gke-default.yaml
📝 Walkthrough
Summary by CodeRabbit
  • New Features
    • Added an optional gcp-project setting for GKE deployment workflows.
    • The default GKE configuration uses acs-team-temp-dev when no project is specified.
    • Create, test, and cleanup workflows now use the selected Google Cloud project.
    • Testing workflows can accept the project as an input instead of relying on a fixed value.
Walkthrough
Changes
The GKE flavors now expose a configurable gcp-project parameter, and related workflows pass it to GKE create and destroy commands instead of using a hardcoded project.
GKE project parameterization
Layer / File(s)Summary
Project parameter contract
chart/infra-server/static/flavors.yaml		Adds optional gcp-project parameters with default value acs-team-temp-dev to the GKE-related flavors.
Workflow project wiring
chart/infra-server/static/janitor-delete-gke-default.yaml, chart/infra-server/static/test-gke-lite.yaml, chart/infra-server/static/workflow-gke-default.yaml		Adds workflow inputs and passes them to GKE create and destroy commands.
Estimated code review effort: 2 (Simple) | ~10 minutes
Suggested reviewers:bradlugo, davdhacs
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check nameStatusExplanationResolution
Description check❓ InconclusiveNo pull request description was provided, so there is nothing to assess for relatedness.Add a short description summarizing the workflow and flavor parameter changes.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title matches the main change: making gcp-project configurable for the gke-default flavor.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch tm/ROX-35590-gke-project
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
coderabbitai[bot]
coderabbitaiBot
reviewed
Jul 27, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@chart/infra-server/static/flavors.yaml`:
- Around line 187-191: The GKE janitor and test workflows lack the gcp-project
contract and do not propagate the project value. In
chart/infra-server/static/flavors.yaml lines 187-191, add matching gcp-project
parameters to janitor-delete-gke-default and test-gke-lite; in
chart/infra-server/static/janitor-delete-gke-default.yaml lines 12-13 and 36,
receive the flavor value and pass it to destroy; in
chart/infra-server/static/test-gke-lite.yaml lines 21-22, 77, and 100, receive
the value and pass it to create and destroy.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 495eb4b4-a7f7-4c65-90df-b1d746b67dbc
📥 Commits
Reviewing files that changed from the base of the PR and between c3d91a7 and 299a1d6.
📒 Files selected for processing (4)
  • chart/infra-server/static/flavors.yaml
  • chart/infra-server/static/janitor-delete-gke-default.yaml
  • chart/infra-server/static/test-gke-lite.yaml
  • chart/infra-server/static/workflow-gke-default.yaml
Comment threadchart/infra-server/static/flavors.yaml
@rhacs-bot
rhacs-bot
commented
Jul 27, 2026

Copy link


Copy Markdown

Contributor
A single node development cluster (infra-pr-1893) was allocated in production infra for this PR.
CI will attempt to deploy quay.io/rhacs-eng/infra-server: to it.
🔌 You can connect to this cluster with:
gcloud container clusters get-credentials infra-pr-1893 --zone us-central1-a --project acs-team-temp-dev

🛠️ And pull infractl from the deployed dev infra-server with:
nohup kubectl -n infra port-forward svc/infra-server-service 8443:8443 &
make pull-infractl-from-dev-server

🔓 You must go to to export an . Your token from the prod infra instance will not work with dev environments.
🚲 You can then use the dev infra instance e.g.:
bin/infractl -k -e localhost:8443 whoami

⚠️Any clusters that you start using your dev infra instance should have a lifespan shorter then the development cluster instance. Otherwise they will not be destroyed when the dev infra instance ceases to exist when the development cluster is deleted.⚠️
Further Development
☕ If you make changes, you can commit and push and CI will take care of updating the development cluster.
🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with:
make helm-deploy

Logs
Logs for the development infra depending on your @redhat.com authuser:
Or:
kubectl -n infra logs -l app=infra-server --tail=1 -f

@tommartensen
tommartensenforce-pushed
the
tm/ROX-35590-gke-project
branch
from
299a1d6 to
e7c92a4CompareJuly 27, 2026 13:53
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@rhacs-botrhacs-botAwaiting requested review from rhacs-botrhacs-bot will be requested when the pull request is marked ready for reviewrhacs-bot is a code owner

At least 1 approving review is required to merge this pull request.


Assignees

@tommartensentommartensen

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tommartensen@rhacs-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
ROX-35590: Expose gcp-project as parameter for gke-default flavor by tommartensen · Pull Request #1893 · stackrox/infra · GitHub
Skip to content
ROX-35590: Expose gcp-project as parameter for gke-default flavor - #1893
Draft
tommartensen wants to merge 1 commit into
masterfrom 
tm/ROX-35590-gke-project
Draft
ROX-35590: Expose gcp-project as parameter for gke-default flavor#1893
tommartensen wants to merge 1 commit into
masterfrom 
tm/ROX-35590-gke-project
Conversation
@tommartensen
@tommartensentommartensen
commented
Jul 27, 2026

Copy link


Copy Markdown

Contributor
 No description provided. 
@tommartensentommartensen
self-assigned this
Jul 27, 2026
@coderabbitai
coderabbitaiBot
commented
Jul 27, 2026•

edited

Loading

Copy link


Copy Markdown

Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: ce7287c6-3d2f-4596-8c84-4f9db3a0393c
📥 Commits
Reviewing files that changed from the base of the PR and between 299a1d6 and e7c92a4.
📒 Files selected for processing (4)
  • chart/infra-server/static/flavors.yaml
  • chart/infra-server/static/janitor-delete-gke-default.yaml
  • chart/infra-server/static/test-gke-lite.yaml
  • chart/infra-server/static/workflow-gke-default.yaml
🚧 Files skipped from review as they are similar to previous changes (3)
  • chart/infra-server/static/test-gke-lite.yaml
  • chart/infra-server/static/workflow-gke-default.yaml
  • chart/infra-server/static/janitor-delete-gke-default.yaml
📝 Walkthrough
Summary by CodeRabbit
  • New Features
    • Added an optional gcp-project setting for GKE deployment workflows.
    • The default GKE configuration uses acs-team-temp-dev when no project is specified.
    • Create, test, and cleanup workflows now use the selected Google Cloud project.
    • Testing workflows can accept the project as an input instead of relying on a fixed value.
Walkthrough
Changes
The GKE flavors now expose a configurable gcp-project parameter, and related workflows pass it to GKE create and destroy commands instead of using a hardcoded project.
GKE project parameterization
Layer / File(s)Summary
Project parameter contract
chart/infra-server/static/flavors.yaml		Adds optional gcp-project parameters with default value acs-team-temp-dev to the GKE-related flavors.
Workflow project wiring
chart/infra-server/static/janitor-delete-gke-default.yaml, chart/infra-server/static/test-gke-lite.yaml, chart/infra-server/static/workflow-gke-default.yaml		Adds workflow inputs and passes them to GKE create and destroy commands.
Estimated code review effort: 2 (Simple) | ~10 minutes
Suggested reviewers:bradlugo, davdhacs
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check nameStatusExplanationResolution
Description check❓ InconclusiveNo pull request description was provided, so there is nothing to assess for relatedness.Add a short description summarizing the workflow and flavor parameter changes.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title matches the main change: making gcp-project configurable for the gke-default flavor.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch tm/ROX-35590-gke-project
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
coderabbitai[bot]
coderabbitaiBot
reviewed
Jul 27, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@chart/infra-server/static/flavors.yaml`:
- Around line 187-191: The GKE janitor and test workflows lack the gcp-project
contract and do not propagate the project value. In
chart/infra-server/static/flavors.yaml lines 187-191, add matching gcp-project
parameters to janitor-delete-gke-default and test-gke-lite; in
chart/infra-server/static/janitor-delete-gke-default.yaml lines 12-13 and 36,
receive the flavor value and pass it to destroy; in
chart/infra-server/static/test-gke-lite.yaml lines 21-22, 77, and 100, receive
the value and pass it to create and destroy.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 495eb4b4-a7f7-4c65-90df-b1d746b67dbc
📥 Commits
Reviewing files that changed from the base of the PR and between c3d91a7 and 299a1d6.
📒 Files selected for processing (4)
  • chart/infra-server/static/flavors.yaml
  • chart/infra-server/static/janitor-delete-gke-default.yaml
  • chart/infra-server/static/test-gke-lite.yaml
  • chart/infra-server/static/workflow-gke-default.yaml
Comment threadchart/infra-server/static/flavors.yaml
@rhacs-bot
rhacs-bot
commented
Jul 27, 2026

Copy link


Copy Markdown

Contributor
A single node development cluster (infra-pr-1893) was allocated in production infra for this PR.
CI will attempt to deploy quay.io/rhacs-eng/infra-server: to it.
🔌 You can connect to this cluster with:
gcloud container clusters get-credentials infra-pr-1893 --zone us-central1-a --project acs-team-temp-dev

🛠️ And pull infractl from the deployed dev infra-server with:
nohup kubectl -n infra port-forward svc/infra-server-service 8443:8443 &
make pull-infractl-from-dev-server

🔓 You must go to to export an . Your token from the prod infra instance will not work with dev environments.
🚲 You can then use the dev infra instance e.g.:
bin/infractl -k -e localhost:8443 whoami

⚠️Any clusters that you start using your dev infra instance should have a lifespan shorter then the development cluster instance. Otherwise they will not be destroyed when the dev infra instance ceases to exist when the development cluster is deleted.⚠️
Further Development
☕ If you make changes, you can commit and push and CI will take care of updating the development cluster.
🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with:
make helm-deploy

Logs
Logs for the development infra depending on your @redhat.com authuser:
Or:
kubectl -n infra logs -l app=infra-server --tail=1 -f

@tommartensen
tommartensenforce-pushed
the
tm/ROX-35590-gke-project
branch
from
299a1d6 to
e7c92a4CompareJuly 27, 2026 13:53
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@rhacs-botrhacs-botAwaiting requested review from rhacs-botrhacs-bot will be requested when the pull request is marked ready for reviewrhacs-bot is a code owner

At least 1 approving review is required to merge this pull request.


Assignees

@tommartensentommartensen

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tommartensen@rhacs-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
ROX-35590: Expose gcp-project as parameter for gke-default flavor by tommartensen · Pull Request #1893 · stackrox/infra · GitHub
Skip to content
ROX-35590: Expose gcp-project as parameter for gke-default flavor - #1893
Draft
tommartensen wants to merge 1 commit into
masterfrom 
tm/ROX-35590-gke-project
Draft
ROX-35590: Expose gcp-project as parameter for gke-default flavor#1893
tommartensen wants to merge 1 commit into
masterfrom 
tm/ROX-35590-gke-project
Conversation
@tommartensen
@tommartensentommartensen
commented
Jul 27, 2026

Copy link


Copy Markdown

Contributor
 No description provided. 
@tommartensentommartensen
self-assigned this
Jul 27, 2026
@coderabbitai
coderabbitaiBot
commented
Jul 27, 2026•

edited

Loading

Copy link


Copy Markdown

Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: ce7287c6-3d2f-4596-8c84-4f9db3a0393c
📥 Commits
Reviewing files that changed from the base of the PR and between 299a1d6 and e7c92a4.
📒 Files selected for processing (4)
  • chart/infra-server/static/flavors.yaml
  • chart/infra-server/static/janitor-delete-gke-default.yaml
  • chart/infra-server/static/test-gke-lite.yaml
  • chart/infra-server/static/workflow-gke-default.yaml
🚧 Files skipped from review as they are similar to previous changes (3)
  • chart/infra-server/static/test-gke-lite.yaml
  • chart/infra-server/static/workflow-gke-default.yaml
  • chart/infra-server/static/janitor-delete-gke-default.yaml
📝 Walkthrough
Summary by CodeRabbit
  • New Features
    • Added an optional gcp-project setting for GKE deployment workflows.
    • The default GKE configuration uses acs-team-temp-dev when no project is specified.
    • Create, test, and cleanup workflows now use the selected Google Cloud project.
    • Testing workflows can accept the project as an input instead of relying on a fixed value.
Walkthrough
Changes
The GKE flavors now expose a configurable gcp-project parameter, and related workflows pass it to GKE create and destroy commands instead of using a hardcoded project.
GKE project parameterization
Layer / File(s)Summary
Project parameter contract
chart/infra-server/static/flavors.yaml		Adds optional gcp-project parameters with default value acs-team-temp-dev to the GKE-related flavors.
Workflow project wiring
chart/infra-server/static/janitor-delete-gke-default.yaml, chart/infra-server/static/test-gke-lite.yaml, chart/infra-server/static/workflow-gke-default.yaml		Adds workflow inputs and passes them to GKE create and destroy commands.
Estimated code review effort: 2 (Simple) | ~10 minutes
Suggested reviewers:bradlugo, davdhacs
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check nameStatusExplanationResolution
Description check❓ InconclusiveNo pull request description was provided, so there is nothing to assess for relatedness.Add a short description summarizing the workflow and flavor parameter changes.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title matches the main change: making gcp-project configurable for the gke-default flavor.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch tm/ROX-35590-gke-project
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
coderabbitai[bot]
coderabbitaiBot
reviewed
Jul 27, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@chart/infra-server/static/flavors.yaml`:
- Around line 187-191: The GKE janitor and test workflows lack the gcp-project
contract and do not propagate the project value. In
chart/infra-server/static/flavors.yaml lines 187-191, add matching gcp-project
parameters to janitor-delete-gke-default and test-gke-lite; in
chart/infra-server/static/janitor-delete-gke-default.yaml lines 12-13 and 36,
receive the flavor value and pass it to destroy; in
chart/infra-server/static/test-gke-lite.yaml lines 21-22, 77, and 100, receive
the value and pass it to create and destroy.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 495eb4b4-a7f7-4c65-90df-b1d746b67dbc
📥 Commits
Reviewing files that changed from the base of the PR and between c3d91a7 and 299a1d6.
📒 Files selected for processing (4)
  • chart/infra-server/static/flavors.yaml
  • chart/infra-server/static/janitor-delete-gke-default.yaml
  • chart/infra-server/static/test-gke-lite.yaml
  • chart/infra-server/static/workflow-gke-default.yaml
Comment threadchart/infra-server/static/flavors.yaml
@rhacs-bot
rhacs-bot
commented
Jul 27, 2026

Copy link


Copy Markdown

Contributor
A single node development cluster (infra-pr-1893) was allocated in production infra for this PR.
CI will attempt to deploy quay.io/rhacs-eng/infra-server: to it.
🔌 You can connect to this cluster with:
gcloud container clusters get-credentials infra-pr-1893 --zone us-central1-a --project acs-team-temp-dev

🛠️ And pull infractl from the deployed dev infra-server with:
nohup kubectl -n infra port-forward svc/infra-server-service 8443:8443 &
make pull-infractl-from-dev-server

🔓 You must go to to export an . Your token from the prod infra instance will not work with dev environments.
🚲 You can then use the dev infra instance e.g.:
bin/infractl -k -e localhost:8443 whoami

⚠️Any clusters that you start using your dev infra instance should have a lifespan shorter then the development cluster instance. Otherwise they will not be destroyed when the dev infra instance ceases to exist when the development cluster is deleted.⚠️
Further Development
☕ If you make changes, you can commit and push and CI will take care of updating the development cluster.
🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with:
make helm-deploy

Logs
Logs for the development infra depending on your @redhat.com authuser:
Or:
kubectl -n infra logs -l app=infra-server --tail=1 -f

@tommartensen
tommartensenforce-pushed
the
tm/ROX-35590-gke-project
branch
from
299a1d6 to
e7c92a4CompareJuly 27, 2026 13:53
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@rhacs-botrhacs-botAwaiting requested review from rhacs-botrhacs-bot will be requested when the pull request is marked ready for reviewrhacs-bot is a code owner

At least 1 approving review is required to merge this pull request.


Assignees

@tommartensentommartensen

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tommartensen@rhacs-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
ROX-35590: Expose gcp-project as parameter for gke-default flavor by tommartensen · Pull Request #1893 · stackrox/infra · GitHub
Skip to content
ROX-35590: Expose gcp-project as parameter for gke-default flavor - #1893
Draft
tommartensen wants to merge 1 commit into
masterfrom 
tm/ROX-35590-gke-project
Draft
ROX-35590: Expose gcp-project as parameter for gke-default flavor#1893
tommartensen wants to merge 1 commit into
masterfrom 
tm/ROX-35590-gke-project
Conversation
@tommartensen
@tommartensentommartensen
commented
Jul 27, 2026

Copy link


Copy Markdown

Contributor
 No description provided. 
@tommartensentommartensen
self-assigned this
Jul 27, 2026
@coderabbitai
coderabbitaiBot
commented
Jul 27, 2026•

edited

Loading

Copy link


Copy Markdown

Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: ce7287c6-3d2f-4596-8c84-4f9db3a0393c
📥 Commits
Reviewing files that changed from the base of the PR and between 299a1d6 and e7c92a4.
📒 Files selected for processing (4)
  • chart/infra-server/static/flavors.yaml
  • chart/infra-server/static/janitor-delete-gke-default.yaml
  • chart/infra-server/static/test-gke-lite.yaml
  • chart/infra-server/static/workflow-gke-default.yaml
🚧 Files skipped from review as they are similar to previous changes (3)
  • chart/infra-server/static/test-gke-lite.yaml
  • chart/infra-server/static/workflow-gke-default.yaml
  • chart/infra-server/static/janitor-delete-gke-default.yaml
📝 Walkthrough
Summary by CodeRabbit
  • New Features
    • Added an optional gcp-project setting for GKE deployment workflows.
    • The default GKE configuration uses acs-team-temp-dev when no project is specified.
    • Create, test, and cleanup workflows now use the selected Google Cloud project.
    • Testing workflows can accept the project as an input instead of relying on a fixed value.
Walkthrough
Changes
The GKE flavors now expose a configurable gcp-project parameter, and related workflows pass it to GKE create and destroy commands instead of using a hardcoded project.
GKE project parameterization
Layer / File(s)Summary
Project parameter contract
chart/infra-server/static/flavors.yaml		Adds optional gcp-project parameters with default value acs-team-temp-dev to the GKE-related flavors.
Workflow project wiring
chart/infra-server/static/janitor-delete-gke-default.yaml, chart/infra-server/static/test-gke-lite.yaml, chart/infra-server/static/workflow-gke-default.yaml		Adds workflow inputs and passes them to GKE create and destroy commands.
Estimated code review effort: 2 (Simple) | ~10 minutes
Suggested reviewers:bradlugo, davdhacs
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check nameStatusExplanationResolution
Description check❓ InconclusiveNo pull request description was provided, so there is nothing to assess for relatedness.Add a short description summarizing the workflow and flavor parameter changes.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title matches the main change: making gcp-project configurable for the gke-default flavor.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch tm/ROX-35590-gke-project
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
coderabbitai[bot]
coderabbitaiBot
reviewed
Jul 27, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@chart/infra-server/static/flavors.yaml`:
- Around line 187-191: The GKE janitor and test workflows lack the gcp-project
contract and do not propagate the project value. In
chart/infra-server/static/flavors.yaml lines 187-191, add matching gcp-project
parameters to janitor-delete-gke-default and test-gke-lite; in
chart/infra-server/static/janitor-delete-gke-default.yaml lines 12-13 and 36,
receive the flavor value and pass it to destroy; in
chart/infra-server/static/test-gke-lite.yaml lines 21-22, 77, and 100, receive
the value and pass it to create and destroy.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 495eb4b4-a7f7-4c65-90df-b1d746b67dbc
📥 Commits
Reviewing files that changed from the base of the PR and between c3d91a7 and 299a1d6.
📒 Files selected for processing (4)
  • chart/infra-server/static/flavors.yaml
  • chart/infra-server/static/janitor-delete-gke-default.yaml
  • chart/infra-server/static/test-gke-lite.yaml
  • chart/infra-server/static/workflow-gke-default.yaml
Comment threadchart/infra-server/static/flavors.yaml
@rhacs-bot
rhacs-bot
commented
Jul 27, 2026

Copy link


Copy Markdown

Contributor
A single node development cluster (infra-pr-1893) was allocated in production infra for this PR.
CI will attempt to deploy quay.io/rhacs-eng/infra-server: to it.
🔌 You can connect to this cluster with:
gcloud container clusters get-credentials infra-pr-1893 --zone us-central1-a --project acs-team-temp-dev

🛠️ And pull infractl from the deployed dev infra-server with:
nohup kubectl -n infra port-forward svc/infra-server-service 8443:8443 &
make pull-infractl-from-dev-server

🔓 You must go to to export an . Your token from the prod infra instance will not work with dev environments.
🚲 You can then use the dev infra instance e.g.:
bin/infractl -k -e localhost:8443 whoami

⚠️Any clusters that you start using your dev infra instance should have a lifespan shorter then the development cluster instance. Otherwise they will not be destroyed when the dev infra instance ceases to exist when the development cluster is deleted.⚠️
Further Development
☕ If you make changes, you can commit and push and CI will take care of updating the development cluster.
🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with:
make helm-deploy

Logs
Logs for the development infra depending on your @redhat.com authuser:
Or:
kubectl -n infra logs -l app=infra-server --tail=1 -f

@tommartensen
tommartensenforce-pushed
the
tm/ROX-35590-gke-project
branch
from
299a1d6 to
e7c92a4CompareJuly 27, 2026 13:53
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@rhacs-botrhacs-botAwaiting requested review from rhacs-botrhacs-bot will be requested when the pull request is marked ready for reviewrhacs-bot is a code owner

At least 1 approving review is required to merge this pull request.


Assignees

@tommartensentommartensen

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tommartensen@rhacs-bot