Skip to content

ROX-12637: make kuttl tests tolerate pause reconcile status condition - #17023

Merged
porridge merged 7 commits into
masterfrom
porridge/ROX-12637-assertions
Sep 30, 2025
Merged

ROX-12637: make kuttl tests tolerate pause reconcile status condition#17023
porridge merged 7 commits into
masterfrom
porridge/ROX-12637-assertions

Conversation

@porridge

@porridgeporridge commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

Description

TODO:

The pause-reconcile support is upstream as of March 2025 (operator-framework/helm-operator-plugins#426). It includes the Paused condition in status.
So we need to teach our tests to tolerate it before we rebase our helm-operator fork.
The problem is kudobuilder/kuttl#76 but it is possible to work it around by using the recently added CEL support. Here I'm changing only the places which are exposed to a status of a CR reconciled by any "old" version of the ACS operator, because the regular CEL-free way is more readable and any failures are also reported in a nicer way.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • modified existing tests

How I validated my change

CI

@openshift-ci

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@porridge

Copy link
Copy Markdown
ContributorAuthor

/test gke-operator-e2e-tests

@rhacs-bot

rhacs-bot commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

Images are ready for the commit at a4ca604.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-889-ga4ca604aa2.

@porridge
porridgeforce-pushed the porridge/ROX-12637-assertions branch from e39dee9 to e5a571eCompareSeptember 25, 2025 08:07
@porridge

Copy link
Copy Markdown
ContributorAuthor

/test gke-operator-e2e-tests

@codecov

codecovBot commented Sep 25, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.80%. Comparing base (23689bd) to head (a4ca604).
⚠️ Report is 38 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #17023 +/- ##
========================================
Coverage 48.80% 48.80% ========================================
Files 2696 2706 +10 Lines 201493 202086 +593 ========================================
+ Hits 98331 98625 +294 - Misses 95400 95695 +295 - Partials 7762 7766 +4 
FlagCoverage Δ
go-unit-tests48.80% <ø> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@porridge

Copy link
Copy Markdown
ContributorAuthor

/test all

@porridge
porridgeforce-pushed the porridge/ROX-12637-assertions branch from d42d299 to 258c5a1CompareSeptember 25, 2025 13:27
@porridge

Copy link
Copy Markdown
ContributorAuthor

/test all

Comment threadoperator/tests/common/central-cr-assert.yaml
porridge added a commit to stackrox/helm-operator that referenced this pull request Sep 29, 2025
@porridge
porridge marked this pull request as ready for review September 29, 2025 09:53
@porridge
porridge requested review from a team as code ownersSeptember 29, 2025 09:53
@porridgeporridge added the auto-retest PRs with this label will be automatically retested if prow checks fails label Sep 29, 2025
@rhacs-bot

Copy link
Copy Markdown
Contributor

/retest

@red-hat-konflux

Copy link
Copy Markdown
Contributor

Caution

There are some errors in your PipelineRun template.

PipelineRunError
central-db-on-pushCEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master|release-.*|refs/tags/.*)$\")\n) || (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") ||\n source_branch.matches(\"(konflux|renovate|appstudio|rhtap)\") ||\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request
main-on-pushCEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master|release-.*|refs/tags/.*)$\")\n) || (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") ||\n source_branch.matches(\"(konflux|renovate|appstudio|rhtap)\") ||\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request
operator-on-pushCEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master|release-.*|refs/tags/.*)$\")\n) || (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") ||\n source_branch.matches(\"(konflux|renovate|appstudio|rhtap)\") ||\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request
operator-bundle-on-pushCEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master|release-.*|refs/tags/.*)$\")\n) || (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") ||\n source_branch.matches(\"(konflux|renovate|appstudio|rhtap)\") ||\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request
retag-collectorCEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master|release-.*|refs/tags/.*)$\")\n) || (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") ||\n source_branch.matches(\"(konflux|renovate|appstudio|rhtap)\") ||\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request
retag-scanner-db-slimCEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master|release-.*|refs/tags/.*)$\")\n) || (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") ||\n source_branch.matches(\"(konflux|renovate|appstudio|rhtap)\") ||\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request
retag-scanner-dbCEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master|release-.*|refs/tags/.*)$\")\n) || (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") ||\n source_branch.matches(\"(konflux|renovate|appstudio|rhtap)\") ||\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request
retag-scanner-slimCEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master|release-.*|refs/tags/.*)$\")\n) || (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") ||\n source_branch.matches(\"(konflux|renovate|appstudio|rhtap)\") ||\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request
retag-scannerCEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master|release-.*|refs/tags/.*)$\")\n) || (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") ||\n source_branch.matches(\"(konflux|renovate|appstudio|rhtap)\") ||\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request
roxctl-on-pushCEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master|release-.*|refs/tags/.*)$\")\n) || (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") ||\n source_branch.matches(\"(konflux|renovate|appstudio|rhtap)\") ||\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request
scanner-v4-on-pushCEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master|release-.*|refs/tags/.*)$\")\n) || (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") ||\n source_branch.matches(\"(konflux|renovate|appstudio|rhtap)\") ||\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request
scanner-v4-db-on-pushCEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master|release-.*|refs/tags/.*)$\")\n) || (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") ||\n source_branch.matches(\"(konflux|renovate|appstudio|rhtap)\") ||\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request

@porridge
porridge merged commit eec7d29 into masterSep 30, 2025
107 checks passed
@porridge
porridge deleted the porridge/ROX-12637-assertions branch September 30, 2025 04:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/operatorauto-retestPRs with this label will be automatically retested if prow checks fails

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@porridge@rhacs-bot@vladbologa