Skip to content

Rewrite toString to match Node internals - #23

Merged
eriwen merged 8 commits into
stacktracejs:masterfrom
niftylettuce:master
Sep 14, 2019
Merged

Rewrite toString to match Node internals#23
eriwen merged 8 commits into
stacktracejs:masterfrom
niftylettuce:master

Conversation

@niftylettuce

@niftylettuceniftylettuce commented Sep 13, 2019

Copy link
Copy Markdown
Contributor

This closes#21 and #22, and rewrites the toString method to output a stack trace format that more closely resembles Node internals.

Ref: https://github.com/nodejs/node/blob/b6bfc193788b1838bee73d584fe089e1104b9f88/src/node_errors.cc#L142-L175

@niftylettuce

niftylettuce commented Sep 13, 2019

Copy link
Copy Markdown
ContributorAuthor

The travis build failed due to an apt-get install failure of google-chrome (not related to this code).

@niftylettuce

niftylettuce commented Sep 13, 2019

Copy link
Copy Markdown
ContributorAuthor

I've tested this on my end, all is fixed and ready for merge!

@niftylettuceniftylettuce mentioned this pull request Sep 13, 2019
Closed
@eriweneriwen self-assigned this Sep 14, 2019
@eriwen
eriwen merged commit 1352264 into stacktracejs:masterSep 14, 2019
@eriweneriwen mentioned this pull request Sep 14, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@eriweneriwen

Labels

a:feature

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Given an array of stack frames, convert to V8 stack trace stack prop

2 participants

@niftylettuce@eriwen