Uh oh!
There was an error while loading. Please reload this page.
Convert reports to JSON - #135
Conversation
There was a problem hiding this comment.
Line is too long.
Missing semicolon.
Expected an identifier and instead saw '=='.
Expected an operator and instead saw 'typeof'.
Expected an assignment or function call and instead saw an expression.
Wrap an immediate function invocation in parens to assist the reader in understanding that the expression is the result of a function, and not the function itself.
'e' is already defined.
't' is already defined.
Possible strict violation.
Expected '{' and instead saw 'throw'.
Expected '{' and instead saw 'return'.
'i' is already defined.
Use '!==' to compare with 'null'.
Too many errors. (50% scanned).
oliversalzburg
commented
Oct 15, 2015
@eriwen Can we exclude |
eriwen
commented
Oct 16, 2015
@oliversalzburg Looks like we can exclude files from Hound by adding a .jshintignore file with the following content: I'm not sure about Travis. It works on master and we haven't made changes. Maybe something is wrong with the PR-specific config somehow... |
eriwen
commented
Oct 16, 2015
Also, this looks good except for the one thing; thank you! |
oliversalzburg
commented
Oct 16, 2015
|
Includes JSON3 in the polyfill version Fixes#133
There was a problem hiding this comment.
How can that still be too long? O_o
There was a problem hiding this comment.
Hm.. I'm guessing the default line length limit is 80.
Sorry about the annoying Hound stuff; don't worry about this kinda thing. I may just disable it since JSHint is part of the build anyway.
eriwen
commented
Oct 17, 2015
Looks good! |
Includes JSON3 in the polyfill version
Fixes#133