Skip to content

Revert "Feature/faster ad tls v3" - #1167

Merged
syclik merged 1 commit into
developfrom
revert-1135-feature/faster-ad-tls-v3
Mar 20, 2019
Merged

Revert "Feature/faster ad tls v3"#1167
syclik merged 1 commit into
developfrom
revert-1135-feature/faster-ad-tls-v3

Conversation

@syclik

@sycliksyclik commented Mar 19, 2019

Copy link
Copy Markdown
Member

Summary

Merging #1135 broke develop for Windows tests.

Tests

Existing tests fail.

Side Effects

None.

Checklist

  • Math issue PR #1135 broke develop. Reverting the PR. #1166

  • Copyright holder: Generable

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

@syclik
syclik requested a review from wds15March 19, 2019 20:41
@sycliksyclik added the bug label Mar 19, 2019
@sycliksyclik modified the milestones: 2.19.0++, 2.19.0Mar 19, 2019
@syclik

Copy link
Copy Markdown
MemberAuthor

@seantalts, the tests are done and passing. I'm merging now.

@syclik
syclik merged commit f9c1644 into developMar 20, 2019
@seantalts

Copy link
Copy Markdown
Member

Thanks! just got up and will start releasing after some tea.

@syclik
syclik deleted the revert-1135-feature/faster-ad-tls-v3 branch March 22, 2019 04:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@syclik@seantalts@serban-nicusor-toptal