Fix plot_daily for missing dates and add timezone/DST tests - #18
Conversation
- Fix bug in plot_daily: handle timeseries with missing dates correctly
- Changed from resample('D') to groupby(normalize()) to only include days with data
- Prevents KeyError when trying to get groups for days without data
- Add comprehensive unittests for plot_daily:
- Test missing dates (non-continuous timeseries)
- Test multiple missing dates
- Test single day in middle of range
- Test timezone-aware (non-UTC) timeseries
- Test DST spring forward (losing an hour)
- Test DST fall back (gaining an hour)
- Bump version to 0.4.3You have run out of free Bugbot PR reviews for this billing cycle. This will reset on December 6. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
codecov-commenter
commented
Nov 26, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #18 +/- ##
==========================================
+ Coverage 90.37% 90.38% +0.01%
==========================================
Files 46 46 Lines 1797 1799 +2 ==========================================
+ Hits 1624 1626 +2
Misses 173 173 ☔ View full report in Codecov by Sentry. |
Uh oh!
There was an error while loading. Please reload this page.
Summary
This PR fixes a bug in
plot_dailythat caused a KeyError when processing timeseries with missing dates, and adds comprehensive unittests for timezone-aware data and DST transitions.Changes
Bug Fix
plot_dailyto handle timeseries with missing dates correctlyresample('D')togroupby(normalize())to only include days with dataTests Added
Version
Testing
All existing tests pass, and new tests verify the functionality works correctly with: