Multi-Site broken: Wrongly cached data of localizations leads to lost content in control panel and multiple (wrong) .md files for the same entry

[wanze]

Bug description

2023_01_11_statamic_multisite_bug.mp4

Preconditions

• 3 sites (at least)
• STATAMIC_STACHE_WATCHER is set to false

How to reproduce

1. Create a new entry in the default site. Save it unpublished (Save draft)
2. Create a new entry in the second site. Save it unpublished (Save draft)
3. Publish both entries (Save & Publish)
4. Create a new entry for the third site, save and publish it.
5. In the sidebar, navigate back to the entry of the second site.

Notice that the just created entry for the third site is not existing anymore (red/crossed). If you know click again on it, Statamic will create a new file on the disk and the previous content is no longer visible in the control panel. 🙀You can repeat this over and over again and create multiple files for the same entry. Clearing the Stache does not fix it, you have to manually remove the "wrong" files from the disk.

How to fix

I think that this issue is caused by serving wrongly cached data of the localizations to the frontend. More information: #7077 (comment)

Logs

No response

Environment

Environment
Application Name: Statamic-Sandbox
Laravel Version: 9.45.1
PHP Version: 8.1.13
Composer Version: 2.4.4
Environment: local
Debug Mode: ENABLED
URL: statamic-sandbox.test
Maintenance Mode: OFF

Cache
Config: NOT CACHED
Events: NOT CACHED
Routes: NOT CACHED
Views: CACHED

Drivers
Broadcasting: log
Cache: statamic
Database: mysql
Logs: stack / single
Mail: smtp
Queue: sync
Session: file

Statamic
Addons: 0
Antlers: regex
Stache Watcher: Disabled
Static Caching: Disabled
Version: 3.3.64

Installation

Fresh statamic/statamic site via CLI

Antlers Parser

runtime (new)

Additional details

No response

[wanze]

After some more debugging, I found out that this issue only happens when SeoPro is installed. Will close here and open an issue in the SeoPro repo.

Edit: This is not true, also happens without SeoPro. See my next comment.

[wanze]

Reopening as it turned out that this is an issue in the core.

I think the problem is caused by caching localizations in the Entry::descendants method. By commenting out the if and removing the cache, the localized descendants are returned correctly to the frontend and the issues mentioned in the ticket description do not occur.

 public function descendants()
 {
// if (! $this->localizations) {
 $this->localizations = Facades\Entry::query()
 ->where('collection', $this->collectionHandle())
 ->where('origin', $this->id())->get()
 ->keyBy->locale();
// }

 $localizations = collect($this->localizations);

 foreach ($localizations as $loc) {
 $localizations = $localizations->merge($loc->descendants());
 }

 return $localizations;
 }

I think this cache needs to be removed or be cleared when new localizations are added or modified. For example:

$entryEn = (new Entry)->id('en')->locale('en')->collection('articles');
$entryEn->save();
$entryEn->descendants(); // --> no descendants, but getting cached!

$entryFr = $entryEn->makeLocalization('fr');
$entryFr->save();

$entryEn->descendants(); // --> still no descendants because cached, but $entryFr should be in there!

[wanze]

Applying the fix of #7339 seems to fix this issue too.

[wanze]

Here is a reproduction repository: https://github.com/gridonic/statamic-issue-7077

• Latest Statamic 3.4.3
• Latest Seo Pro 4.0.1
• Control Panel Login: sudo@gridonic.ch / sudo1234

How to reproduce

1. Create a new Page in English, save it published.
2. Create a new Page in German using English as origin, save it published.
3. Create a new Page in French using English as origin, save it published.
4. In the sidebar, navigate back to the German Page
5. Note that the French Page is now red/crossed even though you have just created it previously.
6. If you create the French page again, you won't see the previous content and Statamic creates a second .md file for it on disk. This needs to be cleaned up manually. You can repeat this endlessly.

How to fix

Do not cache descendants in Entry::descendants(), see #7077 (comment)

[mmodler]

I would love to hear news on this issue. My content editor teammate calls me all the time having this issue on a multisite install, and i frequently delete lost md files on the server...

@wanze What is your workaround for the moment? Core edit? 🫣

[wanze]

Hi @mmodler
Actually I'm surprised that this issue does not get more attention from multi site users. We currently use a patch in combination with the composer-patches package to apply the patch automatically via Composer.