Uh oh!
There was an error while loading. Please reload this page.
[5.x] Update GitHub Actions workflow versions - #10136
Conversation
jasonvarga
commented
May 21, 2024
Which were problematic? |
Jubeki
commented
May 21, 2024
The slack notifications, because I can not test them. |
Jubeki
commented
May 21, 2024
Maybe on another note: if you as maintainer are annoyed with having all workflows run twice (due to push and pull_reqest), I can also send a PR which changes the behaviour to only run the workflows once (Similar to a PR which I send to Laravel Framework: laravel/framework#44053) |
jasonvarga
commented
May 21, 2024
I mean, is there a reason you are updating these versions? Is there some kind of problem with the versions they are on at the moment? |
Jubeki
commented
May 21, 2024
For the ![]() Though there are still deprecations notices, they are fewer:
In general I think it is good to keep dependencies (in this case only dev Dependencies) up to date, because they can include performance improvements or security fixes. There is no real other reason (so changes can be reverted by the maintainers if some versions should not be updated, or to be tested in some other way). You can take this PR as a starting point, or discuss internally if you want to update in some other way or keep the versions running like they are now. |
jasonvarga
commented
May 21, 2024
All good, thanks! We just like to know the reasons for a change. |
jasonvarga
commented
May 21, 2024
That sounds good. Thank you. |

This PR updates the versions of the GitHub Actions workflows.
Some changes are unproblematic in my opinion, but some need some more considerations or are not testable by me.
Laravel Pint
If you want to run a specific pint version, you can configure that using the following configuration.
v1 runs using the latest version of pint as far as I know.
Slack Notifications
The last of the changes, were on failure of tests and js-tests when the tests were scheduled are not testable by me, if it not works, these changes should probably be reverted.