[5.x] Bring back select modifier

[jasonvarga]

This brings back the select modifier from #10183 which got reverted in #10218 because of #10211.

Except this will also fix the issue.

Todo:

• Add test that shows the bug
• Fix bug

[jasonvarga]

@JohnathonKoster This one is probably for you 😄

I've tracked it down to here:

cms/src/View/Antlers/Language/Runtime/NodeProcessor.php

Lines 1401 to 1405 in af63932

	foreach ($recursiveParent->parametersas$param) {
	if (ModifierManager::isModifier($param)) {
	$childDataToUse = $this->runModifier($param->name, $parentParameterValues, $childDataToUse, $rootData);
	}
	}

When you use {{ *recursive children* }}, it ends up looking at the outer nav tag, seeing the select="" parameter, deciding that yes selectis (now) a modifier, and then tries to run the modifier.

I believe this works this way so you can use scope as per this:

cms/tests/Antlers/Runtime/TemplateTest.php

Lines 703 to 713 in dae2639

	publicfunctionrecursive_children_with_scope()
	{
	// the variables are inside RecursiveChildren@index
	$this->app['statamic.tags']['recursive_children'] = RecursiveChildren::class;
	$template = '<ul>{{ recursive_children scope="item" }}<li>{{ item:title }}.{{ item:foo }}.{{ foo }}{{ if item:children }}<ul>{{ *recursive item:children* }}</ul>{{ /if }}</li>{{ /recursive_children }}</ul>';
	$expected = '<ul><li>One..Bar<ul><li>Two..Bar</li><li>Three..Bar<ul><li>Four.Baz.Baz</li></ul></li></ul></li></ul>';
	$this->assertEquals($expected, $this->renderString($template, ['foo' => 'Bar'], true));
	}

Making this change fixes it and lets scope continue to work, but obviously just scope. I can't really think of if that's a problem or not.

-if (ModifierManager::isModifier($param)) {+if ($param->name === 'scope') {

[jasonvarga]

This brings back the select modifier from #10183 which got reverted in #10218 because of #10211.

Except this will also fix the issue.

Todo:

• Add test that shows the bug
• Fix bug

[jasonvarga]

@JohnathonKoster This one is probably for you 😄

I've tracked it down to here:

cms/src/View/Antlers/Language/Runtime/NodeProcessor.php

Lines 1401 to 1405 in af63932

	foreach ($recursiveParent->parametersas$param) {
	if (ModifierManager::isModifier($param)) {
	$childDataToUse = $this->runModifier($param->name, $parentParameterValues, $childDataToUse, $rootData);
	}
	}

When you use {{ *recursive children* }}, it ends up looking at the outer nav tag, seeing the select="" parameter, deciding that yes selectis (now) a modifier, and then tries to run the modifier.

I believe this works this way so you can use scope as per this:

cms/tests/Antlers/Runtime/TemplateTest.php

Lines 703 to 713 in dae2639

	publicfunctionrecursive_children_with_scope()
	{
	// the variables are inside RecursiveChildren@index
	$this->app['statamic.tags']['recursive_children'] = RecursiveChildren::class;
	$template = '<ul>{{ recursive_children scope="item" }}<li>{{ item:title }}.{{ item:foo }}.{{ foo }}{{ if item:children }}<ul>{{ *recursive item:children* }}</ul>{{ /if }}</li>{{ /recursive_children }}</ul>';
	$expected = '<ul><li>One..Bar<ul><li>Two..Bar</li><li>Three..Bar<ul><li>Four.Baz.Baz</li></ul></li></ul></li></ul>';
	$this->assertEquals($expected, $this->renderString($template, ['foo' => 'Bar'], true));
	}

Making this change fixes it and lets scope continue to work, but obviously just scope. I can't really think of if that's a problem or not.

-if (ModifierManager::isModifier($param)) {+if ($param->name === 'scope') {

[jasonvarga]

This brings back the select modifier from #10183 which got reverted in #10218 because of #10211.

Except this will also fix the issue.

Todo:

• Add test that shows the bug
• Fix bug

[jasonvarga]

@JohnathonKoster This one is probably for you 😄

I've tracked it down to here:

cms/src/View/Antlers/Language/Runtime/NodeProcessor.php

Lines 1401 to 1405 in af63932

	foreach ($recursiveParent->parametersas$param) {
	if (ModifierManager::isModifier($param)) {
	$childDataToUse = $this->runModifier($param->name, $parentParameterValues, $childDataToUse, $rootData);
	}
	}

When you use {{ *recursive children* }}, it ends up looking at the outer nav tag, seeing the select="" parameter, deciding that yes selectis (now) a modifier, and then tries to run the modifier.

I believe this works this way so you can use scope as per this:

cms/tests/Antlers/Runtime/TemplateTest.php

Lines 703 to 713 in dae2639

	publicfunctionrecursive_children_with_scope()
	{
	// the variables are inside RecursiveChildren@index
	$this->app['statamic.tags']['recursive_children'] = RecursiveChildren::class;
	$template = '<ul>{{ recursive_children scope="item" }}<li>{{ item:title }}.{{ item:foo }}.{{ foo }}{{ if item:children }}<ul>{{ *recursive item:children* }}</ul>{{ /if }}</li>{{ /recursive_children }}</ul>';
	$expected = '<ul><li>One..Bar<ul><li>Two..Bar</li><li>Three..Bar<ul><li>Four.Baz.Baz</li></ul></li></ul></li></ul>';
	$this->assertEquals($expected, $this->renderString($template, ['foo' => 'Bar'], true));
	}

Making this change fixes it and lets scope continue to work, but obviously just scope. I can't really think of if that's a problem or not.

-if (ModifierManager::isModifier($param)) {+if ($param->name === 'scope') {

[jasonvarga]

This brings back the select modifier from #10183 which got reverted in #10218 because of #10211.

Except this will also fix the issue.

Todo:

• Add test that shows the bug
• Fix bug

[jasonvarga]

@JohnathonKoster This one is probably for you 😄

I've tracked it down to here:

cms/src/View/Antlers/Language/Runtime/NodeProcessor.php

Lines 1401 to 1405 in af63932

	foreach ($recursiveParent->parametersas$param) {
	if (ModifierManager::isModifier($param)) {
	$childDataToUse = $this->runModifier($param->name, $parentParameterValues, $childDataToUse, $rootData);
	}
	}

When you use {{ *recursive children* }}, it ends up looking at the outer nav tag, seeing the select="" parameter, deciding that yes selectis (now) a modifier, and then tries to run the modifier.

I believe this works this way so you can use scope as per this:

cms/tests/Antlers/Runtime/TemplateTest.php

Lines 703 to 713 in dae2639

	publicfunctionrecursive_children_with_scope()
	{
	// the variables are inside RecursiveChildren@index
	$this->app['statamic.tags']['recursive_children'] = RecursiveChildren::class;
	$template = '<ul>{{ recursive_children scope="item" }}<li>{{ item:title }}.{{ item:foo }}.{{ foo }}{{ if item:children }}<ul>{{ *recursive item:children* }}</ul>{{ /if }}</li>{{ /recursive_children }}</ul>';
	$expected = '<ul><li>One..Bar<ul><li>Two..Bar</li><li>Three..Bar<ul><li>Four.Baz.Baz</li></ul></li></ul></li></ul>';
	$this->assertEquals($expected, $this->renderString($template, ['foo' => 'Bar'], true));
	}

Making this change fixes it and lets scope continue to work, but obviously just scope. I can't really think of if that's a problem or not.

-if (ModifierManager::isModifier($param)) {+if ($param->name === 'scope') {

[jasonvarga]

This brings back the select modifier from #10183 which got reverted in #10218 because of #10211.

Except this will also fix the issue.

Todo:

• Add test that shows the bug
• Fix bug

[jasonvarga]

@JohnathonKoster This one is probably for you 😄

I've tracked it down to here:

cms/src/View/Antlers/Language/Runtime/NodeProcessor.php

Lines 1401 to 1405 in af63932

	foreach ($recursiveParent->parametersas$param) {
	if (ModifierManager::isModifier($param)) {
	$childDataToUse = $this->runModifier($param->name, $parentParameterValues, $childDataToUse, $rootData);
	}
	}

When you use {{ *recursive children* }}, it ends up looking at the outer nav tag, seeing the select="" parameter, deciding that yes selectis (now) a modifier, and then tries to run the modifier.

I believe this works this way so you can use scope as per this:

cms/tests/Antlers/Runtime/TemplateTest.php

Lines 703 to 713 in dae2639

	publicfunctionrecursive_children_with_scope()
	{
	// the variables are inside RecursiveChildren@index
	$this->app['statamic.tags']['recursive_children'] = RecursiveChildren::class;
	$template = '<ul>{{ recursive_children scope="item" }}<li>{{ item:title }}.{{ item:foo }}.{{ foo }}{{ if item:children }}<ul>{{ *recursive item:children* }}</ul>{{ /if }}</li>{{ /recursive_children }}</ul>';
	$expected = '<ul><li>One..Bar<ul><li>Two..Bar</li><li>Three..Bar<ul><li>Four.Baz.Baz</li></ul></li></ul></li></ul>';
	$this->assertEquals($expected, $this->renderString($template, ['foo' => 'Bar'], true));
	}

Making this change fixes it and lets scope continue to work, but obviously just scope. I can't really think of if that's a problem or not.

-if (ModifierManager::isModifier($param)) {+if ($param->name === 'scope') {

[jasonvarga]

This brings back the select modifier from #10183 which got reverted in #10218 because of #10211.

Except this will also fix the issue.

Todo:

• Add test that shows the bug
• Fix bug

[jasonvarga]

@JohnathonKoster This one is probably for you 😄

I've tracked it down to here:

cms/src/View/Antlers/Language/Runtime/NodeProcessor.php

Lines 1401 to 1405 in af63932

	foreach ($recursiveParent->parametersas$param) {
	if (ModifierManager::isModifier($param)) {
	$childDataToUse = $this->runModifier($param->name, $parentParameterValues, $childDataToUse, $rootData);
	}
	}

When you use {{ *recursive children* }}, it ends up looking at the outer nav tag, seeing the select="" parameter, deciding that yes selectis (now) a modifier, and then tries to run the modifier.

I believe this works this way so you can use scope as per this:

cms/tests/Antlers/Runtime/TemplateTest.php

Lines 703 to 713 in dae2639

	publicfunctionrecursive_children_with_scope()
	{
	// the variables are inside RecursiveChildren@index
	$this->app['statamic.tags']['recursive_children'] = RecursiveChildren::class;
	$template = '<ul>{{ recursive_children scope="item" }}<li>{{ item:title }}.{{ item:foo }}.{{ foo }}{{ if item:children }}<ul>{{ *recursive item:children* }}</ul>{{ /if }}</li>{{ /recursive_children }}</ul>';
	$expected = '<ul><li>One..Bar<ul><li>Two..Bar</li><li>Three..Bar<ul><li>Four.Baz.Baz</li></ul></li></ul></li></ul>';
	$this->assertEquals($expected, $this->renderString($template, ['foo' => 'Bar'], true));
	}

Making this change fixes it and lets scope continue to work, but obviously just scope. I can't really think of if that's a problem or not.

-if (ModifierManager::isModifier($param)) {+if ($param->name === 'scope') {

[jasonvarga]

This brings back the select modifier from #10183 which got reverted in #10218 because of #10211.

Except this will also fix the issue.

Todo:

• Add test that shows the bug
• Fix bug

[jasonvarga]

@JohnathonKoster This one is probably for you 😄

I've tracked it down to here:

cms/src/View/Antlers/Language/Runtime/NodeProcessor.php

Lines 1401 to 1405 in af63932

	foreach ($recursiveParent->parametersas$param) {
	if (ModifierManager::isModifier($param)) {
	$childDataToUse = $this->runModifier($param->name, $parentParameterValues, $childDataToUse, $rootData);
	}
	}

When you use {{ *recursive children* }}, it ends up looking at the outer nav tag, seeing the select="" parameter, deciding that yes selectis (now) a modifier, and then tries to run the modifier.

I believe this works this way so you can use scope as per this:

cms/tests/Antlers/Runtime/TemplateTest.php

Lines 703 to 713 in dae2639

	publicfunctionrecursive_children_with_scope()
	{
	// the variables are inside RecursiveChildren@index
	$this->app['statamic.tags']['recursive_children'] = RecursiveChildren::class;
	$template = '<ul>{{ recursive_children scope="item" }}<li>{{ item:title }}.{{ item:foo }}.{{ foo }}{{ if item:children }}<ul>{{ *recursive item:children* }}</ul>{{ /if }}</li>{{ /recursive_children }}</ul>';
	$expected = '<ul><li>One..Bar<ul><li>Two..Bar</li><li>Three..Bar<ul><li>Four.Baz.Baz</li></ul></li></ul></li></ul>';
	$this->assertEquals($expected, $this->renderString($template, ['foo' => 'Bar'], true));
	}

Making this change fixes it and lets scope continue to work, but obviously just scope. I can't really think of if that's a problem or not.

-if (ModifierManager::isModifier($param)) {+if ($param->name === 'scope') {

[jasonvarga]

This brings back the select modifier from #10183 which got reverted in #10218 because of #10211.

Except this will also fix the issue.

Todo:

• Add test that shows the bug
• Fix bug

[jasonvarga]

@JohnathonKoster This one is probably for you 😄

I've tracked it down to here:

cms/src/View/Antlers/Language/Runtime/NodeProcessor.php

Lines 1401 to 1405 in af63932

	foreach ($recursiveParent->parametersas$param) {
	if (ModifierManager::isModifier($param)) {
	$childDataToUse = $this->runModifier($param->name, $parentParameterValues, $childDataToUse, $rootData);
	}
	}

When you use {{ *recursive children* }}, it ends up looking at the outer nav tag, seeing the select="" parameter, deciding that yes selectis (now) a modifier, and then tries to run the modifier.

I believe this works this way so you can use scope as per this:

cms/tests/Antlers/Runtime/TemplateTest.php

Lines 703 to 713 in dae2639

	publicfunctionrecursive_children_with_scope()
	{
	// the variables are inside RecursiveChildren@index
	$this->app['statamic.tags']['recursive_children'] = RecursiveChildren::class;
	$template = '<ul>{{ recursive_children scope="item" }}<li>{{ item:title }}.{{ item:foo }}.{{ foo }}{{ if item:children }}<ul>{{ *recursive item:children* }}</ul>{{ /if }}</li>{{ /recursive_children }}</ul>';
	$expected = '<ul><li>One..Bar<ul><li>Two..Bar</li><li>Three..Bar<ul><li>Four.Baz.Baz</li></ul></li></ul></li></ul>';
	$this->assertEquals($expected, $this->renderString($template, ['foo' => 'Bar'], true));
	}

Making this change fixes it and lets scope continue to work, but obviously just scope. I can't really think of if that's a problem or not.

-if (ModifierManager::isModifier($param)) {+if ($param->name === 'scope') {