[5.x] Cast to Array to Resolve Issues with Filters Returning EntryCollection

[sylvesterdamgaard]

Bug introduced in #10467
Cast to array to prevent issues with listings when data is returned as a Statamic\Entries\EntryCollection

The issue will happen when filters don't return an array, but a EntryCollection like this.

publicfunctionfieldItems()
{
$entries = \Statamic\Facades\Entry::query()->where('collection', 'locations')->get();
return [
'locations' => [
'type' => 'select',
'multiple' => true,
'options' => $entries->mapWithKeys(function (\Statamic\Entries\Entry$item, int$key) {
return [$item->id() => $item->title];
}),
],
];
}

[jasonvarga]

Casting a collection to an array like that won't work either.

I think you want to do this:

$options = $this->config('options') ?? [];
$options = $optionsinstanceof Collection ? $options->all() : $options;

[jasonvarga]

What class are you defining your public function fieldItems() in, by the way?

[jasonvarga]

I'm going to assume you were using that in a filter class, and the error you encountered was array_is_list(): Argument #1 ($array) must be of type array, Illuminate\Support\Collection given.

Adding (array) does prevent the error, but would break functionality elsewhere.

I've updated the PR. Thanks!

[sylvesterdamgaard]

Bug introduced in #10467
Cast to array to prevent issues with listings when data is returned as a Statamic\Entries\EntryCollection

The issue will happen when filters don't return an array, but a EntryCollection like this.

publicfunctionfieldItems()
{
$entries = \Statamic\Facades\Entry::query()->where('collection', 'locations')->get();
return [
'locations' => [
'type' => 'select',
'multiple' => true,
'options' => $entries->mapWithKeys(function (\Statamic\Entries\Entry$item, int$key) {
return [$item->id() => $item->title];
}),
],
];
}

[jasonvarga]

Casting a collection to an array like that won't work either.

I think you want to do this:

$options = $this->config('options') ?? [];
$options = $optionsinstanceof Collection ? $options->all() : $options;

[jasonvarga]

What class are you defining your public function fieldItems() in, by the way?

[jasonvarga]

I'm going to assume you were using that in a filter class, and the error you encountered was array_is_list(): Argument #1 ($array) must be of type array, Illuminate\Support\Collection given.

Adding (array) does prevent the error, but would break functionality elsewhere.

I've updated the PR. Thanks!

[sylvesterdamgaard]

Bug introduced in #10467
Cast to array to prevent issues with listings when data is returned as a Statamic\Entries\EntryCollection

The issue will happen when filters don't return an array, but a EntryCollection like this.

publicfunctionfieldItems()
{
$entries = \Statamic\Facades\Entry::query()->where('collection', 'locations')->get();
return [
'locations' => [
'type' => 'select',
'multiple' => true,
'options' => $entries->mapWithKeys(function (\Statamic\Entries\Entry$item, int$key) {
return [$item->id() => $item->title];
}),
],
];
}

[jasonvarga]

Casting a collection to an array like that won't work either.

I think you want to do this:

$options = $this->config('options') ?? [];
$options = $optionsinstanceof Collection ? $options->all() : $options;

[jasonvarga]

What class are you defining your public function fieldItems() in, by the way?

[jasonvarga]

I'm going to assume you were using that in a filter class, and the error you encountered was array_is_list(): Argument #1 ($array) must be of type array, Illuminate\Support\Collection given.

Adding (array) does prevent the error, but would break functionality elsewhere.

I've updated the PR. Thanks!

[sylvesterdamgaard]

Bug introduced in #10467
Cast to array to prevent issues with listings when data is returned as a Statamic\Entries\EntryCollection

The issue will happen when filters don't return an array, but a EntryCollection like this.

publicfunctionfieldItems()
{
$entries = \Statamic\Facades\Entry::query()->where('collection', 'locations')->get();
return [
'locations' => [
'type' => 'select',
'multiple' => true,
'options' => $entries->mapWithKeys(function (\Statamic\Entries\Entry$item, int$key) {
return [$item->id() => $item->title];
}),
],
];
}

[jasonvarga]

Casting a collection to an array like that won't work either.

I think you want to do this:

$options = $this->config('options') ?? [];
$options = $optionsinstanceof Collection ? $options->all() : $options;

[jasonvarga]

What class are you defining your public function fieldItems() in, by the way?

[jasonvarga]

I'm going to assume you were using that in a filter class, and the error you encountered was array_is_list(): Argument #1 ($array) must be of type array, Illuminate\Support\Collection given.

Adding (array) does prevent the error, but would break functionality elsewhere.

I've updated the PR. Thanks!

[sylvesterdamgaard]

Bug introduced in #10467
Cast to array to prevent issues with listings when data is returned as a Statamic\Entries\EntryCollection

The issue will happen when filters don't return an array, but a EntryCollection like this.

publicfunctionfieldItems()
{
$entries = \Statamic\Facades\Entry::query()->where('collection', 'locations')->get();
return [
'locations' => [
'type' => 'select',
'multiple' => true,
'options' => $entries->mapWithKeys(function (\Statamic\Entries\Entry$item, int$key) {
return [$item->id() => $item->title];
}),
],
];
}

[jasonvarga]

Casting a collection to an array like that won't work either.

I think you want to do this:

$options = $this->config('options') ?? [];
$options = $optionsinstanceof Collection ? $options->all() : $options;

[jasonvarga]

What class are you defining your public function fieldItems() in, by the way?

[jasonvarga]

I'm going to assume you were using that in a filter class, and the error you encountered was array_is_list(): Argument #1 ($array) must be of type array, Illuminate\Support\Collection given.

Adding (array) does prevent the error, but would break functionality elsewhere.

I've updated the PR. Thanks!

[sylvesterdamgaard]

Bug introduced in #10467
Cast to array to prevent issues with listings when data is returned as a Statamic\Entries\EntryCollection

The issue will happen when filters don't return an array, but a EntryCollection like this.

publicfunctionfieldItems()
{
$entries = \Statamic\Facades\Entry::query()->where('collection', 'locations')->get();
return [
'locations' => [
'type' => 'select',
'multiple' => true,
'options' => $entries->mapWithKeys(function (\Statamic\Entries\Entry$item, int$key) {
return [$item->id() => $item->title];
}),
],
];
}

[jasonvarga]

Casting a collection to an array like that won't work either.

I think you want to do this:

$options = $this->config('options') ?? [];
$options = $optionsinstanceof Collection ? $options->all() : $options;

[jasonvarga]

What class are you defining your public function fieldItems() in, by the way?

[jasonvarga]

I'm going to assume you were using that in a filter class, and the error you encountered was array_is_list(): Argument #1 ($array) must be of type array, Illuminate\Support\Collection given.

Adding (array) does prevent the error, but would break functionality elsewhere.

I've updated the PR. Thanks!

[sylvesterdamgaard]

Bug introduced in #10467
Cast to array to prevent issues with listings when data is returned as a Statamic\Entries\EntryCollection

The issue will happen when filters don't return an array, but a EntryCollection like this.

publicfunctionfieldItems()
{
$entries = \Statamic\Facades\Entry::query()->where('collection', 'locations')->get();
return [
'locations' => [
'type' => 'select',
'multiple' => true,
'options' => $entries->mapWithKeys(function (\Statamic\Entries\Entry$item, int$key) {
return [$item->id() => $item->title];
}),
],
];
}

[jasonvarga]

Casting a collection to an array like that won't work either.

I think you want to do this:

$options = $this->config('options') ?? [];
$options = $optionsinstanceof Collection ? $options->all() : $options;

[jasonvarga]

What class are you defining your public function fieldItems() in, by the way?

[jasonvarga]

I'm going to assume you were using that in a filter class, and the error you encountered was array_is_list(): Argument #1 ($array) must be of type array, Illuminate\Support\Collection given.

Adding (array) does prevent the error, but would break functionality elsewhere.

I've updated the PR. Thanks!

[sylvesterdamgaard]

Bug introduced in #10467
Cast to array to prevent issues with listings when data is returned as a Statamic\Entries\EntryCollection

The issue will happen when filters don't return an array, but a EntryCollection like this.

publicfunctionfieldItems()
{
$entries = \Statamic\Facades\Entry::query()->where('collection', 'locations')->get();
return [
'locations' => [
'type' => 'select',
'multiple' => true,
'options' => $entries->mapWithKeys(function (\Statamic\Entries\Entry$item, int$key) {
return [$item->id() => $item->title];
}),
],
];
}

[jasonvarga]

Casting a collection to an array like that won't work either.

I think you want to do this:

$options = $this->config('options') ?? [];
$options = $optionsinstanceof Collection ? $options->all() : $options;

[jasonvarga]

What class are you defining your public function fieldItems() in, by the way?

[jasonvarga]

I'm going to assume you were using that in a filter class, and the error you encountered was array_is_list(): Argument #1 ($array) must be of type array, Illuminate\Support\Collection given.

Adding (array) does prevent the error, but would break functionality elsewhere.

I've updated the PR. Thanks!