Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/API/FilterAuthorizer.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,8 @@

class FilterAuthorizer extends AbstractAuthorizer
{
protected $configKey = 'allowed_filters';

/**
* Get allowed filters for resource.
*
Expand All@@ -17,7 +19,7 @@ class FilterAuthorizer extends AbstractAuthorizer
*/
public function allowedForResource($configFile, $queriedResource)
{
$config = config("statamic.{$configFile}.resources.{$queriedResource}.allowed_filters");
$config = config("statamic.{$configFile}.resources.{$queriedResource}.{$this->configKey}");

// Use explicitly configured `allowed_filters` array, otherwise no filters should be allowed.
return is_array($config)
Expand DownExpand Up@@ -54,7 +56,7 @@ public function allowedForSubResources($configFile, $queriedResource, $queriedHa

// Determine if any of our queried resources have filters explicitly disabled.
$disabled = $resources
->filter(fn ($resource) => Arr::get($config, "{$resource}.allowed_filters") === false)
->filter(fn ($resource) => Arr::get($config, "{$resource}.{$this->configKey}") === false)
->isNotEmpty();

// If any queried resource is explicitly disabled, then no filters should be allowed.
Expand All@@ -65,10 +67,10 @@ public function allowedForSubResources($configFile, $queriedResource, $queriedHa
// Determine `allowed_filters` by filtering out any that don't appear in all of them.
// A resource named `*` will apply to all enabled resources at once.
return $resources
->map(fn ($resource) => $config[$resource]['allowed_filters'] ?? [])
->map(fn ($resource) => $config[$resource][$this->configKey] ?? [])
->reduce(function ($carry, $allowedFilters) use ($config) {
return $carry->intersect($allowedFilters)->merge($config['*']['allowed_filters'] ?? []);
}, collect($config[$resources[0] ?? '']['allowed_filters'] ?? []))
return $carry->intersect($allowedFilters)->merge($config['*'][$this->configKey] ?? []);
}, collect($config[$resources[0] ?? ''][$this->configKey] ?? []))
->all();
}
}
8 changes: 8 additions & 0 deletions src/API/QueryScopeAuthorizer.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
<?php

namespace Statamic\API;

class QueryScopeAuthorizer extends FilterAuthorizer
{
protected $configKey = 'allowed_query_scopes';
}
62 changes: 62 additions & 0 deletions src/Http/Controllers/API/ApiController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,10 @@
use Facades\Statamic\API\ResourceAuthorizer;
use Statamic\Exceptions\ApiValidationException;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\Scope;
use Statamic\Facades\Site;
use Statamic\Http\Controllers\Controller;
use Statamic\Support\Arr;
use Statamic\Support\Str;
use Statamic\Tags\Concerns\QueriesConditions;

Expand DownExpand Up@@ -80,12 +82,26 @@ protected function filterAllowedResources($items)
*
* @param \Statamic\Query\Builder $query
* @return \Statamic\Extensions\Pagination\LengthAwarePaginator
*
* @deprecated
*/
protected function filterSortAndPaginate($query)
{
return $this->updateAndPaginate($query);
}

/**
* Filter, sort, scope, and paginate query for API resource output.
*
* @param \Statamic\Query\Builder $query
* @return \Statamic\Extensions\Pagination\LengthAwarePaginator
*/
protected function updateAndPaginate($query)
{
return $this
->filter($query)
->sort($query)
->scope($query)
->paginate($query);
}

Expand DownExpand Up@@ -171,6 +187,52 @@ protected function doesntHaveFilter($field)
->contains($field);
}

/**
* Apply query scopes a query based on conditions in the query_scope parameter.
*
* /endpoint?query_scope[scope_handle]=foo&query_scope[another_scope]=bar
*
* @param \Statamic\Query\Builder $query
* @return $this
*/
protected function scope($query)
{
$this->getScopes()
->each(function ($value, $handle) use ($query) {
Scope::find($handle)?->apply($query, Arr::wrap($value));
});

return $this;
}

/**
* Get scopes for querying.
*
* @return \Illuminate\Support\Collection
*/
protected function getScopes()
{
if (! method_exists($this, 'allowedQueryScopes')) {
return collect();
}

$scopes = collect(request()->query_scope ?? []);

$allowedScopes = collect($this->allowedQueryScopes());

$forbidden = $scopes
->keys()
->filter(fn ($handle) => ! Scope::find($handle) || ! $allowedScopes->contains($handle));

if ($forbidden->isNotEmpty()) {
throw ApiValidationException::withMessages([
'query_scope' => Str::plural('Forbidden query scope', $forbidden).': '.$forbidden->join(', '),
]);
}

return $scopes;
}

/**
* Sorts the query based on the sort parameter.
*
Expand Down
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/AssetsController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Http\Resources\API\AssetResource;

class AssetsController extends ApiController
Expand All@@ -22,7 +23,7 @@ public function index($assetContainer)
->filter->isRelationship()->keys()->all();

return app(AssetResource::class)::collection(
$this->filterSortAndPaginate($assetContainer->queryAssets()->with($with))
$this->updateAndPaginate($assetContainer->queryAssets()->with($with))
);
}

Expand All@@ -37,4 +38,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'assets', $this->containerHandle);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'assets', $this->containerHandle);
}
}
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/CollectionEntriesController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\Entry;
use Statamic\Http\Resources\API\EntryResource;
Expand All@@ -29,7 +30,7 @@ public function index($collection)
->filter->isRelationship()->keys()->all();

return app(EntryResource::class)::collection(
$this->filterSortAndPaginate($collection->queryEntries()->with($with))
$this->updateAndPaginate($collection->queryEntries()->with($with))
);
}

Expand DownExpand Up@@ -81,4 +82,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'collections', $this->collectionHandle);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'collections', $this->collectionHandle);
}
}
6 changes: 6 additions & 0 deletions src/Http/Controllers/API/CollectionTreeController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Http\Resources\API\TreeResource;
use Statamic\Query\ItemQueryBuilder;
Expand DownExpand Up@@ -48,4 +49,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'collections', $this->collectionHandle);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'collections', $this->collectionHandle);
}
}
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/TaxonomyTermEntriesController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Facades\Statamic\API\ResourceAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\Collection;
Expand DownExpand Up@@ -46,7 +47,7 @@ public function index($taxonomy, $term)
$with = $this->getRelationshipFieldsFromCollections($taxonomy);

return app(EntryResource::class)::collection(
$this->filterSortAndPaginate($query->with($with))
$this->updateAndPaginate($query->with($with))
);
}

Expand All@@ -72,4 +73,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'collections', $this->allowedCollections);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'collections', $this->allowedCollections);
}
}
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/TaxonomyTermsController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\Term;
use Statamic\Http\Resources\API\TermResource;
Expand All@@ -24,7 +25,7 @@ public function index($taxonomy)
->filter->isRelationship()->keys()->all();

return app(TermResource::class)::collection(
$this->filterSortAndPaginate($taxonomy->queryTerms()->with($with))
$this->updateAndPaginate($taxonomy->queryTerms()->with($with))
);
}

Expand All@@ -43,4 +44,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'taxonomies', $this->taxonomyHandle);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'taxonomies', $this->taxonomyHandle);
}
}
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/UsersController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\User;
use Statamic\Http\Resources\API\UserResource;
Expand All@@ -16,7 +17,7 @@ public function index()
$this->abortIfDisabled();

return app(UserResource::class)::collection(
$this->filterSortAndPaginate(User::query())
$this->updateAndPaginate(User::query())
);
}

Expand All@@ -42,4 +43,9 @@ protected function allowedFilters()
->reject(fn ($field) => in_array($field, ['password', 'password_hash']))
->all();
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForResource('api', 'users');
}
}
28 changes: 28 additions & 0 deletions tests/API/APITest.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@
use Statamic\Facades\Blueprint;
use Statamic\Facades\Token;
use Statamic\Facades\User;
use Statamic\Query\Scopes\Scope;
use Tests\PreventSavingStacheItemsToDisk;
use Tests\TestCase;

Expand DownExpand Up@@ -136,6 +137,25 @@ public function it_filters_out_past_entries_from_past_private_collection()
$response->assertJsonPath('data.0.id', 'a');
}

#[Test]
public function it_can_use_a_query_scope_on_collection_entries_when_configuration_allows_for_it()
{
app('statamic.scopes')['test_scope'] = TestScope::class;

Facades\Config::set('statamic.api.resources.collections.pages', [
'allowed_query_scopes' => ['test_scope'],
]);

Facades\Collection::make('pages')->save();

Facades\Entry::make()->collection('pages')->id('about')->slug('about')->published(true)->save();
Facades\Entry::make()->collection('pages')->id('dance')->slug('dance')->published(true)->save();
Facades\Entry::make()->collection('pages')->id('nectar')->slug('nectar')->published(true)->save();

$this->assertEndpointDataCount('/api/collections/pages/entries?query_scope[test_scope][operator]=is&query_scope[test_scope][value]=about', 1);
$this->assertEndpointDataCount('/api/collections/pages/entries?query_scope[test_scope][operator]=isnt&query_scope[test_scope][value]=about', 2);
}

#[Test]
public function it_can_filter_collection_entries_when_configuration_allows_for_it()
{
Expand DownExpand Up@@ -592,3 +612,11 @@ public function handle(\Statamic\Contracts\Tokens\Token $token, \Illuminate\Http
return $next($token);
}
}

class TestScope extends Scope
{
public function apply($query, $values)
{
$query->where('id', $values['operator'] == 'is' ? '=' : '!=', $values['value']);
}
}
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[5.x] Support query scopes in REST API by ryanmitchell · Pull Request #10893 · statamic/cms · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/API/FilterAuthorizer.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,8 @@

class FilterAuthorizer extends AbstractAuthorizer
{
protected $configKey = 'allowed_filters';

/**
* Get allowed filters for resource.
*
Expand All@@ -17,7 +19,7 @@ class FilterAuthorizer extends AbstractAuthorizer
*/
public function allowedForResource($configFile, $queriedResource)
{
$config = config("statamic.{$configFile}.resources.{$queriedResource}.allowed_filters");
$config = config("statamic.{$configFile}.resources.{$queriedResource}.{$this->configKey}");

// Use explicitly configured `allowed_filters` array, otherwise no filters should be allowed.
return is_array($config)
Expand DownExpand Up@@ -54,7 +56,7 @@ public function allowedForSubResources($configFile, $queriedResource, $queriedHa

// Determine if any of our queried resources have filters explicitly disabled.
$disabled = $resources
->filter(fn ($resource) => Arr::get($config, "{$resource}.allowed_filters") === false)
->filter(fn ($resource) => Arr::get($config, "{$resource}.{$this->configKey}") === false)
->isNotEmpty();

// If any queried resource is explicitly disabled, then no filters should be allowed.
Expand All@@ -65,10 +67,10 @@ public function allowedForSubResources($configFile, $queriedResource, $queriedHa
// Determine `allowed_filters` by filtering out any that don't appear in all of them.
// A resource named `*` will apply to all enabled resources at once.
return $resources
->map(fn ($resource) => $config[$resource]['allowed_filters'] ?? [])
->map(fn ($resource) => $config[$resource][$this->configKey] ?? [])
->reduce(function ($carry, $allowedFilters) use ($config) {
return $carry->intersect($allowedFilters)->merge($config['*']['allowed_filters'] ?? []);
}, collect($config[$resources[0] ?? '']['allowed_filters'] ?? []))
return $carry->intersect($allowedFilters)->merge($config['*'][$this->configKey] ?? []);
}, collect($config[$resources[0] ?? ''][$this->configKey] ?? []))
->all();
}
}
8 changes: 8 additions & 0 deletions src/API/QueryScopeAuthorizer.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
<?php

namespace Statamic\API;

class QueryScopeAuthorizer extends FilterAuthorizer
{
protected $configKey = 'allowed_query_scopes';
}
62 changes: 62 additions & 0 deletions src/Http/Controllers/API/ApiController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,10 @@
use Facades\Statamic\API\ResourceAuthorizer;
use Statamic\Exceptions\ApiValidationException;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\Scope;
use Statamic\Facades\Site;
use Statamic\Http\Controllers\Controller;
use Statamic\Support\Arr;
use Statamic\Support\Str;
use Statamic\Tags\Concerns\QueriesConditions;

Expand DownExpand Up@@ -80,12 +82,26 @@ protected function filterAllowedResources($items)
*
* @param \Statamic\Query\Builder $query
* @return \Statamic\Extensions\Pagination\LengthAwarePaginator
*
* @deprecated
*/
protected function filterSortAndPaginate($query)
{
return $this->updateAndPaginate($query);
}

/**
* Filter, sort, scope, and paginate query for API resource output.
*
* @param \Statamic\Query\Builder $query
* @return \Statamic\Extensions\Pagination\LengthAwarePaginator
*/
protected function updateAndPaginate($query)
{
return $this
->filter($query)
->sort($query)
->scope($query)
->paginate($query);
}

Expand DownExpand Up@@ -171,6 +187,52 @@ protected function doesntHaveFilter($field)
->contains($field);
}

/**
* Apply query scopes a query based on conditions in the query_scope parameter.
*
* /endpoint?query_scope[scope_handle]=foo&query_scope[another_scope]=bar
*
* @param \Statamic\Query\Builder $query
* @return $this
*/
protected function scope($query)
{
$this->getScopes()
->each(function ($value, $handle) use ($query) {
Scope::find($handle)?->apply($query, Arr::wrap($value));
});

return $this;
}

/**
* Get scopes for querying.
*
* @return \Illuminate\Support\Collection
*/
protected function getScopes()
{
if (! method_exists($this, 'allowedQueryScopes')) {
return collect();
}

$scopes = collect(request()->query_scope ?? []);

$allowedScopes = collect($this->allowedQueryScopes());

$forbidden = $scopes
->keys()
->filter(fn ($handle) => ! Scope::find($handle) || ! $allowedScopes->contains($handle));

if ($forbidden->isNotEmpty()) {
throw ApiValidationException::withMessages([
'query_scope' => Str::plural('Forbidden query scope', $forbidden).': '.$forbidden->join(', '),
]);
}

return $scopes;
}

/**
* Sorts the query based on the sort parameter.
*
Expand Down
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/AssetsController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Http\Resources\API\AssetResource;

class AssetsController extends ApiController
Expand All@@ -22,7 +23,7 @@ public function index($assetContainer)
->filter->isRelationship()->keys()->all();

return app(AssetResource::class)::collection(
$this->filterSortAndPaginate($assetContainer->queryAssets()->with($with))
$this->updateAndPaginate($assetContainer->queryAssets()->with($with))
);
}

Expand All@@ -37,4 +38,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'assets', $this->containerHandle);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'assets', $this->containerHandle);
}
}
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/CollectionEntriesController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\Entry;
use Statamic\Http\Resources\API\EntryResource;
Expand All@@ -29,7 +30,7 @@ public function index($collection)
->filter->isRelationship()->keys()->all();

return app(EntryResource::class)::collection(
$this->filterSortAndPaginate($collection->queryEntries()->with($with))
$this->updateAndPaginate($collection->queryEntries()->with($with))
);
}

Expand DownExpand Up@@ -81,4 +82,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'collections', $this->collectionHandle);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'collections', $this->collectionHandle);
}
}
6 changes: 6 additions & 0 deletions src/Http/Controllers/API/CollectionTreeController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Http\Resources\API\TreeResource;
use Statamic\Query\ItemQueryBuilder;
Expand DownExpand Up@@ -48,4 +49,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'collections', $this->collectionHandle);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'collections', $this->collectionHandle);
}
}
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/TaxonomyTermEntriesController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Facades\Statamic\API\ResourceAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\Collection;
Expand DownExpand Up@@ -46,7 +47,7 @@ public function index($taxonomy, $term)
$with = $this->getRelationshipFieldsFromCollections($taxonomy);

return app(EntryResource::class)::collection(
$this->filterSortAndPaginate($query->with($with))
$this->updateAndPaginate($query->with($with))
);
}

Expand All@@ -72,4 +73,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'collections', $this->allowedCollections);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'collections', $this->allowedCollections);
}
}
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/TaxonomyTermsController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\Term;
use Statamic\Http\Resources\API\TermResource;
Expand All@@ -24,7 +25,7 @@ public function index($taxonomy)
->filter->isRelationship()->keys()->all();

return app(TermResource::class)::collection(
$this->filterSortAndPaginate($taxonomy->queryTerms()->with($with))
$this->updateAndPaginate($taxonomy->queryTerms()->with($with))
);
}

Expand All@@ -43,4 +44,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'taxonomies', $this->taxonomyHandle);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'taxonomies', $this->taxonomyHandle);
}
}
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/UsersController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\User;
use Statamic\Http\Resources\API\UserResource;
Expand All@@ -16,7 +17,7 @@ public function index()
$this->abortIfDisabled();

return app(UserResource::class)::collection(
$this->filterSortAndPaginate(User::query())
$this->updateAndPaginate(User::query())
);
}

Expand All@@ -42,4 +43,9 @@ protected function allowedFilters()
->reject(fn ($field) => in_array($field, ['password', 'password_hash']))
->all();
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForResource('api', 'users');
}
}
28 changes: 28 additions & 0 deletions tests/API/APITest.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@
use Statamic\Facades\Blueprint;
use Statamic\Facades\Token;
use Statamic\Facades\User;
use Statamic\Query\Scopes\Scope;
use Tests\PreventSavingStacheItemsToDisk;
use Tests\TestCase;

Expand DownExpand Up@@ -136,6 +137,25 @@ public function it_filters_out_past_entries_from_past_private_collection()
$response->assertJsonPath('data.0.id', 'a');
}

#[Test]
public function it_can_use_a_query_scope_on_collection_entries_when_configuration_allows_for_it()
{
app('statamic.scopes')['test_scope'] = TestScope::class;

Facades\Config::set('statamic.api.resources.collections.pages', [
'allowed_query_scopes' => ['test_scope'],
]);

Facades\Collection::make('pages')->save();

Facades\Entry::make()->collection('pages')->id('about')->slug('about')->published(true)->save();
Facades\Entry::make()->collection('pages')->id('dance')->slug('dance')->published(true)->save();
Facades\Entry::make()->collection('pages')->id('nectar')->slug('nectar')->published(true)->save();

$this->assertEndpointDataCount('/api/collections/pages/entries?query_scope[test_scope][operator]=is&query_scope[test_scope][value]=about', 1);
$this->assertEndpointDataCount('/api/collections/pages/entries?query_scope[test_scope][operator]=isnt&query_scope[test_scope][value]=about', 2);
}

#[Test]
public function it_can_filter_collection_entries_when_configuration_allows_for_it()
{
Expand DownExpand Up@@ -592,3 +612,11 @@ public function handle(\Statamic\Contracts\Tokens\Token $token, \Illuminate\Http
return $next($token);
}
}

class TestScope extends Scope
{
public function apply($query, $values)
{
$query->where('id', $values['operator'] == 'is' ? '=' : '!=', $values['value']);
}
}
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [5.x] Support query scopes in REST API by ryanmitchell · Pull Request #10893 · statamic/cms · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/API/FilterAuthorizer.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,8 @@

class FilterAuthorizer extends AbstractAuthorizer
{
protected $configKey = 'allowed_filters';

/**
* Get allowed filters for resource.
*
Expand All@@ -17,7 +19,7 @@ class FilterAuthorizer extends AbstractAuthorizer
*/
public function allowedForResource($configFile, $queriedResource)
{
$config = config("statamic.{$configFile}.resources.{$queriedResource}.allowed_filters");
$config = config("statamic.{$configFile}.resources.{$queriedResource}.{$this->configKey}");

// Use explicitly configured `allowed_filters` array, otherwise no filters should be allowed.
return is_array($config)
Expand DownExpand Up@@ -54,7 +56,7 @@ public function allowedForSubResources($configFile, $queriedResource, $queriedHa

// Determine if any of our queried resources have filters explicitly disabled.
$disabled = $resources
->filter(fn ($resource) => Arr::get($config, "{$resource}.allowed_filters") === false)
->filter(fn ($resource) => Arr::get($config, "{$resource}.{$this->configKey}") === false)
->isNotEmpty();

// If any queried resource is explicitly disabled, then no filters should be allowed.
Expand All@@ -65,10 +67,10 @@ public function allowedForSubResources($configFile, $queriedResource, $queriedHa
// Determine `allowed_filters` by filtering out any that don't appear in all of them.
// A resource named `*` will apply to all enabled resources at once.
return $resources
->map(fn ($resource) => $config[$resource]['allowed_filters'] ?? [])
->map(fn ($resource) => $config[$resource][$this->configKey] ?? [])
->reduce(function ($carry, $allowedFilters) use ($config) {
return $carry->intersect($allowedFilters)->merge($config['*']['allowed_filters'] ?? []);
}, collect($config[$resources[0] ?? '']['allowed_filters'] ?? []))
return $carry->intersect($allowedFilters)->merge($config['*'][$this->configKey] ?? []);
}, collect($config[$resources[0] ?? ''][$this->configKey] ?? []))
->all();
}
}
8 changes: 8 additions & 0 deletions src/API/QueryScopeAuthorizer.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
<?php

namespace Statamic\API;

class QueryScopeAuthorizer extends FilterAuthorizer
{
protected $configKey = 'allowed_query_scopes';
}
62 changes: 62 additions & 0 deletions src/Http/Controllers/API/ApiController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,10 @@
use Facades\Statamic\API\ResourceAuthorizer;
use Statamic\Exceptions\ApiValidationException;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\Scope;
use Statamic\Facades\Site;
use Statamic\Http\Controllers\Controller;
use Statamic\Support\Arr;
use Statamic\Support\Str;
use Statamic\Tags\Concerns\QueriesConditions;

Expand DownExpand Up@@ -80,12 +82,26 @@ protected function filterAllowedResources($items)
*
* @param \Statamic\Query\Builder $query
* @return \Statamic\Extensions\Pagination\LengthAwarePaginator
*
* @deprecated
*/
protected function filterSortAndPaginate($query)
{
return $this->updateAndPaginate($query);
}

/**
* Filter, sort, scope, and paginate query for API resource output.
*
* @param \Statamic\Query\Builder $query
* @return \Statamic\Extensions\Pagination\LengthAwarePaginator
*/
protected function updateAndPaginate($query)
{
return $this
->filter($query)
->sort($query)
->scope($query)
->paginate($query);
}

Expand DownExpand Up@@ -171,6 +187,52 @@ protected function doesntHaveFilter($field)
->contains($field);
}

/**
* Apply query scopes a query based on conditions in the query_scope parameter.
*
* /endpoint?query_scope[scope_handle]=foo&query_scope[another_scope]=bar
*
* @param \Statamic\Query\Builder $query
* @return $this
*/
protected function scope($query)
{
$this->getScopes()
->each(function ($value, $handle) use ($query) {
Scope::find($handle)?->apply($query, Arr::wrap($value));
});

return $this;
}

/**
* Get scopes for querying.
*
* @return \Illuminate\Support\Collection
*/
protected function getScopes()
{
if (! method_exists($this, 'allowedQueryScopes')) {
return collect();
}

$scopes = collect(request()->query_scope ?? []);

$allowedScopes = collect($this->allowedQueryScopes());

$forbidden = $scopes
->keys()
->filter(fn ($handle) => ! Scope::find($handle) || ! $allowedScopes->contains($handle));

if ($forbidden->isNotEmpty()) {
throw ApiValidationException::withMessages([
'query_scope' => Str::plural('Forbidden query scope', $forbidden).': '.$forbidden->join(', '),
]);
}

return $scopes;
}

/**
* Sorts the query based on the sort parameter.
*
Expand Down
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/AssetsController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Http\Resources\API\AssetResource;

class AssetsController extends ApiController
Expand All@@ -22,7 +23,7 @@ public function index($assetContainer)
->filter->isRelationship()->keys()->all();

return app(AssetResource::class)::collection(
$this->filterSortAndPaginate($assetContainer->queryAssets()->with($with))
$this->updateAndPaginate($assetContainer->queryAssets()->with($with))
);
}

Expand All@@ -37,4 +38,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'assets', $this->containerHandle);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'assets', $this->containerHandle);
}
}
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/CollectionEntriesController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\Entry;
use Statamic\Http\Resources\API\EntryResource;
Expand All@@ -29,7 +30,7 @@ public function index($collection)
->filter->isRelationship()->keys()->all();

return app(EntryResource::class)::collection(
$this->filterSortAndPaginate($collection->queryEntries()->with($with))
$this->updateAndPaginate($collection->queryEntries()->with($with))
);
}

Expand DownExpand Up@@ -81,4 +82,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'collections', $this->collectionHandle);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'collections', $this->collectionHandle);
}
}
6 changes: 6 additions & 0 deletions src/Http/Controllers/API/CollectionTreeController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Http\Resources\API\TreeResource;
use Statamic\Query\ItemQueryBuilder;
Expand DownExpand Up@@ -48,4 +49,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'collections', $this->collectionHandle);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'collections', $this->collectionHandle);
}
}
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/TaxonomyTermEntriesController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Facades\Statamic\API\ResourceAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\Collection;
Expand DownExpand Up@@ -46,7 +47,7 @@ public function index($taxonomy, $term)
$with = $this->getRelationshipFieldsFromCollections($taxonomy);

return app(EntryResource::class)::collection(
$this->filterSortAndPaginate($query->with($with))
$this->updateAndPaginate($query->with($with))
);
}

Expand All@@ -72,4 +73,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'collections', $this->allowedCollections);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'collections', $this->allowedCollections);
}
}
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/TaxonomyTermsController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\Term;
use Statamic\Http\Resources\API\TermResource;
Expand All@@ -24,7 +25,7 @@ public function index($taxonomy)
->filter->isRelationship()->keys()->all();

return app(TermResource::class)::collection(
$this->filterSortAndPaginate($taxonomy->queryTerms()->with($with))
$this->updateAndPaginate($taxonomy->queryTerms()->with($with))
);
}

Expand All@@ -43,4 +44,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'taxonomies', $this->taxonomyHandle);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'taxonomies', $this->taxonomyHandle);
}
}
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/UsersController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\User;
use Statamic\Http\Resources\API\UserResource;
Expand All@@ -16,7 +17,7 @@ public function index()
$this->abortIfDisabled();

return app(UserResource::class)::collection(
$this->filterSortAndPaginate(User::query())
$this->updateAndPaginate(User::query())
);
}

Expand All@@ -42,4 +43,9 @@ protected function allowedFilters()
->reject(fn ($field) => in_array($field, ['password', 'password_hash']))
->all();
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForResource('api', 'users');
}
}
28 changes: 28 additions & 0 deletions tests/API/APITest.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@
use Statamic\Facades\Blueprint;
use Statamic\Facades\Token;
use Statamic\Facades\User;
use Statamic\Query\Scopes\Scope;
use Tests\PreventSavingStacheItemsToDisk;
use Tests\TestCase;

Expand DownExpand Up@@ -136,6 +137,25 @@ public function it_filters_out_past_entries_from_past_private_collection()
$response->assertJsonPath('data.0.id', 'a');
}

#[Test]
public function it_can_use_a_query_scope_on_collection_entries_when_configuration_allows_for_it()
{
app('statamic.scopes')['test_scope'] = TestScope::class;

Facades\Config::set('statamic.api.resources.collections.pages', [
'allowed_query_scopes' => ['test_scope'],
]);

Facades\Collection::make('pages')->save();

Facades\Entry::make()->collection('pages')->id('about')->slug('about')->published(true)->save();
Facades\Entry::make()->collection('pages')->id('dance')->slug('dance')->published(true)->save();
Facades\Entry::make()->collection('pages')->id('nectar')->slug('nectar')->published(true)->save();

$this->assertEndpointDataCount('/api/collections/pages/entries?query_scope[test_scope][operator]=is&query_scope[test_scope][value]=about', 1);
$this->assertEndpointDataCount('/api/collections/pages/entries?query_scope[test_scope][operator]=isnt&query_scope[test_scope][value]=about', 2);
}

#[Test]
public function it_can_filter_collection_entries_when_configuration_allows_for_it()
{
Expand DownExpand Up@@ -592,3 +612,11 @@ public function handle(\Statamic\Contracts\Tokens\Token $token, \Illuminate\Http
return $next($token);
}
}

class TestScope extends Scope
{
public function apply($query, $values)
{
$query->where('id', $values['operator'] == 'is' ? '=' : '!=', $values['value']);
}
}
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [5.x] Support query scopes in REST API by ryanmitchell · Pull Request #10893 · statamic/cms · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/API/FilterAuthorizer.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,8 @@

class FilterAuthorizer extends AbstractAuthorizer
{
protected $configKey = 'allowed_filters';

/**
* Get allowed filters for resource.
*
Expand All@@ -17,7 +19,7 @@ class FilterAuthorizer extends AbstractAuthorizer
*/
public function allowedForResource($configFile, $queriedResource)
{
$config = config("statamic.{$configFile}.resources.{$queriedResource}.allowed_filters");
$config = config("statamic.{$configFile}.resources.{$queriedResource}.{$this->configKey}");

// Use explicitly configured `allowed_filters` array, otherwise no filters should be allowed.
return is_array($config)
Expand DownExpand Up@@ -54,7 +56,7 @@ public function allowedForSubResources($configFile, $queriedResource, $queriedHa

// Determine if any of our queried resources have filters explicitly disabled.
$disabled = $resources
->filter(fn ($resource) => Arr::get($config, "{$resource}.allowed_filters") === false)
->filter(fn ($resource) => Arr::get($config, "{$resource}.{$this->configKey}") === false)
->isNotEmpty();

// If any queried resource is explicitly disabled, then no filters should be allowed.
Expand All@@ -65,10 +67,10 @@ public function allowedForSubResources($configFile, $queriedResource, $queriedHa
// Determine `allowed_filters` by filtering out any that don't appear in all of them.
// A resource named `*` will apply to all enabled resources at once.
return $resources
->map(fn ($resource) => $config[$resource]['allowed_filters'] ?? [])
->map(fn ($resource) => $config[$resource][$this->configKey] ?? [])
->reduce(function ($carry, $allowedFilters) use ($config) {
return $carry->intersect($allowedFilters)->merge($config['*']['allowed_filters'] ?? []);
}, collect($config[$resources[0] ?? '']['allowed_filters'] ?? []))
return $carry->intersect($allowedFilters)->merge($config['*'][$this->configKey] ?? []);
}, collect($config[$resources[0] ?? ''][$this->configKey] ?? []))
->all();
}
}
8 changes: 8 additions & 0 deletions src/API/QueryScopeAuthorizer.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
<?php

namespace Statamic\API;

class QueryScopeAuthorizer extends FilterAuthorizer
{
protected $configKey = 'allowed_query_scopes';
}
62 changes: 62 additions & 0 deletions src/Http/Controllers/API/ApiController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,10 @@
use Facades\Statamic\API\ResourceAuthorizer;
use Statamic\Exceptions\ApiValidationException;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\Scope;
use Statamic\Facades\Site;
use Statamic\Http\Controllers\Controller;
use Statamic\Support\Arr;
use Statamic\Support\Str;
use Statamic\Tags\Concerns\QueriesConditions;

Expand DownExpand Up@@ -80,12 +82,26 @@ protected function filterAllowedResources($items)
*
* @param \Statamic\Query\Builder $query
* @return \Statamic\Extensions\Pagination\LengthAwarePaginator
*
* @deprecated
*/
protected function filterSortAndPaginate($query)
{
return $this->updateAndPaginate($query);
}

/**
* Filter, sort, scope, and paginate query for API resource output.
*
* @param \Statamic\Query\Builder $query
* @return \Statamic\Extensions\Pagination\LengthAwarePaginator
*/
protected function updateAndPaginate($query)
{
return $this
->filter($query)
->sort($query)
->scope($query)
->paginate($query);
}

Expand DownExpand Up@@ -171,6 +187,52 @@ protected function doesntHaveFilter($field)
->contains($field);
}

/**
* Apply query scopes a query based on conditions in the query_scope parameter.
*
* /endpoint?query_scope[scope_handle]=foo&query_scope[another_scope]=bar
*
* @param \Statamic\Query\Builder $query
* @return $this
*/
protected function scope($query)
{
$this->getScopes()
->each(function ($value, $handle) use ($query) {
Scope::find($handle)?->apply($query, Arr::wrap($value));
});

return $this;
}

/**
* Get scopes for querying.
*
* @return \Illuminate\Support\Collection
*/
protected function getScopes()
{
if (! method_exists($this, 'allowedQueryScopes')) {
return collect();
}

$scopes = collect(request()->query_scope ?? []);

$allowedScopes = collect($this->allowedQueryScopes());

$forbidden = $scopes
->keys()
->filter(fn ($handle) => ! Scope::find($handle) || ! $allowedScopes->contains($handle));

if ($forbidden->isNotEmpty()) {
throw ApiValidationException::withMessages([
'query_scope' => Str::plural('Forbidden query scope', $forbidden).': '.$forbidden->join(', '),
]);
}

return $scopes;
}

/**
* Sorts the query based on the sort parameter.
*
Expand Down
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/AssetsController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Http\Resources\API\AssetResource;

class AssetsController extends ApiController
Expand All@@ -22,7 +23,7 @@ public function index($assetContainer)
->filter->isRelationship()->keys()->all();

return app(AssetResource::class)::collection(
$this->filterSortAndPaginate($assetContainer->queryAssets()->with($with))
$this->updateAndPaginate($assetContainer->queryAssets()->with($with))
);
}

Expand All@@ -37,4 +38,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'assets', $this->containerHandle);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'assets', $this->containerHandle);
}
}
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/CollectionEntriesController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\Entry;
use Statamic\Http\Resources\API\EntryResource;
Expand All@@ -29,7 +30,7 @@ public function index($collection)
->filter->isRelationship()->keys()->all();

return app(EntryResource::class)::collection(
$this->filterSortAndPaginate($collection->queryEntries()->with($with))
$this->updateAndPaginate($collection->queryEntries()->with($with))
);
}

Expand DownExpand Up@@ -81,4 +82,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'collections', $this->collectionHandle);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'collections', $this->collectionHandle);
}
}
6 changes: 6 additions & 0 deletions src/Http/Controllers/API/CollectionTreeController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Http\Resources\API\TreeResource;
use Statamic\Query\ItemQueryBuilder;
Expand DownExpand Up@@ -48,4 +49,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'collections', $this->collectionHandle);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'collections', $this->collectionHandle);
}
}
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/TaxonomyTermEntriesController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Facades\Statamic\API\ResourceAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\Collection;
Expand DownExpand Up@@ -46,7 +47,7 @@ public function index($taxonomy, $term)
$with = $this->getRelationshipFieldsFromCollections($taxonomy);

return app(EntryResource::class)::collection(
$this->filterSortAndPaginate($query->with($with))
$this->updateAndPaginate($query->with($with))
);
}

Expand All@@ -72,4 +73,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'collections', $this->allowedCollections);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'collections', $this->allowedCollections);
}
}
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/TaxonomyTermsController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\Term;
use Statamic\Http\Resources\API\TermResource;
Expand All@@ -24,7 +25,7 @@ public function index($taxonomy)
->filter->isRelationship()->keys()->all();

return app(TermResource::class)::collection(
$this->filterSortAndPaginate($taxonomy->queryTerms()->with($with))
$this->updateAndPaginate($taxonomy->queryTerms()->with($with))
);
}

Expand All@@ -43,4 +44,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'taxonomies', $this->taxonomyHandle);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'taxonomies', $this->taxonomyHandle);
}
}
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/UsersController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\User;
use Statamic\Http\Resources\API\UserResource;
Expand All@@ -16,7 +17,7 @@ public function index()
$this->abortIfDisabled();

return app(UserResource::class)::collection(
$this->filterSortAndPaginate(User::query())
$this->updateAndPaginate(User::query())
);
}

Expand All@@ -42,4 +43,9 @@ protected function allowedFilters()
->reject(fn ($field) => in_array($field, ['password', 'password_hash']))
->all();
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForResource('api', 'users');
}
}
28 changes: 28 additions & 0 deletions tests/API/APITest.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@
use Statamic\Facades\Blueprint;
use Statamic\Facades\Token;
use Statamic\Facades\User;
use Statamic\Query\Scopes\Scope;
use Tests\PreventSavingStacheItemsToDisk;
use Tests\TestCase;

Expand DownExpand Up@@ -136,6 +137,25 @@ public function it_filters_out_past_entries_from_past_private_collection()
$response->assertJsonPath('data.0.id', 'a');
}

#[Test]
public function it_can_use_a_query_scope_on_collection_entries_when_configuration_allows_for_it()
{
app('statamic.scopes')['test_scope'] = TestScope::class;

Facades\Config::set('statamic.api.resources.collections.pages', [
'allowed_query_scopes' => ['test_scope'],
]);

Facades\Collection::make('pages')->save();

Facades\Entry::make()->collection('pages')->id('about')->slug('about')->published(true)->save();
Facades\Entry::make()->collection('pages')->id('dance')->slug('dance')->published(true)->save();
Facades\Entry::make()->collection('pages')->id('nectar')->slug('nectar')->published(true)->save();

$this->assertEndpointDataCount('/api/collections/pages/entries?query_scope[test_scope][operator]=is&query_scope[test_scope][value]=about', 1);
$this->assertEndpointDataCount('/api/collections/pages/entries?query_scope[test_scope][operator]=isnt&query_scope[test_scope][value]=about', 2);
}

#[Test]
public function it_can_filter_collection_entries_when_configuration_allows_for_it()
{
Expand DownExpand Up@@ -592,3 +612,11 @@ public function handle(\Statamic\Contracts\Tokens\Token $token, \Illuminate\Http
return $next($token);
}
}

class TestScope extends Scope
{
public function apply($query, $values)
{
$query->where('id', $values['operator'] == 'is' ? '=' : '!=', $values['value']);
}
}
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' [5.x] Support query scopes in REST API by ryanmitchell · Pull Request #10893 · statamic/cms · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/API/FilterAuthorizer.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,8 @@

class FilterAuthorizer extends AbstractAuthorizer
{
protected $configKey = 'allowed_filters';

/**
* Get allowed filters for resource.
*
Expand All@@ -17,7 +19,7 @@ class FilterAuthorizer extends AbstractAuthorizer
*/
public function allowedForResource($configFile, $queriedResource)
{
$config = config("statamic.{$configFile}.resources.{$queriedResource}.allowed_filters");
$config = config("statamic.{$configFile}.resources.{$queriedResource}.{$this->configKey}");

// Use explicitly configured `allowed_filters` array, otherwise no filters should be allowed.
return is_array($config)
Expand DownExpand Up@@ -54,7 +56,7 @@ public function allowedForSubResources($configFile, $queriedResource, $queriedHa

// Determine if any of our queried resources have filters explicitly disabled.
$disabled = $resources
->filter(fn ($resource) => Arr::get($config, "{$resource}.allowed_filters") === false)
->filter(fn ($resource) => Arr::get($config, "{$resource}.{$this->configKey}") === false)
->isNotEmpty();

// If any queried resource is explicitly disabled, then no filters should be allowed.
Expand All@@ -65,10 +67,10 @@ public function allowedForSubResources($configFile, $queriedResource, $queriedHa
// Determine `allowed_filters` by filtering out any that don't appear in all of them.
// A resource named `*` will apply to all enabled resources at once.
return $resources
->map(fn ($resource) => $config[$resource]['allowed_filters'] ?? [])
->map(fn ($resource) => $config[$resource][$this->configKey] ?? [])
->reduce(function ($carry, $allowedFilters) use ($config) {
return $carry->intersect($allowedFilters)->merge($config['*']['allowed_filters'] ?? []);
}, collect($config[$resources[0] ?? '']['allowed_filters'] ?? []))
return $carry->intersect($allowedFilters)->merge($config['*'][$this->configKey] ?? []);
}, collect($config[$resources[0] ?? ''][$this->configKey] ?? []))
->all();
}
}
8 changes: 8 additions & 0 deletions src/API/QueryScopeAuthorizer.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
<?php

namespace Statamic\API;

class QueryScopeAuthorizer extends FilterAuthorizer
{
protected $configKey = 'allowed_query_scopes';
}
62 changes: 62 additions & 0 deletions src/Http/Controllers/API/ApiController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,10 @@
use Facades\Statamic\API\ResourceAuthorizer;
use Statamic\Exceptions\ApiValidationException;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\Scope;
use Statamic\Facades\Site;
use Statamic\Http\Controllers\Controller;
use Statamic\Support\Arr;
use Statamic\Support\Str;
use Statamic\Tags\Concerns\QueriesConditions;

Expand DownExpand Up@@ -80,12 +82,26 @@ protected function filterAllowedResources($items)
*
* @param \Statamic\Query\Builder $query
* @return \Statamic\Extensions\Pagination\LengthAwarePaginator
*
* @deprecated
*/
protected function filterSortAndPaginate($query)
{
return $this->updateAndPaginate($query);
}

/**
* Filter, sort, scope, and paginate query for API resource output.
*
* @param \Statamic\Query\Builder $query
* @return \Statamic\Extensions\Pagination\LengthAwarePaginator
*/
protected function updateAndPaginate($query)
{
return $this
->filter($query)
->sort($query)
->scope($query)
->paginate($query);
}

Expand DownExpand Up@@ -171,6 +187,52 @@ protected function doesntHaveFilter($field)
->contains($field);
}

/**
* Apply query scopes a query based on conditions in the query_scope parameter.
*
* /endpoint?query_scope[scope_handle]=foo&query_scope[another_scope]=bar
*
* @param \Statamic\Query\Builder $query
* @return $this
*/
protected function scope($query)
{
$this->getScopes()
->each(function ($value, $handle) use ($query) {
Scope::find($handle)?->apply($query, Arr::wrap($value));
});

return $this;
}

/**
* Get scopes for querying.
*
* @return \Illuminate\Support\Collection
*/
protected function getScopes()
{
if (! method_exists($this, 'allowedQueryScopes')) {
return collect();
}

$scopes = collect(request()->query_scope ?? []);

$allowedScopes = collect($this->allowedQueryScopes());

$forbidden = $scopes
->keys()
->filter(fn ($handle) => ! Scope::find($handle) || ! $allowedScopes->contains($handle));

if ($forbidden->isNotEmpty()) {
throw ApiValidationException::withMessages([
'query_scope' => Str::plural('Forbidden query scope', $forbidden).': '.$forbidden->join(', '),
]);
}

return $scopes;
}

/**
* Sorts the query based on the sort parameter.
*
Expand Down
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/AssetsController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Http\Resources\API\AssetResource;

class AssetsController extends ApiController
Expand All@@ -22,7 +23,7 @@ public function index($assetContainer)
->filter->isRelationship()->keys()->all();

return app(AssetResource::class)::collection(
$this->filterSortAndPaginate($assetContainer->queryAssets()->with($with))
$this->updateAndPaginate($assetContainer->queryAssets()->with($with))
);
}

Expand All@@ -37,4 +38,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'assets', $this->containerHandle);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'assets', $this->containerHandle);
}
}
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/CollectionEntriesController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\Entry;
use Statamic\Http\Resources\API\EntryResource;
Expand All@@ -29,7 +30,7 @@ public function index($collection)
->filter->isRelationship()->keys()->all();

return app(EntryResource::class)::collection(
$this->filterSortAndPaginate($collection->queryEntries()->with($with))
$this->updateAndPaginate($collection->queryEntries()->with($with))
);
}

Expand DownExpand Up@@ -81,4 +82,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'collections', $this->collectionHandle);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'collections', $this->collectionHandle);
}
}
6 changes: 6 additions & 0 deletions src/Http/Controllers/API/CollectionTreeController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Http\Resources\API\TreeResource;
use Statamic\Query\ItemQueryBuilder;
Expand DownExpand Up@@ -48,4 +49,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'collections', $this->collectionHandle);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'collections', $this->collectionHandle);
}
}
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/TaxonomyTermEntriesController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Facades\Statamic\API\ResourceAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\Collection;
Expand DownExpand Up@@ -46,7 +47,7 @@ public function index($taxonomy, $term)
$with = $this->getRelationshipFieldsFromCollections($taxonomy);

return app(EntryResource::class)::collection(
$this->filterSortAndPaginate($query->with($with))
$this->updateAndPaginate($query->with($with))
);
}

Expand All@@ -72,4 +73,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'collections', $this->allowedCollections);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'collections', $this->allowedCollections);
}
}
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/TaxonomyTermsController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\Term;
use Statamic\Http\Resources\API\TermResource;
Expand All@@ -24,7 +25,7 @@ public function index($taxonomy)
->filter->isRelationship()->keys()->all();

return app(TermResource::class)::collection(
$this->filterSortAndPaginate($taxonomy->queryTerms()->with($with))
$this->updateAndPaginate($taxonomy->queryTerms()->with($with))
);
}

Expand All@@ -43,4 +44,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'taxonomies', $this->taxonomyHandle);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'taxonomies', $this->taxonomyHandle);
}
}
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/UsersController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\User;
use Statamic\Http\Resources\API\UserResource;
Expand All@@ -16,7 +17,7 @@ public function index()
$this->abortIfDisabled();

return app(UserResource::class)::collection(
$this->filterSortAndPaginate(User::query())
$this->updateAndPaginate(User::query())
);
}

Expand All@@ -42,4 +43,9 @@ protected function allowedFilters()
->reject(fn ($field) => in_array($field, ['password', 'password_hash']))
->all();
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForResource('api', 'users');
}
}
28 changes: 28 additions & 0 deletions tests/API/APITest.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@
use Statamic\Facades\Blueprint;
use Statamic\Facades\Token;
use Statamic\Facades\User;
use Statamic\Query\Scopes\Scope;
use Tests\PreventSavingStacheItemsToDisk;
use Tests\TestCase;

Expand DownExpand Up@@ -136,6 +137,25 @@ public function it_filters_out_past_entries_from_past_private_collection()
$response->assertJsonPath('data.0.id', 'a');
}

#[Test]
public function it_can_use_a_query_scope_on_collection_entries_when_configuration_allows_for_it()
{
app('statamic.scopes')['test_scope'] = TestScope::class;

Facades\Config::set('statamic.api.resources.collections.pages', [
'allowed_query_scopes' => ['test_scope'],
]);

Facades\Collection::make('pages')->save();

Facades\Entry::make()->collection('pages')->id('about')->slug('about')->published(true)->save();
Facades\Entry::make()->collection('pages')->id('dance')->slug('dance')->published(true)->save();
Facades\Entry::make()->collection('pages')->id('nectar')->slug('nectar')->published(true)->save();

$this->assertEndpointDataCount('/api/collections/pages/entries?query_scope[test_scope][operator]=is&query_scope[test_scope][value]=about', 1);
$this->assertEndpointDataCount('/api/collections/pages/entries?query_scope[test_scope][operator]=isnt&query_scope[test_scope][value]=about', 2);
}

#[Test]
public function it_can_filter_collection_entries_when_configuration_allows_for_it()
{
Expand DownExpand Up@@ -592,3 +612,11 @@ public function handle(\Statamic\Contracts\Tokens\Token $token, \Illuminate\Http
return $next($token);
}
}

class TestScope extends Scope
{
public function apply($query, $values)
{
$query->where('id', $values['operator'] == 'is' ? '=' : '!=', $values['value']);
}
}
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [5.x] Support query scopes in REST API by ryanmitchell · Pull Request #10893 · statamic/cms · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/API/FilterAuthorizer.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,8 @@

class FilterAuthorizer extends AbstractAuthorizer
{
protected $configKey = 'allowed_filters';

/**
* Get allowed filters for resource.
*
Expand All@@ -17,7 +19,7 @@ class FilterAuthorizer extends AbstractAuthorizer
*/
public function allowedForResource($configFile, $queriedResource)
{
$config = config("statamic.{$configFile}.resources.{$queriedResource}.allowed_filters");
$config = config("statamic.{$configFile}.resources.{$queriedResource}.{$this->configKey}");

// Use explicitly configured `allowed_filters` array, otherwise no filters should be allowed.
return is_array($config)
Expand DownExpand Up@@ -54,7 +56,7 @@ public function allowedForSubResources($configFile, $queriedResource, $queriedHa

// Determine if any of our queried resources have filters explicitly disabled.
$disabled = $resources
->filter(fn ($resource) => Arr::get($config, "{$resource}.allowed_filters") === false)
->filter(fn ($resource) => Arr::get($config, "{$resource}.{$this->configKey}") === false)
->isNotEmpty();

// If any queried resource is explicitly disabled, then no filters should be allowed.
Expand All@@ -65,10 +67,10 @@ public function allowedForSubResources($configFile, $queriedResource, $queriedHa
// Determine `allowed_filters` by filtering out any that don't appear in all of them.
// A resource named `*` will apply to all enabled resources at once.
return $resources
->map(fn ($resource) => $config[$resource]['allowed_filters'] ?? [])
->map(fn ($resource) => $config[$resource][$this->configKey] ?? [])
->reduce(function ($carry, $allowedFilters) use ($config) {
return $carry->intersect($allowedFilters)->merge($config['*']['allowed_filters'] ?? []);
}, collect($config[$resources[0] ?? '']['allowed_filters'] ?? []))
return $carry->intersect($allowedFilters)->merge($config['*'][$this->configKey] ?? []);
}, collect($config[$resources[0] ?? ''][$this->configKey] ?? []))
->all();
}
}
8 changes: 8 additions & 0 deletions src/API/QueryScopeAuthorizer.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
<?php

namespace Statamic\API;

class QueryScopeAuthorizer extends FilterAuthorizer
{
protected $configKey = 'allowed_query_scopes';
}
62 changes: 62 additions & 0 deletions src/Http/Controllers/API/ApiController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,10 @@
use Facades\Statamic\API\ResourceAuthorizer;
use Statamic\Exceptions\ApiValidationException;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\Scope;
use Statamic\Facades\Site;
use Statamic\Http\Controllers\Controller;
use Statamic\Support\Arr;
use Statamic\Support\Str;
use Statamic\Tags\Concerns\QueriesConditions;

Expand DownExpand Up@@ -80,12 +82,26 @@ protected function filterAllowedResources($items)
*
* @param \Statamic\Query\Builder $query
* @return \Statamic\Extensions\Pagination\LengthAwarePaginator
*
* @deprecated
*/
protected function filterSortAndPaginate($query)
{
return $this->updateAndPaginate($query);
}

/**
* Filter, sort, scope, and paginate query for API resource output.
*
* @param \Statamic\Query\Builder $query
* @return \Statamic\Extensions\Pagination\LengthAwarePaginator
*/
protected function updateAndPaginate($query)
{
return $this
->filter($query)
->sort($query)
->scope($query)
->paginate($query);
}

Expand DownExpand Up@@ -171,6 +187,52 @@ protected function doesntHaveFilter($field)
->contains($field);
}

/**
* Apply query scopes a query based on conditions in the query_scope parameter.
*
* /endpoint?query_scope[scope_handle]=foo&query_scope[another_scope]=bar
*
* @param \Statamic\Query\Builder $query
* @return $this
*/
protected function scope($query)
{
$this->getScopes()
->each(function ($value, $handle) use ($query) {
Scope::find($handle)?->apply($query, Arr::wrap($value));
});

return $this;
}

/**
* Get scopes for querying.
*
* @return \Illuminate\Support\Collection
*/
protected function getScopes()
{
if (! method_exists($this, 'allowedQueryScopes')) {
return collect();
}

$scopes = collect(request()->query_scope ?? []);

$allowedScopes = collect($this->allowedQueryScopes());

$forbidden = $scopes
->keys()
->filter(fn ($handle) => ! Scope::find($handle) || ! $allowedScopes->contains($handle));

if ($forbidden->isNotEmpty()) {
throw ApiValidationException::withMessages([
'query_scope' => Str::plural('Forbidden query scope', $forbidden).': '.$forbidden->join(', '),
]);
}

return $scopes;
}

/**
* Sorts the query based on the sort parameter.
*
Expand Down
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/AssetsController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Http\Resources\API\AssetResource;

class AssetsController extends ApiController
Expand All@@ -22,7 +23,7 @@ public function index($assetContainer)
->filter->isRelationship()->keys()->all();

return app(AssetResource::class)::collection(
$this->filterSortAndPaginate($assetContainer->queryAssets()->with($with))
$this->updateAndPaginate($assetContainer->queryAssets()->with($with))
);
}

Expand All@@ -37,4 +38,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'assets', $this->containerHandle);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'assets', $this->containerHandle);
}
}
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/CollectionEntriesController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\Entry;
use Statamic\Http\Resources\API\EntryResource;
Expand All@@ -29,7 +30,7 @@ public function index($collection)
->filter->isRelationship()->keys()->all();

return app(EntryResource::class)::collection(
$this->filterSortAndPaginate($collection->queryEntries()->with($with))
$this->updateAndPaginate($collection->queryEntries()->with($with))
);
}

Expand DownExpand Up@@ -81,4 +82,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'collections', $this->collectionHandle);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'collections', $this->collectionHandle);
}
}
6 changes: 6 additions & 0 deletions src/Http/Controllers/API/CollectionTreeController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Http\Resources\API\TreeResource;
use Statamic\Query\ItemQueryBuilder;
Expand DownExpand Up@@ -48,4 +49,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'collections', $this->collectionHandle);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'collections', $this->collectionHandle);
}
}
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/TaxonomyTermEntriesController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Facades\Statamic\API\ResourceAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\Collection;
Expand DownExpand Up@@ -46,7 +47,7 @@ public function index($taxonomy, $term)
$with = $this->getRelationshipFieldsFromCollections($taxonomy);

return app(EntryResource::class)::collection(
$this->filterSortAndPaginate($query->with($with))
$this->updateAndPaginate($query->with($with))
);
}

Expand All@@ -72,4 +73,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'collections', $this->allowedCollections);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'collections', $this->allowedCollections);
}
}
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/TaxonomyTermsController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\Term;
use Statamic\Http\Resources\API\TermResource;
Expand All@@ -24,7 +25,7 @@ public function index($taxonomy)
->filter->isRelationship()->keys()->all();

return app(TermResource::class)::collection(
$this->filterSortAndPaginate($taxonomy->queryTerms()->with($with))
$this->updateAndPaginate($taxonomy->queryTerms()->with($with))
);
}

Expand All@@ -43,4 +44,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'taxonomies', $this->taxonomyHandle);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'taxonomies', $this->taxonomyHandle);
}
}
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/UsersController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\User;
use Statamic\Http\Resources\API\UserResource;
Expand All@@ -16,7 +17,7 @@ public function index()
$this->abortIfDisabled();

return app(UserResource::class)::collection(
$this->filterSortAndPaginate(User::query())
$this->updateAndPaginate(User::query())
);
}

Expand All@@ -42,4 +43,9 @@ protected function allowedFilters()
->reject(fn ($field) => in_array($field, ['password', 'password_hash']))
->all();
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForResource('api', 'users');
}
}
28 changes: 28 additions & 0 deletions tests/API/APITest.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@
use Statamic\Facades\Blueprint;
use Statamic\Facades\Token;
use Statamic\Facades\User;
use Statamic\Query\Scopes\Scope;
use Tests\PreventSavingStacheItemsToDisk;
use Tests\TestCase;

Expand DownExpand Up@@ -136,6 +137,25 @@ public function it_filters_out_past_entries_from_past_private_collection()
$response->assertJsonPath('data.0.id', 'a');
}

#[Test]
public function it_can_use_a_query_scope_on_collection_entries_when_configuration_allows_for_it()
{
app('statamic.scopes')['test_scope'] = TestScope::class;

Facades\Config::set('statamic.api.resources.collections.pages', [
'allowed_query_scopes' => ['test_scope'],
]);

Facades\Collection::make('pages')->save();

Facades\Entry::make()->collection('pages')->id('about')->slug('about')->published(true)->save();
Facades\Entry::make()->collection('pages')->id('dance')->slug('dance')->published(true)->save();
Facades\Entry::make()->collection('pages')->id('nectar')->slug('nectar')->published(true)->save();

$this->assertEndpointDataCount('/api/collections/pages/entries?query_scope[test_scope][operator]=is&query_scope[test_scope][value]=about', 1);
$this->assertEndpointDataCount('/api/collections/pages/entries?query_scope[test_scope][operator]=isnt&query_scope[test_scope][value]=about', 2);
}

#[Test]
public function it_can_filter_collection_entries_when_configuration_allows_for_it()
{
Expand DownExpand Up@@ -592,3 +612,11 @@ public function handle(\Statamic\Contracts\Tokens\Token $token, \Illuminate\Http
return $next($token);
}
}

class TestScope extends Scope
{
public function apply($query, $values)
{
$query->where('id', $values['operator'] == 'is' ? '=' : '!=', $values['value']);
}
}
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [5.x] Support query scopes in REST API by ryanmitchell · Pull Request #10893 · statamic/cms · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/API/FilterAuthorizer.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,8 @@

class FilterAuthorizer extends AbstractAuthorizer
{
protected $configKey = 'allowed_filters';

/**
* Get allowed filters for resource.
*
Expand All@@ -17,7 +19,7 @@ class FilterAuthorizer extends AbstractAuthorizer
*/
public function allowedForResource($configFile, $queriedResource)
{
$config = config("statamic.{$configFile}.resources.{$queriedResource}.allowed_filters");
$config = config("statamic.{$configFile}.resources.{$queriedResource}.{$this->configKey}");

// Use explicitly configured `allowed_filters` array, otherwise no filters should be allowed.
return is_array($config)
Expand DownExpand Up@@ -54,7 +56,7 @@ public function allowedForSubResources($configFile, $queriedResource, $queriedHa

// Determine if any of our queried resources have filters explicitly disabled.
$disabled = $resources
->filter(fn ($resource) => Arr::get($config, "{$resource}.allowed_filters") === false)
->filter(fn ($resource) => Arr::get($config, "{$resource}.{$this->configKey}") === false)
->isNotEmpty();

// If any queried resource is explicitly disabled, then no filters should be allowed.
Expand All@@ -65,10 +67,10 @@ public function allowedForSubResources($configFile, $queriedResource, $queriedHa
// Determine `allowed_filters` by filtering out any that don't appear in all of them.
// A resource named `*` will apply to all enabled resources at once.
return $resources
->map(fn ($resource) => $config[$resource]['allowed_filters'] ?? [])
->map(fn ($resource) => $config[$resource][$this->configKey] ?? [])
->reduce(function ($carry, $allowedFilters) use ($config) {
return $carry->intersect($allowedFilters)->merge($config['*']['allowed_filters'] ?? []);
}, collect($config[$resources[0] ?? '']['allowed_filters'] ?? []))
return $carry->intersect($allowedFilters)->merge($config['*'][$this->configKey] ?? []);
}, collect($config[$resources[0] ?? ''][$this->configKey] ?? []))
->all();
}
}
8 changes: 8 additions & 0 deletions src/API/QueryScopeAuthorizer.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
<?php

namespace Statamic\API;

class QueryScopeAuthorizer extends FilterAuthorizer
{
protected $configKey = 'allowed_query_scopes';
}
62 changes: 62 additions & 0 deletions src/Http/Controllers/API/ApiController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,10 @@
use Facades\Statamic\API\ResourceAuthorizer;
use Statamic\Exceptions\ApiValidationException;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\Scope;
use Statamic\Facades\Site;
use Statamic\Http\Controllers\Controller;
use Statamic\Support\Arr;
use Statamic\Support\Str;
use Statamic\Tags\Concerns\QueriesConditions;

Expand DownExpand Up@@ -80,12 +82,26 @@ protected function filterAllowedResources($items)
*
* @param \Statamic\Query\Builder $query
* @return \Statamic\Extensions\Pagination\LengthAwarePaginator
*
* @deprecated
*/
protected function filterSortAndPaginate($query)
{
return $this->updateAndPaginate($query);
}

/**
* Filter, sort, scope, and paginate query for API resource output.
*
* @param \Statamic\Query\Builder $query
* @return \Statamic\Extensions\Pagination\LengthAwarePaginator
*/
protected function updateAndPaginate($query)
{
return $this
->filter($query)
->sort($query)
->scope($query)
->paginate($query);
}

Expand DownExpand Up@@ -171,6 +187,52 @@ protected function doesntHaveFilter($field)
->contains($field);
}

/**
* Apply query scopes a query based on conditions in the query_scope parameter.
*
* /endpoint?query_scope[scope_handle]=foo&query_scope[another_scope]=bar
*
* @param \Statamic\Query\Builder $query
* @return $this
*/
protected function scope($query)
{
$this->getScopes()
->each(function ($value, $handle) use ($query) {
Scope::find($handle)?->apply($query, Arr::wrap($value));
});

return $this;
}

/**
* Get scopes for querying.
*
* @return \Illuminate\Support\Collection
*/
protected function getScopes()
{
if (! method_exists($this, 'allowedQueryScopes')) {
return collect();
}

$scopes = collect(request()->query_scope ?? []);

$allowedScopes = collect($this->allowedQueryScopes());

$forbidden = $scopes
->keys()
->filter(fn ($handle) => ! Scope::find($handle) || ! $allowedScopes->contains($handle));

if ($forbidden->isNotEmpty()) {
throw ApiValidationException::withMessages([
'query_scope' => Str::plural('Forbidden query scope', $forbidden).': '.$forbidden->join(', '),
]);
}

return $scopes;
}

/**
* Sorts the query based on the sort parameter.
*
Expand Down
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/AssetsController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Http\Resources\API\AssetResource;

class AssetsController extends ApiController
Expand All@@ -22,7 +23,7 @@ public function index($assetContainer)
->filter->isRelationship()->keys()->all();

return app(AssetResource::class)::collection(
$this->filterSortAndPaginate($assetContainer->queryAssets()->with($with))
$this->updateAndPaginate($assetContainer->queryAssets()->with($with))
);
}

Expand All@@ -37,4 +38,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'assets', $this->containerHandle);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'assets', $this->containerHandle);
}
}
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/CollectionEntriesController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\Entry;
use Statamic\Http\Resources\API\EntryResource;
Expand All@@ -29,7 +30,7 @@ public function index($collection)
->filter->isRelationship()->keys()->all();

return app(EntryResource::class)::collection(
$this->filterSortAndPaginate($collection->queryEntries()->with($with))
$this->updateAndPaginate($collection->queryEntries()->with($with))
);
}

Expand DownExpand Up@@ -81,4 +82,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'collections', $this->collectionHandle);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'collections', $this->collectionHandle);
}
}
6 changes: 6 additions & 0 deletions src/Http/Controllers/API/CollectionTreeController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Http\Resources\API\TreeResource;
use Statamic\Query\ItemQueryBuilder;
Expand DownExpand Up@@ -48,4 +49,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'collections', $this->collectionHandle);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'collections', $this->collectionHandle);
}
}
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/TaxonomyTermEntriesController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Facades\Statamic\API\ResourceAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\Collection;
Expand DownExpand Up@@ -46,7 +47,7 @@ public function index($taxonomy, $term)
$with = $this->getRelationshipFieldsFromCollections($taxonomy);

return app(EntryResource::class)::collection(
$this->filterSortAndPaginate($query->with($with))
$this->updateAndPaginate($query->with($with))
);
}

Expand All@@ -72,4 +73,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'collections', $this->allowedCollections);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'collections', $this->allowedCollections);
}
}
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/TaxonomyTermsController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\Term;
use Statamic\Http\Resources\API\TermResource;
Expand All@@ -24,7 +25,7 @@ public function index($taxonomy)
->filter->isRelationship()->keys()->all();

return app(TermResource::class)::collection(
$this->filterSortAndPaginate($taxonomy->queryTerms()->with($with))
$this->updateAndPaginate($taxonomy->queryTerms()->with($with))
);
}

Expand All@@ -43,4 +44,9 @@ protected function allowedFilters()
{
return FilterAuthorizer::allowedForSubResources('api', 'taxonomies', $this->taxonomyHandle);
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForSubResources('api', 'taxonomies', $this->taxonomyHandle);
}
}
8 changes: 7 additions & 1 deletion src/Http/Controllers/API/UsersController.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Statamic\Http\Controllers\API;

use Facades\Statamic\API\FilterAuthorizer;
use Facades\Statamic\API\QueryScopeAuthorizer;
use Statamic\Exceptions\NotFoundHttpException;
use Statamic\Facades\User;
use Statamic\Http\Resources\API\UserResource;
Expand All@@ -16,7 +17,7 @@ public function index()
$this->abortIfDisabled();

return app(UserResource::class)::collection(
$this->filterSortAndPaginate(User::query())
$this->updateAndPaginate(User::query())
);
}

Expand All@@ -42,4 +43,9 @@ protected function allowedFilters()
->reject(fn ($field) => in_array($field, ['password', 'password_hash']))
->all();
}

protected function allowedQueryScopes()
{
return QueryScopeAuthorizer::allowedForResource('api', 'users');
}
}
28 changes: 28 additions & 0 deletions tests/API/APITest.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@
use Statamic\Facades\Blueprint;
use Statamic\Facades\Token;
use Statamic\Facades\User;
use Statamic\Query\Scopes\Scope;
use Tests\PreventSavingStacheItemsToDisk;
use Tests\TestCase;

Expand DownExpand Up@@ -136,6 +137,25 @@ public function it_filters_out_past_entries_from_past_private_collection()
$response->assertJsonPath('data.0.id', 'a');
}

#[Test]
public function it_can_use_a_query_scope_on_collection_entries_when_configuration_allows_for_it()
{
app('statamic.scopes')['test_scope'] = TestScope::class;

Facades\Config::set('statamic.api.resources.collections.pages', [
'allowed_query_scopes' => ['test_scope'],
]);

Facades\Collection::make('pages')->save();

Facades\Entry::make()->collection('pages')->id('about')->slug('about')->published(true)->save();
Facades\Entry::make()->collection('pages')->id('dance')->slug('dance')->published(true)->save();
Facades\Entry::make()->collection('pages')->id('nectar')->slug('nectar')->published(true)->save();

$this->assertEndpointDataCount('/api/collections/pages/entries?query_scope[test_scope][operator]=is&query_scope[test_scope][value]=about', 1);
$this->assertEndpointDataCount('/api/collections/pages/entries?query_scope[test_scope][operator]=isnt&query_scope[test_scope][value]=about', 2);
}

#[Test]
public function it_can_filter_collection_entries_when_configuration_allows_for_it()
{
Expand DownExpand Up@@ -592,3 +612,11 @@ public function handle(\Statamic\Contracts\Tokens\Token $token, \Illuminate\Http
return $next($token);
}
}

class TestScope extends Scope
{
public function apply($query, $values)
{
$query->where('id', $values['operator'] == 'is' ? '=' : '!=', $values['value']);
}
}