Uh oh!
There was an error while loading. Please reload this page.
[5.x] Corrects issue serializing/deserializing "resolvingValues" when using Eloquent driver - #11888
Closed
JohnathonKoster wants to merge 1 commit into
Closed
Conversation
jasonvarga
commented
Jun 25, 2025
Member
Not necessary since #11894 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes#11887
When deserializing/serializing an entry instance to a class that extends file entry, such as the Eloquent driver's entry instance, we will run into an issue when attempting to repopulate the
$resolvingValuesvariable.This PR addresses it in two ways:
$resolvingValuesfrom private to protected, so any other classes that may use theHasOrigintrait do not run into issues__sleepmethod to exclude theresolvingValuesvalue