[6.x] Fix single-mode date fieldtype crashing when saving with a time by mynetx · Pull Request #14880 · statamic/cms

mynetx · 2026-06-25T21:25:22Z

Saving an entry with a single-mode date field whose format includes a time throws a TypeError. The CP submits the value as a ['date' => ..., 'time' => ...] array, but processSingle() passed it straight to Carbon::parse(), which can't parse arrays. This hits the default date field, since the default save format (Y-m-d H:i) makes formatHasTime() true regardless of time_enabled.

This combines the date and time into a single string before parsing.

Fixes#14860

The Control Panel submits a single date that includes a time as a ['date' => ..., 'time' => ...] array, but processSingle() passed it straight to Carbon::parse(), which throws a TypeError on arrays. This hit the default date field, whose default save format (Y-m-d H:i) makes formatHasTime() true regardless of time_enabled. Combine the date and time into a single string before parsing, and treat a missing date as an empty value. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

edalzell · 2026-07-06T17:05:57Z

+ // parse an array. A missing date means the field was left empty.
+ if (is_array($data)) {
+ if (! ($data['date'] ?? null)) {
+ return null;


can we use the array helpers here to remove the double if?

jasonvarga · 2026-07-06T18:51:15Z

The CP does not submit the array [date, time] anymore. That changed in 6.0. Where are you still seeing this happen?

jasonvarga

The CP does not submit the array [date, time] anymore. That changed in 6.0. Where are you still seeing this happen?

This PR is attempting to fix a situation that shouldn't happen.

Reviewing as "Requesting changes" so we don't unintentionally merge until hearing reasoning.

mynetx · 2026-07-06T21:45:16Z

Thanks both, you're right. I dug in and can confirm the 6.x CP never submits the {date, time} shape anymore.

Why I opened it: the issue came with a clean stack trace at Date::processDateTime() -> Carbon::parse(array), and I could reproduce the TypeError from tinker with $ft->process(['date' => ..., 'time' => ...]). I took the reporter's payload at face value and didn't check that the current CP still produces it.

It doesn't. The 6.0 date rewrite (#11647) moved single mode to plain ISO strings, preProcessSingle() hands the picker a string, and splitDateTimeForPreProcessSingle() (the old {date, time} producer) is now dead code. The only way to hit the crash is to hand-feed processSingle() the old 5.x array shape, which nothing in the real CP does. And in 5.x that same array was combined inside processSingle(), so it wasn't a bug there either.

So this fixes a path that can't be reached. Closing it. Sorry for the noise, and thanks for the quick catch.

mynetx · 2026-06-25T21:25:22Z

Saving an entry with a single-mode date field whose format includes a time throws a TypeError. The CP submits the value as a ['date' => ..., 'time' => ...] array, but processSingle() passed it straight to Carbon::parse(), which can't parse arrays. This hits the default date field, since the default save format (Y-m-d H:i) makes formatHasTime() true regardless of time_enabled.

This combines the date and time into a single string before parsing.

Fixes#14860

The Control Panel submits a single date that includes a time as a ['date' => ..., 'time' => ...] array, but processSingle() passed it straight to Carbon::parse(), which throws a TypeError on arrays. This hit the default date field, whose default save format (Y-m-d H:i) makes formatHasTime() true regardless of time_enabled. Combine the date and time into a single string before parsing, and treat a missing date as an empty value. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

edalzell · 2026-07-06T17:05:57Z

+ // parse an array. A missing date means the field was left empty.
+ if (is_array($data)) {
+ if (! ($data['date'] ?? null)) {
+ return null;


can we use the array helpers here to remove the double if?

jasonvarga · 2026-07-06T18:51:15Z

The CP does not submit the array [date, time] anymore. That changed in 6.0. Where are you still seeing this happen?

jasonvarga

The CP does not submit the array [date, time] anymore. That changed in 6.0. Where are you still seeing this happen?

This PR is attempting to fix a situation that shouldn't happen.

Reviewing as "Requesting changes" so we don't unintentionally merge until hearing reasoning.

mynetx · 2026-07-06T21:45:16Z

Thanks both, you're right. I dug in and can confirm the 6.x CP never submits the {date, time} shape anymore.

Why I opened it: the issue came with a clean stack trace at Date::processDateTime() -> Carbon::parse(array), and I could reproduce the TypeError from tinker with $ft->process(['date' => ..., 'time' => ...]). I took the reporter's payload at face value and didn't check that the current CP still produces it.

It doesn't. The 6.0 date rewrite (#11647) moved single mode to plain ISO strings, preProcessSingle() hands the picker a string, and splitDateTimeForPreProcessSingle() (the old {date, time} producer) is now dead code. The only way to hit the crash is to hand-feed processSingle() the old 5.x array shape, which nothing in the real CP does. And in 5.x that same array was combined inside processSingle(), so it wasn't a bug there either.

So this fixes a path that can't be reached. Closing it. Sorry for the noise, and thanks for the quick catch.

mynetx · 2026-06-25T21:25:22Z

Saving an entry with a single-mode date field whose format includes a time throws a TypeError. The CP submits the value as a ['date' => ..., 'time' => ...] array, but processSingle() passed it straight to Carbon::parse(), which can't parse arrays. This hits the default date field, since the default save format (Y-m-d H:i) makes formatHasTime() true regardless of time_enabled.

This combines the date and time into a single string before parsing.

Fixes#14860

The Control Panel submits a single date that includes a time as a ['date' => ..., 'time' => ...] array, but processSingle() passed it straight to Carbon::parse(), which throws a TypeError on arrays. This hit the default date field, whose default save format (Y-m-d H:i) makes formatHasTime() true regardless of time_enabled. Combine the date and time into a single string before parsing, and treat a missing date as an empty value. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

edalzell · 2026-07-06T17:05:57Z

+ // parse an array. A missing date means the field was left empty.
+ if (is_array($data)) {
+ if (! ($data['date'] ?? null)) {
+ return null;


can we use the array helpers here to remove the double if?

jasonvarga · 2026-07-06T18:51:15Z

The CP does not submit the array [date, time] anymore. That changed in 6.0. Where are you still seeing this happen?

jasonvarga

The CP does not submit the array [date, time] anymore. That changed in 6.0. Where are you still seeing this happen?

This PR is attempting to fix a situation that shouldn't happen.

Reviewing as "Requesting changes" so we don't unintentionally merge until hearing reasoning.

mynetx · 2026-07-06T21:45:16Z

Thanks both, you're right. I dug in and can confirm the 6.x CP never submits the {date, time} shape anymore.

Why I opened it: the issue came with a clean stack trace at Date::processDateTime() -> Carbon::parse(array), and I could reproduce the TypeError from tinker with $ft->process(['date' => ..., 'time' => ...]). I took the reporter's payload at face value and didn't check that the current CP still produces it.

It doesn't. The 6.0 date rewrite (#11647) moved single mode to plain ISO strings, preProcessSingle() hands the picker a string, and splitDateTimeForPreProcessSingle() (the old {date, time} producer) is now dead code. The only way to hit the crash is to hand-feed processSingle() the old 5.x array shape, which nothing in the real CP does. And in 5.x that same array was combined inside processSingle(), so it wasn't a bug there either.

So this fixes a path that can't be reached. Closing it. Sorry for the noise, and thanks for the quick catch.

mynetx · 2026-06-25T21:25:22Z

Saving an entry with a single-mode date field whose format includes a time throws a TypeError. The CP submits the value as a ['date' => ..., 'time' => ...] array, but processSingle() passed it straight to Carbon::parse(), which can't parse arrays. This hits the default date field, since the default save format (Y-m-d H:i) makes formatHasTime() true regardless of time_enabled.

This combines the date and time into a single string before parsing.

Fixes#14860

The Control Panel submits a single date that includes a time as a ['date' => ..., 'time' => ...] array, but processSingle() passed it straight to Carbon::parse(), which throws a TypeError on arrays. This hit the default date field, whose default save format (Y-m-d H:i) makes formatHasTime() true regardless of time_enabled. Combine the date and time into a single string before parsing, and treat a missing date as an empty value. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

edalzell · 2026-07-06T17:05:57Z

+ // parse an array. A missing date means the field was left empty.
+ if (is_array($data)) {
+ if (! ($data['date'] ?? null)) {
+ return null;


can we use the array helpers here to remove the double if?

jasonvarga · 2026-07-06T18:51:15Z

The CP does not submit the array [date, time] anymore. That changed in 6.0. Where are you still seeing this happen?

jasonvarga

The CP does not submit the array [date, time] anymore. That changed in 6.0. Where are you still seeing this happen?

This PR is attempting to fix a situation that shouldn't happen.

Reviewing as "Requesting changes" so we don't unintentionally merge until hearing reasoning.

mynetx · 2026-07-06T21:45:16Z

Thanks both, you're right. I dug in and can confirm the 6.x CP never submits the {date, time} shape anymore.

Why I opened it: the issue came with a clean stack trace at Date::processDateTime() -> Carbon::parse(array), and I could reproduce the TypeError from tinker with $ft->process(['date' => ..., 'time' => ...]). I took the reporter's payload at face value and didn't check that the current CP still produces it.

It doesn't. The 6.0 date rewrite (#11647) moved single mode to plain ISO strings, preProcessSingle() hands the picker a string, and splitDateTimeForPreProcessSingle() (the old {date, time} producer) is now dead code. The only way to hit the crash is to hand-feed processSingle() the old 5.x array shape, which nothing in the real CP does. And in 5.x that same array was combined inside processSingle(), so it wasn't a bug there either.

So this fixes a path that can't be reached. Closing it. Sorry for the noise, and thanks for the quick catch.

mynetx · 2026-06-25T21:25:22Z

Saving an entry with a single-mode date field whose format includes a time throws a TypeError. The CP submits the value as a ['date' => ..., 'time' => ...] array, but processSingle() passed it straight to Carbon::parse(), which can't parse arrays. This hits the default date field, since the default save format (Y-m-d H:i) makes formatHasTime() true regardless of time_enabled.

This combines the date and time into a single string before parsing.

Fixes#14860

The Control Panel submits a single date that includes a time as a ['date' => ..., 'time' => ...] array, but processSingle() passed it straight to Carbon::parse(), which throws a TypeError on arrays. This hit the default date field, whose default save format (Y-m-d H:i) makes formatHasTime() true regardless of time_enabled. Combine the date and time into a single string before parsing, and treat a missing date as an empty value. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

edalzell · 2026-07-06T17:05:57Z

+ // parse an array. A missing date means the field was left empty.
+ if (is_array($data)) {
+ if (! ($data['date'] ?? null)) {
+ return null;


can we use the array helpers here to remove the double if?

jasonvarga · 2026-07-06T18:51:15Z

The CP does not submit the array [date, time] anymore. That changed in 6.0. Where are you still seeing this happen?

jasonvarga

The CP does not submit the array [date, time] anymore. That changed in 6.0. Where are you still seeing this happen?

This PR is attempting to fix a situation that shouldn't happen.

Reviewing as "Requesting changes" so we don't unintentionally merge until hearing reasoning.

mynetx · 2026-07-06T21:45:16Z

Thanks both, you're right. I dug in and can confirm the 6.x CP never submits the {date, time} shape anymore.

Why I opened it: the issue came with a clean stack trace at Date::processDateTime() -> Carbon::parse(array), and I could reproduce the TypeError from tinker with $ft->process(['date' => ..., 'time' => ...]). I took the reporter's payload at face value and didn't check that the current CP still produces it.

It doesn't. The 6.0 date rewrite (#11647) moved single mode to plain ISO strings, preProcessSingle() hands the picker a string, and splitDateTimeForPreProcessSingle() (the old {date, time} producer) is now dead code. The only way to hit the crash is to hand-feed processSingle() the old 5.x array shape, which nothing in the real CP does. And in 5.x that same array was combined inside processSingle(), so it wasn't a bug there either.

So this fixes a path that can't be reached. Closing it. Sorry for the noise, and thanks for the quick catch.

mynetx · 2026-06-25T21:25:22Z

Saving an entry with a single-mode date field whose format includes a time throws a TypeError. The CP submits the value as a ['date' => ..., 'time' => ...] array, but processSingle() passed it straight to Carbon::parse(), which can't parse arrays. This hits the default date field, since the default save format (Y-m-d H:i) makes formatHasTime() true regardless of time_enabled.

This combines the date and time into a single string before parsing.

Fixes#14860

The Control Panel submits a single date that includes a time as a ['date' => ..., 'time' => ...] array, but processSingle() passed it straight to Carbon::parse(), which throws a TypeError on arrays. This hit the default date field, whose default save format (Y-m-d H:i) makes formatHasTime() true regardless of time_enabled. Combine the date and time into a single string before parsing, and treat a missing date as an empty value. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

edalzell · 2026-07-06T17:05:57Z

+ // parse an array. A missing date means the field was left empty.
+ if (is_array($data)) {
+ if (! ($data['date'] ?? null)) {
+ return null;


can we use the array helpers here to remove the double if?

jasonvarga · 2026-07-06T18:51:15Z

The CP does not submit the array [date, time] anymore. That changed in 6.0. Where are you still seeing this happen?

jasonvarga

The CP does not submit the array [date, time] anymore. That changed in 6.0. Where are you still seeing this happen?

This PR is attempting to fix a situation that shouldn't happen.

Reviewing as "Requesting changes" so we don't unintentionally merge until hearing reasoning.

mynetx · 2026-07-06T21:45:16Z

Thanks both, you're right. I dug in and can confirm the 6.x CP never submits the {date, time} shape anymore.

Why I opened it: the issue came with a clean stack trace at Date::processDateTime() -> Carbon::parse(array), and I could reproduce the TypeError from tinker with $ft->process(['date' => ..., 'time' => ...]). I took the reporter's payload at face value and didn't check that the current CP still produces it.

It doesn't. The 6.0 date rewrite (#11647) moved single mode to plain ISO strings, preProcessSingle() hands the picker a string, and splitDateTimeForPreProcessSingle() (the old {date, time} producer) is now dead code. The only way to hit the crash is to hand-feed processSingle() the old 5.x array shape, which nothing in the real CP does. And in 5.x that same array was combined inside processSingle(), so it wasn't a bug there either.

So this fixes a path that can't be reached. Closing it. Sorry for the noise, and thanks for the quick catch.

mynetx · 2026-06-25T21:25:22Z

Saving an entry with a single-mode date field whose format includes a time throws a TypeError. The CP submits the value as a ['date' => ..., 'time' => ...] array, but processSingle() passed it straight to Carbon::parse(), which can't parse arrays. This hits the default date field, since the default save format (Y-m-d H:i) makes formatHasTime() true regardless of time_enabled.

This combines the date and time into a single string before parsing.

Fixes#14860

The Control Panel submits a single date that includes a time as a ['date' => ..., 'time' => ...] array, but processSingle() passed it straight to Carbon::parse(), which throws a TypeError on arrays. This hit the default date field, whose default save format (Y-m-d H:i) makes formatHasTime() true regardless of time_enabled. Combine the date and time into a single string before parsing, and treat a missing date as an empty value. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

edalzell · 2026-07-06T17:05:57Z

+ // parse an array. A missing date means the field was left empty.
+ if (is_array($data)) {
+ if (! ($data['date'] ?? null)) {
+ return null;


can we use the array helpers here to remove the double if?

jasonvarga · 2026-07-06T18:51:15Z

The CP does not submit the array [date, time] anymore. That changed in 6.0. Where are you still seeing this happen?

jasonvarga

The CP does not submit the array [date, time] anymore. That changed in 6.0. Where are you still seeing this happen?

This PR is attempting to fix a situation that shouldn't happen.

Reviewing as "Requesting changes" so we don't unintentionally merge until hearing reasoning.

mynetx · 2026-07-06T21:45:16Z

Thanks both, you're right. I dug in and can confirm the 6.x CP never submits the {date, time} shape anymore.

Why I opened it: the issue came with a clean stack trace at Date::processDateTime() -> Carbon::parse(array), and I could reproduce the TypeError from tinker with $ft->process(['date' => ..., 'time' => ...]). I took the reporter's payload at face value and didn't check that the current CP still produces it.

It doesn't. The 6.0 date rewrite (#11647) moved single mode to plain ISO strings, preProcessSingle() hands the picker a string, and splitDateTimeForPreProcessSingle() (the old {date, time} producer) is now dead code. The only way to hit the crash is to hand-feed processSingle() the old 5.x array shape, which nothing in the real CP does. And in 5.x that same array was combined inside processSingle(), so it wasn't a bug there either.

So this fixes a path that can't be reached. Closing it. Sorry for the noise, and thanks for the quick catch.

mynetx · 2026-06-25T21:25:22Z

Saving an entry with a single-mode date field whose format includes a time throws a TypeError. The CP submits the value as a ['date' => ..., 'time' => ...] array, but processSingle() passed it straight to Carbon::parse(), which can't parse arrays. This hits the default date field, since the default save format (Y-m-d H:i) makes formatHasTime() true regardless of time_enabled.

This combines the date and time into a single string before parsing.

Fixes#14860

The Control Panel submits a single date that includes a time as a ['date' => ..., 'time' => ...] array, but processSingle() passed it straight to Carbon::parse(), which throws a TypeError on arrays. This hit the default date field, whose default save format (Y-m-d H:i) makes formatHasTime() true regardless of time_enabled. Combine the date and time into a single string before parsing, and treat a missing date as an empty value. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

edalzell · 2026-07-06T17:05:57Z

+ // parse an array. A missing date means the field was left empty.
+ if (is_array($data)) {
+ if (! ($data['date'] ?? null)) {
+ return null;


can we use the array helpers here to remove the double if?

jasonvarga · 2026-07-06T18:51:15Z

The CP does not submit the array [date, time] anymore. That changed in 6.0. Where are you still seeing this happen?

jasonvarga

The CP does not submit the array [date, time] anymore. That changed in 6.0. Where are you still seeing this happen?

This PR is attempting to fix a situation that shouldn't happen.

Reviewing as "Requesting changes" so we don't unintentionally merge until hearing reasoning.

mynetx · 2026-07-06T21:45:16Z

Thanks both, you're right. I dug in and can confirm the 6.x CP never submits the {date, time} shape anymore.

Why I opened it: the issue came with a clean stack trace at Date::processDateTime() -> Carbon::parse(array), and I could reproduce the TypeError from tinker with $ft->process(['date' => ..., 'time' => ...]). I took the reporter's payload at face value and didn't check that the current CP still produces it.

It doesn't. The 6.0 date rewrite (#11647) moved single mode to plain ISO strings, preProcessSingle() hands the picker a string, and splitDateTimeForPreProcessSingle() (the old {date, time} producer) is now dead code. The only way to hit the crash is to hand-feed processSingle() the old 5.x array shape, which nothing in the real CP does. And in 5.x that same array was combined inside processSingle(), so it wasn't a bug there either.

So this fixes a path that can't be reached. Closing it. Sorry for the noise, and thanks for the quick catch.

mynetx force-pushed the fix/single-mode-date-time-save branch from 8cb8a9e to 8421624Compare July 6, 2026 08:32

edalzell reviewed Jul 6, 2026
View reviewed changes

jasonvarga requested changes Jul 6, 2026
View reviewed changes