') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [6.x] Fix incorrect update badges in the Control Panel updater by aaronbushnell · Pull Request #14890 · statamic/cms · GitHub
Skip to content

[6.x] Fix incorrect update badges in the Control Panel updater - #14890

Merged
jasonvarga merged 2 commits into
statamic:6.xfrom
aaronbushnell:version-compare-bug-fix
Jul 7, 2026
Merged

[6.x] Fix incorrect update badges in the Control Panel updater#14890
jasonvarga merged 2 commits into
statamic:6.xfrom
aaronbushnell:version-compare-bug-fix

Conversation

@aaronbushnell

@aaronbushnellaaronbushnell commented Jun 27, 2026•
edited by jasonvarga
Loading

Copy link
Copy Markdown
Contributor

Fixes two cases where the updater showed the wrong badge:

  1. Installed version newer than the marketplace (e.g. installed 7.12.1, marketplace still indexes 7.12.0) showed a false "Update available". Addon::isLatestVersion() now treats equal-or-newer as up to date.

  2. Paginating the changelog flipped the header badge ("Update available" → "Up to date", or "Security update available" → "Update available"), because it was derived from the current page. The badges are now computed server-side across all releases and returned from the changelog endpoint.

Related:

@aaronbushnell@claude
Fix false "Update available" when installed version is newer than mar…
30ac3f8
…ketplace latest
The update check treated "not exactly equal to the marketplace's latest"
as "an update is available", rather than "the installed version is older
than the latest". This surfaced an "Update available" badge whenever a
local install was ahead of the marketplace's indexed version (e.g. in the
window between a release landing on Packagist and the marketplace indexing
it).
- Addon::isLatestVersion() now uses `>=` instead of strict equality, so an
install equal to or newer than the marketplace latest is up to date.
- The per-product updater badge derives "up to date" from the changelog's
release types (no `upgrade` releases) instead of a string comparison,
matching the server's classification and the count badge.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@aaronbushnell
aaronbushnell marked this pull request as ready for review June 27, 2026 01:47
@craigcastledine

craigcastledine commented Jul 7, 2026

Copy link
Copy Markdown

Experiencing this also on 6.24.1. Same story on my end with three Alt Design addons that are each one release ahead of the marketplace's latest_version (alt-inbound 2.0.1 vs 2.0.0, alt-redirect 1.8.0 vs 1.7.0, alt-seo 1.4.2 vs 1.4.1). Result: a stuck "3" on the Updates badge while the Updates page happily says everything's up to date. Your fix sorts it.

@duncanmcclean

duncanmcclean commented Jul 7, 2026

Copy link
Copy Markdown
Member

Thanks for the PR!

The underlying issue should now be fixed on the Marketplace side — see my comment here: #10277 (comment). I've leave it to @jasonvarga to decide whether it's still worth merging this as an extra safeguard.

@aaronbushnell

aaronbushnell commented Jul 7, 2026

Copy link
Copy Markdown
ContributorAuthor

Thanks, @duncanmcclean! This might also be useful if and when future beta versions of Statamic (or addons) are installed, but the CMS shows there are "updates". Since you're not on the same version as what's in the Marketplace you might still see those badges notifying you to make an update.

@jasonvarga@claude
Make updater badge state server-authoritative
6a9b79a
The "Up to date" and "Security update available" header badges were derived
from the current changelog page. Paginating past page 1 (which holds the
newest, upgrade-typed releases) left only older releases, so both badges
dropped incorrectly. Return onLatestVersion and securityUpdateAvailable from
the changelog endpoint, computed across the full release set, and bind them
directly.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@jasonvargajasonvarga changed the title [6.x] Fix false "Update available" when installed version is newer than marketplace version[6.x] Fix incorrect update badges in the Control Panel updaterJul 7, 2026
@jasonvarga

jasonvarga commented Jul 7, 2026

Copy link
Copy Markdown
Member

Thanks for this! I pushed a couple of changes on top:

  • While testing, I noticed the same class of bug on the updater's changelog page: the "Up to date" / "Security update available" badges are derived from the current page of releases, so paginating past page 1 flipped them incorrectly. I moved that logic server-side — the changelog endpoint now returns onLatestVersion and securityUpdateAvailable computed across all releases, and Updater.vue just binds them. That also let the latestRelease/latestVersion bits go away.
  • Your Updater.vue change was the same idea, just page-scoped, so this supersedes it.

I updated the PR title and description to reflect it.

By the way, Duncan's .com changes have hopefully addressed your initial problem, but if not, this PR is a nice defense in depth anyway.

@jasonvarga
jasonvarga merged commit cd4ad2f into statamic:6.xJul 7, 2026
21 checks passed
@aaronbushnell
aaronbushnell deleted the version-compare-bug-fix branch July 7, 2026 17:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aaronbushnell@craigcastledine@duncanmcclean@jasonvarga