Skip to content

[6.x] Use form handle in key#14974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonvarga merged 3 commits into from
Jul 10, 2026
Merged

[6.x] Use form handle in key #14974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a62c096
use form handle in key
edalzell Jul 10, 2026
aaddd88
fix test
edalzell Jul 10, 2026
ae901b7
use proper yaml content
edalzell Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Stache/Stores/FormSubmissionsStore.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ class FormSubmissionsStore extends ChildStore

public function getItemKey($item)
{
return $item->id();
return $item->form()->handle().'::'.$item->id();
}

public function getItemFilter(SplFileInfo $file)
Expand Down
20 changes: 19 additions & 1 deletion tests/Stache/Stores/FormSubmissionStoreTest.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -29,6 +29,24 @@ public function setUp(): void
Stache::store('form-submissions')->directory($this->directory);
}

#[Test]
public function it_has_handle_in_key()
{
Facades\Form::make('contact_form')->save();
Facades\Form::make('other_form')->save();
$contactSubmission = $this->parent->store('contact_form')->makeItemFromFile(
Path::tidy($this->directory).'/contact_form/1631083591.2832.yaml',
"name: John Smith\nmessage: Hello"
);
$otherSubmission = $this->parent->store('other_form')->makeItemFromFile(
Path::tidy($this->directory).'/other_form/1631083591.2832.yaml',
"name: John Smith\nmessage: Hello"
);

$this->assertEquals('contact_form::1631083591.2832', $this->parent->store('contact_form')->getItemKey($contactSubmission));
$this->assertEquals('other_form::1631083591.2832', $this->parent->store('other_form')->getItemKey($otherSubmission));
}

#[Test]
public function it_makes_entry_instances_from_files()
{
Expand DownExpand Up@@ -72,6 +90,6 @@ public function it_saves_to_disk()
@unlink($path);
$this->assertFileDoesNotExist($path);

$this->assertEquals($path, $this->parent->store('test_form')->paths()->get($submission->id()));
$this->assertEquals($path, $this->parent->store('test_form')->paths()->get('test_form::'.$submission->id()));
}
}
Loading