[6.x] Fix CP nav breaking when a form has no title

[jasonvarga]

Fixes two independent bugs that could take down the entire Control Panel nav.

Nav::create() returned null when given a null display name

NavItem::display() is a fluent get-or-set, so passing null means "get". Chaining create() off it returned the current display (null) rather than the item, and pushed that null into the registered items — corrupting the list for everything downstream. Nav::item() is an alias, so it had the same problem.

The item is now constructed and display() called as a statement, so the item is always returned. display()'s fluent get-or-set semantics are unchanged.

A form with no title crashed the nav

Form::title() was the only titled entity without a fallback, so a form whose YAML has no title returned null. Combined with the above, CoreNav died with Call to a member function url() on null — one malformed form took out the whole nav.

Form::title() now falls back to the humanized handle, matching collections, taxonomies, asset containers, globals, roles, and user groups. save() writes the raw property, so the fallback is never persisted to YAML.

[jasonvarga]

Fixes two independent bugs that could take down the entire Control Panel nav.

Nav::create() returned null when given a null display name

NavItem::display() is a fluent get-or-set, so passing null means "get". Chaining create() off it returned the current display (null) rather than the item, and pushed that null into the registered items — corrupting the list for everything downstream. Nav::item() is an alias, so it had the same problem.

The item is now constructed and display() called as a statement, so the item is always returned. display()'s fluent get-or-set semantics are unchanged.

A form with no title crashed the nav

Form::title() was the only titled entity without a fallback, so a form whose YAML has no title returned null. Combined with the above, CoreNav died with Call to a member function url() on null — one malformed form took out the whole nav.

Form::title() now falls back to the humanized handle, matching collections, taxonomies, asset containers, globals, roles, and user groups. save() writes the raw property, so the fallback is never persisted to YAML.

[jasonvarga]

Fixes two independent bugs that could take down the entire Control Panel nav.

Nav::create() returned null when given a null display name

NavItem::display() is a fluent get-or-set, so passing null means "get". Chaining create() off it returned the current display (null) rather than the item, and pushed that null into the registered items — corrupting the list for everything downstream. Nav::item() is an alias, so it had the same problem.

The item is now constructed and display() called as a statement, so the item is always returned. display()'s fluent get-or-set semantics are unchanged.

A form with no title crashed the nav

Form::title() was the only titled entity without a fallback, so a form whose YAML has no title returned null. Combined with the above, CoreNav died with Call to a member function url() on null — one malformed form took out the whole nav.

Form::title() now falls back to the humanized handle, matching collections, taxonomies, asset containers, globals, roles, and user groups. save() writes the raw property, so the fallback is never persisted to YAML.

[jasonvarga]

Fixes two independent bugs that could take down the entire Control Panel nav.

Nav::create() returned null when given a null display name

NavItem::display() is a fluent get-or-set, so passing null means "get". Chaining create() off it returned the current display (null) rather than the item, and pushed that null into the registered items — corrupting the list for everything downstream. Nav::item() is an alias, so it had the same problem.

The item is now constructed and display() called as a statement, so the item is always returned. display()'s fluent get-or-set semantics are unchanged.

A form with no title crashed the nav

Form::title() was the only titled entity without a fallback, so a form whose YAML has no title returned null. Combined with the above, CoreNav died with Call to a member function url() on null — one malformed form took out the whole nav.

Form::title() now falls back to the humanized handle, matching collections, taxonomies, asset containers, globals, roles, and user groups. save() writes the raw property, so the fallback is never persisted to YAML.

[jasonvarga]

Fixes two independent bugs that could take down the entire Control Panel nav.

Nav::create() returned null when given a null display name

NavItem::display() is a fluent get-or-set, so passing null means "get". Chaining create() off it returned the current display (null) rather than the item, and pushed that null into the registered items — corrupting the list for everything downstream. Nav::item() is an alias, so it had the same problem.

The item is now constructed and display() called as a statement, so the item is always returned. display()'s fluent get-or-set semantics are unchanged.

A form with no title crashed the nav

Form::title() was the only titled entity without a fallback, so a form whose YAML has no title returned null. Combined with the above, CoreNav died with Call to a member function url() on null — one malformed form took out the whole nav.

Form::title() now falls back to the humanized handle, matching collections, taxonomies, asset containers, globals, roles, and user groups. save() writes the raw property, so the fallback is never persisted to YAML.

[jasonvarga]

Fixes two independent bugs that could take down the entire Control Panel nav.

Nav::create() returned null when given a null display name

NavItem::display() is a fluent get-or-set, so passing null means "get". Chaining create() off it returned the current display (null) rather than the item, and pushed that null into the registered items — corrupting the list for everything downstream. Nav::item() is an alias, so it had the same problem.

The item is now constructed and display() called as a statement, so the item is always returned. display()'s fluent get-or-set semantics are unchanged.

A form with no title crashed the nav

Form::title() was the only titled entity without a fallback, so a form whose YAML has no title returned null. Combined with the above, CoreNav died with Call to a member function url() on null — one malformed form took out the whole nav.

Form::title() now falls back to the humanized handle, matching collections, taxonomies, asset containers, globals, roles, and user groups. save() writes the raw property, so the fallback is never persisted to YAML.

[jasonvarga]

Fixes two independent bugs that could take down the entire Control Panel nav.

Nav::create() returned null when given a null display name

NavItem::display() is a fluent get-or-set, so passing null means "get". Chaining create() off it returned the current display (null) rather than the item, and pushed that null into the registered items — corrupting the list for everything downstream. Nav::item() is an alias, so it had the same problem.

The item is now constructed and display() called as a statement, so the item is always returned. display()'s fluent get-or-set semantics are unchanged.

A form with no title crashed the nav

Form::title() was the only titled entity without a fallback, so a form whose YAML has no title returned null. Combined with the above, CoreNav died with Call to a member function url() on null — one malformed form took out the whole nav.

Form::title() now falls back to the humanized handle, matching collections, taxonomies, asset containers, globals, roles, and user groups. save() writes the raw property, so the fallback is never persisted to YAML.

[jasonvarga]

Fixes two independent bugs that could take down the entire Control Panel nav.

Nav::create() returned null when given a null display name

NavItem::display() is a fluent get-or-set, so passing null means "get". Chaining create() off it returned the current display (null) rather than the item, and pushed that null into the registered items — corrupting the list for everything downstream. Nav::item() is an alias, so it had the same problem.

The item is now constructed and display() called as a statement, so the item is always returned. display()'s fluent get-or-set semantics are unchanged.

A form with no title crashed the nav

Form::title() was the only titled entity without a fallback, so a form whose YAML has no title returned null. Combined with the above, CoreNav died with Call to a member function url() on null — one malformed form took out the whole nav.

Form::title() now falls back to the humanized handle, matching collections, taxonomies, asset containers, globals, roles, and user groups. save() writes the raw property, so the fallback is never persisted to YAML.