Uh oh!
There was an error while loading. Please reload this page.
[6.x] Allow unique rule validation messages to be overridden at the app level - #15197
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where custom translations for the
unique_entry_value,unique_term_value,unique_user_valueandunique_form_handlevalidation rules, defined in an app'slang/{locale}/validation.phpfile, were being ignored.This was happening because #9785 converted these rules from string-based rules (registered via
Validator::extend) into class-based rules. String-based rules resolved their messages through Laravel's standard message lookup, which checks the app'svalidation.phpfile first, whereas the class-based rules translate the namespacedstatamic::validation.*key directly, which can only be overridden inlang/vendor/statamic/{locale}/validation.php.This PR fixes it by using the app-level translation when one exists, falling back to the
statamic::namespaced translation otherwise.Fixes#10819
Caused by #9785