Square orientation user avatar generation for CP header

[ncla]

Fixes#5729

This one takes different approach from #5730, here I forcefully generate 1:1 aspect ratio image with existing ThumbnailController@show route.

However I had to change ThumbnailController to allow to override orientation, because before it would read the orientation from the asset, and it would be impossible to force cp_thumbnail_small_square image manipulation preset.

The only other place where this thumbnail route seems to be used is in src/Assets/Asset.php. The orientation path segment is optional and should not break existing usage.

One concern I see is that the avatar() method on HasAvatar trait could impact the avatar outputted on Antlers front-end, but from what I can see it does not (I tried outputting avatar from {{ current_user }}. From my understanding Statamic/Auth/User is used for CP user only? It would be amusing to receive an URL from CP thumbnail route.

I am okay if this PR does not get merged, while this is neater solution than #5730, it is slightly more complex and riskier (maybe it breaks something I am not aware of). But if you think this is good approach, then let me know if this needs additional adjustments, more than happy to address them. Regardless this was a journey for me to deep dive Statamic CMS source code a bit.

[ncla]

Oops, completely forgot about the tests. Hold on.. 😅

[jasonvarga]

One concern I see is that the avatar() method on HasAvatar trait could impact the avatar outputted on Antlers front-end, but from what I can see it does not

You're right. It's different on the frontend. avatar when used on the frontend would have different logic. You'd get the actual asset object, not the thumbnail URL used in the cp.

{{ current_user }}
{{ avatar /}} => /assets/myavatar.jpg
{{ avatar }}
{{ filename }} => myavatar
etc
{{ /avatar }}
{{ /current_user }}

Nice PR!

[ncla]

Fixes#5729

This one takes different approach from #5730, here I forcefully generate 1:1 aspect ratio image with existing ThumbnailController@show route.

However I had to change ThumbnailController to allow to override orientation, because before it would read the orientation from the asset, and it would be impossible to force cp_thumbnail_small_square image manipulation preset.

The only other place where this thumbnail route seems to be used is in src/Assets/Asset.php. The orientation path segment is optional and should not break existing usage.

One concern I see is that the avatar() method on HasAvatar trait could impact the avatar outputted on Antlers front-end, but from what I can see it does not (I tried outputting avatar from {{ current_user }}. From my understanding Statamic/Auth/User is used for CP user only? It would be amusing to receive an URL from CP thumbnail route.

I am okay if this PR does not get merged, while this is neater solution than #5730, it is slightly more complex and riskier (maybe it breaks something I am not aware of). But if you think this is good approach, then let me know if this needs additional adjustments, more than happy to address them. Regardless this was a journey for me to deep dive Statamic CMS source code a bit.

[ncla]

Oops, completely forgot about the tests. Hold on.. 😅

[jasonvarga]

One concern I see is that the avatar() method on HasAvatar trait could impact the avatar outputted on Antlers front-end, but from what I can see it does not

You're right. It's different on the frontend. avatar when used on the frontend would have different logic. You'd get the actual asset object, not the thumbnail URL used in the cp.

{{ current_user }}
{{ avatar /}} => /assets/myavatar.jpg
{{ avatar }}
{{ filename }} => myavatar
etc
{{ /avatar }}
{{ /current_user }}

Nice PR!

[ncla]

Fixes#5729

This one takes different approach from #5730, here I forcefully generate 1:1 aspect ratio image with existing ThumbnailController@show route.

However I had to change ThumbnailController to allow to override orientation, because before it would read the orientation from the asset, and it would be impossible to force cp_thumbnail_small_square image manipulation preset.

The only other place where this thumbnail route seems to be used is in src/Assets/Asset.php. The orientation path segment is optional and should not break existing usage.

One concern I see is that the avatar() method on HasAvatar trait could impact the avatar outputted on Antlers front-end, but from what I can see it does not (I tried outputting avatar from {{ current_user }}. From my understanding Statamic/Auth/User is used for CP user only? It would be amusing to receive an URL from CP thumbnail route.

I am okay if this PR does not get merged, while this is neater solution than #5730, it is slightly more complex and riskier (maybe it breaks something I am not aware of). But if you think this is good approach, then let me know if this needs additional adjustments, more than happy to address them. Regardless this was a journey for me to deep dive Statamic CMS source code a bit.

[ncla]

Oops, completely forgot about the tests. Hold on.. 😅

[jasonvarga]

One concern I see is that the avatar() method on HasAvatar trait could impact the avatar outputted on Antlers front-end, but from what I can see it does not

You're right. It's different on the frontend. avatar when used on the frontend would have different logic. You'd get the actual asset object, not the thumbnail URL used in the cp.

{{ current_user }}
{{ avatar /}} => /assets/myavatar.jpg
{{ avatar }}
{{ filename }} => myavatar
etc
{{ /avatar }}
{{ /current_user }}

Nice PR!

[ncla]

Fixes#5729

This one takes different approach from #5730, here I forcefully generate 1:1 aspect ratio image with existing ThumbnailController@show route.

However I had to change ThumbnailController to allow to override orientation, because before it would read the orientation from the asset, and it would be impossible to force cp_thumbnail_small_square image manipulation preset.

The only other place where this thumbnail route seems to be used is in src/Assets/Asset.php. The orientation path segment is optional and should not break existing usage.

One concern I see is that the avatar() method on HasAvatar trait could impact the avatar outputted on Antlers front-end, but from what I can see it does not (I tried outputting avatar from {{ current_user }}. From my understanding Statamic/Auth/User is used for CP user only? It would be amusing to receive an URL from CP thumbnail route.

I am okay if this PR does not get merged, while this is neater solution than #5730, it is slightly more complex and riskier (maybe it breaks something I am not aware of). But if you think this is good approach, then let me know if this needs additional adjustments, more than happy to address them. Regardless this was a journey for me to deep dive Statamic CMS source code a bit.

[ncla]

Oops, completely forgot about the tests. Hold on.. 😅

[jasonvarga]

One concern I see is that the avatar() method on HasAvatar trait could impact the avatar outputted on Antlers front-end, but from what I can see it does not

You're right. It's different on the frontend. avatar when used on the frontend would have different logic. You'd get the actual asset object, not the thumbnail URL used in the cp.

{{ current_user }}
{{ avatar /}} => /assets/myavatar.jpg
{{ avatar }}
{{ filename }} => myavatar
etc
{{ /avatar }}
{{ /current_user }}

Nice PR!

[ncla]

Fixes#5729

This one takes different approach from #5730, here I forcefully generate 1:1 aspect ratio image with existing ThumbnailController@show route.

However I had to change ThumbnailController to allow to override orientation, because before it would read the orientation from the asset, and it would be impossible to force cp_thumbnail_small_square image manipulation preset.

The only other place where this thumbnail route seems to be used is in src/Assets/Asset.php. The orientation path segment is optional and should not break existing usage.

One concern I see is that the avatar() method on HasAvatar trait could impact the avatar outputted on Antlers front-end, but from what I can see it does not (I tried outputting avatar from {{ current_user }}. From my understanding Statamic/Auth/User is used for CP user only? It would be amusing to receive an URL from CP thumbnail route.

I am okay if this PR does not get merged, while this is neater solution than #5730, it is slightly more complex and riskier (maybe it breaks something I am not aware of). But if you think this is good approach, then let me know if this needs additional adjustments, more than happy to address them. Regardless this was a journey for me to deep dive Statamic CMS source code a bit.

[ncla]

Oops, completely forgot about the tests. Hold on.. 😅

[jasonvarga]

One concern I see is that the avatar() method on HasAvatar trait could impact the avatar outputted on Antlers front-end, but from what I can see it does not

You're right. It's different on the frontend. avatar when used on the frontend would have different logic. You'd get the actual asset object, not the thumbnail URL used in the cp.

{{ current_user }}
{{ avatar /}} => /assets/myavatar.jpg
{{ avatar }}
{{ filename }} => myavatar
etc
{{ /avatar }}
{{ /current_user }}

Nice PR!

[ncla]

Fixes#5729

This one takes different approach from #5730, here I forcefully generate 1:1 aspect ratio image with existing ThumbnailController@show route.

However I had to change ThumbnailController to allow to override orientation, because before it would read the orientation from the asset, and it would be impossible to force cp_thumbnail_small_square image manipulation preset.

The only other place where this thumbnail route seems to be used is in src/Assets/Asset.php. The orientation path segment is optional and should not break existing usage.

One concern I see is that the avatar() method on HasAvatar trait could impact the avatar outputted on Antlers front-end, but from what I can see it does not (I tried outputting avatar from {{ current_user }}. From my understanding Statamic/Auth/User is used for CP user only? It would be amusing to receive an URL from CP thumbnail route.

I am okay if this PR does not get merged, while this is neater solution than #5730, it is slightly more complex and riskier (maybe it breaks something I am not aware of). But if you think this is good approach, then let me know if this needs additional adjustments, more than happy to address them. Regardless this was a journey for me to deep dive Statamic CMS source code a bit.

[ncla]

Oops, completely forgot about the tests. Hold on.. 😅

[jasonvarga]

One concern I see is that the avatar() method on HasAvatar trait could impact the avatar outputted on Antlers front-end, but from what I can see it does not

You're right. It's different on the frontend. avatar when used on the frontend would have different logic. You'd get the actual asset object, not the thumbnail URL used in the cp.

{{ current_user }}
{{ avatar /}} => /assets/myavatar.jpg
{{ avatar }}
{{ filename }} => myavatar
etc
{{ /avatar }}
{{ /current_user }}

Nice PR!

[ncla]

Fixes#5729

This one takes different approach from #5730, here I forcefully generate 1:1 aspect ratio image with existing ThumbnailController@show route.

However I had to change ThumbnailController to allow to override orientation, because before it would read the orientation from the asset, and it would be impossible to force cp_thumbnail_small_square image manipulation preset.

The only other place where this thumbnail route seems to be used is in src/Assets/Asset.php. The orientation path segment is optional and should not break existing usage.

One concern I see is that the avatar() method on HasAvatar trait could impact the avatar outputted on Antlers front-end, but from what I can see it does not (I tried outputting avatar from {{ current_user }}. From my understanding Statamic/Auth/User is used for CP user only? It would be amusing to receive an URL from CP thumbnail route.

I am okay if this PR does not get merged, while this is neater solution than #5730, it is slightly more complex and riskier (maybe it breaks something I am not aware of). But if you think this is good approach, then let me know if this needs additional adjustments, more than happy to address them. Regardless this was a journey for me to deep dive Statamic CMS source code a bit.

[ncla]

Oops, completely forgot about the tests. Hold on.. 😅

[jasonvarga]

One concern I see is that the avatar() method on HasAvatar trait could impact the avatar outputted on Antlers front-end, but from what I can see it does not

You're right. It's different on the frontend. avatar when used on the frontend would have different logic. You'd get the actual asset object, not the thumbnail URL used in the cp.

{{ current_user }}
{{ avatar /}} => /assets/myavatar.jpg
{{ avatar }}
{{ filename }} => myavatar
etc
{{ /avatar }}
{{ /current_user }}

Nice PR!