Fix toggle field casting to boolean when field is hidden

[jesseleite]

Ensure the toggle fieldtype only casts to a saveable boolean when the value is submitted. When conditionally hidden, it should save neither true nor false, according to our docs on conditional field data flow.

Fixes#6347.

[aerni]

@jesseleite This issue still persists for me. I'm on the latest version. It might be due to nesting. My toggle field is in a Grid that's in a Grid that's in a Replicator.

[jesseleite]

@aerni I can't reproduce this with a toggle in a grid in a replicator. Could you provide more details what is happening for you, with steps to reproduce?

In my test here... When the toggle is hidden, nothing is saved. If the toggle is visible, the proper value of the toggle gets saved. This is the expected behaviour, as described in description and docs link above.

[aerni]

I'll try to reproduce the issue on a fresh site and share the repo with you.

[aerni]

Alright. I was able to reproduce the issue.

1. Clone this repo: https://github.com/aerni/toggle-issue
2. Open the home page in the CP
3. Open the Show more settings revealer in the button grid
4. Notice that there is no Download toggle, so it shouldn't save anything. But download: false is still saved to file.
5. The download toggle is only visible and should only be saved if you select Asset as the Link Type.

Let me know if you need more info.

[jasonvarga]

Try taking out the default: false from the download field config.

[aerni]

I actually need it to default: true when the toggle is visible. I just have it set to false now because I was testing if that made a difference.

[jesseleite]

@aerni I notice you are hiding the download toggle using a revealer. Any time a field is hidden via a revealer, data flow behaviour changes to always submit those hidden-by-revealer fields.

[aerni]

Yeah, I understand that. However, the download toggle has multiple conditions. One condition is triggered by the link_type which is a select fieldtype. So in this case it should still be removed from the data flow.

[jesseleite]

@aerni Yeah I hear you now. This has nothing to do with toggle field specifically, or nesting within grids for that matter. This would happen on any field hidden by a revealer when multiple field conditions are set.

Need to think about whether this might affect another use case negatively or not, but maybe I can improve revealer handling when multiple conditions are being evaluated 👍

Feel free to follow along here: #6385

[aerni]

Ok, cool. Thanks for opening an issue 👍

[jesseleite]

No problem, good find!

[jesseleite]

Ensure the toggle fieldtype only casts to a saveable boolean when the value is submitted. When conditionally hidden, it should save neither true nor false, according to our docs on conditional field data flow.

Fixes#6347.

[aerni]

@jesseleite This issue still persists for me. I'm on the latest version. It might be due to nesting. My toggle field is in a Grid that's in a Grid that's in a Replicator.

[jesseleite]

@aerni I can't reproduce this with a toggle in a grid in a replicator. Could you provide more details what is happening for you, with steps to reproduce?

In my test here... When the toggle is hidden, nothing is saved. If the toggle is visible, the proper value of the toggle gets saved. This is the expected behaviour, as described in description and docs link above.

[aerni]

I'll try to reproduce the issue on a fresh site and share the repo with you.

[aerni]

Alright. I was able to reproduce the issue.

1. Clone this repo: https://github.com/aerni/toggle-issue
2. Open the home page in the CP
3. Open the Show more settings revealer in the button grid
4. Notice that there is no Download toggle, so it shouldn't save anything. But download: false is still saved to file.
5. The download toggle is only visible and should only be saved if you select Asset as the Link Type.

Let me know if you need more info.

[jasonvarga]

Try taking out the default: false from the download field config.

[aerni]

I actually need it to default: true when the toggle is visible. I just have it set to false now because I was testing if that made a difference.

[jesseleite]

@aerni I notice you are hiding the download toggle using a revealer. Any time a field is hidden via a revealer, data flow behaviour changes to always submit those hidden-by-revealer fields.

[aerni]

Yeah, I understand that. However, the download toggle has multiple conditions. One condition is triggered by the link_type which is a select fieldtype. So in this case it should still be removed from the data flow.

[jesseleite]

@aerni Yeah I hear you now. This has nothing to do with toggle field specifically, or nesting within grids for that matter. This would happen on any field hidden by a revealer when multiple field conditions are set.

Need to think about whether this might affect another use case negatively or not, but maybe I can improve revealer handling when multiple conditions are being evaluated 👍

Feel free to follow along here: #6385

[aerni]

Ok, cool. Thanks for opening an issue 👍

[jesseleite]

No problem, good find!

[jesseleite]

Ensure the toggle fieldtype only casts to a saveable boolean when the value is submitted. When conditionally hidden, it should save neither true nor false, according to our docs on conditional field data flow.

Fixes#6347.

[aerni]

@jesseleite This issue still persists for me. I'm on the latest version. It might be due to nesting. My toggle field is in a Grid that's in a Grid that's in a Replicator.

[jesseleite]

@aerni I can't reproduce this with a toggle in a grid in a replicator. Could you provide more details what is happening for you, with steps to reproduce?

In my test here... When the toggle is hidden, nothing is saved. If the toggle is visible, the proper value of the toggle gets saved. This is the expected behaviour, as described in description and docs link above.

[aerni]

I'll try to reproduce the issue on a fresh site and share the repo with you.

[aerni]

Alright. I was able to reproduce the issue.

1. Clone this repo: https://github.com/aerni/toggle-issue
2. Open the home page in the CP
3. Open the Show more settings revealer in the button grid
4. Notice that there is no Download toggle, so it shouldn't save anything. But download: false is still saved to file.
5. The download toggle is only visible and should only be saved if you select Asset as the Link Type.

Let me know if you need more info.

[jasonvarga]

Try taking out the default: false from the download field config.

[aerni]

I actually need it to default: true when the toggle is visible. I just have it set to false now because I was testing if that made a difference.

[jesseleite]

@aerni I notice you are hiding the download toggle using a revealer. Any time a field is hidden via a revealer, data flow behaviour changes to always submit those hidden-by-revealer fields.

[aerni]

Yeah, I understand that. However, the download toggle has multiple conditions. One condition is triggered by the link_type which is a select fieldtype. So in this case it should still be removed from the data flow.

[jesseleite]

@aerni Yeah I hear you now. This has nothing to do with toggle field specifically, or nesting within grids for that matter. This would happen on any field hidden by a revealer when multiple field conditions are set.

Need to think about whether this might affect another use case negatively or not, but maybe I can improve revealer handling when multiple conditions are being evaluated 👍

Feel free to follow along here: #6385

[aerni]

Ok, cool. Thanks for opening an issue 👍

[jesseleite]

No problem, good find!

[jesseleite]

Ensure the toggle fieldtype only casts to a saveable boolean when the value is submitted. When conditionally hidden, it should save neither true nor false, according to our docs on conditional field data flow.

Fixes#6347.

[aerni]

@jesseleite This issue still persists for me. I'm on the latest version. It might be due to nesting. My toggle field is in a Grid that's in a Grid that's in a Replicator.

[jesseleite]

@aerni I can't reproduce this with a toggle in a grid in a replicator. Could you provide more details what is happening for you, with steps to reproduce?

In my test here... When the toggle is hidden, nothing is saved. If the toggle is visible, the proper value of the toggle gets saved. This is the expected behaviour, as described in description and docs link above.

[aerni]

I'll try to reproduce the issue on a fresh site and share the repo with you.

[aerni]

Alright. I was able to reproduce the issue.

1. Clone this repo: https://github.com/aerni/toggle-issue
2. Open the home page in the CP
3. Open the Show more settings revealer in the button grid
4. Notice that there is no Download toggle, so it shouldn't save anything. But download: false is still saved to file.
5. The download toggle is only visible and should only be saved if you select Asset as the Link Type.

Let me know if you need more info.

[jasonvarga]

Try taking out the default: false from the download field config.

[aerni]

I actually need it to default: true when the toggle is visible. I just have it set to false now because I was testing if that made a difference.

[jesseleite]

@aerni I notice you are hiding the download toggle using a revealer. Any time a field is hidden via a revealer, data flow behaviour changes to always submit those hidden-by-revealer fields.

[aerni]

Yeah, I understand that. However, the download toggle has multiple conditions. One condition is triggered by the link_type which is a select fieldtype. So in this case it should still be removed from the data flow.

[jesseleite]

@aerni Yeah I hear you now. This has nothing to do with toggle field specifically, or nesting within grids for that matter. This would happen on any field hidden by a revealer when multiple field conditions are set.

Need to think about whether this might affect another use case negatively or not, but maybe I can improve revealer handling when multiple conditions are being evaluated 👍

Feel free to follow along here: #6385

[aerni]

Ok, cool. Thanks for opening an issue 👍

[jesseleite]

No problem, good find!

[jesseleite]

Ensure the toggle fieldtype only casts to a saveable boolean when the value is submitted. When conditionally hidden, it should save neither true nor false, according to our docs on conditional field data flow.

Fixes#6347.

[aerni]

@jesseleite This issue still persists for me. I'm on the latest version. It might be due to nesting. My toggle field is in a Grid that's in a Grid that's in a Replicator.

[jesseleite]

@aerni I can't reproduce this with a toggle in a grid in a replicator. Could you provide more details what is happening for you, with steps to reproduce?

In my test here... When the toggle is hidden, nothing is saved. If the toggle is visible, the proper value of the toggle gets saved. This is the expected behaviour, as described in description and docs link above.

[aerni]

I'll try to reproduce the issue on a fresh site and share the repo with you.

[aerni]

Alright. I was able to reproduce the issue.

1. Clone this repo: https://github.com/aerni/toggle-issue
2. Open the home page in the CP
3. Open the Show more settings revealer in the button grid
4. Notice that there is no Download toggle, so it shouldn't save anything. But download: false is still saved to file.
5. The download toggle is only visible and should only be saved if you select Asset as the Link Type.

Let me know if you need more info.

[jasonvarga]

Try taking out the default: false from the download field config.

[aerni]

I actually need it to default: true when the toggle is visible. I just have it set to false now because I was testing if that made a difference.

[jesseleite]

@aerni I notice you are hiding the download toggle using a revealer. Any time a field is hidden via a revealer, data flow behaviour changes to always submit those hidden-by-revealer fields.

[aerni]

Yeah, I understand that. However, the download toggle has multiple conditions. One condition is triggered by the link_type which is a select fieldtype. So in this case it should still be removed from the data flow.

[jesseleite]

@aerni Yeah I hear you now. This has nothing to do with toggle field specifically, or nesting within grids for that matter. This would happen on any field hidden by a revealer when multiple field conditions are set.

Need to think about whether this might affect another use case negatively or not, but maybe I can improve revealer handling when multiple conditions are being evaluated 👍

Feel free to follow along here: #6385

[aerni]

Ok, cool. Thanks for opening an issue 👍

[jesseleite]

No problem, good find!

[jesseleite]

Ensure the toggle fieldtype only casts to a saveable boolean when the value is submitted. When conditionally hidden, it should save neither true nor false, according to our docs on conditional field data flow.

Fixes#6347.

[aerni]

@jesseleite This issue still persists for me. I'm on the latest version. It might be due to nesting. My toggle field is in a Grid that's in a Grid that's in a Replicator.

[jesseleite]

@aerni I can't reproduce this with a toggle in a grid in a replicator. Could you provide more details what is happening for you, with steps to reproduce?

In my test here... When the toggle is hidden, nothing is saved. If the toggle is visible, the proper value of the toggle gets saved. This is the expected behaviour, as described in description and docs link above.

[aerni]

I'll try to reproduce the issue on a fresh site and share the repo with you.

[aerni]

Alright. I was able to reproduce the issue.

1. Clone this repo: https://github.com/aerni/toggle-issue
2. Open the home page in the CP
3. Open the Show more settings revealer in the button grid
4. Notice that there is no Download toggle, so it shouldn't save anything. But download: false is still saved to file.
5. The download toggle is only visible and should only be saved if you select Asset as the Link Type.

Let me know if you need more info.

[jasonvarga]

Try taking out the default: false from the download field config.

[aerni]

I actually need it to default: true when the toggle is visible. I just have it set to false now because I was testing if that made a difference.

[jesseleite]

@aerni I notice you are hiding the download toggle using a revealer. Any time a field is hidden via a revealer, data flow behaviour changes to always submit those hidden-by-revealer fields.

[aerni]

Yeah, I understand that. However, the download toggle has multiple conditions. One condition is triggered by the link_type which is a select fieldtype. So in this case it should still be removed from the data flow.

[jesseleite]

@aerni Yeah I hear you now. This has nothing to do with toggle field specifically, or nesting within grids for that matter. This would happen on any field hidden by a revealer when multiple field conditions are set.

Need to think about whether this might affect another use case negatively or not, but maybe I can improve revealer handling when multiple conditions are being evaluated 👍

Feel free to follow along here: #6385

[aerni]

Ok, cool. Thanks for opening an issue 👍

[jesseleite]

No problem, good find!

[jesseleite]

Ensure the toggle fieldtype only casts to a saveable boolean when the value is submitted. When conditionally hidden, it should save neither true nor false, according to our docs on conditional field data flow.

Fixes#6347.

[aerni]

@jesseleite This issue still persists for me. I'm on the latest version. It might be due to nesting. My toggle field is in a Grid that's in a Grid that's in a Replicator.

[jesseleite]

@aerni I can't reproduce this with a toggle in a grid in a replicator. Could you provide more details what is happening for you, with steps to reproduce?

In my test here... When the toggle is hidden, nothing is saved. If the toggle is visible, the proper value of the toggle gets saved. This is the expected behaviour, as described in description and docs link above.

[aerni]

I'll try to reproduce the issue on a fresh site and share the repo with you.

[aerni]

Alright. I was able to reproduce the issue.

1. Clone this repo: https://github.com/aerni/toggle-issue
2. Open the home page in the CP
3. Open the Show more settings revealer in the button grid
4. Notice that there is no Download toggle, so it shouldn't save anything. But download: false is still saved to file.
5. The download toggle is only visible and should only be saved if you select Asset as the Link Type.

Let me know if you need more info.

[jasonvarga]

Try taking out the default: false from the download field config.

[aerni]

I actually need it to default: true when the toggle is visible. I just have it set to false now because I was testing if that made a difference.

[jesseleite]

@aerni I notice you are hiding the download toggle using a revealer. Any time a field is hidden via a revealer, data flow behaviour changes to always submit those hidden-by-revealer fields.

[aerni]

Yeah, I understand that. However, the download toggle has multiple conditions. One condition is triggered by the link_type which is a select fieldtype. So in this case it should still be removed from the data flow.

[jesseleite]

@aerni Yeah I hear you now. This has nothing to do with toggle field specifically, or nesting within grids for that matter. This would happen on any field hidden by a revealer when multiple field conditions are set.

Need to think about whether this might affect another use case negatively or not, but maybe I can improve revealer handling when multiple conditions are being evaluated 👍

Feel free to follow along here: #6385

[aerni]

Ok, cool. Thanks for opening an issue 👍

[jesseleite]

No problem, good find!

[jesseleite]

Ensure the toggle fieldtype only casts to a saveable boolean when the value is submitted. When conditionally hidden, it should save neither true nor false, according to our docs on conditional field data flow.

Fixes#6347.

[aerni]

@jesseleite This issue still persists for me. I'm on the latest version. It might be due to nesting. My toggle field is in a Grid that's in a Grid that's in a Replicator.

[jesseleite]

@aerni I can't reproduce this with a toggle in a grid in a replicator. Could you provide more details what is happening for you, with steps to reproduce?

In my test here... When the toggle is hidden, nothing is saved. If the toggle is visible, the proper value of the toggle gets saved. This is the expected behaviour, as described in description and docs link above.

[aerni]

I'll try to reproduce the issue on a fresh site and share the repo with you.

[aerni]

Alright. I was able to reproduce the issue.

1. Clone this repo: https://github.com/aerni/toggle-issue
2. Open the home page in the CP
3. Open the Show more settings revealer in the button grid
4. Notice that there is no Download toggle, so it shouldn't save anything. But download: false is still saved to file.
5. The download toggle is only visible and should only be saved if you select Asset as the Link Type.

Let me know if you need more info.

[jasonvarga]

Try taking out the default: false from the download field config.

[aerni]

I actually need it to default: true when the toggle is visible. I just have it set to false now because I was testing if that made a difference.

[jesseleite]

@aerni I notice you are hiding the download toggle using a revealer. Any time a field is hidden via a revealer, data flow behaviour changes to always submit those hidden-by-revealer fields.

[aerni]

Yeah, I understand that. However, the download toggle has multiple conditions. One condition is triggered by the link_type which is a select fieldtype. So in this case it should still be removed from the data flow.

[jesseleite]

@aerni Yeah I hear you now. This has nothing to do with toggle field specifically, or nesting within grids for that matter. This would happen on any field hidden by a revealer when multiple field conditions are set.

Need to think about whether this might affect another use case negatively or not, but maybe I can improve revealer handling when multiple conditions are being evaluated 👍

Feel free to follow along here: #6385

[aerni]

Ok, cool. Thanks for opening an issue 👍

[jesseleite]

No problem, good find!