Skip to content

UI fixes and improvements - #6383

Closed
j3ll3yfi5h wants to merge 10 commits into
statamic:3.3from
j3ll3yfi5h:3.3
Closed

UI fixes and improvements#6383
j3ll3yfi5h wants to merge 10 commits into
statamic:3.3from
j3ll3yfi5h:3.3

Conversation

@j3ll3yfi5h

@j3ll3yfi5hj3ll3yfi5h commented Jul 27, 2022

Copy link
Copy Markdown
Contributor

Fixes#3030
Fixes#5034

  • introduce four main sections with z-indexes
  • position mainsections sticky instead absolute/fixed
  • prevent duplicate nav markup
  • improve table overflowing
    • Collections
    • Entries
    • Terms
    • Assets
    • Fieldsets
    • Forms
    • Form Submissions
    • Users
    • User Groups
  • prevent popover overflows
  • change <header> children margins to flex gaps and fix overflowing headings

Bildschirmfoto 2022-07-25 um 18 28 36

jasonvarga
jasonvarga previously requested changes Jul 31, 2022

@jasonvargajasonvarga left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the update to package-lock.json necessary? If not, please revert it.

@jasonvarga

Copy link
Copy Markdown
Member

To make this easier to review, I'd stop adding items to the scope of this PR.

Additional UI issues can be fixed in separate PRs.

If/when you're done with the items you've outlined in the description, go ahead and mark this as ready for review.

@j3ll3yfi5h

Copy link
Copy Markdown
ContributorAuthor

Alright. I'm currently using the changes on a client project to see, how it behaves and I'll make it ready for review by the end of the day. 👍

@j3ll3yfi5h
j3ll3yfi5h marked this pull request as ready for review August 3, 2022 21:13
@jasonvarga
jasonvarga dismissed their stale reviewAugust 3, 2022 22:22

Change was made.

@jackmcdade
jackmcdade self-requested a review August 4, 2022 13:37

@jackmcdadejackmcdade left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the table overflow stuff looks great!

Unfortunately the nav, section, and z-index stuff breaks all the fullscreen modes of Bard, Markdown, etc.

182860826-5a2de712-8d34-49ea-a933-833f83c55fe6

If you want to break this PR up, I can merge the table stuff today, or we can wait. Up to you.

@j3ll3yfi5h

Copy link
Copy Markdown
ContributorAuthor

Oh, I did totally miss those fullscreen views, sorry!

I'll look into it, maybe there ist something we can do with the PortalVue.

@jackmcdade

Copy link
Copy Markdown
Member

Or maybe it's mostly z-index? Previously each of those numbers had a purpose too (997, 998, etc) to account for the Bard Nav, main nav, etc etc.

@jackmcdade

Copy link
Copy Markdown
Member

I also found that the table view gets way too tall
CleanShot 2022-09-07 at 09 54 36@2x

@j3ll3yfi5h

j3ll3yfi5h commented Sep 12, 2022

Copy link
Copy Markdown
ContributorAuthor

I also found that the table view gets way too tall

This was in my opinion the nicest way to fix those popovers, which are causing scrollbars:

189731678-91540675-7005-478f-b7d8-ee1b3a7d2bd5.mov

At least ten fields in the filter without scrolling should work in my opinion - what is your opinion on this?

@jackmcdade

Copy link
Copy Markdown
Member

Will be using this as inspiration for my work in #7559 — as it is right here I won't be able to merge it, but thank you for the hard work! It is most appreciated and valued.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Collection listing breaks with too many fields [UI] The mobile interface doesn't fill with the width of the layout.

3 participants

@j3ll3yfi5h@jasonvarga@jackmcdade