Static cache: properly support multisite and async queues

[arthurperton]

Fixes#3291. Fixes#6397.

Invalidating URLs in the static cache should work well now on multisite and when using async queues*. On multisite, when you update an entry, it will also invalidate the URLs of the descendants of that entry.

*When using with async queues, you must have your APP_URL set to the right value.

[jasonvarga]

This is working well when it's the individual urls getting invalidated.
e.g. you save an entry, and that entry's url gets invalidated.

What's not working is when you have an array of 'urls' to invalidate from the config.

'invalidation' => [
'rules' => [
'collections' => [
'blog' => [
'/blog', // only does http://site1.com/blog. it won't invalidate `site2.com/blog`
],
],
],
]

Since you typically define relative the urls in the config, when it looks through, it doesn't pass along the domain.

This sorta thing:

$this->cacher->invalidateUrl(...$this->splitUrlAndDomain($url));

What we could probably do is in AbstractCacher@invalidateUrls, for each item, if they're not already an absolute URL, add the base url onto the start of it.

Then we can have support for invalidating multi-domain urls by telling people to define absolute urls in their config. That'd solve #6397.

'invalidation' => [
'rules' => [
'collections' => [
'blog' => [
'/blog', // assumes http://site1.com/blog'https://site2.com/blog', // since its defined absolute, we dont have to assume.
],
],
],
]

[arthurperton]

Thanks, good point! I've been working on a fix, still have to add some tests later.

[arthurperton]

Allright the AbstractCacher always passes a domain too now to ->invalidateUrl(). I also changed ->getBaseUrl() to make it more predictable and in line with what we want for multisite.

Tests were added for both ->invalidateUrls() and ->getBaseUrl().

[arthurperton]

🎉

[stuartcusackie]

Still an issue on 3.3.67 I'm afraid.

[freshface]

Yes, also on 3.4.7

[arthurperton]

Fixes#3291. Fixes#6397.

Invalidating URLs in the static cache should work well now on multisite and when using async queues*. On multisite, when you update an entry, it will also invalidate the URLs of the descendants of that entry.

*When using with async queues, you must have your APP_URL set to the right value.

[jasonvarga]

This is working well when it's the individual urls getting invalidated.
e.g. you save an entry, and that entry's url gets invalidated.

What's not working is when you have an array of 'urls' to invalidate from the config.

'invalidation' => [
'rules' => [
'collections' => [
'blog' => [
'/blog', // only does http://site1.com/blog. it won't invalidate `site2.com/blog`
],
],
],
]

Since you typically define relative the urls in the config, when it looks through, it doesn't pass along the domain.

This sorta thing:

$this->cacher->invalidateUrl(...$this->splitUrlAndDomain($url));

What we could probably do is in AbstractCacher@invalidateUrls, for each item, if they're not already an absolute URL, add the base url onto the start of it.

Then we can have support for invalidating multi-domain urls by telling people to define absolute urls in their config. That'd solve #6397.

'invalidation' => [
'rules' => [
'collections' => [
'blog' => [
'/blog', // assumes http://site1.com/blog'https://site2.com/blog', // since its defined absolute, we dont have to assume.
],
],
],
]

[arthurperton]

Thanks, good point! I've been working on a fix, still have to add some tests later.

[arthurperton]

Allright the AbstractCacher always passes a domain too now to ->invalidateUrl(). I also changed ->getBaseUrl() to make it more predictable and in line with what we want for multisite.

Tests were added for both ->invalidateUrls() and ->getBaseUrl().

[arthurperton]

🎉

[stuartcusackie]

Still an issue on 3.3.67 I'm afraid.

[freshface]

Yes, also on 3.4.7

[arthurperton]

Fixes#3291. Fixes#6397.

Invalidating URLs in the static cache should work well now on multisite and when using async queues*. On multisite, when you update an entry, it will also invalidate the URLs of the descendants of that entry.

*When using with async queues, you must have your APP_URL set to the right value.

[jasonvarga]

This is working well when it's the individual urls getting invalidated.
e.g. you save an entry, and that entry's url gets invalidated.

What's not working is when you have an array of 'urls' to invalidate from the config.

'invalidation' => [
'rules' => [
'collections' => [
'blog' => [
'/blog', // only does http://site1.com/blog. it won't invalidate `site2.com/blog`
],
],
],
]

Since you typically define relative the urls in the config, when it looks through, it doesn't pass along the domain.

This sorta thing:

$this->cacher->invalidateUrl(...$this->splitUrlAndDomain($url));

What we could probably do is in AbstractCacher@invalidateUrls, for each item, if they're not already an absolute URL, add the base url onto the start of it.

Then we can have support for invalidating multi-domain urls by telling people to define absolute urls in their config. That'd solve #6397.

'invalidation' => [
'rules' => [
'collections' => [
'blog' => [
'/blog', // assumes http://site1.com/blog'https://site2.com/blog', // since its defined absolute, we dont have to assume.
],
],
],
]

[arthurperton]

Thanks, good point! I've been working on a fix, still have to add some tests later.

[arthurperton]

Allright the AbstractCacher always passes a domain too now to ->invalidateUrl(). I also changed ->getBaseUrl() to make it more predictable and in line with what we want for multisite.

Tests were added for both ->invalidateUrls() and ->getBaseUrl().

[arthurperton]

🎉

[stuartcusackie]

Still an issue on 3.3.67 I'm afraid.

[freshface]

Yes, also on 3.4.7

[arthurperton]

Fixes#3291. Fixes#6397.

Invalidating URLs in the static cache should work well now on multisite and when using async queues*. On multisite, when you update an entry, it will also invalidate the URLs of the descendants of that entry.

*When using with async queues, you must have your APP_URL set to the right value.

[jasonvarga]

This is working well when it's the individual urls getting invalidated.
e.g. you save an entry, and that entry's url gets invalidated.

What's not working is when you have an array of 'urls' to invalidate from the config.

'invalidation' => [
'rules' => [
'collections' => [
'blog' => [
'/blog', // only does http://site1.com/blog. it won't invalidate `site2.com/blog`
],
],
],
]

Since you typically define relative the urls in the config, when it looks through, it doesn't pass along the domain.

This sorta thing:

$this->cacher->invalidateUrl(...$this->splitUrlAndDomain($url));

What we could probably do is in AbstractCacher@invalidateUrls, for each item, if they're not already an absolute URL, add the base url onto the start of it.

Then we can have support for invalidating multi-domain urls by telling people to define absolute urls in their config. That'd solve #6397.

'invalidation' => [
'rules' => [
'collections' => [
'blog' => [
'/blog', // assumes http://site1.com/blog'https://site2.com/blog', // since its defined absolute, we dont have to assume.
],
],
],
]

[arthurperton]

Thanks, good point! I've been working on a fix, still have to add some tests later.

[arthurperton]

Allright the AbstractCacher always passes a domain too now to ->invalidateUrl(). I also changed ->getBaseUrl() to make it more predictable and in line with what we want for multisite.

Tests were added for both ->invalidateUrls() and ->getBaseUrl().

[arthurperton]

🎉

[stuartcusackie]

Still an issue on 3.3.67 I'm afraid.

[freshface]

Yes, also on 3.4.7

[arthurperton]

Fixes#3291. Fixes#6397.

Invalidating URLs in the static cache should work well now on multisite and when using async queues*. On multisite, when you update an entry, it will also invalidate the URLs of the descendants of that entry.

*When using with async queues, you must have your APP_URL set to the right value.

[jasonvarga]

This is working well when it's the individual urls getting invalidated.
e.g. you save an entry, and that entry's url gets invalidated.

What's not working is when you have an array of 'urls' to invalidate from the config.

'invalidation' => [
'rules' => [
'collections' => [
'blog' => [
'/blog', // only does http://site1.com/blog. it won't invalidate `site2.com/blog`
],
],
],
]

Since you typically define relative the urls in the config, when it looks through, it doesn't pass along the domain.

This sorta thing:

$this->cacher->invalidateUrl(...$this->splitUrlAndDomain($url));

What we could probably do is in AbstractCacher@invalidateUrls, for each item, if they're not already an absolute URL, add the base url onto the start of it.

Then we can have support for invalidating multi-domain urls by telling people to define absolute urls in their config. That'd solve #6397.

'invalidation' => [
'rules' => [
'collections' => [
'blog' => [
'/blog', // assumes http://site1.com/blog'https://site2.com/blog', // since its defined absolute, we dont have to assume.
],
],
],
]

[arthurperton]

Thanks, good point! I've been working on a fix, still have to add some tests later.

[arthurperton]

Allright the AbstractCacher always passes a domain too now to ->invalidateUrl(). I also changed ->getBaseUrl() to make it more predictable and in line with what we want for multisite.

Tests were added for both ->invalidateUrls() and ->getBaseUrl().

[arthurperton]

🎉

[stuartcusackie]

Still an issue on 3.3.67 I'm afraid.

[freshface]

Yes, also on 3.4.7

[arthurperton]

Fixes#3291. Fixes#6397.

Invalidating URLs in the static cache should work well now on multisite and when using async queues*. On multisite, when you update an entry, it will also invalidate the URLs of the descendants of that entry.

*When using with async queues, you must have your APP_URL set to the right value.

[jasonvarga]

This is working well when it's the individual urls getting invalidated.
e.g. you save an entry, and that entry's url gets invalidated.

What's not working is when you have an array of 'urls' to invalidate from the config.

'invalidation' => [
'rules' => [
'collections' => [
'blog' => [
'/blog', // only does http://site1.com/blog. it won't invalidate `site2.com/blog`
],
],
],
]

Since you typically define relative the urls in the config, when it looks through, it doesn't pass along the domain.

This sorta thing:

$this->cacher->invalidateUrl(...$this->splitUrlAndDomain($url));

What we could probably do is in AbstractCacher@invalidateUrls, for each item, if they're not already an absolute URL, add the base url onto the start of it.

Then we can have support for invalidating multi-domain urls by telling people to define absolute urls in their config. That'd solve #6397.

'invalidation' => [
'rules' => [
'collections' => [
'blog' => [
'/blog', // assumes http://site1.com/blog'https://site2.com/blog', // since its defined absolute, we dont have to assume.
],
],
],
]

[arthurperton]

Thanks, good point! I've been working on a fix, still have to add some tests later.

[arthurperton]

Allright the AbstractCacher always passes a domain too now to ->invalidateUrl(). I also changed ->getBaseUrl() to make it more predictable and in line with what we want for multisite.

Tests were added for both ->invalidateUrls() and ->getBaseUrl().

[arthurperton]

🎉

[stuartcusackie]

Still an issue on 3.3.67 I'm afraid.

[freshface]

Yes, also on 3.4.7

[arthurperton]

Fixes#3291. Fixes#6397.

Invalidating URLs in the static cache should work well now on multisite and when using async queues*. On multisite, when you update an entry, it will also invalidate the URLs of the descendants of that entry.

*When using with async queues, you must have your APP_URL set to the right value.

[jasonvarga]

This is working well when it's the individual urls getting invalidated.
e.g. you save an entry, and that entry's url gets invalidated.

What's not working is when you have an array of 'urls' to invalidate from the config.

'invalidation' => [
'rules' => [
'collections' => [
'blog' => [
'/blog', // only does http://site1.com/blog. it won't invalidate `site2.com/blog`
],
],
],
]

Since you typically define relative the urls in the config, when it looks through, it doesn't pass along the domain.

This sorta thing:

$this->cacher->invalidateUrl(...$this->splitUrlAndDomain($url));

What we could probably do is in AbstractCacher@invalidateUrls, for each item, if they're not already an absolute URL, add the base url onto the start of it.

Then we can have support for invalidating multi-domain urls by telling people to define absolute urls in their config. That'd solve #6397.

'invalidation' => [
'rules' => [
'collections' => [
'blog' => [
'/blog', // assumes http://site1.com/blog'https://site2.com/blog', // since its defined absolute, we dont have to assume.
],
],
],
]

[arthurperton]

Thanks, good point! I've been working on a fix, still have to add some tests later.

[arthurperton]

Allright the AbstractCacher always passes a domain too now to ->invalidateUrl(). I also changed ->getBaseUrl() to make it more predictable and in line with what we want for multisite.

Tests were added for both ->invalidateUrls() and ->getBaseUrl().

[arthurperton]

🎉

[stuartcusackie]

Still an issue on 3.3.67 I'm afraid.

[freshface]

Yes, also on 3.4.7

[arthurperton]

Fixes#3291. Fixes#6397.

Invalidating URLs in the static cache should work well now on multisite and when using async queues*. On multisite, when you update an entry, it will also invalidate the URLs of the descendants of that entry.

*When using with async queues, you must have your APP_URL set to the right value.

[jasonvarga]

This is working well when it's the individual urls getting invalidated.
e.g. you save an entry, and that entry's url gets invalidated.

What's not working is when you have an array of 'urls' to invalidate from the config.

'invalidation' => [
'rules' => [
'collections' => [
'blog' => [
'/blog', // only does http://site1.com/blog. it won't invalidate `site2.com/blog`
],
],
],
]

Since you typically define relative the urls in the config, when it looks through, it doesn't pass along the domain.

This sorta thing:

$this->cacher->invalidateUrl(...$this->splitUrlAndDomain($url));

What we could probably do is in AbstractCacher@invalidateUrls, for each item, if they're not already an absolute URL, add the base url onto the start of it.

Then we can have support for invalidating multi-domain urls by telling people to define absolute urls in their config. That'd solve #6397.

'invalidation' => [
'rules' => [
'collections' => [
'blog' => [
'/blog', // assumes http://site1.com/blog'https://site2.com/blog', // since its defined absolute, we dont have to assume.
],
],
],
]

[arthurperton]

Thanks, good point! I've been working on a fix, still have to add some tests later.

[arthurperton]

Allright the AbstractCacher always passes a domain too now to ->invalidateUrl(). I also changed ->getBaseUrl() to make it more predictable and in line with what we want for multisite.

Tests were added for both ->invalidateUrls() and ->getBaseUrl().

[arthurperton]

🎉

[stuartcusackie]

Still an issue on 3.3.67 I'm afraid.

[freshface]

Yes, also on 3.4.7