Uh oh!
There was an error while loading. Please reload this page.
Fix handling for empty checkboxes fieldtype on front-end - #7180
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #7178
Previously, if you uncheck all the boxes in a
checkboxesfield on the frontend, it would act like the field wasn't submitted at all, so the previous value would be used.This PR adds a hidden field with an empty value. So if you uncheck all the options, an empty value still gets submitted, so the value will be updated to nothing, as expected.
Added a test to ensure that the hidden field is in the html.
Add equivalent test for toggle field while we're at it, which relies on the same behavior.
Again, this only matters for #6400 since at the moment front-end fields are only used for forms, which are create-only at the moment.