Uh oh!
There was an error while loading. Please reload this page.
[4.x] Invalidate Stache status index value on date - #8281
Closed
jasonvarga wants to merge 3 commits into
Closed
Conversation
mmodler
commented
Dec 1, 2023
Contributor
In our big project, we use this as hacky workaround So i would very much celebrate progress on this issue :) |
jasonvarga
commented
Jan 13, 2024
MemberAuthor
Fairly confident this won't be necessary after #9317 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #5089
Closes#2217
This is more of the direction I had in mind. This will save the status along with a timestamp of when the value should "expire". When loading the index, it'll loop over them, see if any timestamps are expired, then update them.
This obviously only solves the problem for the Stache. For Eloquent, we'd need to think of a different solution.
I still think the real solution is to scrap querying by
statusand instead put the logic in the query itself. (e.g. where date is in past, and published is true, etc). But that's a bigger job and likely a breaking change.This should solve what @aerni needed (scheduled entries), and what @buffalom brought up (expired entries).
Todo: