[4.x] Make contains modifier handle array needles

[ryanmitchell]

Sometimes you need to compare arrays to arrays, and it would be nice if the contains modifier was smart enough to handle it.

This PR updates that modifier to check if the intersect count between the 2 arrays is greater than zero, and if so it's true. This allows you to do things like:

{{ collection:pages array_field:contains="this|or|that" }}

or

{{ my_value | contains("this|or|that") }}

Which people seem to assume should work (judging by discord).

I thought it better to do it this way rather than a new modifier.

You could argue it should be a strict comparison, where the intersect count needs to match the needle count, but this approach matches whereJsonContains, and I've updated the queriesConditions contains method too.

[jasonvarga]

This allows you to do things like:
{{ collection:pages array_field:contains="this|or|that" }}

Are you sure? I don't believe that uses the modifier.

[ryanmitchell]

This allows you to do things like:
{{ collection:pages array_field:contains="this|or|that" }}

Are you sure? I don't believe that uses the modifier.

Forgot to push up the queriesConditions change - I blame @edalzell, he was rushing me

[jasonvarga]

A test for the condition side of this would be very welcomed too. There's a QueriesConditionsTest class.

[ryanmitchell]

No problem - added.

Genuine question - is contains the right name/place for this? Going by the modifier it is, looking at queriesConditions I'm not so sure as its very string orientated.

[jasonvarga]

The functionality is probably fine, but you're right to question the naming. We should give this a little more thought.

[jackmcdade]

What if we named it has, like Laravel's collection helper that is for essentially the same purpose? https://laravel.com/docs/10.x/helpers#method-array-has

[ryanmitchell]

I think has is for keys, where this is checking values?

[jackmcdade]

I think has is for keys, where this is checking values?

Oh yeah you're right, my apologies.

[jasonvarga]

Closing in favor of #9491

[ryanmitchell]

Sometimes you need to compare arrays to arrays, and it would be nice if the contains modifier was smart enough to handle it.

This PR updates that modifier to check if the intersect count between the 2 arrays is greater than zero, and if so it's true. This allows you to do things like:

{{ collection:pages array_field:contains="this|or|that" }}

or

{{ my_value | contains("this|or|that") }}

Which people seem to assume should work (judging by discord).

I thought it better to do it this way rather than a new modifier.

You could argue it should be a strict comparison, where the intersect count needs to match the needle count, but this approach matches whereJsonContains, and I've updated the queriesConditions contains method too.

[jasonvarga]

This allows you to do things like:
{{ collection:pages array_field:contains="this|or|that" }}

Are you sure? I don't believe that uses the modifier.

[ryanmitchell]

This allows you to do things like:
{{ collection:pages array_field:contains="this|or|that" }}

Are you sure? I don't believe that uses the modifier.

Forgot to push up the queriesConditions change - I blame @edalzell, he was rushing me

[jasonvarga]

A test for the condition side of this would be very welcomed too. There's a QueriesConditionsTest class.

[ryanmitchell]

No problem - added.

Genuine question - is contains the right name/place for this? Going by the modifier it is, looking at queriesConditions I'm not so sure as its very string orientated.

[jasonvarga]

The functionality is probably fine, but you're right to question the naming. We should give this a little more thought.

[jackmcdade]

What if we named it has, like Laravel's collection helper that is for essentially the same purpose? https://laravel.com/docs/10.x/helpers#method-array-has

[ryanmitchell]

I think has is for keys, where this is checking values?

[jackmcdade]

I think has is for keys, where this is checking values?

Oh yeah you're right, my apologies.

[jasonvarga]

Closing in favor of #9491

[ryanmitchell]

Sometimes you need to compare arrays to arrays, and it would be nice if the contains modifier was smart enough to handle it.

This PR updates that modifier to check if the intersect count between the 2 arrays is greater than zero, and if so it's true. This allows you to do things like:

{{ collection:pages array_field:contains="this|or|that" }}

or

{{ my_value | contains("this|or|that") }}

Which people seem to assume should work (judging by discord).

I thought it better to do it this way rather than a new modifier.

You could argue it should be a strict comparison, where the intersect count needs to match the needle count, but this approach matches whereJsonContains, and I've updated the queriesConditions contains method too.

[jasonvarga]

This allows you to do things like:
{{ collection:pages array_field:contains="this|or|that" }}

Are you sure? I don't believe that uses the modifier.

[ryanmitchell]

This allows you to do things like:
{{ collection:pages array_field:contains="this|or|that" }}

Are you sure? I don't believe that uses the modifier.

Forgot to push up the queriesConditions change - I blame @edalzell, he was rushing me

[jasonvarga]

A test for the condition side of this would be very welcomed too. There's a QueriesConditionsTest class.

[ryanmitchell]

No problem - added.

Genuine question - is contains the right name/place for this? Going by the modifier it is, looking at queriesConditions I'm not so sure as its very string orientated.

[jasonvarga]

The functionality is probably fine, but you're right to question the naming. We should give this a little more thought.

[jackmcdade]

What if we named it has, like Laravel's collection helper that is for essentially the same purpose? https://laravel.com/docs/10.x/helpers#method-array-has

[ryanmitchell]

I think has is for keys, where this is checking values?

[jackmcdade]

I think has is for keys, where this is checking values?

Oh yeah you're right, my apologies.

[jasonvarga]

Closing in favor of #9491

[ryanmitchell]

Sometimes you need to compare arrays to arrays, and it would be nice if the contains modifier was smart enough to handle it.

This PR updates that modifier to check if the intersect count between the 2 arrays is greater than zero, and if so it's true. This allows you to do things like:

{{ collection:pages array_field:contains="this|or|that" }}

or

{{ my_value | contains("this|or|that") }}

Which people seem to assume should work (judging by discord).

I thought it better to do it this way rather than a new modifier.

You could argue it should be a strict comparison, where the intersect count needs to match the needle count, but this approach matches whereJsonContains, and I've updated the queriesConditions contains method too.

[jasonvarga]

This allows you to do things like:
{{ collection:pages array_field:contains="this|or|that" }}

Are you sure? I don't believe that uses the modifier.

[ryanmitchell]

This allows you to do things like:
{{ collection:pages array_field:contains="this|or|that" }}

Are you sure? I don't believe that uses the modifier.

Forgot to push up the queriesConditions change - I blame @edalzell, he was rushing me

[jasonvarga]

A test for the condition side of this would be very welcomed too. There's a QueriesConditionsTest class.

[ryanmitchell]

No problem - added.

Genuine question - is contains the right name/place for this? Going by the modifier it is, looking at queriesConditions I'm not so sure as its very string orientated.

[jasonvarga]

The functionality is probably fine, but you're right to question the naming. We should give this a little more thought.

[jackmcdade]

What if we named it has, like Laravel's collection helper that is for essentially the same purpose? https://laravel.com/docs/10.x/helpers#method-array-has

[ryanmitchell]

I think has is for keys, where this is checking values?

[jackmcdade]

I think has is for keys, where this is checking values?

Oh yeah you're right, my apologies.

[jasonvarga]

Closing in favor of #9491

[ryanmitchell]

Sometimes you need to compare arrays to arrays, and it would be nice if the contains modifier was smart enough to handle it.

This PR updates that modifier to check if the intersect count between the 2 arrays is greater than zero, and if so it's true. This allows you to do things like:

{{ collection:pages array_field:contains="this|or|that" }}

or

{{ my_value | contains("this|or|that") }}

Which people seem to assume should work (judging by discord).

I thought it better to do it this way rather than a new modifier.

You could argue it should be a strict comparison, where the intersect count needs to match the needle count, but this approach matches whereJsonContains, and I've updated the queriesConditions contains method too.

[jasonvarga]

This allows you to do things like:
{{ collection:pages array_field:contains="this|or|that" }}

Are you sure? I don't believe that uses the modifier.

[ryanmitchell]

This allows you to do things like:
{{ collection:pages array_field:contains="this|or|that" }}

Are you sure? I don't believe that uses the modifier.

Forgot to push up the queriesConditions change - I blame @edalzell, he was rushing me

[jasonvarga]

A test for the condition side of this would be very welcomed too. There's a QueriesConditionsTest class.

[ryanmitchell]

No problem - added.

Genuine question - is contains the right name/place for this? Going by the modifier it is, looking at queriesConditions I'm not so sure as its very string orientated.

[jasonvarga]

The functionality is probably fine, but you're right to question the naming. We should give this a little more thought.

[jackmcdade]

What if we named it has, like Laravel's collection helper that is for essentially the same purpose? https://laravel.com/docs/10.x/helpers#method-array-has

[ryanmitchell]

I think has is for keys, where this is checking values?

[jackmcdade]

I think has is for keys, where this is checking values?

Oh yeah you're right, my apologies.

[jasonvarga]

Closing in favor of #9491

[ryanmitchell]

Sometimes you need to compare arrays to arrays, and it would be nice if the contains modifier was smart enough to handle it.

This PR updates that modifier to check if the intersect count between the 2 arrays is greater than zero, and if so it's true. This allows you to do things like:

{{ collection:pages array_field:contains="this|or|that" }}

or

{{ my_value | contains("this|or|that") }}

Which people seem to assume should work (judging by discord).

I thought it better to do it this way rather than a new modifier.

You could argue it should be a strict comparison, where the intersect count needs to match the needle count, but this approach matches whereJsonContains, and I've updated the queriesConditions contains method too.

[jasonvarga]

This allows you to do things like:
{{ collection:pages array_field:contains="this|or|that" }}

Are you sure? I don't believe that uses the modifier.

[ryanmitchell]

This allows you to do things like:
{{ collection:pages array_field:contains="this|or|that" }}

Are you sure? I don't believe that uses the modifier.

Forgot to push up the queriesConditions change - I blame @edalzell, he was rushing me

[jasonvarga]

A test for the condition side of this would be very welcomed too. There's a QueriesConditionsTest class.

[ryanmitchell]

No problem - added.

Genuine question - is contains the right name/place for this? Going by the modifier it is, looking at queriesConditions I'm not so sure as its very string orientated.

[jasonvarga]

The functionality is probably fine, but you're right to question the naming. We should give this a little more thought.

[jackmcdade]

What if we named it has, like Laravel's collection helper that is for essentially the same purpose? https://laravel.com/docs/10.x/helpers#method-array-has

[ryanmitchell]

I think has is for keys, where this is checking values?

[jackmcdade]

I think has is for keys, where this is checking values?

Oh yeah you're right, my apologies.

[jasonvarga]

Closing in favor of #9491

[ryanmitchell]

Sometimes you need to compare arrays to arrays, and it would be nice if the contains modifier was smart enough to handle it.

This PR updates that modifier to check if the intersect count between the 2 arrays is greater than zero, and if so it's true. This allows you to do things like:

{{ collection:pages array_field:contains="this|or|that" }}

or

{{ my_value | contains("this|or|that") }}

Which people seem to assume should work (judging by discord).

I thought it better to do it this way rather than a new modifier.

You could argue it should be a strict comparison, where the intersect count needs to match the needle count, but this approach matches whereJsonContains, and I've updated the queriesConditions contains method too.

[jasonvarga]

This allows you to do things like:
{{ collection:pages array_field:contains="this|or|that" }}

Are you sure? I don't believe that uses the modifier.

[ryanmitchell]

This allows you to do things like:
{{ collection:pages array_field:contains="this|or|that" }}

Are you sure? I don't believe that uses the modifier.

Forgot to push up the queriesConditions change - I blame @edalzell, he was rushing me

[jasonvarga]

A test for the condition side of this would be very welcomed too. There's a QueriesConditionsTest class.

[ryanmitchell]

No problem - added.

Genuine question - is contains the right name/place for this? Going by the modifier it is, looking at queriesConditions I'm not so sure as its very string orientated.

[jasonvarga]

The functionality is probably fine, but you're right to question the naming. We should give this a little more thought.

[jackmcdade]

What if we named it has, like Laravel's collection helper that is for essentially the same purpose? https://laravel.com/docs/10.x/helpers#method-array-has

[ryanmitchell]

I think has is for keys, where this is checking values?

[jackmcdade]

I think has is for keys, where this is checking values?

Oh yeah you're right, my apologies.

[jasonvarga]

Closing in favor of #9491

[ryanmitchell]

Sometimes you need to compare arrays to arrays, and it would be nice if the contains modifier was smart enough to handle it.

This PR updates that modifier to check if the intersect count between the 2 arrays is greater than zero, and if so it's true. This allows you to do things like:

{{ collection:pages array_field:contains="this|or|that" }}

or

{{ my_value | contains("this|or|that") }}

Which people seem to assume should work (judging by discord).

I thought it better to do it this way rather than a new modifier.

You could argue it should be a strict comparison, where the intersect count needs to match the needle count, but this approach matches whereJsonContains, and I've updated the queriesConditions contains method too.

[jasonvarga]

This allows you to do things like:
{{ collection:pages array_field:contains="this|or|that" }}

Are you sure? I don't believe that uses the modifier.

[ryanmitchell]

This allows you to do things like:
{{ collection:pages array_field:contains="this|or|that" }}

Are you sure? I don't believe that uses the modifier.

Forgot to push up the queriesConditions change - I blame @edalzell, he was rushing me

[jasonvarga]

A test for the condition side of this would be very welcomed too. There's a QueriesConditionsTest class.

[ryanmitchell]

No problem - added.

Genuine question - is contains the right name/place for this? Going by the modifier it is, looking at queriesConditions I'm not so sure as its very string orientated.

[jasonvarga]

The functionality is probably fine, but you're right to question the naming. We should give this a little more thought.

[jackmcdade]

What if we named it has, like Laravel's collection helper that is for essentially the same purpose? https://laravel.com/docs/10.x/helpers#method-array-has

[ryanmitchell]

I think has is for keys, where this is checking values?

[jackmcdade]

I think has is for keys, where this is checking values?

Oh yeah you're right, my apologies.

[jasonvarga]

Closing in favor of #9491