') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [4.x] Filter out any nulls from front end form checkboxes by ryanmitchell · Pull Request #9212 · statamic/cms · GitHub
Skip to content

[4.x] Filter out any nulls from front end form checkboxes - #9212

Merged
duncanmcclean merged 6 commits into
statamic:4.xfrom
ryanmitchell:fix/issue-9194
Dec 15, 2023
Merged

[4.x] Filter out any nulls from front end form checkboxes#9212
duncanmcclean merged 6 commits into
statamic:4.xfrom
ryanmitchell:fix/issue-9194

Conversation

@ryanmitchell

@ryanmitchellryanmitchell commented Dec 15, 2023

Copy link
Copy Markdown
Contributor

Filter out any null values in checkboxes on front end form requests.

The hidden input cant be removed as it was added to solve an issue on user profile forms.

Closes#9194

duncanmcclean
duncanmcclean reviewed Dec 15, 2023
View reviewed changes

@duncanmccleanduncanmcclean left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is now filtering out null values, it's also filtering out checked values which we don't want to be filtering out.

@ryanmitchell

ryanmitchell commented Dec 15, 2023

Copy link
Copy Markdown
ContributorAuthor

What do you mean by a checked value?

@duncanmcclean

duncanmcclean commented Dec 15, 2023

Copy link
Copy Markdown
Member

What do you mean by a checked value?

If I 'check' a checkbox, that doesn't get saved.

@ryanmitchell

ryanmitchell commented Dec 15, 2023

Copy link
Copy Markdown
ContributorAuthor

Yeah but what is the value on the checkbox input? It would need to have a value=“something” for it not to be filtered.

@duncanmcclean

duncanmcclean commented Dec 15, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Nevermind, I didn't add any options to the checkbox field. My bad! 🤦‍♂️

@duncanmcclean
duncanmcclean merged commit 673ad42 into statamic:4.xDec 15, 2023
@ryanmitchell
ryanmitchell deleted the fix/issue-9194 branch December 15, 2023 13:35
jesseleite added a commit that referenced this pull request Feb 28, 2025
@jesseleite
Always out nulls in checkbox process() for recursion.
5c65b20
A more proper fix for #9212.
@jesseleitejesseleite mentioned this pull request Feb 28, 2025
Merged
26 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@duncanmccleanduncanmccleanduncanmcclean approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Checkboxes fieldtype in a form adds additional null value

2 participants

@ryanmitchell@duncanmcclean