[4.x] Ensure unique slugs

[aerni]

This PR provides a fix to ensure unique slugs when saving entries programmatically.

In a collection with required slugs, you will run into a validation error when trying to save an entry with a slug that already exists. However, this validation only happens when saving entries in the CP.

If you save entries programmatically, duplicate entries will get a number appended to the filename.

jack-mcdade.md
jack-mcdade.1.md
jack-mcdade.2.md

While this ensures that we don't override existing entries, it doesn't solve the issue of duplicate slugs. Each entry now shares the same jack-mcdade slug. This can easily be fixed by making the delimiter slug-friendly by changing it from . to -.

[jasonvarga]

Thanks but slugs don't need to be unique anymore since #3671

The validation error you encounter is due to the URI being non-unique, not the slug.

[aerni]

Hmm, I understand. I meant URI not slug. I guess I'll have to think of another approach to fix this issue. Having multiple files with the same slug results in non-unique URI's in a collection that requires slugs.

[aerni]

It looks like the slug is extracted from the path here:

cms/src/Stache/Stores/CollectionEntriesStore.php

Line 80 in d19b9d0

$slug = (newGetSlugFromPath)($path);

So I should be able to extract the correct slug using a - instead of . as a delimiter in there. Does that sound right?

[jasonvarga]

If you're creating entries programmatically and you want the slugs to be unique, you'll need to check the slug doesn't already exist yourself.

[aerni]

That's what I'm currently doing. But it feels dirty and like something that should be handled by the stache. I made a quick proof of concept and this works:

if ($this->isDate($segments[0])) {
returnisset($segments[2])
? "{$segments[1]}-{$segments[2]}"
: $segments[1];
}
returnisset($segments[1])
? "{$segments[0]}-{$segments[1]}"
: $segments[0];

Whenever there is a file with .{number}.md it will extract that number and add it as -{number} to the slug. The slug is then set on the entry. And the stache takes care of resaving the entry to -{number}.md.

cms/src/Stache/Stores/CollectionEntriesStore.php

Lines 80 to 86 in d19b9d0

	$slug = (newGetSlugFromPath)($path);
	if (! $collection->requiresSlugs() && $slug == $id) {
	$entry->slug(null);
	} else {
	$entry->slug($slug);
	}

This seems like a viable fix to me, no?

[jasonvarga]

This sounds like custom logic so you can override it in your own app if you want. The number suffix logic is Stache-specific and only exists because you can't have two identical filenames in the same folder. In a database table it's fine. Maybe you can use the EntrySaving event to check if another entry with that slug exists and update it.

[aerni]

Alright. Doing that already. Glad to know that's the way to go. Thanks!

[aerni]

This PR provides a fix to ensure unique slugs when saving entries programmatically.

In a collection with required slugs, you will run into a validation error when trying to save an entry with a slug that already exists. However, this validation only happens when saving entries in the CP.

If you save entries programmatically, duplicate entries will get a number appended to the filename.

jack-mcdade.md
jack-mcdade.1.md
jack-mcdade.2.md

While this ensures that we don't override existing entries, it doesn't solve the issue of duplicate slugs. Each entry now shares the same jack-mcdade slug. This can easily be fixed by making the delimiter slug-friendly by changing it from . to -.

[jasonvarga]

Thanks but slugs don't need to be unique anymore since #3671

The validation error you encounter is due to the URI being non-unique, not the slug.

[aerni]

Hmm, I understand. I meant URI not slug. I guess I'll have to think of another approach to fix this issue. Having multiple files with the same slug results in non-unique URI's in a collection that requires slugs.

[aerni]

It looks like the slug is extracted from the path here:

cms/src/Stache/Stores/CollectionEntriesStore.php

Line 80 in d19b9d0

$slug = (newGetSlugFromPath)($path);

So I should be able to extract the correct slug using a - instead of . as a delimiter in there. Does that sound right?

[jasonvarga]

If you're creating entries programmatically and you want the slugs to be unique, you'll need to check the slug doesn't already exist yourself.

[aerni]

That's what I'm currently doing. But it feels dirty and like something that should be handled by the stache. I made a quick proof of concept and this works:

if ($this->isDate($segments[0])) {
returnisset($segments[2])
? "{$segments[1]}-{$segments[2]}"
: $segments[1];
}
returnisset($segments[1])
? "{$segments[0]}-{$segments[1]}"
: $segments[0];

Whenever there is a file with .{number}.md it will extract that number and add it as -{number} to the slug. The slug is then set on the entry. And the stache takes care of resaving the entry to -{number}.md.

cms/src/Stache/Stores/CollectionEntriesStore.php

Lines 80 to 86 in d19b9d0

	$slug = (newGetSlugFromPath)($path);
	if (! $collection->requiresSlugs() && $slug == $id) {
	$entry->slug(null);
	} else {
	$entry->slug($slug);
	}

This seems like a viable fix to me, no?

[jasonvarga]

This sounds like custom logic so you can override it in your own app if you want. The number suffix logic is Stache-specific and only exists because you can't have two identical filenames in the same folder. In a database table it's fine. Maybe you can use the EntrySaving event to check if another entry with that slug exists and update it.

[aerni]

Alright. Doing that already. Glad to know that's the way to go. Thanks!

[aerni]

This PR provides a fix to ensure unique slugs when saving entries programmatically.

In a collection with required slugs, you will run into a validation error when trying to save an entry with a slug that already exists. However, this validation only happens when saving entries in the CP.

If you save entries programmatically, duplicate entries will get a number appended to the filename.

jack-mcdade.md
jack-mcdade.1.md
jack-mcdade.2.md

While this ensures that we don't override existing entries, it doesn't solve the issue of duplicate slugs. Each entry now shares the same jack-mcdade slug. This can easily be fixed by making the delimiter slug-friendly by changing it from . to -.

[jasonvarga]

Thanks but slugs don't need to be unique anymore since #3671

The validation error you encounter is due to the URI being non-unique, not the slug.

[aerni]

Hmm, I understand. I meant URI not slug. I guess I'll have to think of another approach to fix this issue. Having multiple files with the same slug results in non-unique URI's in a collection that requires slugs.

[aerni]

It looks like the slug is extracted from the path here:

cms/src/Stache/Stores/CollectionEntriesStore.php

Line 80 in d19b9d0

$slug = (newGetSlugFromPath)($path);

So I should be able to extract the correct slug using a - instead of . as a delimiter in there. Does that sound right?

[jasonvarga]

If you're creating entries programmatically and you want the slugs to be unique, you'll need to check the slug doesn't already exist yourself.

[aerni]

That's what I'm currently doing. But it feels dirty and like something that should be handled by the stache. I made a quick proof of concept and this works:

if ($this->isDate($segments[0])) {
returnisset($segments[2])
? "{$segments[1]}-{$segments[2]}"
: $segments[1];
}
returnisset($segments[1])
? "{$segments[0]}-{$segments[1]}"
: $segments[0];

Whenever there is a file with .{number}.md it will extract that number and add it as -{number} to the slug. The slug is then set on the entry. And the stache takes care of resaving the entry to -{number}.md.

cms/src/Stache/Stores/CollectionEntriesStore.php

Lines 80 to 86 in d19b9d0

	$slug = (newGetSlugFromPath)($path);
	if (! $collection->requiresSlugs() && $slug == $id) {
	$entry->slug(null);
	} else {
	$entry->slug($slug);
	}

This seems like a viable fix to me, no?

[jasonvarga]

This sounds like custom logic so you can override it in your own app if you want. The number suffix logic is Stache-specific and only exists because you can't have two identical filenames in the same folder. In a database table it's fine. Maybe you can use the EntrySaving event to check if another entry with that slug exists and update it.

[aerni]

Alright. Doing that already. Glad to know that's the way to go. Thanks!

[aerni]

This PR provides a fix to ensure unique slugs when saving entries programmatically.

In a collection with required slugs, you will run into a validation error when trying to save an entry with a slug that already exists. However, this validation only happens when saving entries in the CP.

If you save entries programmatically, duplicate entries will get a number appended to the filename.

jack-mcdade.md
jack-mcdade.1.md
jack-mcdade.2.md

While this ensures that we don't override existing entries, it doesn't solve the issue of duplicate slugs. Each entry now shares the same jack-mcdade slug. This can easily be fixed by making the delimiter slug-friendly by changing it from . to -.

[jasonvarga]

Thanks but slugs don't need to be unique anymore since #3671

The validation error you encounter is due to the URI being non-unique, not the slug.

[aerni]

Hmm, I understand. I meant URI not slug. I guess I'll have to think of another approach to fix this issue. Having multiple files with the same slug results in non-unique URI's in a collection that requires slugs.

[aerni]

It looks like the slug is extracted from the path here:

cms/src/Stache/Stores/CollectionEntriesStore.php

Line 80 in d19b9d0

$slug = (newGetSlugFromPath)($path);

So I should be able to extract the correct slug using a - instead of . as a delimiter in there. Does that sound right?

[jasonvarga]

If you're creating entries programmatically and you want the slugs to be unique, you'll need to check the slug doesn't already exist yourself.

[aerni]

That's what I'm currently doing. But it feels dirty and like something that should be handled by the stache. I made a quick proof of concept and this works:

if ($this->isDate($segments[0])) {
returnisset($segments[2])
? "{$segments[1]}-{$segments[2]}"
: $segments[1];
}
returnisset($segments[1])
? "{$segments[0]}-{$segments[1]}"
: $segments[0];

Whenever there is a file with .{number}.md it will extract that number and add it as -{number} to the slug. The slug is then set on the entry. And the stache takes care of resaving the entry to -{number}.md.

cms/src/Stache/Stores/CollectionEntriesStore.php

Lines 80 to 86 in d19b9d0

	$slug = (newGetSlugFromPath)($path);
	if (! $collection->requiresSlugs() && $slug == $id) {
	$entry->slug(null);
	} else {
	$entry->slug($slug);
	}

This seems like a viable fix to me, no?

[jasonvarga]

This sounds like custom logic so you can override it in your own app if you want. The number suffix logic is Stache-specific and only exists because you can't have two identical filenames in the same folder. In a database table it's fine. Maybe you can use the EntrySaving event to check if another entry with that slug exists and update it.

[aerni]

Alright. Doing that already. Glad to know that's the way to go. Thanks!

[aerni]

This PR provides a fix to ensure unique slugs when saving entries programmatically.

In a collection with required slugs, you will run into a validation error when trying to save an entry with a slug that already exists. However, this validation only happens when saving entries in the CP.

If you save entries programmatically, duplicate entries will get a number appended to the filename.

jack-mcdade.md
jack-mcdade.1.md
jack-mcdade.2.md

While this ensures that we don't override existing entries, it doesn't solve the issue of duplicate slugs. Each entry now shares the same jack-mcdade slug. This can easily be fixed by making the delimiter slug-friendly by changing it from . to -.

[jasonvarga]

Thanks but slugs don't need to be unique anymore since #3671

The validation error you encounter is due to the URI being non-unique, not the slug.

[aerni]

Hmm, I understand. I meant URI not slug. I guess I'll have to think of another approach to fix this issue. Having multiple files with the same slug results in non-unique URI's in a collection that requires slugs.

[aerni]

It looks like the slug is extracted from the path here:

cms/src/Stache/Stores/CollectionEntriesStore.php

Line 80 in d19b9d0

$slug = (newGetSlugFromPath)($path);

So I should be able to extract the correct slug using a - instead of . as a delimiter in there. Does that sound right?

[jasonvarga]

If you're creating entries programmatically and you want the slugs to be unique, you'll need to check the slug doesn't already exist yourself.

[aerni]

That's what I'm currently doing. But it feels dirty and like something that should be handled by the stache. I made a quick proof of concept and this works:

if ($this->isDate($segments[0])) {
returnisset($segments[2])
? "{$segments[1]}-{$segments[2]}"
: $segments[1];
}
returnisset($segments[1])
? "{$segments[0]}-{$segments[1]}"
: $segments[0];

Whenever there is a file with .{number}.md it will extract that number and add it as -{number} to the slug. The slug is then set on the entry. And the stache takes care of resaving the entry to -{number}.md.

cms/src/Stache/Stores/CollectionEntriesStore.php

Lines 80 to 86 in d19b9d0

	$slug = (newGetSlugFromPath)($path);
	if (! $collection->requiresSlugs() && $slug == $id) {
	$entry->slug(null);
	} else {
	$entry->slug($slug);
	}

This seems like a viable fix to me, no?

[jasonvarga]

This sounds like custom logic so you can override it in your own app if you want. The number suffix logic is Stache-specific and only exists because you can't have two identical filenames in the same folder. In a database table it's fine. Maybe you can use the EntrySaving event to check if another entry with that slug exists and update it.

[aerni]

Alright. Doing that already. Glad to know that's the way to go. Thanks!

[aerni]

This PR provides a fix to ensure unique slugs when saving entries programmatically.

In a collection with required slugs, you will run into a validation error when trying to save an entry with a slug that already exists. However, this validation only happens when saving entries in the CP.

If you save entries programmatically, duplicate entries will get a number appended to the filename.

jack-mcdade.md
jack-mcdade.1.md
jack-mcdade.2.md

While this ensures that we don't override existing entries, it doesn't solve the issue of duplicate slugs. Each entry now shares the same jack-mcdade slug. This can easily be fixed by making the delimiter slug-friendly by changing it from . to -.

[jasonvarga]

Thanks but slugs don't need to be unique anymore since #3671

The validation error you encounter is due to the URI being non-unique, not the slug.

[aerni]

Hmm, I understand. I meant URI not slug. I guess I'll have to think of another approach to fix this issue. Having multiple files with the same slug results in non-unique URI's in a collection that requires slugs.

[aerni]

It looks like the slug is extracted from the path here:

cms/src/Stache/Stores/CollectionEntriesStore.php

Line 80 in d19b9d0

$slug = (newGetSlugFromPath)($path);

So I should be able to extract the correct slug using a - instead of . as a delimiter in there. Does that sound right?

[jasonvarga]

If you're creating entries programmatically and you want the slugs to be unique, you'll need to check the slug doesn't already exist yourself.

[aerni]

That's what I'm currently doing. But it feels dirty and like something that should be handled by the stache. I made a quick proof of concept and this works:

if ($this->isDate($segments[0])) {
returnisset($segments[2])
? "{$segments[1]}-{$segments[2]}"
: $segments[1];
}
returnisset($segments[1])
? "{$segments[0]}-{$segments[1]}"
: $segments[0];

Whenever there is a file with .{number}.md it will extract that number and add it as -{number} to the slug. The slug is then set on the entry. And the stache takes care of resaving the entry to -{number}.md.

cms/src/Stache/Stores/CollectionEntriesStore.php

Lines 80 to 86 in d19b9d0

	$slug = (newGetSlugFromPath)($path);
	if (! $collection->requiresSlugs() && $slug == $id) {
	$entry->slug(null);
	} else {
	$entry->slug($slug);
	}

This seems like a viable fix to me, no?

[jasonvarga]

This sounds like custom logic so you can override it in your own app if you want. The number suffix logic is Stache-specific and only exists because you can't have two identical filenames in the same folder. In a database table it's fine. Maybe you can use the EntrySaving event to check if another entry with that slug exists and update it.

[aerni]

Alright. Doing that already. Glad to know that's the way to go. Thanks!

[aerni]

This PR provides a fix to ensure unique slugs when saving entries programmatically.

In a collection with required slugs, you will run into a validation error when trying to save an entry with a slug that already exists. However, this validation only happens when saving entries in the CP.

If you save entries programmatically, duplicate entries will get a number appended to the filename.

jack-mcdade.md
jack-mcdade.1.md
jack-mcdade.2.md

While this ensures that we don't override existing entries, it doesn't solve the issue of duplicate slugs. Each entry now shares the same jack-mcdade slug. This can easily be fixed by making the delimiter slug-friendly by changing it from . to -.

[jasonvarga]

Thanks but slugs don't need to be unique anymore since #3671

The validation error you encounter is due to the URI being non-unique, not the slug.

[aerni]

Hmm, I understand. I meant URI not slug. I guess I'll have to think of another approach to fix this issue. Having multiple files with the same slug results in non-unique URI's in a collection that requires slugs.

[aerni]

It looks like the slug is extracted from the path here:

cms/src/Stache/Stores/CollectionEntriesStore.php

Line 80 in d19b9d0

$slug = (newGetSlugFromPath)($path);

So I should be able to extract the correct slug using a - instead of . as a delimiter in there. Does that sound right?

[jasonvarga]

If you're creating entries programmatically and you want the slugs to be unique, you'll need to check the slug doesn't already exist yourself.

[aerni]

That's what I'm currently doing. But it feels dirty and like something that should be handled by the stache. I made a quick proof of concept and this works:

if ($this->isDate($segments[0])) {
returnisset($segments[2])
? "{$segments[1]}-{$segments[2]}"
: $segments[1];
}
returnisset($segments[1])
? "{$segments[0]}-{$segments[1]}"
: $segments[0];

Whenever there is a file with .{number}.md it will extract that number and add it as -{number} to the slug. The slug is then set on the entry. And the stache takes care of resaving the entry to -{number}.md.

cms/src/Stache/Stores/CollectionEntriesStore.php

Lines 80 to 86 in d19b9d0

	$slug = (newGetSlugFromPath)($path);
	if (! $collection->requiresSlugs() && $slug == $id) {
	$entry->slug(null);
	} else {
	$entry->slug($slug);
	}

This seems like a viable fix to me, no?

[jasonvarga]

This sounds like custom logic so you can override it in your own app if you want. The number suffix logic is Stache-specific and only exists because you can't have two identical filenames in the same folder. In a database table it's fine. Maybe you can use the EntrySaving event to check if another entry with that slug exists and update it.

[aerni]

Alright. Doing that already. Glad to know that's the way to go. Thanks!

[aerni]

This PR provides a fix to ensure unique slugs when saving entries programmatically.

In a collection with required slugs, you will run into a validation error when trying to save an entry with a slug that already exists. However, this validation only happens when saving entries in the CP.

If you save entries programmatically, duplicate entries will get a number appended to the filename.

jack-mcdade.md
jack-mcdade.1.md
jack-mcdade.2.md

While this ensures that we don't override existing entries, it doesn't solve the issue of duplicate slugs. Each entry now shares the same jack-mcdade slug. This can easily be fixed by making the delimiter slug-friendly by changing it from . to -.

[jasonvarga]

Thanks but slugs don't need to be unique anymore since #3671

The validation error you encounter is due to the URI being non-unique, not the slug.

[aerni]

Hmm, I understand. I meant URI not slug. I guess I'll have to think of another approach to fix this issue. Having multiple files with the same slug results in non-unique URI's in a collection that requires slugs.

[aerni]

It looks like the slug is extracted from the path here:

cms/src/Stache/Stores/CollectionEntriesStore.php

Line 80 in d19b9d0

$slug = (newGetSlugFromPath)($path);

So I should be able to extract the correct slug using a - instead of . as a delimiter in there. Does that sound right?

[jasonvarga]

If you're creating entries programmatically and you want the slugs to be unique, you'll need to check the slug doesn't already exist yourself.

[aerni]

That's what I'm currently doing. But it feels dirty and like something that should be handled by the stache. I made a quick proof of concept and this works:

if ($this->isDate($segments[0])) {
returnisset($segments[2])
? "{$segments[1]}-{$segments[2]}"
: $segments[1];
}
returnisset($segments[1])
? "{$segments[0]}-{$segments[1]}"
: $segments[0];

Whenever there is a file with .{number}.md it will extract that number and add it as -{number} to the slug. The slug is then set on the entry. And the stache takes care of resaving the entry to -{number}.md.

cms/src/Stache/Stores/CollectionEntriesStore.php

Lines 80 to 86 in d19b9d0

	$slug = (newGetSlugFromPath)($path);
	if (! $collection->requiresSlugs() && $slug == $id) {
	$entry->slug(null);
	} else {
	$entry->slug($slug);
	}

This seems like a viable fix to me, no?

[jasonvarga]

This sounds like custom logic so you can override it in your own app if you want. The number suffix logic is Stache-specific and only exists because you can't have two identical filenames in the same folder. In a database table it's fine. Maybe you can use the EntrySaving event to check if another entry with that slug exists and update it.

[aerni]

Alright. Doing that already. Glad to know that's the way to go. Thanks!