[5.x] Fallback to `nocache` content when request is missing the `Cache` middleware by duncanmcclean · Pull Request #9406 · statamic/cms

duncanmcclean · 2024-01-26T15:20:57Z

This pull request fixes an issue with the {{ nocache }} tag on custom routes that aren't using Statamic's Cache middleware, used for static caching.

Previously, if you used the {{ nocache }} tag or it's Blade directive counterpart on a custom route without the middleware, NOCACHE_PLACEHOLDER text will have been displayed.

This PR fixes that and simply falls back to the intended contents / view when the response isn't being statically cached.

Fixes#6744.

…ddleware-is-missing

jasonvarga

The failing test that's happening now would have happened before too if you ran it by itself.

Since you had a static property, its value sticks around between tests.

So lets say you had one test that set that to true, when it got to this test, it would still be true. This made it pass, but it shouldn't have.

Anyway, the remaining failing test is just some whitespace changes. I'll dig in some more when I have more time. I'm not sure that editing the test is the answer. There must be a reason it changed.

…ddleware-is-missing

…e-content-when-cache-middleware-is-missing

…ddleware-is-missing

Made the route test just care about replacing regions. Move the nested logic to a different test. If there was a nested nocache tag, it wouldn't be in the view. It would have been converted to a placeholder string.

duncanmcclean · 2024-01-26T15:20:57Z

This pull request fixes an issue with the {{ nocache }} tag on custom routes that aren't using Statamic's Cache middleware, used for static caching.

Previously, if you used the {{ nocache }} tag or it's Blade directive counterpart on a custom route without the middleware, NOCACHE_PLACEHOLDER text will have been displayed.

This PR fixes that and simply falls back to the intended contents / view when the response isn't being statically cached.

Fixes#6744.

…ddleware-is-missing

jasonvarga

The failing test that's happening now would have happened before too if you ran it by itself.

Since you had a static property, its value sticks around between tests.

So lets say you had one test that set that to true, when it got to this test, it would still be true. This made it pass, but it shouldn't have.

Anyway, the remaining failing test is just some whitespace changes. I'll dig in some more when I have more time. I'm not sure that editing the test is the answer. There must be a reason it changed.

…ddleware-is-missing

…e-content-when-cache-middleware-is-missing

…ddleware-is-missing

Made the route test just care about replacing regions. Move the nested logic to a different test. If there was a nested nocache tag, it wouldn't be in the view. It would have been converted to a placeholder string.

duncanmcclean · 2024-01-26T15:20:57Z

This pull request fixes an issue with the {{ nocache }} tag on custom routes that aren't using Statamic's Cache middleware, used for static caching.

Previously, if you used the {{ nocache }} tag or it's Blade directive counterpart on a custom route without the middleware, NOCACHE_PLACEHOLDER text will have been displayed.

This PR fixes that and simply falls back to the intended contents / view when the response isn't being statically cached.

Fixes#6744.

…ddleware-is-missing

jasonvarga

The failing test that's happening now would have happened before too if you ran it by itself.

Since you had a static property, its value sticks around between tests.

So lets say you had one test that set that to true, when it got to this test, it would still be true. This made it pass, but it shouldn't have.

Anyway, the remaining failing test is just some whitespace changes. I'll dig in some more when I have more time. I'm not sure that editing the test is the answer. There must be a reason it changed.

…ddleware-is-missing

…e-content-when-cache-middleware-is-missing

…ddleware-is-missing

Made the route test just care about replacing regions. Move the nested logic to a different test. If there was a nested nocache tag, it wouldn't be in the view. It would have been converted to a placeholder string.

duncanmcclean · 2024-01-26T15:20:57Z

This pull request fixes an issue with the {{ nocache }} tag on custom routes that aren't using Statamic's Cache middleware, used for static caching.

Previously, if you used the {{ nocache }} tag or it's Blade directive counterpart on a custom route without the middleware, NOCACHE_PLACEHOLDER text will have been displayed.

This PR fixes that and simply falls back to the intended contents / view when the response isn't being statically cached.

Fixes#6744.

…ddleware-is-missing

jasonvarga

The failing test that's happening now would have happened before too if you ran it by itself.

Since you had a static property, its value sticks around between tests.

So lets say you had one test that set that to true, when it got to this test, it would still be true. This made it pass, but it shouldn't have.

Anyway, the remaining failing test is just some whitespace changes. I'll dig in some more when I have more time. I'm not sure that editing the test is the answer. There must be a reason it changed.

…ddleware-is-missing

…e-content-when-cache-middleware-is-missing

…ddleware-is-missing

Made the route test just care about replacing regions. Move the nested logic to a different test. If there was a nested nocache tag, it wouldn't be in the view. It would have been converted to a placeholder string.

duncanmcclean · 2024-01-26T15:20:57Z

This pull request fixes an issue with the {{ nocache }} tag on custom routes that aren't using Statamic's Cache middleware, used for static caching.

Previously, if you used the {{ nocache }} tag or it's Blade directive counterpart on a custom route without the middleware, NOCACHE_PLACEHOLDER text will have been displayed.

This PR fixes that and simply falls back to the intended contents / view when the response isn't being statically cached.

Fixes#6744.

…ddleware-is-missing

jasonvarga

The failing test that's happening now would have happened before too if you ran it by itself.

Since you had a static property, its value sticks around between tests.

So lets say you had one test that set that to true, when it got to this test, it would still be true. This made it pass, but it shouldn't have.

Anyway, the remaining failing test is just some whitespace changes. I'll dig in some more when I have more time. I'm not sure that editing the test is the answer. There must be a reason it changed.

…ddleware-is-missing

…e-content-when-cache-middleware-is-missing

…ddleware-is-missing

Made the route test just care about replacing regions. Move the nested logic to a different test. If there was a nested nocache tag, it wouldn't be in the view. It would have been converted to a placeholder string.

duncanmcclean · 2024-01-26T15:20:57Z

This pull request fixes an issue with the {{ nocache }} tag on custom routes that aren't using Statamic's Cache middleware, used for static caching.

Previously, if you used the {{ nocache }} tag or it's Blade directive counterpart on a custom route without the middleware, NOCACHE_PLACEHOLDER text will have been displayed.

This PR fixes that and simply falls back to the intended contents / view when the response isn't being statically cached.

Fixes#6744.

…ddleware-is-missing

jasonvarga

The failing test that's happening now would have happened before too if you ran it by itself.

Since you had a static property, its value sticks around between tests.

So lets say you had one test that set that to true, when it got to this test, it would still be true. This made it pass, but it shouldn't have.

Anyway, the remaining failing test is just some whitespace changes. I'll dig in some more when I have more time. I'm not sure that editing the test is the answer. There must be a reason it changed.

…ddleware-is-missing

…e-content-when-cache-middleware-is-missing

…ddleware-is-missing

Made the route test just care about replacing regions. Move the nested logic to a different test. If there was a nested nocache tag, it wouldn't be in the view. It would have been converted to a placeholder string.

duncanmcclean · 2024-01-26T15:20:57Z

This pull request fixes an issue with the {{ nocache }} tag on custom routes that aren't using Statamic's Cache middleware, used for static caching.

Previously, if you used the {{ nocache }} tag or it's Blade directive counterpart on a custom route without the middleware, NOCACHE_PLACEHOLDER text will have been displayed.

This PR fixes that and simply falls back to the intended contents / view when the response isn't being statically cached.

Fixes#6744.

…ddleware-is-missing

jasonvarga

The failing test that's happening now would have happened before too if you ran it by itself.

Since you had a static property, its value sticks around between tests.

So lets say you had one test that set that to true, when it got to this test, it would still be true. This made it pass, but it shouldn't have.

Anyway, the remaining failing test is just some whitespace changes. I'll dig in some more when I have more time. I'm not sure that editing the test is the answer. There must be a reason it changed.

…ddleware-is-missing

…e-content-when-cache-middleware-is-missing

…ddleware-is-missing

Made the route test just care about replacing regions. Move the nested logic to a different test. If there was a nested nocache tag, it wouldn't be in the view. It would have been converted to a placeholder string.

duncanmcclean · 2024-01-26T15:20:57Z

This pull request fixes an issue with the {{ nocache }} tag on custom routes that aren't using Statamic's Cache middleware, used for static caching.

Previously, if you used the {{ nocache }} tag or it's Blade directive counterpart on a custom route without the middleware, NOCACHE_PLACEHOLDER text will have been displayed.

This PR fixes that and simply falls back to the intended contents / view when the response isn't being statically cached.

Fixes#6744.

…ddleware-is-missing

jasonvarga

The failing test that's happening now would have happened before too if you ran it by itself.

Since you had a static property, its value sticks around between tests.

So lets say you had one test that set that to true, when it got to this test, it would still be true. This made it pass, but it shouldn't have.

Anyway, the remaining failing test is just some whitespace changes. I'll dig in some more when I have more time. I'm not sure that editing the test is the answer. There must be a reason it changed.

…ddleware-is-missing

…e-content-when-cache-middleware-is-missing

…ddleware-is-missing

Made the route test just care about replacing regions. Move the nested logic to a different test. If there was a nested nocache tag, it wouldn't be in the view. It would have been converted to a placeholder string.

duncanmccleanand others added 6 commits January 26, 2024 15:07

When request is missing middleware, fallback to nocache contents
faf29f1

When request is missing middleware, fallback to nocache view
ba4cdd9

avoid a static variable
066213c

parse will get the context automatically
bc378c8

hit a route with the cache middleware in the test
b2da6d8

Merge branch '4.x' into fix/fallback-to-nocache-content-when-cache-mi…
0e0ac73
…ddleware-is-missing

jasonvarga requested changes Jan 26, 2024
View reviewed changes

Merge branch '4.x' into fix/fallback-to-nocache-content-when-cache-mi…
ad109e9
…ddleware-is-missing

duncanmcclean mentioned this pull request Mar 8, 2024
Update nocache.md to reflect usage with default Laravel routes statamic/docs#1096
Closed

Merge remote-tracking branch 'origin/5.x' into fix/fallback-to-nocach…
44ba740
…e-content-when-cache-middleware-is-missing

duncanmcclean changed the title ~~[4.x] Fallback to nocache content when request is missing the Cache middleware~~[5.x] Fallback to nocache content when request is missing the Cache middlewareMay 13, 2024

duncanmcclean changed the base branch from 4.x to 5.xMay 13, 2024 11:43

duncanmccleanand others added 4 commits July 16, 2024 11:43

Merge branch '5.x' into fix/fallback-to-nocache-content-when-cache-mi…
bcf9e86
…ddleware-is-missing

Merge branch '5.x' into fix/fallback-to-nocache-content-when-cache-mi…
5298609
…ddleware-is-missing

Adjust tests to better reflect reality ...
dd8faff
Made the route test just care about replacing regions. Move the nested logic to a different test. If there was a nested nocache tag, it wouldn't be in the view. It would have been converted to a placeholder string.

less diff, for erin
07b16f9

jasonvarga merged commit 20089a8 into 5.xAug 1, 2024

jasonvarga deleted the fix/fallback-to-nocache-content-when-cache-middleware-is-missing branch August 1, 2024 21:01