Uh oh!
There was an error while loading. Please reload this page.
[4.x] Switch locale - #9452
Closed
peimn wants to merge 5 commits into
Closed
Conversation
duncanmcclean
commented
Feb 13, 2024
Member
Hey! Are you able to provide more details about what was broken before this fix? |
jasonvarga
commented
Feb 13, 2024
Member
This is letting the site selector change the translation of the CP. I'm not really a fan of this approach. If you want the control panel to be in the language you prefer to use, then you should set a preference. I don't think changing to a different site should impact the way you view the entire CP. Thanks! |
peimn
commented
Feb 14, 2024
ContributorAuthor
Nothing was broken! But I think when we change site we are going to edit and publish on that site so the cp has to be on the locale and direction that site has... |
peimn
commented
Feb 14, 2024
ContributorAuthor
In this PR it checks preferences for any locale set in first then applies locale of site |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will switch locale when user switches site if didn't select any default locale in preferences