[5.x] Augmentation performance improvements by JohnathonKoster · Pull Request #9636 · statamic/cms

JohnathonKoster · 2024-03-02T16:01:57Z

This PR is an extension of #9574, and reworks some more internal augmentation behaviors. The changes in this PR come together to allow us to reuse fields arrays and augmentation keys as much as possible in a new BulkAugmentor. This new class will work to reduce the overhead of resolving this information as much as possible. For example, if you want to augment 1,000 entries and they can all safely reuse the same fields/keys, the BulkAugmentor will only do those calls once. This PR only focuses on pages/entries for now.

Positive improvements across a variety of different situations, particularly the `group_by` modifier

* Allow for implementors to return `null`, which disables the bulk process for that item * Entry now takes data keys into consideration to prevent "locking" an entry into something if it has custom data

jasonvarga

Please target master.

Requested changes were made.

# Conflicts: # src/Entries/Entry.php

…some just because ... - Dedicated AbstractAugmented 'wrap' methods, to avoid passing around hard to follow booleans. - Avoid a hard to follow boolean in InvokableValue - Make InvokableValue easier to follow both paths in general. - TransientValue and DeferredValue now pass their references when calling shallow(), which were missing, and was the reason for needing to check for nulls. - Typehints and visibility

… ... If you pass a closure as the raw value, it'll lazily evaluate them when resolving.

materialize() just called resolve() and returned a new Value instance. Now that the subclasses are gone, there's no need to new up a separate Value instance. It can just return itself. With that gone, we might as well just call resolve since materialize would just be an alias.

- Add static factory methods to BulkAugmentor. - Rename BulkAugmentor augmented() to toArray(). Seemed more inline with what it did. Looks like it makes sense when compared to the toDeferredAugmentedArray in the "else" where its used in RuntimeValues. - Reduce visibility where possible

Since dd(), dump(), etc can have variable arguments, avoid making our own Dumper methods. Just use the class to resolve the values and pass them into the original functions. Rename resolveValues to resolve. Simplify map. Remove unnecessary guard.

JohnathonKoster · 2024-03-02T16:01:57Z

This PR is an extension of #9574, and reworks some more internal augmentation behaviors. The changes in this PR come together to allow us to reuse fields arrays and augmentation keys as much as possible in a new BulkAugmentor. This new class will work to reduce the overhead of resolving this information as much as possible. For example, if you want to augment 1,000 entries and they can all safely reuse the same fields/keys, the BulkAugmentor will only do those calls once. This PR only focuses on pages/entries for now.

Positive improvements across a variety of different situations, particularly the `group_by` modifier

* Allow for implementors to return `null`, which disables the bulk process for that item * Entry now takes data keys into consideration to prevent "locking" an entry into something if it has custom data

jasonvarga

Please target master.

Requested changes were made.

# Conflicts: # src/Entries/Entry.php

…some just because ... - Dedicated AbstractAugmented 'wrap' methods, to avoid passing around hard to follow booleans. - Avoid a hard to follow boolean in InvokableValue - Make InvokableValue easier to follow both paths in general. - TransientValue and DeferredValue now pass their references when calling shallow(), which were missing, and was the reason for needing to check for nulls. - Typehints and visibility

… ... If you pass a closure as the raw value, it'll lazily evaluate them when resolving.

materialize() just called resolve() and returned a new Value instance. Now that the subclasses are gone, there's no need to new up a separate Value instance. It can just return itself. With that gone, we might as well just call resolve since materialize would just be an alias.

- Add static factory methods to BulkAugmentor. - Rename BulkAugmentor augmented() to toArray(). Seemed more inline with what it did. Looks like it makes sense when compared to the toDeferredAugmentedArray in the "else" where its used in RuntimeValues. - Reduce visibility where possible

Since dd(), dump(), etc can have variable arguments, avoid making our own Dumper methods. Just use the class to resolve the values and pass them into the original functions. Rename resolveValues to resolve. Simplify map. Remove unnecessary guard.

JohnathonKoster · 2024-03-02T16:01:57Z

This PR is an extension of #9574, and reworks some more internal augmentation behaviors. The changes in this PR come together to allow us to reuse fields arrays and augmentation keys as much as possible in a new BulkAugmentor. This new class will work to reduce the overhead of resolving this information as much as possible. For example, if you want to augment 1,000 entries and they can all safely reuse the same fields/keys, the BulkAugmentor will only do those calls once. This PR only focuses on pages/entries for now.

Positive improvements across a variety of different situations, particularly the `group_by` modifier

* Allow for implementors to return `null`, which disables the bulk process for that item * Entry now takes data keys into consideration to prevent "locking" an entry into something if it has custom data

jasonvarga

Please target master.

Requested changes were made.

# Conflicts: # src/Entries/Entry.php

…some just because ... - Dedicated AbstractAugmented 'wrap' methods, to avoid passing around hard to follow booleans. - Avoid a hard to follow boolean in InvokableValue - Make InvokableValue easier to follow both paths in general. - TransientValue and DeferredValue now pass their references when calling shallow(), which were missing, and was the reason for needing to check for nulls. - Typehints and visibility

… ... If you pass a closure as the raw value, it'll lazily evaluate them when resolving.

materialize() just called resolve() and returned a new Value instance. Now that the subclasses are gone, there's no need to new up a separate Value instance. It can just return itself. With that gone, we might as well just call resolve since materialize would just be an alias.

- Add static factory methods to BulkAugmentor. - Rename BulkAugmentor augmented() to toArray(). Seemed more inline with what it did. Looks like it makes sense when compared to the toDeferredAugmentedArray in the "else" where its used in RuntimeValues. - Reduce visibility where possible

Since dd(), dump(), etc can have variable arguments, avoid making our own Dumper methods. Just use the class to resolve the values and pass them into the original functions. Rename resolveValues to resolve. Simplify map. Remove unnecessary guard.

JohnathonKoster · 2024-03-02T16:01:57Z

This PR is an extension of #9574, and reworks some more internal augmentation behaviors. The changes in this PR come together to allow us to reuse fields arrays and augmentation keys as much as possible in a new BulkAugmentor. This new class will work to reduce the overhead of resolving this information as much as possible. For example, if you want to augment 1,000 entries and they can all safely reuse the same fields/keys, the BulkAugmentor will only do those calls once. This PR only focuses on pages/entries for now.

Positive improvements across a variety of different situations, particularly the `group_by` modifier

* Allow for implementors to return `null`, which disables the bulk process for that item * Entry now takes data keys into consideration to prevent "locking" an entry into something if it has custom data

jasonvarga

Please target master.

Requested changes were made.

# Conflicts: # src/Entries/Entry.php

…some just because ... - Dedicated AbstractAugmented 'wrap' methods, to avoid passing around hard to follow booleans. - Avoid a hard to follow boolean in InvokableValue - Make InvokableValue easier to follow both paths in general. - TransientValue and DeferredValue now pass their references when calling shallow(), which were missing, and was the reason for needing to check for nulls. - Typehints and visibility

… ... If you pass a closure as the raw value, it'll lazily evaluate them when resolving.

materialize() just called resolve() and returned a new Value instance. Now that the subclasses are gone, there's no need to new up a separate Value instance. It can just return itself. With that gone, we might as well just call resolve since materialize would just be an alias.

- Add static factory methods to BulkAugmentor. - Rename BulkAugmentor augmented() to toArray(). Seemed more inline with what it did. Looks like it makes sense when compared to the toDeferredAugmentedArray in the "else" where its used in RuntimeValues. - Reduce visibility where possible

Since dd(), dump(), etc can have variable arguments, avoid making our own Dumper methods. Just use the class to resolve the values and pass them into the original functions. Rename resolveValues to resolve. Simplify map. Remove unnecessary guard.

JohnathonKoster · 2024-03-02T16:01:57Z

This PR is an extension of #9574, and reworks some more internal augmentation behaviors. The changes in this PR come together to allow us to reuse fields arrays and augmentation keys as much as possible in a new BulkAugmentor. This new class will work to reduce the overhead of resolving this information as much as possible. For example, if you want to augment 1,000 entries and they can all safely reuse the same fields/keys, the BulkAugmentor will only do those calls once. This PR only focuses on pages/entries for now.

Positive improvements across a variety of different situations, particularly the `group_by` modifier

* Allow for implementors to return `null`, which disables the bulk process for that item * Entry now takes data keys into consideration to prevent "locking" an entry into something if it has custom data

jasonvarga

Please target master.

Requested changes were made.

# Conflicts: # src/Entries/Entry.php

…some just because ... - Dedicated AbstractAugmented 'wrap' methods, to avoid passing around hard to follow booleans. - Avoid a hard to follow boolean in InvokableValue - Make InvokableValue easier to follow both paths in general. - TransientValue and DeferredValue now pass their references when calling shallow(), which were missing, and was the reason for needing to check for nulls. - Typehints and visibility

… ... If you pass a closure as the raw value, it'll lazily evaluate them when resolving.

materialize() just called resolve() and returned a new Value instance. Now that the subclasses are gone, there's no need to new up a separate Value instance. It can just return itself. With that gone, we might as well just call resolve since materialize would just be an alias.

- Add static factory methods to BulkAugmentor. - Rename BulkAugmentor augmented() to toArray(). Seemed more inline with what it did. Looks like it makes sense when compared to the toDeferredAugmentedArray in the "else" where its used in RuntimeValues. - Reduce visibility where possible

Since dd(), dump(), etc can have variable arguments, avoid making our own Dumper methods. Just use the class to resolve the values and pass them into the original functions. Rename resolveValues to resolve. Simplify map. Remove unnecessary guard.

JohnathonKoster · 2024-03-02T16:01:57Z

This PR is an extension of #9574, and reworks some more internal augmentation behaviors. The changes in this PR come together to allow us to reuse fields arrays and augmentation keys as much as possible in a new BulkAugmentor. This new class will work to reduce the overhead of resolving this information as much as possible. For example, if you want to augment 1,000 entries and they can all safely reuse the same fields/keys, the BulkAugmentor will only do those calls once. This PR only focuses on pages/entries for now.

Positive improvements across a variety of different situations, particularly the `group_by` modifier

* Allow for implementors to return `null`, which disables the bulk process for that item * Entry now takes data keys into consideration to prevent "locking" an entry into something if it has custom data

jasonvarga

Please target master.

Requested changes were made.

# Conflicts: # src/Entries/Entry.php

…some just because ... - Dedicated AbstractAugmented 'wrap' methods, to avoid passing around hard to follow booleans. - Avoid a hard to follow boolean in InvokableValue - Make InvokableValue easier to follow both paths in general. - TransientValue and DeferredValue now pass their references when calling shallow(), which were missing, and was the reason for needing to check for nulls. - Typehints and visibility

… ... If you pass a closure as the raw value, it'll lazily evaluate them when resolving.

materialize() just called resolve() and returned a new Value instance. Now that the subclasses are gone, there's no need to new up a separate Value instance. It can just return itself. With that gone, we might as well just call resolve since materialize would just be an alias.

- Add static factory methods to BulkAugmentor. - Rename BulkAugmentor augmented() to toArray(). Seemed more inline with what it did. Looks like it makes sense when compared to the toDeferredAugmentedArray in the "else" where its used in RuntimeValues. - Reduce visibility where possible

Since dd(), dump(), etc can have variable arguments, avoid making our own Dumper methods. Just use the class to resolve the values and pass them into the original functions. Rename resolveValues to resolve. Simplify map. Remove unnecessary guard.

JohnathonKoster · 2024-03-02T16:01:57Z

This PR is an extension of #9574, and reworks some more internal augmentation behaviors. The changes in this PR come together to allow us to reuse fields arrays and augmentation keys as much as possible in a new BulkAugmentor. This new class will work to reduce the overhead of resolving this information as much as possible. For example, if you want to augment 1,000 entries and they can all safely reuse the same fields/keys, the BulkAugmentor will only do those calls once. This PR only focuses on pages/entries for now.

Positive improvements across a variety of different situations, particularly the `group_by` modifier

* Allow for implementors to return `null`, which disables the bulk process for that item * Entry now takes data keys into consideration to prevent "locking" an entry into something if it has custom data

jasonvarga

Please target master.

Requested changes were made.

# Conflicts: # src/Entries/Entry.php

…some just because ... - Dedicated AbstractAugmented 'wrap' methods, to avoid passing around hard to follow booleans. - Avoid a hard to follow boolean in InvokableValue - Make InvokableValue easier to follow both paths in general. - TransientValue and DeferredValue now pass their references when calling shallow(), which were missing, and was the reason for needing to check for nulls. - Typehints and visibility

… ... If you pass a closure as the raw value, it'll lazily evaluate them when resolving.

materialize() just called resolve() and returned a new Value instance. Now that the subclasses are gone, there's no need to new up a separate Value instance. It can just return itself. With that gone, we might as well just call resolve since materialize would just be an alias.

- Add static factory methods to BulkAugmentor. - Rename BulkAugmentor augmented() to toArray(). Seemed more inline with what it did. Looks like it makes sense when compared to the toDeferredAugmentedArray in the "else" where its used in RuntimeValues. - Reduce visibility where possible

Since dd(), dump(), etc can have variable arguments, avoid making our own Dumper methods. Just use the class to resolve the values and pass them into the original functions. Rename resolveValues to resolve. Simplify map. Remove unnecessary guard.

JohnathonKoster · 2024-03-02T16:01:57Z

This PR is an extension of #9574, and reworks some more internal augmentation behaviors. The changes in this PR come together to allow us to reuse fields arrays and augmentation keys as much as possible in a new BulkAugmentor. This new class will work to reduce the overhead of resolving this information as much as possible. For example, if you want to augment 1,000 entries and they can all safely reuse the same fields/keys, the BulkAugmentor will only do those calls once. This PR only focuses on pages/entries for now.

Positive improvements across a variety of different situations, particularly the `group_by` modifier

* Allow for implementors to return `null`, which disables the bulk process for that item * Entry now takes data keys into consideration to prevent "locking" an entry into something if it has custom data

jasonvarga

Please target master.

Requested changes were made.

# Conflicts: # src/Entries/Entry.php

…some just because ... - Dedicated AbstractAugmented 'wrap' methods, to avoid passing around hard to follow booleans. - Avoid a hard to follow boolean in InvokableValue - Make InvokableValue easier to follow both paths in general. - TransientValue and DeferredValue now pass their references when calling shallow(), which were missing, and was the reason for needing to check for nulls. - Typehints and visibility

… ... If you pass a closure as the raw value, it'll lazily evaluate them when resolving.

materialize() just called resolve() and returned a new Value instance. Now that the subclasses are gone, there's no need to new up a separate Value instance. It can just return itself. With that gone, we might as well just call resolve since materialize would just be an alias.

- Add static factory methods to BulkAugmentor. - Rename BulkAugmentor augmented() to toArray(). Seemed more inline with what it did. Looks like it makes sense when compared to the toDeferredAugmentedArray in the "else" where its used in RuntimeValues. - Reduce visibility where possible

Since dd(), dump(), etc can have variable arguments, avoid making our own Dumper methods. Just use the class to resolve the values and pass them into the original functions. Rename resolveValues to resolve. Simplify map. Remove unnecessary guard.

JohnathonKoster added 7 commits February 22, 2024 14:24

Makes method-backed augmented values lazy/deferrable
fe2c56f

A tiny, but not nothing difference
1df8569

Merge branch '4.x' into deferred-method-augmentation
af03d7e

🧹
d220d16

Reduce calls to blueprintFields
9cf6cd1

Use deferred augmentation in more places internally
20c376a
Positive improvements across a variety of different situations, particularly the `group_by` modifier

Delay the resolution of regular values
e7eafa9

JohnathonKoster marked this pull request as draft March 2, 2024 16:02

JohnathonKoster added 5 commits March 2, 2024 10:27

Refactors shared logic across deferred values
7b7cfa4

Need to account for relationships
b10b6c5

Adds transient values
ee66acd

Refactor select to allow for known fields to be supplied
eedbb88

Adds the Augmentor 50000; uses it inside Antlers augmentation
86d22d3

JohnathonKoster mentioned this pull request Mar 2, 2024
[5.x] Augmentation Adjustments #9574
Closed

JohnathonKoster changed the title ~~[5.x] Deferred all augmentation~~[5.x] Defer all augmentation, allow for Bulk Augmentation (reuse key/fields across similar items), even more internal augmentation adjustmentsMar 2, 2024

JohnathonKoster added 3 commits March 2, 2024 13:45

Some key adjustments
24d7878
* Allow for implementors to return `null`, which disables the bulk process for that item * Entry now takes data keys into consideration to prevent "locking" an entry into something if it has custom data

Update nav tag to use bulk augmentor
477541a

Restore a familiar experience to dump, dd, and its friends
2ede1a2

JohnathonKoster mentioned this pull request Mar 2, 2024
[5.x] Consolidated WIP Items #9588
Closed
37 tasks

JohnathonKoster marked this pull request as ready for review March 2, 2024 21:25

Ensure fieldtype materializes values
f5eee7c

jasonvarga previously requested changes Mar 7, 2024
View reviewed changes

JohnathonKoster changed the base branch from 4.x to masterMarch 8, 2024 01:07

jasonvargaand others added 6 commits March 12, 2024 12:37

Merge branch 'master' into deferred-all-augmentation
9c67cf1

Merge branch 'master' into deferred-all-augmentation
41aa519

Merge branch 'master' into fork/deferred-all-augmentation
a529524
# Conflicts: # src/Entries/Entry.php

Merge branch 'master' into deferred-all-augmentation
f07e257

Merge branch 'master' into deferred-all-augmentation
c576286

jasonvarga added 6 commits May 1, 2024 13:05

Clear this up
1f989dd

Remove the 3 Value class inheritors by using a closure based solution…
bcaa0f4
… ... If you pass a closure as the raw value, it'll lazily evaluate them when resolving.

oops
015368c

isSelecting is never used since transient values were introduced
8dd6b79

null coalesce
828e3a5

jasonvarga changed the title ~~[5.x] Defer all augmentation, allow for Bulk Augmentation (reuse key/fields across similar items), even more internal augmentation adjustments~~[5.x] Augmentation performance improvementsMay 1, 2024

jasonvarga added 15 commits May 1, 2024 16:44

refactor to single fieldtype method
1ec54a1

Avoid passing around fields argument
3509be9

docblock for clickthrough fun
81a8547

undo some viz changes
e3ad099

not that
d85fac3

Get augmented once
2811e9c

avoid passing around a fieldtype
9fb80bd

rename
37f13c1

resolve when serializing (so it works in nocache)
5c4e66d

apply to terms
0a2836a

viz
fecfc5b

nitpick
bf5c321

contract
6bac97b

Nitpick dumper ...
8a5bb26
Since dd(), dump(), etc can have variable arguments, avoid making our own Dumper methods. Just use the class to resolve the values and pass them into the original functions. Rename resolveValues to resolve. Simplify map. Remove unnecessary guard.

jasonvarga merged commit d0f29dd into statamic:masterMay 2, 2024

duncanmcclean mentioned this pull request May 3, 2024
[7.x] Augmentation improvements statamic-rad-pack/runway#481
Merged
1 task

o1y mentioned this pull request May 5, 2024
[5.x] Global fields with Antlers enabled not parsing anymore #10001
Closed

This was referenced May 14, 2024
Navigations can't access group data when it has a condition #10055
Closed
[5.x] Fix augmentation issues for URL nav items #10086
Merged

jasonvarga mentioned this pull request May 29, 2024
[5.x] Bring back select param on nav tag #10226
Merged

This was referenced Jul 8, 2024
[5.x] Change method visibility in AbstractAugmented class #10414
Merged
[5.x] Fix augmentable not resolved in transient values #10417
Merged

JohnathonKoster added 7 commits February 22, 2024 14:24

Makes method-backed augmented values lazy/deferrable
fe2c56f

A tiny, but not nothing difference
1df8569

Merge branch '4.x' into deferred-method-augmentation
af03d7e

🧹
d220d16

Reduce calls to blueprintFields
9cf6cd1

Use deferred augmentation in more places internally
20c376a
Positive improvements across a variety of different situations, particularly the `group_by` modifier

Delay the resolution of regular values
e7eafa9

JohnathonKoster marked this pull request as draft March 2, 2024 16:02

JohnathonKoster added 5 commits March 2, 2024 10:27

Refactors shared logic across deferred values
7b7cfa4

Need to account for relationships
b10b6c5

Adds transient values
ee66acd

Refactor select to allow for known fields to be supplied
eedbb88

Adds the Augmentor 50000; uses it inside Antlers augmentation
86d22d3

JohnathonKoster mentioned this pull request Mar 2, 2024
[5.x] Augmentation Adjustments #9574
Closed

JohnathonKoster changed the title ~~[5.x] Deferred all augmentation~~[5.x] Defer all augmentation, allow for Bulk Augmentation (reuse key/fields across similar items), even more internal augmentation adjustmentsMar 2, 2024

JohnathonKoster added 3 commits March 2, 2024 13:45

Some key adjustments
24d7878
* Allow for implementors to return `null`, which disables the bulk process for that item * Entry now takes data keys into consideration to prevent "locking" an entry into something if it has custom data

Update nav tag to use bulk augmentor
477541a

Restore a familiar experience to dump, dd, and its friends
2ede1a2

JohnathonKoster mentioned this pull request Mar 2, 2024
[5.x] Consolidated WIP Items #9588
Closed
37 tasks

JohnathonKoster marked this pull request as ready for review March 2, 2024 21:25

Ensure fieldtype materializes values
f5eee7c

jasonvarga previously requested changes Mar 7, 2024
View reviewed changes

JohnathonKoster changed the base branch from 4.x to masterMarch 8, 2024 01:07

jasonvargaand others added 6 commits March 12, 2024 12:37

Merge branch 'master' into deferred-all-augmentation
9c67cf1

Merge branch 'master' into deferred-all-augmentation
41aa519

Merge branch 'master' into fork/deferred-all-augmentation
a529524
# Conflicts: # src/Entries/Entry.php

Merge branch 'master' into deferred-all-augmentation
f07e257

Merge branch 'master' into deferred-all-augmentation
c576286

jasonvarga added 6 commits May 1, 2024 13:05

Clear this up
1f989dd

Remove the 3 Value class inheritors by using a closure based solution…
bcaa0f4
… ... If you pass a closure as the raw value, it'll lazily evaluate them when resolving.

oops
015368c

isSelecting is never used since transient values were introduced
8dd6b79

null coalesce
828e3a5

jasonvarga changed the title ~~[5.x] Defer all augmentation, allow for Bulk Augmentation (reuse key/fields across similar items), even more internal augmentation adjustments~~[5.x] Augmentation performance improvementsMay 1, 2024

jasonvarga added 15 commits May 1, 2024 16:44

refactor to single fieldtype method
1ec54a1

Avoid passing around fields argument
3509be9

docblock for clickthrough fun
81a8547

undo some viz changes
e3ad099

not that
d85fac3

Get augmented once
2811e9c

avoid passing around a fieldtype
9fb80bd

rename
37f13c1

resolve when serializing (so it works in nocache)
5c4e66d

apply to terms
0a2836a

viz
fecfc5b

nitpick
bf5c321

contract
6bac97b

Nitpick dumper ...
8a5bb26
Since dd(), dump(), etc can have variable arguments, avoid making our own Dumper methods. Just use the class to resolve the values and pass them into the original functions. Rename resolveValues to resolve. Simplify map. Remove unnecessary guard.

jasonvarga merged commit d0f29dd into statamic:masterMay 2, 2024

duncanmcclean mentioned this pull request May 3, 2024
[7.x] Augmentation improvements statamic-rad-pack/runway#481
Merged
1 task

o1y mentioned this pull request May 5, 2024
[5.x] Global fields with Antlers enabled not parsing anymore #10001
Closed

This was referenced May 14, 2024
Navigations can't access group data when it has a condition #10055
Closed
[5.x] Fix augmentation issues for URL nav items #10086
Merged

jasonvarga mentioned this pull request May 29, 2024
[5.x] Bring back select param on nav tag #10226
Merged

This was referenced Jul 8, 2024
[5.x] Change method visibility in AbstractAugmented class #10414
Merged
[5.x] Fix augmentable not resolved in transient values #10417
Merged

JohnathonKoster added 7 commits February 22, 2024 14:24

Makes method-backed augmented values lazy/deferrable
fe2c56f

A tiny, but not nothing difference
1df8569

Merge branch '4.x' into deferred-method-augmentation
af03d7e

🧹
d220d16

Reduce calls to blueprintFields
9cf6cd1

Use deferred augmentation in more places internally
20c376a
Positive improvements across a variety of different situations, particularly the `group_by` modifier

Delay the resolution of regular values
e7eafa9

JohnathonKoster marked this pull request as draft March 2, 2024 16:02

JohnathonKoster added 5 commits March 2, 2024 10:27

Refactors shared logic across deferred values
7b7cfa4

Need to account for relationships
b10b6c5

Adds transient values
ee66acd

Refactor select to allow for known fields to be supplied
eedbb88

Adds the Augmentor 50000; uses it inside Antlers augmentation
86d22d3

JohnathonKoster mentioned this pull request Mar 2, 2024
[5.x] Augmentation Adjustments #9574
Closed

JohnathonKoster changed the title ~~[5.x] Deferred all augmentation~~[5.x] Defer all augmentation, allow for Bulk Augmentation (reuse key/fields across similar items), even more internal augmentation adjustmentsMar 2, 2024

JohnathonKoster added 3 commits March 2, 2024 13:45

Some key adjustments
24d7878
* Allow for implementors to return `null`, which disables the bulk process for that item * Entry now takes data keys into consideration to prevent "locking" an entry into something if it has custom data

Update nav tag to use bulk augmentor
477541a

Restore a familiar experience to dump, dd, and its friends
2ede1a2

JohnathonKoster mentioned this pull request Mar 2, 2024
[5.x] Consolidated WIP Items #9588
Closed
37 tasks

JohnathonKoster marked this pull request as ready for review March 2, 2024 21:25

Ensure fieldtype materializes values
f5eee7c

jasonvarga previously requested changes Mar 7, 2024
View reviewed changes

JohnathonKoster changed the base branch from 4.x to masterMarch 8, 2024 01:07

jasonvargaand others added 6 commits March 12, 2024 12:37

Merge branch 'master' into deferred-all-augmentation
9c67cf1

Merge branch 'master' into deferred-all-augmentation
41aa519

Merge branch 'master' into fork/deferred-all-augmentation
a529524
# Conflicts: # src/Entries/Entry.php

Merge branch 'master' into deferred-all-augmentation
f07e257

Merge branch 'master' into deferred-all-augmentation
c576286

jasonvarga added 6 commits May 1, 2024 13:05

Clear this up
1f989dd

Remove the 3 Value class inheritors by using a closure based solution…
bcaa0f4
… ... If you pass a closure as the raw value, it'll lazily evaluate them when resolving.

oops
015368c

isSelecting is never used since transient values were introduced
8dd6b79

null coalesce
828e3a5

jasonvarga changed the title ~~[5.x] Defer all augmentation, allow for Bulk Augmentation (reuse key/fields across similar items), even more internal augmentation adjustments~~[5.x] Augmentation performance improvementsMay 1, 2024

jasonvarga added 15 commits May 1, 2024 16:44

refactor to single fieldtype method
1ec54a1

Avoid passing around fields argument
3509be9

docblock for clickthrough fun
81a8547

undo some viz changes
e3ad099

not that
d85fac3

Get augmented once
2811e9c

avoid passing around a fieldtype
9fb80bd

rename
37f13c1

resolve when serializing (so it works in nocache)
5c4e66d

apply to terms
0a2836a

viz
fecfc5b

nitpick
bf5c321

contract
6bac97b

Nitpick dumper ...
8a5bb26
Since dd(), dump(), etc can have variable arguments, avoid making our own Dumper methods. Just use the class to resolve the values and pass them into the original functions. Rename resolveValues to resolve. Simplify map. Remove unnecessary guard.

jasonvarga merged commit d0f29dd into statamic:masterMay 2, 2024

duncanmcclean mentioned this pull request May 3, 2024
[7.x] Augmentation improvements statamic-rad-pack/runway#481
Merged
1 task

o1y mentioned this pull request May 5, 2024
[5.x] Global fields with Antlers enabled not parsing anymore #10001
Closed

This was referenced May 14, 2024
Navigations can't access group data when it has a condition #10055
Closed
[5.x] Fix augmentation issues for URL nav items #10086
Merged

jasonvarga mentioned this pull request May 29, 2024
[5.x] Bring back select param on nav tag #10226
Merged

This was referenced Jul 8, 2024
[5.x] Change method visibility in AbstractAugmented class #10414
Merged
[5.x] Fix augmentable not resolved in transient values #10417
Merged

JohnathonKoster added 7 commits February 22, 2024 14:24

Makes method-backed augmented values lazy/deferrable
fe2c56f

A tiny, but not nothing difference
1df8569

Merge branch '4.x' into deferred-method-augmentation
af03d7e

🧹
d220d16

Reduce calls to blueprintFields
9cf6cd1

Use deferred augmentation in more places internally
20c376a
Positive improvements across a variety of different situations, particularly the `group_by` modifier

Delay the resolution of regular values
e7eafa9

JohnathonKoster marked this pull request as draft March 2, 2024 16:02

JohnathonKoster added 5 commits March 2, 2024 10:27

Refactors shared logic across deferred values
7b7cfa4

Need to account for relationships
b10b6c5

Adds transient values
ee66acd

Refactor select to allow for known fields to be supplied
eedbb88

Adds the Augmentor 50000; uses it inside Antlers augmentation
86d22d3

JohnathonKoster mentioned this pull request Mar 2, 2024
[5.x] Augmentation Adjustments #9574
Closed

JohnathonKoster changed the title ~~[5.x] Deferred all augmentation~~[5.x] Defer all augmentation, allow for Bulk Augmentation (reuse key/fields across similar items), even more internal augmentation adjustmentsMar 2, 2024

JohnathonKoster added 3 commits March 2, 2024 13:45

Some key adjustments
24d7878
* Allow for implementors to return `null`, which disables the bulk process for that item * Entry now takes data keys into consideration to prevent "locking" an entry into something if it has custom data

Update nav tag to use bulk augmentor
477541a

Restore a familiar experience to dump, dd, and its friends
2ede1a2

JohnathonKoster mentioned this pull request Mar 2, 2024
[5.x] Consolidated WIP Items #9588
Closed
37 tasks

JohnathonKoster marked this pull request as ready for review March 2, 2024 21:25

Ensure fieldtype materializes values
f5eee7c

jasonvarga previously requested changes Mar 7, 2024
View reviewed changes

JohnathonKoster changed the base branch from 4.x to masterMarch 8, 2024 01:07

jasonvargaand others added 6 commits March 12, 2024 12:37

Merge branch 'master' into deferred-all-augmentation
9c67cf1

Merge branch 'master' into deferred-all-augmentation
41aa519

Merge branch 'master' into fork/deferred-all-augmentation
a529524
# Conflicts: # src/Entries/Entry.php

Merge branch 'master' into deferred-all-augmentation
f07e257

Merge branch 'master' into deferred-all-augmentation
c576286

jasonvarga added 6 commits May 1, 2024 13:05

Clear this up
1f989dd

Remove the 3 Value class inheritors by using a closure based solution…
bcaa0f4
… ... If you pass a closure as the raw value, it'll lazily evaluate them when resolving.

oops
015368c

isSelecting is never used since transient values were introduced
8dd6b79

null coalesce
828e3a5

jasonvarga changed the title ~~[5.x] Defer all augmentation, allow for Bulk Augmentation (reuse key/fields across similar items), even more internal augmentation adjustments~~[5.x] Augmentation performance improvementsMay 1, 2024

jasonvarga added 15 commits May 1, 2024 16:44

refactor to single fieldtype method
1ec54a1

Avoid passing around fields argument
3509be9

docblock for clickthrough fun
81a8547

undo some viz changes
e3ad099

not that
d85fac3

Get augmented once
2811e9c

avoid passing around a fieldtype
9fb80bd

rename
37f13c1

resolve when serializing (so it works in nocache)
5c4e66d

apply to terms
0a2836a

viz
fecfc5b

nitpick
bf5c321

contract
6bac97b

Nitpick dumper ...
8a5bb26
Since dd(), dump(), etc can have variable arguments, avoid making our own Dumper methods. Just use the class to resolve the values and pass them into the original functions. Rename resolveValues to resolve. Simplify map. Remove unnecessary guard.

jasonvarga merged commit d0f29dd into statamic:masterMay 2, 2024

duncanmcclean mentioned this pull request May 3, 2024
[7.x] Augmentation improvements statamic-rad-pack/runway#481
Merged
1 task

o1y mentioned this pull request May 5, 2024
[5.x] Global fields with Antlers enabled not parsing anymore #10001
Closed

This was referenced May 14, 2024
Navigations can't access group data when it has a condition #10055
Closed
[5.x] Fix augmentation issues for URL nav items #10086
Merged

jasonvarga mentioned this pull request May 29, 2024
[5.x] Bring back select param on nav tag #10226
Merged

This was referenced Jul 8, 2024
[5.x] Change method visibility in AbstractAugmented class #10414
Merged
[5.x] Fix augmentable not resolved in transient values #10417
Merged

JohnathonKoster added 7 commits February 22, 2024 14:24

Makes method-backed augmented values lazy/deferrable
fe2c56f

A tiny, but not nothing difference
1df8569

Merge branch '4.x' into deferred-method-augmentation
af03d7e

🧹
d220d16

Reduce calls to blueprintFields
9cf6cd1

Use deferred augmentation in more places internally
20c376a
Positive improvements across a variety of different situations, particularly the `group_by` modifier

Delay the resolution of regular values
e7eafa9

JohnathonKoster marked this pull request as draft March 2, 2024 16:02

JohnathonKoster added 5 commits March 2, 2024 10:27

Refactors shared logic across deferred values
7b7cfa4

Need to account for relationships
b10b6c5

Adds transient values
ee66acd

Refactor select to allow for known fields to be supplied
eedbb88

Adds the Augmentor 50000; uses it inside Antlers augmentation
86d22d3

JohnathonKoster mentioned this pull request Mar 2, 2024
[5.x] Augmentation Adjustments #9574
Closed

JohnathonKoster changed the title ~~[5.x] Deferred all augmentation~~[5.x] Defer all augmentation, allow for Bulk Augmentation (reuse key/fields across similar items), even more internal augmentation adjustmentsMar 2, 2024

JohnathonKoster added 3 commits March 2, 2024 13:45

Some key adjustments
24d7878
* Allow for implementors to return `null`, which disables the bulk process for that item * Entry now takes data keys into consideration to prevent "locking" an entry into something if it has custom data

Update nav tag to use bulk augmentor
477541a

Restore a familiar experience to dump, dd, and its friends
2ede1a2

JohnathonKoster mentioned this pull request Mar 2, 2024
[5.x] Consolidated WIP Items #9588
Closed
37 tasks

JohnathonKoster marked this pull request as ready for review March 2, 2024 21:25

Ensure fieldtype materializes values
f5eee7c

jasonvarga previously requested changes Mar 7, 2024
View reviewed changes

JohnathonKoster changed the base branch from 4.x to masterMarch 8, 2024 01:07

jasonvargaand others added 6 commits March 12, 2024 12:37

Merge branch 'master' into deferred-all-augmentation
9c67cf1

Merge branch 'master' into deferred-all-augmentation
41aa519

Merge branch 'master' into fork/deferred-all-augmentation
a529524
# Conflicts: # src/Entries/Entry.php

Merge branch 'master' into deferred-all-augmentation
f07e257

Merge branch 'master' into deferred-all-augmentation
c576286

jasonvarga added 6 commits May 1, 2024 13:05

Clear this up
1f989dd

Remove the 3 Value class inheritors by using a closure based solution…
bcaa0f4
… ... If you pass a closure as the raw value, it'll lazily evaluate them when resolving.

oops
015368c

isSelecting is never used since transient values were introduced
8dd6b79

null coalesce
828e3a5

jasonvarga changed the title ~~[5.x] Defer all augmentation, allow for Bulk Augmentation (reuse key/fields across similar items), even more internal augmentation adjustments~~[5.x] Augmentation performance improvementsMay 1, 2024

jasonvarga added 15 commits May 1, 2024 16:44

refactor to single fieldtype method
1ec54a1

Avoid passing around fields argument
3509be9

docblock for clickthrough fun
81a8547

undo some viz changes
e3ad099

not that
d85fac3

Get augmented once
2811e9c

avoid passing around a fieldtype
9fb80bd

rename
37f13c1

resolve when serializing (so it works in nocache)
5c4e66d

apply to terms
0a2836a

viz
fecfc5b

nitpick
bf5c321

contract
6bac97b

Nitpick dumper ...
8a5bb26
Since dd(), dump(), etc can have variable arguments, avoid making our own Dumper methods. Just use the class to resolve the values and pass them into the original functions. Rename resolveValues to resolve. Simplify map. Remove unnecessary guard.

jasonvarga merged commit d0f29dd into statamic:masterMay 2, 2024

duncanmcclean mentioned this pull request May 3, 2024
[7.x] Augmentation improvements statamic-rad-pack/runway#481
Merged
1 task

o1y mentioned this pull request May 5, 2024
[5.x] Global fields with Antlers enabled not parsing anymore #10001
Closed

This was referenced May 14, 2024
Navigations can't access group data when it has a condition #10055
Closed
[5.x] Fix augmentation issues for URL nav items #10086
Merged

jasonvarga mentioned this pull request May 29, 2024
[5.x] Bring back select param on nav tag #10226
Merged

This was referenced Jul 8, 2024
[5.x] Change method visibility in AbstractAugmented class #10414
Merged
[5.x] Fix augmentable not resolved in transient values #10417
Merged

JohnathonKoster added 7 commits February 22, 2024 14:24

Makes method-backed augmented values lazy/deferrable
fe2c56f

A tiny, but not nothing difference
1df8569

Merge branch '4.x' into deferred-method-augmentation
af03d7e

🧹
d220d16

Reduce calls to blueprintFields
9cf6cd1

Use deferred augmentation in more places internally
20c376a
Positive improvements across a variety of different situations, particularly the `group_by` modifier

Delay the resolution of regular values
e7eafa9

JohnathonKoster marked this pull request as draft March 2, 2024 16:02

JohnathonKoster added 5 commits March 2, 2024 10:27

Refactors shared logic across deferred values
7b7cfa4

Need to account for relationships
b10b6c5

Adds transient values
ee66acd

Refactor select to allow for known fields to be supplied
eedbb88

Adds the Augmentor 50000; uses it inside Antlers augmentation
86d22d3

JohnathonKoster mentioned this pull request Mar 2, 2024
[5.x] Augmentation Adjustments #9574
Closed

JohnathonKoster changed the title ~~[5.x] Deferred all augmentation~~[5.x] Defer all augmentation, allow for Bulk Augmentation (reuse key/fields across similar items), even more internal augmentation adjustmentsMar 2, 2024

JohnathonKoster added 3 commits March 2, 2024 13:45

Some key adjustments
24d7878
* Allow for implementors to return `null`, which disables the bulk process for that item * Entry now takes data keys into consideration to prevent "locking" an entry into something if it has custom data

Update nav tag to use bulk augmentor
477541a

Restore a familiar experience to dump, dd, and its friends
2ede1a2

JohnathonKoster mentioned this pull request Mar 2, 2024
[5.x] Consolidated WIP Items #9588
Closed
37 tasks

JohnathonKoster marked this pull request as ready for review March 2, 2024 21:25

Ensure fieldtype materializes values
f5eee7c

jasonvarga previously requested changes Mar 7, 2024
View reviewed changes

JohnathonKoster changed the base branch from 4.x to masterMarch 8, 2024 01:07

jasonvargaand others added 6 commits March 12, 2024 12:37

Merge branch 'master' into deferred-all-augmentation
9c67cf1

Merge branch 'master' into deferred-all-augmentation
41aa519

Merge branch 'master' into fork/deferred-all-augmentation
a529524
# Conflicts: # src/Entries/Entry.php

Merge branch 'master' into deferred-all-augmentation
f07e257

Merge branch 'master' into deferred-all-augmentation
c576286

jasonvarga added 6 commits May 1, 2024 13:05

Clear this up
1f989dd

Remove the 3 Value class inheritors by using a closure based solution…
bcaa0f4
… ... If you pass a closure as the raw value, it'll lazily evaluate them when resolving.

oops
015368c

isSelecting is never used since transient values were introduced
8dd6b79

null coalesce
828e3a5

jasonvarga changed the title ~~[5.x] Defer all augmentation, allow for Bulk Augmentation (reuse key/fields across similar items), even more internal augmentation adjustments~~[5.x] Augmentation performance improvementsMay 1, 2024

jasonvarga added 15 commits May 1, 2024 16:44

refactor to single fieldtype method
1ec54a1

Avoid passing around fields argument
3509be9

docblock for clickthrough fun
81a8547

undo some viz changes
e3ad099

not that
d85fac3

Get augmented once
2811e9c

avoid passing around a fieldtype
9fb80bd

rename
37f13c1

resolve when serializing (so it works in nocache)
5c4e66d

apply to terms
0a2836a

viz
fecfc5b

nitpick
bf5c321

contract
6bac97b

Nitpick dumper ...
8a5bb26
Since dd(), dump(), etc can have variable arguments, avoid making our own Dumper methods. Just use the class to resolve the values and pass them into the original functions. Rename resolveValues to resolve. Simplify map. Remove unnecessary guard.

jasonvarga merged commit d0f29dd into statamic:masterMay 2, 2024

duncanmcclean mentioned this pull request May 3, 2024
[7.x] Augmentation improvements statamic-rad-pack/runway#481
Merged
1 task

o1y mentioned this pull request May 5, 2024
[5.x] Global fields with Antlers enabled not parsing anymore #10001
Closed

This was referenced May 14, 2024
Navigations can't access group data when it has a condition #10055
Closed
[5.x] Fix augmentation issues for URL nav items #10086
Merged

jasonvarga mentioned this pull request May 29, 2024
[5.x] Bring back select param on nav tag #10226
Merged

This was referenced Jul 8, 2024
[5.x] Change method visibility in AbstractAugmented class #10414
Merged
[5.x] Fix augmentable not resolved in transient values #10417
Merged

JohnathonKoster added 7 commits February 22, 2024 14:24

Makes method-backed augmented values lazy/deferrable
fe2c56f

A tiny, but not nothing difference
1df8569

Merge branch '4.x' into deferred-method-augmentation
af03d7e

🧹
d220d16

Reduce calls to blueprintFields
9cf6cd1

Use deferred augmentation in more places internally
20c376a
Positive improvements across a variety of different situations, particularly the `group_by` modifier

Delay the resolution of regular values
e7eafa9

JohnathonKoster marked this pull request as draft March 2, 2024 16:02

JohnathonKoster added 5 commits March 2, 2024 10:27

Refactors shared logic across deferred values
7b7cfa4

Need to account for relationships
b10b6c5

Adds transient values
ee66acd

Refactor select to allow for known fields to be supplied
eedbb88

Adds the Augmentor 50000; uses it inside Antlers augmentation
86d22d3

JohnathonKoster mentioned this pull request Mar 2, 2024
[5.x] Augmentation Adjustments #9574
Closed

JohnathonKoster changed the title ~~[5.x] Deferred all augmentation~~[5.x] Defer all augmentation, allow for Bulk Augmentation (reuse key/fields across similar items), even more internal augmentation adjustmentsMar 2, 2024

JohnathonKoster added 3 commits March 2, 2024 13:45

Some key adjustments
24d7878
* Allow for implementors to return `null`, which disables the bulk process for that item * Entry now takes data keys into consideration to prevent "locking" an entry into something if it has custom data

Update nav tag to use bulk augmentor
477541a

Restore a familiar experience to dump, dd, and its friends
2ede1a2

JohnathonKoster mentioned this pull request Mar 2, 2024
[5.x] Consolidated WIP Items #9588
Closed
37 tasks

JohnathonKoster marked this pull request as ready for review March 2, 2024 21:25

Ensure fieldtype materializes values
f5eee7c

jasonvarga previously requested changes Mar 7, 2024
View reviewed changes

JohnathonKoster changed the base branch from 4.x to masterMarch 8, 2024 01:07

jasonvargaand others added 6 commits March 12, 2024 12:37

Merge branch 'master' into deferred-all-augmentation
9c67cf1

Merge branch 'master' into deferred-all-augmentation
41aa519

Merge branch 'master' into fork/deferred-all-augmentation
a529524
# Conflicts: # src/Entries/Entry.php

Merge branch 'master' into deferred-all-augmentation
f07e257

Merge branch 'master' into deferred-all-augmentation
c576286

jasonvarga added 6 commits May 1, 2024 13:05

Clear this up
1f989dd

Remove the 3 Value class inheritors by using a closure based solution…
bcaa0f4
… ... If you pass a closure as the raw value, it'll lazily evaluate them when resolving.

oops
015368c

isSelecting is never used since transient values were introduced
8dd6b79

null coalesce
828e3a5

jasonvarga changed the title ~~[5.x] Defer all augmentation, allow for Bulk Augmentation (reuse key/fields across similar items), even more internal augmentation adjustments~~[5.x] Augmentation performance improvementsMay 1, 2024

jasonvarga added 15 commits May 1, 2024 16:44

refactor to single fieldtype method
1ec54a1

Avoid passing around fields argument
3509be9

docblock for clickthrough fun
81a8547

undo some viz changes
e3ad099

not that
d85fac3

Get augmented once
2811e9c

avoid passing around a fieldtype
9fb80bd

rename
37f13c1

resolve when serializing (so it works in nocache)
5c4e66d

apply to terms
0a2836a

viz
fecfc5b

nitpick
bf5c321

contract
6bac97b

Nitpick dumper ...
8a5bb26
Since dd(), dump(), etc can have variable arguments, avoid making our own Dumper methods. Just use the class to resolve the values and pass them into the original functions. Rename resolveValues to resolve. Simplify map. Remove unnecessary guard.

jasonvarga merged commit d0f29dd into statamic:masterMay 2, 2024

duncanmcclean mentioned this pull request May 3, 2024
[7.x] Augmentation improvements statamic-rad-pack/runway#481
Merged
1 task

o1y mentioned this pull request May 5, 2024
[5.x] Global fields with Antlers enabled not parsing anymore #10001
Closed

This was referenced May 14, 2024
Navigations can't access group data when it has a condition #10055
Closed
[5.x] Fix augmentation issues for URL nav items #10086
Merged

jasonvarga mentioned this pull request May 29, 2024
[5.x] Bring back select param on nav tag #10226
Merged

This was referenced Jul 8, 2024
[5.x] Change method visibility in AbstractAugmented class #10414
Merged
[5.x] Fix augmentable not resolved in transient values #10417
Merged

JohnathonKoster added 7 commits February 22, 2024 14:24

Makes method-backed augmented values lazy/deferrable
fe2c56f

A tiny, but not nothing difference
1df8569

Merge branch '4.x' into deferred-method-augmentation
af03d7e

🧹
d220d16

Reduce calls to blueprintFields
9cf6cd1

Use deferred augmentation in more places internally
20c376a
Positive improvements across a variety of different situations, particularly the `group_by` modifier

Delay the resolution of regular values
e7eafa9

JohnathonKoster marked this pull request as draft March 2, 2024 16:02

JohnathonKoster added 5 commits March 2, 2024 10:27

Refactors shared logic across deferred values
7b7cfa4

Need to account for relationships
b10b6c5

Adds transient values
ee66acd

Refactor select to allow for known fields to be supplied
eedbb88

Adds the Augmentor 50000; uses it inside Antlers augmentation
86d22d3

JohnathonKoster mentioned this pull request Mar 2, 2024
[5.x] Augmentation Adjustments #9574
Closed

JohnathonKoster changed the title ~~[5.x] Deferred all augmentation~~[5.x] Defer all augmentation, allow for Bulk Augmentation (reuse key/fields across similar items), even more internal augmentation adjustmentsMar 2, 2024

JohnathonKoster added 3 commits March 2, 2024 13:45

Some key adjustments
24d7878
* Allow for implementors to return `null`, which disables the bulk process for that item * Entry now takes data keys into consideration to prevent "locking" an entry into something if it has custom data

Update nav tag to use bulk augmentor
477541a

Restore a familiar experience to dump, dd, and its friends
2ede1a2

JohnathonKoster mentioned this pull request Mar 2, 2024
[5.x] Consolidated WIP Items #9588
Closed
37 tasks

JohnathonKoster marked this pull request as ready for review March 2, 2024 21:25

Ensure fieldtype materializes values
f5eee7c

jasonvarga previously requested changes Mar 7, 2024
View reviewed changes

JohnathonKoster changed the base branch from 4.x to masterMarch 8, 2024 01:07

jasonvargaand others added 6 commits March 12, 2024 12:37

Merge branch 'master' into deferred-all-augmentation
9c67cf1

Merge branch 'master' into deferred-all-augmentation
41aa519

Merge branch 'master' into fork/deferred-all-augmentation
a529524
# Conflicts: # src/Entries/Entry.php

Merge branch 'master' into deferred-all-augmentation
f07e257

Merge branch 'master' into deferred-all-augmentation
c576286

jasonvarga added 6 commits May 1, 2024 13:05

Clear this up
1f989dd

Remove the 3 Value class inheritors by using a closure based solution…
bcaa0f4
… ... If you pass a closure as the raw value, it'll lazily evaluate them when resolving.

oops
015368c

isSelecting is never used since transient values were introduced
8dd6b79

null coalesce
828e3a5

jasonvarga changed the title ~~[5.x] Defer all augmentation, allow for Bulk Augmentation (reuse key/fields across similar items), even more internal augmentation adjustments~~[5.x] Augmentation performance improvementsMay 1, 2024

jasonvarga added 15 commits May 1, 2024 16:44

refactor to single fieldtype method
1ec54a1

Avoid passing around fields argument
3509be9

docblock for clickthrough fun
81a8547

undo some viz changes
e3ad099

not that
d85fac3

Get augmented once
2811e9c

avoid passing around a fieldtype
9fb80bd

rename
37f13c1

resolve when serializing (so it works in nocache)
5c4e66d

apply to terms
0a2836a

viz
fecfc5b

nitpick
bf5c321

contract
6bac97b

Nitpick dumper ...
8a5bb26
Since dd(), dump(), etc can have variable arguments, avoid making our own Dumper methods. Just use the class to resolve the values and pass them into the original functions. Rename resolveValues to resolve. Simplify map. Remove unnecessary guard.

jasonvarga merged commit d0f29dd into statamic:masterMay 2, 2024

duncanmcclean mentioned this pull request May 3, 2024
[7.x] Augmentation improvements statamic-rad-pack/runway#481
Merged
1 task

o1y mentioned this pull request May 5, 2024
[5.x] Global fields with Antlers enabled not parsing anymore #10001
Closed

This was referenced May 14, 2024
Navigations can't access group data when it has a condition #10055
Closed
[5.x] Fix augmentation issues for URL nav items #10086
Merged

jasonvarga mentioned this pull request May 29, 2024
[5.x] Bring back select param on nav tag #10226
Merged

This was referenced Jul 8, 2024
[5.x] Change method visibility in AbstractAugmented class #10414
Merged
[5.x] Fix augmentable not resolved in transient values #10417
Merged

Uh oh!

Uh oh!

Conversation

JohnathonKoster commented Mar 2, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasonvarga left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

JohnathonKoster commented Mar 2, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasonvarga left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

JohnathonKoster commented Mar 2, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasonvarga left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

JohnathonKoster commented Mar 2, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasonvarga left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

JohnathonKoster commented Mar 2, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasonvarga left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

JohnathonKoster commented Mar 2, 2024•
edited
Loading

JohnathonKoster commented Mar 2, 2024•
edited
Loading

JohnathonKoster commented Mar 2, 2024•
edited
Loading

JohnathonKoster commented Mar 2, 2024•
edited
Loading

JohnathonKoster commented Mar 2, 2024•
edited
Loading

JohnathonKoster commented Mar 2, 2024•
edited
Loading

JohnathonKoster commented Mar 2, 2024•
edited
Loading