[5.x] Add pluck to query builder

[JohnathonKoster]

This PR implements pluck method on the query builder.

Note: this implementation currently only resolves values from the Stache indexes, but a fallback to gathering data from entry instances could also be added if desired 🙂

[jasonvarga]

this implementation currently only resolves values from the Stache indexes

I think this is fine. We could justify it as the same thing happening with Eloquent models and accessors. Calling pluck directly on a query builder only gets the values from the database. Calling pluck on a collection will get accessors too.

class Post extends Model
{
protectedfunctionformattedTitle(): Attribute
{
return Attribute::make(
get: fn ($value, $attributes) => Str::title($attributes['title']),
);
}
}
Post::query()->pluck('title'); // ['post one', 'post two']
Post::query()->pluck('formattedTitle'); // QueryException Unknown column formattedTitle
Post::query()->get()->pluck('formattedTitle'); // ['Post One', 'Post Two']

[jasonvarga]

There's a bunch of code in this PR that when removed still passes.

If it's necessary, can you please add test coverage?

[JohnathonKoster]

This PR implements pluck method on the query builder.

Note: this implementation currently only resolves values from the Stache indexes, but a fallback to gathering data from entry instances could also be added if desired 🙂

[jasonvarga]

this implementation currently only resolves values from the Stache indexes

I think this is fine. We could justify it as the same thing happening with Eloquent models and accessors. Calling pluck directly on a query builder only gets the values from the database. Calling pluck on a collection will get accessors too.

class Post extends Model
{
protectedfunctionformattedTitle(): Attribute
{
return Attribute::make(
get: fn ($value, $attributes) => Str::title($attributes['title']),
);
}
}
Post::query()->pluck('title'); // ['post one', 'post two']
Post::query()->pluck('formattedTitle'); // QueryException Unknown column formattedTitle
Post::query()->get()->pluck('formattedTitle'); // ['Post One', 'Post Two']

[jasonvarga]

There's a bunch of code in this PR that when removed still passes.

If it's necessary, can you please add test coverage?

[JohnathonKoster]

This PR implements pluck method on the query builder.

Note: this implementation currently only resolves values from the Stache indexes, but a fallback to gathering data from entry instances could also be added if desired 🙂

[jasonvarga]

this implementation currently only resolves values from the Stache indexes

I think this is fine. We could justify it as the same thing happening with Eloquent models and accessors. Calling pluck directly on a query builder only gets the values from the database. Calling pluck on a collection will get accessors too.

class Post extends Model
{
protectedfunctionformattedTitle(): Attribute
{
return Attribute::make(
get: fn ($value, $attributes) => Str::title($attributes['title']),
);
}
}
Post::query()->pluck('title'); // ['post one', 'post two']
Post::query()->pluck('formattedTitle'); // QueryException Unknown column formattedTitle
Post::query()->get()->pluck('formattedTitle'); // ['Post One', 'Post Two']

[jasonvarga]

There's a bunch of code in this PR that when removed still passes.

If it's necessary, can you please add test coverage?

[JohnathonKoster]

This PR implements pluck method on the query builder.

Note: this implementation currently only resolves values from the Stache indexes, but a fallback to gathering data from entry instances could also be added if desired 🙂

[jasonvarga]

this implementation currently only resolves values from the Stache indexes

I think this is fine. We could justify it as the same thing happening with Eloquent models and accessors. Calling pluck directly on a query builder only gets the values from the database. Calling pluck on a collection will get accessors too.

class Post extends Model
{
protectedfunctionformattedTitle(): Attribute
{
return Attribute::make(
get: fn ($value, $attributes) => Str::title($attributes['title']),
);
}
}
Post::query()->pluck('title'); // ['post one', 'post two']
Post::query()->pluck('formattedTitle'); // QueryException Unknown column formattedTitle
Post::query()->get()->pluck('formattedTitle'); // ['Post One', 'Post Two']

[jasonvarga]

There's a bunch of code in this PR that when removed still passes.

If it's necessary, can you please add test coverage?

[JohnathonKoster]

This PR implements pluck method on the query builder.

Note: this implementation currently only resolves values from the Stache indexes, but a fallback to gathering data from entry instances could also be added if desired 🙂

[jasonvarga]

this implementation currently only resolves values from the Stache indexes

I think this is fine. We could justify it as the same thing happening with Eloquent models and accessors. Calling pluck directly on a query builder only gets the values from the database. Calling pluck on a collection will get accessors too.

class Post extends Model
{
protectedfunctionformattedTitle(): Attribute
{
return Attribute::make(
get: fn ($value, $attributes) => Str::title($attributes['title']),
);
}
}
Post::query()->pluck('title'); // ['post one', 'post two']
Post::query()->pluck('formattedTitle'); // QueryException Unknown column formattedTitle
Post::query()->get()->pluck('formattedTitle'); // ['Post One', 'Post Two']

[jasonvarga]

There's a bunch of code in this PR that when removed still passes.

If it's necessary, can you please add test coverage?

[JohnathonKoster]

This PR implements pluck method on the query builder.

Note: this implementation currently only resolves values from the Stache indexes, but a fallback to gathering data from entry instances could also be added if desired 🙂

[jasonvarga]

this implementation currently only resolves values from the Stache indexes

I think this is fine. We could justify it as the same thing happening with Eloquent models and accessors. Calling pluck directly on a query builder only gets the values from the database. Calling pluck on a collection will get accessors too.

class Post extends Model
{
protectedfunctionformattedTitle(): Attribute
{
return Attribute::make(
get: fn ($value, $attributes) => Str::title($attributes['title']),
);
}
}
Post::query()->pluck('title'); // ['post one', 'post two']
Post::query()->pluck('formattedTitle'); // QueryException Unknown column formattedTitle
Post::query()->get()->pluck('formattedTitle'); // ['Post One', 'Post Two']

[jasonvarga]

There's a bunch of code in this PR that when removed still passes.

If it's necessary, can you please add test coverage?

[JohnathonKoster]

This PR implements pluck method on the query builder.

Note: this implementation currently only resolves values from the Stache indexes, but a fallback to gathering data from entry instances could also be added if desired 🙂

[jasonvarga]

this implementation currently only resolves values from the Stache indexes

I think this is fine. We could justify it as the same thing happening with Eloquent models and accessors. Calling pluck directly on a query builder only gets the values from the database. Calling pluck on a collection will get accessors too.

class Post extends Model
{
protectedfunctionformattedTitle(): Attribute
{
return Attribute::make(
get: fn ($value, $attributes) => Str::title($attributes['title']),
);
}
}
Post::query()->pluck('title'); // ['post one', 'post two']
Post::query()->pluck('formattedTitle'); // QueryException Unknown column formattedTitle
Post::query()->get()->pluck('formattedTitle'); // ['Post One', 'Post Two']

[jasonvarga]

There's a bunch of code in this PR that when removed still passes.

If it's necessary, can you please add test coverage?

[JohnathonKoster]

This PR implements pluck method on the query builder.

Note: this implementation currently only resolves values from the Stache indexes, but a fallback to gathering data from entry instances could also be added if desired 🙂

[jasonvarga]

this implementation currently only resolves values from the Stache indexes

I think this is fine. We could justify it as the same thing happening with Eloquent models and accessors. Calling pluck directly on a query builder only gets the values from the database. Calling pluck on a collection will get accessors too.

class Post extends Model
{
protectedfunctionformattedTitle(): Attribute
{
return Attribute::make(
get: fn ($value, $attributes) => Str::title($attributes['title']),
);
}
}
Post::query()->pluck('title'); // ['post one', 'post two']
Post::query()->pluck('formattedTitle'); // QueryException Unknown column formattedTitle
Post::query()->get()->pluck('formattedTitle'); // ['Post One', 'Post Two']

[jasonvarga]

There's a bunch of code in this PR that when removed still passes.

If it's necessary, can you please add test coverage?