Uh oh!
There was an error while loading. Please reload this page.
[4.x] Fix stacked grid margin-top styling - #9733
Merged
Merged
Conversation
jesseleite
marked this pull request as draft
March 14, 2024 16:29
jesseleite
marked this pull request as ready for review
March 14, 2024 19:02
33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on @duncanmcclean's #9307 PR to fix more edge case styling issues around stacked grid rows...
fullscreenandhide_displayconfigured onstackedgridsrequired: trueasterisk*as well, since it's part of label, semantically speaking.Examples
Here are some screenshots showing what it looks like after my proposed changes...
When showing both the display label & fullscreen button:
When hiding both the display label & fullscreen button:
Note: this is the edge case I need fixed for #9632
When showing only the display label (with fullscreen button hidden):
When showing only the fullscreen button (with display label hidden):