Skip to content

[5.x] Fix issues with PreventsSavingStacheItemsToDisk trait - #9874

Merged
jasonvarga merged 4 commits into
masterfrom
fix/prevents-saving-stache-items-to-disk-trait
Apr 12, 2024
Merged

[5.x] Fix issues with PreventsSavingStacheItemsToDisk trait#9874
jasonvarga merged 4 commits into
masterfrom
fix/prevents-saving-stache-items-to-disk-trait

Conversation

@duncanmcclean

@duncanmccleanduncanmcclean commented Apr 12, 2024

Copy link
Copy Markdown
Member

This pull request fixes some issues I introduced in my previous PR, #9871:

  • After testing with the Eloquent Driver, I realised that it was creating the temporary files in paths like this: tests/__fixtures__/dev-null/Users/duncan/Code/Statamic/eloquent-driver/vendor/orchestra/testbench-core/laravel/content/collections instead of simply tests/__fixtures__/content/collections
    • This was only happening for addons, so I refactored the path replacement logic in the trait and configured the default Stache directories in the AddonTestCase
  • After running the tests, the tearDown method is supposed to delete the temporary Stache files. However, after I renamed the PreventsSavingStacheItemsToDisk trait in c0d5f1f, it stopped doing that.

@duncanmccleanduncanmcclean changed the title Fix/prevents saving stache items to disk trait[5.x] Fix issues with PreventsSavingStacheItemsToDisk traitApr 12, 2024
@jasonvarga
jasonvarga merged commit ebdebd1 into masterApr 12, 2024
@jasonvarga
jasonvarga deleted the fix/prevents-saving-stache-items-to-disk-trait branch April 12, 2024 20:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@duncanmcclean@jasonvarga