Skip to content

20/isin array - #34

Open
chaburkland wants to merge 32 commits into
static-frame:masterfrom
chaburkland:20/isin_array
Open

20/isin array#34
chaburkland wants to merge 32 commits into
static-frame:masterfrom
chaburkland:20/isin_array

Conversation

@chaburkland

@chaburklandchaburkland commented Mar 10, 2021

Copy link
Copy Markdown
Collaborator

Closes#20

Checklist

  • Object 1D
  • Object 2D
  • Dtype 1D unique
  • Dtype 2D unique
  • Dtype 1D non-unique
  • Dtype 2D non-unique

@chaburklandchaburkland self-assigned this Mar 10, 2021

@brandtbucherbrandtbucher left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh boy. 🙂

I just went over this quickly during lunch. I've refrained from checking or commenting on anything except refcounts, to keep this focused.

I may have missed or falsely flagged some since I went through this so quickly. But I'm confident most of them are genuine leaks.

Comment threadarraykit.c Outdated
Comment threadarraykit.c Outdated
Comment threadarraykit.c Outdated
Comment threadarraykit.c Outdated
Comment threadarraykit.c Outdated
Comment threadarraykit.c Outdated
Comment threadarraykit.c Outdated
Comment threadarraykit.c Outdated
Comment threadarraykit.c Outdated
Comment threadarraykit.c Outdated
@chaburkland

Copy link
Copy Markdown
CollaboratorAuthor

Thanks @brandtbucher . These comments make me realize that my understanding of Python's object reference management is virtually non-existent. I'm thinking that it would be really helpful to meet with you to talk about it since I want to understand the core design of it, so that I can intuit where (and why) these leaks are happening myself

Comment threadarraykit.c Outdated
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
@chaburkland
chaburkland marked this pull request as ready for review March 26, 2021 21:49
@brandtbucher
brandtbucher removed their request for review November 17, 2022 21:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement isin_array

2 participants

@chaburkland@brandtbucher