Skip to content

Format dates according to settings - #21

Closed
rdeago wants to merge 1 commit into
statiqdev:mainfrom
rdeago:fix-dates
Closed

Format dates according to settings#21
rdeago wants to merge 1 commit into
statiqdev:mainfrom
rdeago:fix-dates

Conversation

@rdeago

Copy link
Copy Markdown
Contributor

This PR fixes the three instances in which DateTime.ToLongDateString() is called instead of DateTimeCultureExtensions.ToLongDateString(IExecutionContext), thus ignoring any DateTimeDisplayCulture setting.

I didn't even open an issue for this since it is a rather trivial bug with a rather trivial fix.

@rdeago

Copy link
Copy Markdown
ContributorAuthor

Actually, never mind. This PR is identical to #19, which has been gathering dust for six months now.

@rdeagordeago closed this Oct 21, 2022
@rdeago
rdeago deleted the fix-dates branch October 21, 2022 10:09
@daveaglick

Copy link
Copy Markdown
Member

which has been gathering dust for six months now

😬 guess I better get some PRs merged! Time flies when you don't have a lot of it to spare...

@rdeago

Copy link
Copy Markdown
ContributorAuthor

@daveaglick sorry if I sounded rude, my fault for not checking open PRs.

I was so proud of myself for understanding the problem and coming up with the solution while knowing next to zilch about both Statiq and Razor... Oh well, interesting experience anyway. I spent some time in the flow like it rarely happens these days.

Time flies when you don't have a lot of it to spare...

Man, can I relate! 😄 🤦‍♂️

Anyway, more PRs soon to come:

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rdeago@daveaglick