Uh oh!
There was an error while loading. Please reload this page.
feat : ✨ Add Basic Simulation Support for STEAMI Board - #1
Conversation
@Charly-sketch |
Charly-sketch
commented
Oct 8, 2024
via email
Ok pas de soucis
Le mar. 8 oct. 2024, 10:09, Sébastien NEDJAR ***@***.***> a
écrit : … Assigned #1 <#1> to
@Charly-sketch <https://github.com/Charly-sketch>.
—
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCU5K7YQKWZTVX3RGMFQVN3Z2OHNDAVCNFSM6AAAAABPPRH37GVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGU2TEMJYGM4DQMQ>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
nedseb
left a comment
There was a problem hiding this comment.
Je viens de faire une première passe de relecture. Je t'ai déjà mis pas mal de questions, je te laisse y répondre et/ou faire les modifications nécéssaire.
Comme remarque globale, j'ai l'impression que tu inclues trop de fonctionnalités dans ton board.ts pour une première PR.
To make review easier
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
✨ Add Basic Simulation Support for STEAMI Board
Description:
This pull request adds the initial components necessary for simulating the STEAMI board in the MakeCode editor. Specifically, this PR includes:
dalboard.jsCode: Basic implementation inspired by the Micro:bit simulator to enable core functionalities for STEAMI.These additions are aimed at providing the foundational simulation support, allowing further features to be built on top of this framework. The approach and structure closely align with the existing implementation for Micro:bit, ensuring familiarity and easier expansion in the future.
Please review and provide any feedback or suggestions for improvement. Thank you!