Uh oh!
There was an error while loading. Please reload this page.
Adds support for Appbase - #192
Conversation
roadscape
commented
Mar 27, 2018
It seems the account history test might be failing partially because of a bug in steemd's ah pruning where the very first item in history is always present. The test is not very strict though, so it might actually pass if there wasn't some quirk in |
574360c to
a11aba8Compareroadscape
commented
Apr 2, 2018
next step is to audit the appbase-switch logic, and run tests against:
use dev environment for both as it has all the steemd fixes for passing tests. the main problem here is recursive loop because |
roadscape
commented
Apr 2, 2018
Also, we are not saving the appbase flag per endpoint, and we make a call every single time we switch to a new node (and I guess after each RPCError) -- resulting in extra complexity in the request failure flow (which is already too much). How about this approach:
If we can find a reliable error string from pre-appbase nodes this approach will be much cleaner. |
sneak
commented
Apr 2, 2018
Maintaining BC is not important for very long, as with HF20 everything will be appbase. |
cyon1c
commented
Apr 2, 2018
@sneak we have to maintain BC for the time being for devs hitting any non-appbase node. |
sneak
commented
Apr 2, 2018
Of course - I'm just saying that we probably shouldn't invest significant engineering into architecting a toggle that's going to be ripped out permanently in a few months. I think it's as simple as branching on the presence of a |
sneak
commented
Apr 2, 2018
We certainly don't need to branch on a per-server level. It can be processwide, and it can simply default to appbase. |
roadscape
commented
Apr 3, 2018
Alternative implementation at #202 |
Branch of #166.
On node initialization,
http_clientwill attempt to request the node_version fromcondenser_api.get_version.All tests pass except
account_history.