Skip to content

feat: add issue-body default - #47

Merged
stefanbuck merged 4 commits into
stefanbuck:mainfrom
joshjohanning:joshjohanning-add-issue-body-default
Oct 20, 2022
Merged

feat: add issue-body default#47
stefanbuck merged 4 commits into
stefanbuck:mainfrom
joshjohanning:joshjohanning-add-issue-body-default

Conversation

@joshjohanning

Copy link
Copy Markdown
Contributor

closes#46

🎉

@lemeurherve

Copy link
Copy Markdown
Contributor

Does this mean issue-body isn't required in the action setup anymore? If so, I think the README should be updated too.

@joshjohanning

Copy link
Copy Markdown
ContributorAuthor

Nice, yeah @lemeurherve - I updated the readme accordingly.

@gr2m / @stefanbuck , take a look at the readme and see if that's how you want it presented.

Comment threadREADME.md Outdated
joshjohanningand others added 2 commits October 20, 2022 13:19
Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com>
Comment threadREADME.md
template-path: .github/ISSUE_TEMPLATE/bug-report.yml
```

The text to be parsed can be set explicitly using `issue-body` input, otherwise it can be left to use the default value of `${{ github.event.issue.body }}`.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lemeurherve@gr2m , what do we think about this line?

I originally wrote it longer, but cut it down for brevity, and people don't really need to see the historical references here?

Originally wrote:

In version 3.0.0, new input for issue-body is added to mitigate script injection attacks (see: #42). Version 3.0.1 defaulted issue-body to ${{ github.event.issue.body }} for convenience (see: #47). The text to be parsed can be set explicitly using issue-body input, otherwise it can be left to use the default value.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say it's great, we can iterate on it later, I'd get this PR merged

@stefanbuck

Copy link
Copy Markdown
Owner

Amazing! It's really awesome to see you all to care enough about this little project to spend your time improving it. Thank you ❤️

@stefanbuck
stefanbuck merged commit 741688b into stefanbuck:mainOct 20, 2022
@stefanbuck

stefanbuck commented Oct 20, 2022

Copy link
Copy Markdown
Owner

For some odd reason the release pipeline was using an older commit as a baseline and this resulted in another 3.0.0 release ergo the pipeline failed with tag 'v3.0.0' already exists. I created the release manual for now, but the same happened earlier before as well see #43 (comment)@gr2m do you have any idea what is causing this?

@stefanbuck

Copy link
Copy Markdown
Owner

Given this is happening since #39 it must be related to this change. Is there another way to address #23?

@gr2m

gr2m commented Oct 21, 2022

Copy link
Copy Markdown
Collaborator

I had a quick glance but don't know what the reason might be. I gotta go for today, but could you file an issue and assign it to me please? I'll have a look tomorrow

@joshjohanning

Copy link
Copy Markdown
ContributorAuthor

I had a quick glance but don't know what the reason might be. I gotta go for today, but could you file an issue and assign it to me please? I'll have a look tomorrow

I had this browser tab still open for some reason, so I created the issue 👌 ☝️

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Question: Why not provide a default value for issue-body in 3.0.0?

4 participants

@joshjohanning@lemeurherve@stefanbuck@gr2m