feat(src): Earn positions tab by CassioMG · Pull Request #2979 · stellar/freighter

CassioMG · 2026-08-26T14:52:14Z

TL;DR

Adds a Positions tab to Home, between Tokens and Collectibles, listing the Blend pools the account has supplied to. Tapping a pool opens a My position sheet with the pool's balance, its interest earned, and the tokens supplied to it; tapping one of those tokens opens the pool sheet on a new Your position tab, and About pool opens the same sheet showing market data alone. Accounts with no positions get an empty state projecting what they could earn.

Every route into the deposit flow — the floating + Deposit pill, Start Earning, and the sheet's Deposit button — is gated behind the same earn_deposit flag as Home's Earn tile, so they all appear and disappear together. With the flag off the tab, the pool cards and both sheet tabs still work: the flag gates depositing, not viewing.

Positions load alongside balances and collectibles on Home, refresh on the same 30-second cadence, and are cached per network and account.

Based on feat/earn-deposit (#2974), not master. Review that first — this sits on top of it.

Before this leaves draft

git revert 726cc9ea — temporary debug logging of raw Blend payloads, deliberately kept so the responses could be inspected while building. (The SHA has moved twice through rebases; this is the current one.)

blend-positions-wip.mov

Implementation details (for agents)

Data. A getBlendPositions client for POST /api/v1/accounts/positions plus camelCase domain types. Positions cache in the existing cache slice keyed [network][publicKey], read through a useGetPositions hook modelled on useGetCollectibles — with one deliberate divergence: it re-throws rather than swallowing failures, because the tab must distinguish "could not load" from "you have none". A position is money.

Orchestration. useGetAccountData fetches positions unawaited alongside collectibles and joins the existing 30s balances interval. useGetPositions.fetchData takes a per-call useCache override so the initial load uses the 3-minute cache while the 30s refresh and account switches bypass it — without that lever the "30-second refresh" would have genuinely hit the network on roughly one tick in six.

Presentation. positionRows.ts is the single place the pool-shaped payload is flattened into token rows. poolPositionSummary.ts owns the pool-level figures; positionSummary.ts owns the supply-level ones. Two functions with distinct jobs rather than one with a mode flag.

Sheet. PoolDetailsSheet gained position, focusedAssetId, onDeposit, defaultTab, onTabChange and overviewOnly — all optional. Gating hasPosition on !overviewOnly hides the tab strip and forces the Overview pane with no third code path.

Prefill. The deposit prefill travels as a query flag rather than pre-dispatched state, because the Earn view runs resetSubmission() on mount and that reducer returns the whole slice to initialState.

Number handling. A nullable USD/APY value is null when unavailable and 0 when genuinely zero; nulls render NO_FIAT_VALUE and are never coalesced. On-chain amounts stay full-precision integer strings scaled with BigNumber.

Two correctness fixes worth calling out:

formatAccountUsd used to truncate via Math.floor(parseFloat(v) * 100) / 100. Binary float makes 1.15 * 100 = 114.99999999999999, so 6.56% of exact-cent values rendered one cent low — $1.15 showed as $1.14 — across every position figure. Now uses BigNumber.ROUND_DOWN; verified 0 of 1,000,000 wrong. The app-wide roundUsdValue still behaves this way and is used by Send, Swap and the balance list — deliberately left alone here as a much larger blast radius, but it wants its own look.
The pool total now comes from suppliedUsd, not netUsd. netUsd is supplied minus borrowed, while the interest total and the list beneath the header both come from supply rows — so with a borrow present the header read $600 above a list totalling $1,000. Borrows are not surfaced anywhere in this UI.

Analytics. source (home | position_row | positions_empty | positions_pill) rides ducks/earn.ts and is stamped on the deposit outcomes; the pool sheet's own events get a separate PoolDetailsSource union, because About pool opens the sheet but can never start a deposit. Note the position_row funnel is genuinely shorter — it skips the token picker, so earn.token_selected never fires for it. Documented rather than papered over with a synthesised event.

⚠️ Dashboard owners: earn.pool_details_opened and earn.pool_details_tab_selected previously emitted home | position_row | positions_empty; they now emit earn_amount | position_row | about_pool. Only position_row is common to both.

Verification. 246 suites / 1963 tests, 0 failures · earnPositions.test.ts 4/4 · earnDeposit.test.ts 7/7 · build:extension clean.

The last commit before the design pass fixes an e2e bug that predates this branch: loginToTestAccount navigates before registering stubs, so the popup's feature-flag fetch had already resolved to the default and the earn_deposit vardata stub never applied. It was never effective — the old true default was covering for it. This also unblocks earnDeposit.test.ts, which fails 7/7 on feat/earn-deposit alone.

Follow-ups / out of scope:

roundUsdValue's float truncation, app-wide (see above).
Retiring getBlendSuppliedTokens — EarnAmount now reads its pool position from the cache but still issues a second positions request.
Two structural design mismatches left undone because they need markup changes rather than styling: My position's pool-name nesting under the Blend chip, and the 40px supplied-asset icon versus the shared 32px AssetIcon.
The 30s interval is resettable by any render (its dep array holds an unmemoised fetchBalances), and clearInterval doesn't cancel an in-flight tick. Both pre-existing on the balances path; positions now ride the same timer.
On feat/earn-deposit's own node 9808-34747, Overview's "Net APY" reads green-10 where ours reads green-11 — left untouched as its owner's call.

Note for @aristides: the design pass changed the sheet's shared header (pool name md/semi-bold → sm/medium, "by Blend" sm → xs), which alters your deposit-flow sheet too. Your own node corroborates those values, so it corrects the header rather than diverging from it — but it will show up in your diff.

🤖 Generated with Claude Code

github-actions · 2026-08-26T14:54:54Z

PR Preview build is ready: https://github.com/stellar/freighter/releases/tag/untagged-dc3fe20d58a5d621dbc3
Backend: V1 prod + V2 beta (no sandbox configured for @CassioMG). SDF collaborators only — install instructions in the release description.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

…e Blockaid rescan Whole-branch review findings C1, I3, I4, I7 -- all seams between per-task work that no single task's review could see: - C1: the view computed AccountPositions' hasError from resolvedData.hasPositionsError alone, but a failed account fetch discards resolvedData entirely, so a fetch failure rendered as "No positions yet" instead of the error state. - I3: getBlendPools and getBlendEarnOptions were awaited ahead of the mainnet scanned-balances refetch, delaying Blockaid's isSuspicious/isMalicious labels on every earn-supported Home load. Both now start unawaited alongside positionsRequest (or as soon as their own gating condition is known) and land via the same mutate-then-spread-dispatch pattern collectibles and positions use, so neither sits in front of the rescan. - I4: the 30s positions refresh kept the last good positions but also flagged hasPositionsError, so a single flaky tick flashed rows to an error banner and back. Now only surfaced when there is no prior data left to show. - I7: positionsRequest was unawaited across several `await`s before its own try/catch, so a rejection in that window fired Sentry's unhandledrejection handler on top of the deliberate captureException. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

…position Whole-branch review findings C2, I1, I2: - C2: toDepositRow subtracted lifetime interestEarned from the current totalTokens to derive principal. A fully-exited position (total_tokens back to 0 with interest history intact) or any over-withdrawal drives that subtraction negative -- three figures on "Your position" that no longer reconcile. When the derivation goes out of range the row's principal reading no longer applies, so it now reports tokens: "0" and usd: null instead of a negative amount. - I2: the focused-asset fallback (`supply.find(...) || supply[0]`) couldn't tell "no asset was named" from "named an asset the position doesn't hold" -- and EarnAmount always names one now, so every mismatch fell back to a different asset's figures under this asset's headers. A genuine mismatch now resolves to an empty scope, and PoolDetailsSheet computes hasPosition from the same resolution rule (hasResolvableSupply) so it never shows a tab with nothing in it. - I1: the row formatted its USD figures with formatAmount/roundUsdValue while the sheet used formatCompactUsd, which goes compact at $1,000 -- a $1,500 position read differently in each place. Both now go through one new formatAccountUsd, added next to formatCompactUsd with the scope each is for spelled out in its docstring. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Whole-branch review findings I5, T7-c: - I5: the supply-APY-plus-emissions formula -- the branch's one deliberate exception to null-is-not-zero -- was copy-pasted in positionRows.ts and positionSummary.ts (byte-identical), inlined again in earnProjection.ts, and pre-existed a third time in useGetEarnTokensData.tsx. Four copies means a future change to the null-emissions behaviour silently misses three of them. Extracted to formatPoolStats.ts, next to formatRate, and imported at all four call sites; useGetEarnTokensData.tsx (a colleague's in-flight PR) only had its local definition swapped for the import, nothing else touched. - T7-c: earnProjection.test.ts's "returns null when no pool has a priced rate" test passed an empty pools array, so it only exercised the reduce's initial value, never the pool.supplyApy === null skip branch it claimed to cover. Renamed to describe what it actually tests, and added a genuine null-rate case (mixed with a priced pool, so the skip branch is actually exercised). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

…ed balances The mainnet rescan block built a throwaway scannedPayload local (balances + isScanAppended: true) and dispatched that, without ever writing those fields back onto payload itself. That was safe only because nothing dispatched from payload again afterward -- but the I3 fix moved the earnOptions landing to run after this block precisely so it would stop blocking the rescan, and that landing dispatches { ...payload }. Since the reducer fully replaces state per dispatch (helpers/request.ts), that silently reverted balances and isScanAppended right back to their pre-scan values. Affects every mainnet account with zero Blend positions (no error, empty list) -- the only population for which earnOptionsRequest is non-null. AccountAssets renders Blockaid's isSuspicious/isMalicious flags from these balances, so a malicious-token warning would appear when the scan lands and then disappear moments later, until the next 30s tick restores it. Fixed by mutating balances/isScanAppended onto payload itself before dispatching, the same pattern collectibles/positions/pools/earnOptions already use elsewhere in this function -- so any dispatch added after this block, now or later, carries the scanned data forward instead of reverting it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Follows the convention a22cfd8 established across the Earn flow. The constant is the same "--" string, so nothing renders differently; this keeps the placeholder in one place so a future change to it cannot miss a call site. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

…ctly

roundUsdValue floors by multiplying the value by 100 as a JS float, so binary float error turns an exact 1.15 into 114.99999999999999 and floors it to 1.14 -- 6.56% of exact-cent values in the $0.01-$10,000.00 range render a penny low. formatAccountUsd is now the single formatter for every position figure on the Positions tab, so this reached the pool card total, My position's total and gain, and the sheet's balance, deposits and earnings. Truncate via BigNumber#decimalPlaces(2, ROUND_DOWN) instead, which truncates the decimal string exactly rather than through float multiplication. roundUsdValue itself is untouched -- it is used app-wide and out of scope for this fix.

totalUsd came from position.netUsd, documented as "supplied minus borrowed", while the list beneath the header sums supplied assets only. An account supplying $1,000 USDC and borrowing $400 in the same pool (creatable in Blend's own UI, though Freighter cannot create one) would show a $600.00 header above a list reading $1,000.00 -- two figures shown together that don't reconcile. A borrow-heavy position could even render a negative header over an empty-looking list. Take the total from suppliedUsd, falling back to netUsd only when suppliedUsd itself is unpriced, so the header is the same quantity as the rows it heads. Every existing fixture set borrowedUsd: 0, which is why this went uncaught -- add a borrow-present case.

Wrapper passed no remoteConfig preloaded state, so this suite inherited the real initialState default for earn_deposit -- currently true, but about to flip to false upstream. Every sibling flag-dependent test already sets the flag explicitly; this was the one outlier that would have broken silently on the next rebase.

The two role="tab" buttons sat in a container with no role="tablist" to place them in, so a screen reader announced "tab" with no set context.

pool was a required prop the component never read -- its destructure deliberately omitted it to satisfy noUnusedLocals, per the comment this removes. Remove the prop, its type, and the call site argument.

Radix's Sheet here is controlled by open={Boolean(selectedPosition)}. When a 30-second refresh tick drops the selected pool from positions, the sheet closes declaratively -- but Radix's onOpenChange only fires on user interaction, so selectedPoolId and sheetMode were never cleared. If the pool reappeared on a later tick, selectedPosition went truthy again and the sheet reopened by itself, nested modal restored, with no tap from the account. Clear both in an effect the moment the selection stops resolving to a live position. Also pins the existing "opens on Your position" sheet test to the tapped asset's own balance, guarding the class of bug this branch already fixed once for the pool sheet.

About 20 comments across this branch's shipped files pointed at this run's internal planning -- "Task N", "(I1)", "(I2)", "(I3)", "(I5)", "(R2)", "(R3)", "(C1)", "(C2)", "(T7-c)". Those artifacts are git-ignored and mean nothing to anyone reading the repo later, including whoever this branch merges into. Rewrote each to say what it means without the pointer, keeping the substance. Left untouched every hit that predates this branch (RFC #2883's (D5)/(D6)/(D8) markers in popup/metrics, and an unrelated CAP-71 "(V2)" test name that isn't a plan reference at all).

`loginToTestAccount` navigates before registering stubs, so the popup's one-shot `fetchFeatureFlags` had already fired and rejected by the time stubBlendEarn registered its vardata route — a route registered after the fact never intercepts a request already sent. The stub was therefore never effective; the flag's old `true` default was silently doing the work, and upstream flipping it to `false` exposed that. Reload once the routes are in place so the popup remounts and refetches with the stub live, mirroring what stubExperimentVariants already does for the maintenance flags. Scoped to the Earn stubs rather than changing the shared login helper, which every suite depends on. This also unblocks earnDeposit.test.ts, which fails 7/7 on feat/earn-deposit alone for the same reason. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Figma is reachable again (node 9808-30558 for the populated pool card, 9808-30015 for the empty state). Fill in the PositionsPoolCard row's background/radius/padding/type-scale, correct the empty state's type scale and the "you could earn up to" card (it turns out to be small inline text, not a hero figure), and settle the green question raised in both this file and PoolDetailsSheet's: node 9808-30558's Success/Text/Primary (#4cc38a) is green-11 in this dark theme, so PositionRow__apy moves from green-09 to green-11 and both "unresolved counter-example" comments are replaced with that citation. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Figma node 9956-72252 is reachable again. Fill in the Blend chip and "About pool" pill (background, border, radius, padding, and the PoolIcon size they each need, scoped locally rather than resized globally), correct the totals block's type scale (the total figure is 24px regular, not medium, with the app's usual -4% tracking), color the gain green per node 9808-30558's resolved Success/Text/Primary, and give each supplied-asset row the card treatment the node draws around it via a BalanceRow-scoped override rather than touching PositionRow or BalanceRow themselves. The node nests the pool name under the Blend chip rather than as a full-width line below the whole identity row the way this component's markup renders it; fixing that needs a JSX restructure that's out of scope for a pixels-only pass, so it's left as a documented gap -- see the task report. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Figma node 9965-62123 ("Your position" tab) is reachable again; node 9808-34747 (Overview, maintained separately) renders the same header/tabs chrome and corroborates the values below, so this fixes that chrome too without touching anything Overview-specific. Fix the header title (14px medium, not 16px semibold), the "by Blend" tagline (12px regular, previously wrongly inheriting the title's color along with its own wrong size), the close button's background, and the PoolIcon size. Redraw the tab strip as the much-less-rounded segmented control the node actually shows (6px radius, not a full pill) with the correct brand colors on the active tab. Strip the card background off the balance/APY header row entirely -- the node draws it as plain text -- and correct both figures' type scale. Add the missing divider between the earnings row and the stat rows below it, scoped to this file rather than the shared StatRow component. Settle the same green question AccountPositions/styles.scss's commit does: node 9808-30558's Success/Text/Primary is green-11, so both existing green-11 uses here are confirmed correct and their stale "unresolved counter-example" comment is replaced with that citation. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

CassioMG force-pushed the earn-positions branch from 7c7769e to 0e40167 Compare August 26, 2026 18:20

CassioMG and others added 28 commits August 26, 2026 17:05

feat(earn): add a positions client for the Blend account endpoint

0bddedd

chore(earn): log raw Blend responses while building positions

726cc9e

feat(earn): cache account positions alongside balances and collectibles

13b1cf7

fix(earn): read the positions cache at call time instead of subscribing

66d6b3e

feat(home): fetch positions with the rest of the account data

916f7b0

fix(earn): bypass the positions cache on refresh and account switch

1a688e2

feat(home): add the Positions tab

d3979a4

fix(home): hide the floating add button on the Positions tab

dd0e267

feat(home): list supplied tokens on the Positions tab

f77a1f4

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

fix(home): keep a flat-zero interest gain from reading as colored

5afc057

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

test(home): cover the interest-gain null/zero/positive boundary

6fbf8a5

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

feat(home): project potential earnings on the empty Positions tab

2e8aaac

docs(home): correct the empty-state loader's stale Task 7 reference

a398cf8

feat(earn): derive a pool position's summary figures

3f29a52

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

fix(earn): keep deposit usd null when interest usd is unknown

77e88ee

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

feat(earn): give the pool sheet a Your position tab

5f97c56

docs(earn): correct the pool sheet's green-shade provenance comments

abd6f1c

feat(earn): open the pool sheet from a position row

e3f4551

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

feat(earn): show the position tab during a deposit

35dc3db

feat(earn): attribute deposits to where the flow started

8fee5d1

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

test(earn): cover the Positions tab end to end

f5792f5

feat(earn): summarise a pool position's totals

edb6353

docs(earn): stop describing the deleted pool-scope path in YourPosition

9348d37

CassioMG and others added 18 commits August 26, 2026 17:05

feat(home): add a pool card for the Positions tab

811f9f4

fix(home): stop the pool card's global class colliding with earn's

f6a8b95

feat(home): list pools on the Positions tab

ac152aa

fix(home): translate the My position title and cover PositionRow dire…

9dd62e1

…ctly

feat(home): show a pool's totals and supplied tokens

6ba27d4

feat(earn): open the pool sheet as overview only from About pool

cc5b145

feat(earn): gate every deposit entry point behind the earn flag

fb14e93

feat(earn): track the pool-first positions navigation

0580226

test(earn): cover the pool-first positions navigation end to end

596a0be

test(earn): verify the deposit CTA actually prefills the amount screen

56387f6

fix(earn): give the pool-details tab strip a tablist role

b5ef815

The two role="tab" buttons sat in a container with no role="tablist" to place them in, so a screen reader announced "tab" with no set context.

refactor(earn): drop MyPosition's unused pool prop

0a44ca2

pool was a required prop the component never read -- its destructure deliberately omitted it to satisfy noUnusedLocals, per the comment this removes. Remove the prop, its type, and the call site argument.

CassioMG force-pushed the earn-positions branch from 0e40167 to 6249f9d Compare August 27, 2026 00:42

CassioMG and others added 3 commits August 26, 2026 18:10

CassioMG closed this Sep 14, 2026

Navigation Menu

Uh oh!

feat(src): Earn positions tab - #2979

feat(src): Earn positions tab#2979
CassioMG wants to merge 49 commits into
feat/earn-depositfrom
earn-positions

CassioMG commented Aug 26, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 26, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

CassioMG commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TL;DR

Before this leaves draft

Uh oh!

github-actions Bot commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

CassioMG commented Aug 26, 2026 •

edited

Loading

github-actions Bot commented Aug 26, 2026 •

edited

Loading