fix: structured error instead of panic on non-authorizer auth entry addresses by Galmanus · Pull Request #2695 · stellar/stellar-cli

Galmanus · 2026-08-22T10:42:09Z

What

sign_soroban_authorizations had three todo!() arms — muxed account, claimable balance, and liquidity pool credential addresses — so any transaction carrying such an auth entry crashed the CLI with a raw panic and backtrace. They now return a structured Error::UnsupportedAuthAddress naming the address kind and its strkey.

Why

Part of #2534. Per the ruling in that issue's discussion, muxed accounts are not valid authorizers (confirmed there with dmkozh), so the actionable half of the issue is turning the panics into diagnosable errors — the error text says these addresses "cannot authorize", not "not yet supported". Also refreshes the resolve_secret comment in config/address.rs that pointed at the removed todo!.

Note: PR #2547 attempted this earlier but modifies Dockerfile/entrypoint.sh/docker/README.md, which were removed from main by #2616, and has been conflicting since May. This is a minimal replacement (2 files, no unrelated changes); happy to close in its favor if it gets rebased.

Testing

Three new unit tests (test_{muxed_account,claimable_balance,liquidity_pool}_auth_address_errors_instead_of_panicking) build a transaction with an auth entry for each address kind and assert the structured error — the regression being guarded is "errors, does not panic". cargo test -p soroban-cli --lib signer::: 25 passed. cargo clippy and cargo fmt --check clean.

Copilot

Pull request overview

Replaces panic paths for unsupported Soroban authorization addresses with structured errors.

Changes:

Adds UnsupportedAuthAddress handling for three address variants.
Adds regression tests and updates related documentation.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
`cmd/soroban-cli/src/signer/mod.rs`	Returns structured errors and adds tests.
`cmd/soroban-cli/src/config/address.rs`	Updates muxed-account signing commentary.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+ async fn assert_unsupported_auth_address(address: ScAddress, expected_kind: &str) {
+ let signer = local_signer([1u8; 32]);
+ let source = MuxedAccount::Ed25519(Uint256([9u8; 32]));
+ let contract = [42u8; 32];
+
+ let entry = address_auth(address, invocation(contract, "hello"));
+ let host_fn = HostFunction::InvokeContract(invoke_args(contract, "hello"));
+ let tx = build_tx(source, host_fn, vec![entry]);
+
+ let res = sign_soroban_authorizations(
+ &tx,
+ &[signer],
+ EXPIRATION_LEDGER,
+ NETWORK,
+ false,
+ &Print::new(true),
+ )
+ .await;
+
+ match res {
+ Err(Error::UnsupportedAuthAddress { kind, .. }) => assert_eq!(kind, expected_kind),
+ other => panic!("expected UnsupportedAuthAddress error, got: {other:?}"),
+ }
+ }


+ // when nothing matches. Muxed accounts (`M...`) carry no secret of
+ // their own and are not valid authorizers (see
+ // `Error::UnsupportedAuthAddress` in `sign_soroban_authorizations`),
 // so they keep returning `CannotSign`.


… auth entry addresses An auth entry whose credential address is a muxed account, claimable balance, or liquidity pool crashed the CLI with a raw `todo!()` panic and a backtrace. These ScAddress variants are values, not valid authorizers, so signing now fails with a diagnosable error naming the address kind and its strkey. Also refreshes the resolve_secret comment that pointed at the removed `todo!`. Part of stellar#2534

…nd clarify muxed CannotSign comment

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Galmanus · 2026-08-22T10:42:09Z

What

sign_soroban_authorizations had three todo!() arms — muxed account, claimable balance, and liquidity pool credential addresses — so any transaction carrying such an auth entry crashed the CLI with a raw panic and backtrace. They now return a structured Error::UnsupportedAuthAddress naming the address kind and its strkey.

Why

Part of #2534. Per the ruling in that issue's discussion, muxed accounts are not valid authorizers (confirmed there with dmkozh), so the actionable half of the issue is turning the panics into diagnosable errors — the error text says these addresses "cannot authorize", not "not yet supported". Also refreshes the resolve_secret comment in config/address.rs that pointed at the removed todo!.

Note: PR #2547 attempted this earlier but modifies Dockerfile/entrypoint.sh/docker/README.md, which were removed from main by #2616, and has been conflicting since May. This is a minimal replacement (2 files, no unrelated changes); happy to close in its favor if it gets rebased.

Testing

Three new unit tests (test_{muxed_account,claimable_balance,liquidity_pool}_auth_address_errors_instead_of_panicking) build a transaction with an auth entry for each address kind and assert the structured error — the regression being guarded is "errors, does not panic". cargo test -p soroban-cli --lib signer::: 25 passed. cargo clippy and cargo fmt --check clean.

Copilot

Pull request overview

Replaces panic paths for unsupported Soroban authorization addresses with structured errors.

Changes:

Adds UnsupportedAuthAddress handling for three address variants.
Adds regression tests and updates related documentation.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
`cmd/soroban-cli/src/signer/mod.rs`	Returns structured errors and adds tests.
`cmd/soroban-cli/src/config/address.rs`	Updates muxed-account signing commentary.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+ async fn assert_unsupported_auth_address(address: ScAddress, expected_kind: &str) {
+ let signer = local_signer([1u8; 32]);
+ let source = MuxedAccount::Ed25519(Uint256([9u8; 32]));
+ let contract = [42u8; 32];
+
+ let entry = address_auth(address, invocation(contract, "hello"));
+ let host_fn = HostFunction::InvokeContract(invoke_args(contract, "hello"));
+ let tx = build_tx(source, host_fn, vec![entry]);
+
+ let res = sign_soroban_authorizations(
+ &tx,
+ &[signer],
+ EXPIRATION_LEDGER,
+ NETWORK,
+ false,
+ &Print::new(true),
+ )
+ .await;
+
+ match res {
+ Err(Error::UnsupportedAuthAddress { kind, .. }) => assert_eq!(kind, expected_kind),
+ other => panic!("expected UnsupportedAuthAddress error, got: {other:?}"),
+ }
+ }


+ // when nothing matches. Muxed accounts (`M...`) carry no secret of
+ // their own and are not valid authorizers (see
+ // `Error::UnsupportedAuthAddress` in `sign_soroban_authorizations`),
 // so they keep returning `CannotSign`.


… auth entry addresses An auth entry whose credential address is a muxed account, claimable balance, or liquidity pool crashed the CLI with a raw `todo!()` panic and a backtrace. These ScAddress variants are values, not valid authorizers, so signing now fails with a diagnosable error naming the address kind and its strkey. Also refreshes the resolve_secret comment that pointed at the removed `todo!`. Part of stellar#2534

…nd clarify muxed CannotSign comment

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Galmanus · 2026-08-22T10:42:09Z

What

sign_soroban_authorizations had three todo!() arms — muxed account, claimable balance, and liquidity pool credential addresses — so any transaction carrying such an auth entry crashed the CLI with a raw panic and backtrace. They now return a structured Error::UnsupportedAuthAddress naming the address kind and its strkey.

Why

Part of #2534. Per the ruling in that issue's discussion, muxed accounts are not valid authorizers (confirmed there with dmkozh), so the actionable half of the issue is turning the panics into diagnosable errors — the error text says these addresses "cannot authorize", not "not yet supported". Also refreshes the resolve_secret comment in config/address.rs that pointed at the removed todo!.

Note: PR #2547 attempted this earlier but modifies Dockerfile/entrypoint.sh/docker/README.md, which were removed from main by #2616, and has been conflicting since May. This is a minimal replacement (2 files, no unrelated changes); happy to close in its favor if it gets rebased.

Testing

Three new unit tests (test_{muxed_account,claimable_balance,liquidity_pool}_auth_address_errors_instead_of_panicking) build a transaction with an auth entry for each address kind and assert the structured error — the regression being guarded is "errors, does not panic". cargo test -p soroban-cli --lib signer::: 25 passed. cargo clippy and cargo fmt --check clean.

Copilot

Pull request overview

Replaces panic paths for unsupported Soroban authorization addresses with structured errors.

Changes:

Adds UnsupportedAuthAddress handling for three address variants.
Adds regression tests and updates related documentation.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
`cmd/soroban-cli/src/signer/mod.rs`	Returns structured errors and adds tests.
`cmd/soroban-cli/src/config/address.rs`	Updates muxed-account signing commentary.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+ async fn assert_unsupported_auth_address(address: ScAddress, expected_kind: &str) {
+ let signer = local_signer([1u8; 32]);
+ let source = MuxedAccount::Ed25519(Uint256([9u8; 32]));
+ let contract = [42u8; 32];
+
+ let entry = address_auth(address, invocation(contract, "hello"));
+ let host_fn = HostFunction::InvokeContract(invoke_args(contract, "hello"));
+ let tx = build_tx(source, host_fn, vec![entry]);
+
+ let res = sign_soroban_authorizations(
+ &tx,
+ &[signer],
+ EXPIRATION_LEDGER,
+ NETWORK,
+ false,
+ &Print::new(true),
+ )
+ .await;
+
+ match res {
+ Err(Error::UnsupportedAuthAddress { kind, .. }) => assert_eq!(kind, expected_kind),
+ other => panic!("expected UnsupportedAuthAddress error, got: {other:?}"),
+ }
+ }


+ // when nothing matches. Muxed accounts (`M...`) carry no secret of
+ // their own and are not valid authorizers (see
+ // `Error::UnsupportedAuthAddress` in `sign_soroban_authorizations`),
 // so they keep returning `CannotSign`.


… auth entry addresses An auth entry whose credential address is a muxed account, claimable balance, or liquidity pool crashed the CLI with a raw `todo!()` panic and a backtrace. These ScAddress variants are values, not valid authorizers, so signing now fails with a diagnosable error naming the address kind and its strkey. Also refreshes the resolve_secret comment that pointed at the removed `todo!`. Part of stellar#2534

…nd clarify muxed CannotSign comment

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Galmanus · 2026-08-22T10:42:09Z

What

sign_soroban_authorizations had three todo!() arms — muxed account, claimable balance, and liquidity pool credential addresses — so any transaction carrying such an auth entry crashed the CLI with a raw panic and backtrace. They now return a structured Error::UnsupportedAuthAddress naming the address kind and its strkey.

Why

Part of #2534. Per the ruling in that issue's discussion, muxed accounts are not valid authorizers (confirmed there with dmkozh), so the actionable half of the issue is turning the panics into diagnosable errors — the error text says these addresses "cannot authorize", not "not yet supported". Also refreshes the resolve_secret comment in config/address.rs that pointed at the removed todo!.

Note: PR #2547 attempted this earlier but modifies Dockerfile/entrypoint.sh/docker/README.md, which were removed from main by #2616, and has been conflicting since May. This is a minimal replacement (2 files, no unrelated changes); happy to close in its favor if it gets rebased.

Testing

Three new unit tests (test_{muxed_account,claimable_balance,liquidity_pool}_auth_address_errors_instead_of_panicking) build a transaction with an auth entry for each address kind and assert the structured error — the regression being guarded is "errors, does not panic". cargo test -p soroban-cli --lib signer::: 25 passed. cargo clippy and cargo fmt --check clean.

Copilot

Pull request overview

Replaces panic paths for unsupported Soroban authorization addresses with structured errors.

Changes:

Adds UnsupportedAuthAddress handling for three address variants.
Adds regression tests and updates related documentation.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
`cmd/soroban-cli/src/signer/mod.rs`	Returns structured errors and adds tests.
`cmd/soroban-cli/src/config/address.rs`	Updates muxed-account signing commentary.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+ async fn assert_unsupported_auth_address(address: ScAddress, expected_kind: &str) {
+ let signer = local_signer([1u8; 32]);
+ let source = MuxedAccount::Ed25519(Uint256([9u8; 32]));
+ let contract = [42u8; 32];
+
+ let entry = address_auth(address, invocation(contract, "hello"));
+ let host_fn = HostFunction::InvokeContract(invoke_args(contract, "hello"));
+ let tx = build_tx(source, host_fn, vec![entry]);
+
+ let res = sign_soroban_authorizations(
+ &tx,
+ &[signer],
+ EXPIRATION_LEDGER,
+ NETWORK,
+ false,
+ &Print::new(true),
+ )
+ .await;
+
+ match res {
+ Err(Error::UnsupportedAuthAddress { kind, .. }) => assert_eq!(kind, expected_kind),
+ other => panic!("expected UnsupportedAuthAddress error, got: {other:?}"),
+ }
+ }


+ // when nothing matches. Muxed accounts (`M...`) carry no secret of
+ // their own and are not valid authorizers (see
+ // `Error::UnsupportedAuthAddress` in `sign_soroban_authorizations`),
 // so they keep returning `CannotSign`.


… auth entry addresses An auth entry whose credential address is a muxed account, claimable balance, or liquidity pool crashed the CLI with a raw `todo!()` panic and a backtrace. These ScAddress variants are values, not valid authorizers, so signing now fails with a diagnosable error naming the address kind and its strkey. Also refreshes the resolve_secret comment that pointed at the removed `todo!`. Part of stellar#2534

…nd clarify muxed CannotSign comment

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Galmanus · 2026-08-22T10:42:09Z

What

sign_soroban_authorizations had three todo!() arms — muxed account, claimable balance, and liquidity pool credential addresses — so any transaction carrying such an auth entry crashed the CLI with a raw panic and backtrace. They now return a structured Error::UnsupportedAuthAddress naming the address kind and its strkey.

Why

Part of #2534. Per the ruling in that issue's discussion, muxed accounts are not valid authorizers (confirmed there with dmkozh), so the actionable half of the issue is turning the panics into diagnosable errors — the error text says these addresses "cannot authorize", not "not yet supported". Also refreshes the resolve_secret comment in config/address.rs that pointed at the removed todo!.

Note: PR #2547 attempted this earlier but modifies Dockerfile/entrypoint.sh/docker/README.md, which were removed from main by #2616, and has been conflicting since May. This is a minimal replacement (2 files, no unrelated changes); happy to close in its favor if it gets rebased.

Testing

Three new unit tests (test_{muxed_account,claimable_balance,liquidity_pool}_auth_address_errors_instead_of_panicking) build a transaction with an auth entry for each address kind and assert the structured error — the regression being guarded is "errors, does not panic". cargo test -p soroban-cli --lib signer::: 25 passed. cargo clippy and cargo fmt --check clean.

Copilot

Pull request overview

Replaces panic paths for unsupported Soroban authorization addresses with structured errors.

Changes:

Adds UnsupportedAuthAddress handling for three address variants.
Adds regression tests and updates related documentation.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
`cmd/soroban-cli/src/signer/mod.rs`	Returns structured errors and adds tests.
`cmd/soroban-cli/src/config/address.rs`	Updates muxed-account signing commentary.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+ async fn assert_unsupported_auth_address(address: ScAddress, expected_kind: &str) {
+ let signer = local_signer([1u8; 32]);
+ let source = MuxedAccount::Ed25519(Uint256([9u8; 32]));
+ let contract = [42u8; 32];
+
+ let entry = address_auth(address, invocation(contract, "hello"));
+ let host_fn = HostFunction::InvokeContract(invoke_args(contract, "hello"));
+ let tx = build_tx(source, host_fn, vec![entry]);
+
+ let res = sign_soroban_authorizations(
+ &tx,
+ &[signer],
+ EXPIRATION_LEDGER,
+ NETWORK,
+ false,
+ &Print::new(true),
+ )
+ .await;
+
+ match res {
+ Err(Error::UnsupportedAuthAddress { kind, .. }) => assert_eq!(kind, expected_kind),
+ other => panic!("expected UnsupportedAuthAddress error, got: {other:?}"),
+ }
+ }


+ // when nothing matches. Muxed accounts (`M...`) carry no secret of
+ // their own and are not valid authorizers (see
+ // `Error::UnsupportedAuthAddress` in `sign_soroban_authorizations`),
 // so they keep returning `CannotSign`.


… auth entry addresses An auth entry whose credential address is a muxed account, claimable balance, or liquidity pool crashed the CLI with a raw `todo!()` panic and a backtrace. These ScAddress variants are values, not valid authorizers, so signing now fails with a diagnosable error naming the address kind and its strkey. Also refreshes the resolve_secret comment that pointed at the removed `todo!`. Part of stellar#2534

…nd clarify muxed CannotSign comment

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Galmanus · 2026-08-22T10:42:09Z

What

sign_soroban_authorizations had three todo!() arms — muxed account, claimable balance, and liquidity pool credential addresses — so any transaction carrying such an auth entry crashed the CLI with a raw panic and backtrace. They now return a structured Error::UnsupportedAuthAddress naming the address kind and its strkey.

Why

Part of #2534. Per the ruling in that issue's discussion, muxed accounts are not valid authorizers (confirmed there with dmkozh), so the actionable half of the issue is turning the panics into diagnosable errors — the error text says these addresses "cannot authorize", not "not yet supported". Also refreshes the resolve_secret comment in config/address.rs that pointed at the removed todo!.

Note: PR #2547 attempted this earlier but modifies Dockerfile/entrypoint.sh/docker/README.md, which were removed from main by #2616, and has been conflicting since May. This is a minimal replacement (2 files, no unrelated changes); happy to close in its favor if it gets rebased.

Testing

Three new unit tests (test_{muxed_account,claimable_balance,liquidity_pool}_auth_address_errors_instead_of_panicking) build a transaction with an auth entry for each address kind and assert the structured error — the regression being guarded is "errors, does not panic". cargo test -p soroban-cli --lib signer::: 25 passed. cargo clippy and cargo fmt --check clean.

Copilot

Pull request overview

Replaces panic paths for unsupported Soroban authorization addresses with structured errors.

Changes:

Adds UnsupportedAuthAddress handling for three address variants.
Adds regression tests and updates related documentation.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
`cmd/soroban-cli/src/signer/mod.rs`	Returns structured errors and adds tests.
`cmd/soroban-cli/src/config/address.rs`	Updates muxed-account signing commentary.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+ async fn assert_unsupported_auth_address(address: ScAddress, expected_kind: &str) {
+ let signer = local_signer([1u8; 32]);
+ let source = MuxedAccount::Ed25519(Uint256([9u8; 32]));
+ let contract = [42u8; 32];
+
+ let entry = address_auth(address, invocation(contract, "hello"));
+ let host_fn = HostFunction::InvokeContract(invoke_args(contract, "hello"));
+ let tx = build_tx(source, host_fn, vec![entry]);
+
+ let res = sign_soroban_authorizations(
+ &tx,
+ &[signer],
+ EXPIRATION_LEDGER,
+ NETWORK,
+ false,
+ &Print::new(true),
+ )
+ .await;
+
+ match res {
+ Err(Error::UnsupportedAuthAddress { kind, .. }) => assert_eq!(kind, expected_kind),
+ other => panic!("expected UnsupportedAuthAddress error, got: {other:?}"),
+ }
+ }


+ // when nothing matches. Muxed accounts (`M...`) carry no secret of
+ // their own and are not valid authorizers (see
+ // `Error::UnsupportedAuthAddress` in `sign_soroban_authorizations`),
 // so they keep returning `CannotSign`.


… auth entry addresses An auth entry whose credential address is a muxed account, claimable balance, or liquidity pool crashed the CLI with a raw `todo!()` panic and a backtrace. These ScAddress variants are values, not valid authorizers, so signing now fails with a diagnosable error naming the address kind and its strkey. Also refreshes the resolve_secret comment that pointed at the removed `todo!`. Part of stellar#2534

…nd clarify muxed CannotSign comment

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Galmanus · 2026-08-22T10:42:09Z

What

sign_soroban_authorizations had three todo!() arms — muxed account, claimable balance, and liquidity pool credential addresses — so any transaction carrying such an auth entry crashed the CLI with a raw panic and backtrace. They now return a structured Error::UnsupportedAuthAddress naming the address kind and its strkey.

Why

Part of #2534. Per the ruling in that issue's discussion, muxed accounts are not valid authorizers (confirmed there with dmkozh), so the actionable half of the issue is turning the panics into diagnosable errors — the error text says these addresses "cannot authorize", not "not yet supported". Also refreshes the resolve_secret comment in config/address.rs that pointed at the removed todo!.

Note: PR #2547 attempted this earlier but modifies Dockerfile/entrypoint.sh/docker/README.md, which were removed from main by #2616, and has been conflicting since May. This is a minimal replacement (2 files, no unrelated changes); happy to close in its favor if it gets rebased.

Testing

Three new unit tests (test_{muxed_account,claimable_balance,liquidity_pool}_auth_address_errors_instead_of_panicking) build a transaction with an auth entry for each address kind and assert the structured error — the regression being guarded is "errors, does not panic". cargo test -p soroban-cli --lib signer::: 25 passed. cargo clippy and cargo fmt --check clean.

Copilot

Pull request overview

Replaces panic paths for unsupported Soroban authorization addresses with structured errors.

Changes:

Adds UnsupportedAuthAddress handling for three address variants.
Adds regression tests and updates related documentation.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
`cmd/soroban-cli/src/signer/mod.rs`	Returns structured errors and adds tests.
`cmd/soroban-cli/src/config/address.rs`	Updates muxed-account signing commentary.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+ async fn assert_unsupported_auth_address(address: ScAddress, expected_kind: &str) {
+ let signer = local_signer([1u8; 32]);
+ let source = MuxedAccount::Ed25519(Uint256([9u8; 32]));
+ let contract = [42u8; 32];
+
+ let entry = address_auth(address, invocation(contract, "hello"));
+ let host_fn = HostFunction::InvokeContract(invoke_args(contract, "hello"));
+ let tx = build_tx(source, host_fn, vec![entry]);
+
+ let res = sign_soroban_authorizations(
+ &tx,
+ &[signer],
+ EXPIRATION_LEDGER,
+ NETWORK,
+ false,
+ &Print::new(true),
+ )
+ .await;
+
+ match res {
+ Err(Error::UnsupportedAuthAddress { kind, .. }) => assert_eq!(kind, expected_kind),
+ other => panic!("expected UnsupportedAuthAddress error, got: {other:?}"),
+ }
+ }


+ // when nothing matches. Muxed accounts (`M...`) carry no secret of
+ // their own and are not valid authorizers (see
+ // `Error::UnsupportedAuthAddress` in `sign_soroban_authorizations`),
 // so they keep returning `CannotSign`.


… auth entry addresses An auth entry whose credential address is a muxed account, claimable balance, or liquidity pool crashed the CLI with a raw `todo!()` panic and a backtrace. These ScAddress variants are values, not valid authorizers, so signing now fails with a diagnosable error naming the address kind and its strkey. Also refreshes the resolve_secret comment that pointed at the removed `todo!`. Part of stellar#2534

…nd clarify muxed CannotSign comment

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Galmanus · 2026-08-22T10:42:09Z

What

sign_soroban_authorizations had three todo!() arms — muxed account, claimable balance, and liquidity pool credential addresses — so any transaction carrying such an auth entry crashed the CLI with a raw panic and backtrace. They now return a structured Error::UnsupportedAuthAddress naming the address kind and its strkey.

Why

Part of #2534. Per the ruling in that issue's discussion, muxed accounts are not valid authorizers (confirmed there with dmkozh), so the actionable half of the issue is turning the panics into diagnosable errors — the error text says these addresses "cannot authorize", not "not yet supported". Also refreshes the resolve_secret comment in config/address.rs that pointed at the removed todo!.

Note: PR #2547 attempted this earlier but modifies Dockerfile/entrypoint.sh/docker/README.md, which were removed from main by #2616, and has been conflicting since May. This is a minimal replacement (2 files, no unrelated changes); happy to close in its favor if it gets rebased.

Testing

Three new unit tests (test_{muxed_account,claimable_balance,liquidity_pool}_auth_address_errors_instead_of_panicking) build a transaction with an auth entry for each address kind and assert the structured error — the regression being guarded is "errors, does not panic". cargo test -p soroban-cli --lib signer::: 25 passed. cargo clippy and cargo fmt --check clean.

Copilot

Pull request overview

Replaces panic paths for unsupported Soroban authorization addresses with structured errors.

Changes:

Adds UnsupportedAuthAddress handling for three address variants.
Adds regression tests and updates related documentation.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
`cmd/soroban-cli/src/signer/mod.rs`	Returns structured errors and adds tests.
`cmd/soroban-cli/src/config/address.rs`	Updates muxed-account signing commentary.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+ async fn assert_unsupported_auth_address(address: ScAddress, expected_kind: &str) {
+ let signer = local_signer([1u8; 32]);
+ let source = MuxedAccount::Ed25519(Uint256([9u8; 32]));
+ let contract = [42u8; 32];
+
+ let entry = address_auth(address, invocation(contract, "hello"));
+ let host_fn = HostFunction::InvokeContract(invoke_args(contract, "hello"));
+ let tx = build_tx(source, host_fn, vec![entry]);
+
+ let res = sign_soroban_authorizations(
+ &tx,
+ &[signer],
+ EXPIRATION_LEDGER,
+ NETWORK,
+ false,
+ &Print::new(true),
+ )
+ .await;
+
+ match res {
+ Err(Error::UnsupportedAuthAddress { kind, .. }) => assert_eq!(kind, expected_kind),
+ other => panic!("expected UnsupportedAuthAddress error, got: {other:?}"),
+ }
+ }


+ // when nothing matches. Muxed accounts (`M...`) carry no secret of
+ // their own and are not valid authorizers (see
+ // `Error::UnsupportedAuthAddress` in `sign_soroban_authorizations`),
 // so they keep returning `CannotSign`.


… auth entry addresses An auth entry whose credential address is a muxed account, claimable balance, or liquidity pool crashed the CLI with a raw `todo!()` panic and a backtrace. These ScAddress variants are values, not valid authorizers, so signing now fails with a diagnosable error naming the address kind and its strkey. Also refreshes the resolve_secret comment that pointed at the removed `todo!`. Part of stellar#2534

…nd clarify muxed CannotSign comment

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

CopilotAI balanced review requested due to automatic review settings August 22, 2026 10:42

github-project-automationBot added this to DevX Aug 22, 2026

github-project-automationBot moved this to Backlog (Not Ready) in DevX Aug 22, 2026

Copilotstarted reviewing on behalf of Galmanus August 22, 2026 10:42 View session

CopilotAI reviewed Aug 22, 2026
View reviewed changes

Galmanus added 2 commits September 1, 2026 17:58

test: assert the offending address in UnsupportedAuthAddress errors a…
7a7b3d5
…nd clarify muxed CannotSign comment

CopilotAI review requested due to automatic review settings September 1, 2026 23:05

Galmanus force-pushed the fix/2534-auth-address-panics branch from 576a81d to 7a7b3d5Compare September 1, 2026 23:05

Copilotstarted reviewing on behalf of Galmanus September 1, 2026 23:05 View session

CopilotAI reviewed Sep 1, 2026
View reviewed changes

CopilotAI balanced review requested due to automatic review settings August 22, 2026 10:42

github-project-automationBot added this to DevX Aug 22, 2026

github-project-automationBot moved this to Backlog (Not Ready) in DevX Aug 22, 2026

Copilotstarted reviewing on behalf of Galmanus August 22, 2026 10:42 View session

CopilotAI reviewed Aug 22, 2026
View reviewed changes

Galmanus added 2 commits September 1, 2026 17:58

test: assert the offending address in UnsupportedAuthAddress errors a…
7a7b3d5
…nd clarify muxed CannotSign comment

CopilotAI review requested due to automatic review settings September 1, 2026 23:05

Galmanus force-pushed the fix/2534-auth-address-panics branch from 576a81d to 7a7b3d5Compare September 1, 2026 23:05

Copilotstarted reviewing on behalf of Galmanus September 1, 2026 23:05 View session

CopilotAI reviewed Sep 1, 2026
View reviewed changes

CopilotAI balanced review requested due to automatic review settings August 22, 2026 10:42

github-project-automationBot added this to DevX Aug 22, 2026

github-project-automationBot moved this to Backlog (Not Ready) in DevX Aug 22, 2026

Copilotstarted reviewing on behalf of Galmanus August 22, 2026 10:42 View session

CopilotAI reviewed Aug 22, 2026
View reviewed changes

Galmanus added 2 commits September 1, 2026 17:58

test: assert the offending address in UnsupportedAuthAddress errors a…
7a7b3d5
…nd clarify muxed CannotSign comment

CopilotAI review requested due to automatic review settings September 1, 2026 23:05

Galmanus force-pushed the fix/2534-auth-address-panics branch from 576a81d to 7a7b3d5Compare September 1, 2026 23:05

Copilotstarted reviewing on behalf of Galmanus September 1, 2026 23:05 View session

CopilotAI reviewed Sep 1, 2026
View reviewed changes

CopilotAI balanced review requested due to automatic review settings August 22, 2026 10:42

github-project-automationBot added this to DevX Aug 22, 2026

github-project-automationBot moved this to Backlog (Not Ready) in DevX Aug 22, 2026

Copilotstarted reviewing on behalf of Galmanus August 22, 2026 10:42 View session

CopilotAI reviewed Aug 22, 2026
View reviewed changes

Galmanus added 2 commits September 1, 2026 17:58

test: assert the offending address in UnsupportedAuthAddress errors a…
7a7b3d5
…nd clarify muxed CannotSign comment

CopilotAI review requested due to automatic review settings September 1, 2026 23:05

Galmanus force-pushed the fix/2534-auth-address-panics branch from 576a81d to 7a7b3d5Compare September 1, 2026 23:05

Copilotstarted reviewing on behalf of Galmanus September 1, 2026 23:05 View session

CopilotAI reviewed Sep 1, 2026
View reviewed changes

CopilotAI balanced review requested due to automatic review settings August 22, 2026 10:42

github-project-automationBot added this to DevX Aug 22, 2026

github-project-automationBot moved this to Backlog (Not Ready) in DevX Aug 22, 2026

Copilotstarted reviewing on behalf of Galmanus August 22, 2026 10:42 View session

CopilotAI reviewed Aug 22, 2026
View reviewed changes

Galmanus added 2 commits September 1, 2026 17:58

test: assert the offending address in UnsupportedAuthAddress errors a…
7a7b3d5
…nd clarify muxed CannotSign comment

CopilotAI review requested due to automatic review settings September 1, 2026 23:05

Galmanus force-pushed the fix/2534-auth-address-panics branch from 576a81d to 7a7b3d5Compare September 1, 2026 23:05

Copilotstarted reviewing on behalf of Galmanus September 1, 2026 23:05 View session

CopilotAI reviewed Sep 1, 2026
View reviewed changes

CopilotAI balanced review requested due to automatic review settings August 22, 2026 10:42

github-project-automationBot added this to DevX Aug 22, 2026

github-project-automationBot moved this to Backlog (Not Ready) in DevX Aug 22, 2026

Copilotstarted reviewing on behalf of Galmanus August 22, 2026 10:42 View session

CopilotAI reviewed Aug 22, 2026
View reviewed changes

Galmanus added 2 commits September 1, 2026 17:58

test: assert the offending address in UnsupportedAuthAddress errors a…
7a7b3d5
…nd clarify muxed CannotSign comment

CopilotAI review requested due to automatic review settings September 1, 2026 23:05

Galmanus force-pushed the fix/2534-auth-address-panics branch from 576a81d to 7a7b3d5Compare September 1, 2026 23:05

Copilotstarted reviewing on behalf of Galmanus September 1, 2026 23:05 View session

CopilotAI reviewed Sep 1, 2026
View reviewed changes

CopilotAI balanced review requested due to automatic review settings August 22, 2026 10:42

github-project-automationBot added this to DevX Aug 22, 2026

github-project-automationBot moved this to Backlog (Not Ready) in DevX Aug 22, 2026

Copilotstarted reviewing on behalf of Galmanus August 22, 2026 10:42 View session

CopilotAI reviewed Aug 22, 2026
View reviewed changes

Galmanus added 2 commits September 1, 2026 17:58

test: assert the offending address in UnsupportedAuthAddress errors a…
7a7b3d5
…nd clarify muxed CannotSign comment

CopilotAI review requested due to automatic review settings September 1, 2026 23:05

Galmanus force-pushed the fix/2534-auth-address-panics branch from 576a81d to 7a7b3d5Compare September 1, 2026 23:05

Copilotstarted reviewing on behalf of Galmanus September 1, 2026 23:05 View session

CopilotAI reviewed Sep 1, 2026
View reviewed changes

CopilotAI balanced review requested due to automatic review settings August 22, 2026 10:42

github-project-automationBot added this to DevX Aug 22, 2026

github-project-automationBot moved this to Backlog (Not Ready) in DevX Aug 22, 2026

Copilotstarted reviewing on behalf of Galmanus August 22, 2026 10:42 View session

CopilotAI reviewed Aug 22, 2026
View reviewed changes

Galmanus added 2 commits September 1, 2026 17:58

test: assert the offending address in UnsupportedAuthAddress errors a…
7a7b3d5
…nd clarify muxed CannotSign comment

CopilotAI review requested due to automatic review settings September 1, 2026 23:05

Galmanus force-pushed the fix/2534-auth-address-panics branch from 576a81d to 7a7b3d5Compare September 1, 2026 23:05

Copilotstarted reviewing on behalf of Galmanus September 1, 2026 23:05 View session

CopilotAI reviewed Sep 1, 2026
View reviewed changes

Uh oh!

Conversation

Galmanus commented Aug 22, 2026

What

Why

Testing

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Galmanus commented Aug 22, 2026

What

Why

Testing

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Galmanus commented Aug 22, 2026

What

Why

Testing

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Galmanus commented Aug 22, 2026

What

Why

Testing

Uh oh!

CopilotAI left a comment