fix: warn when tx simulate discards existing signatures by Galmanus · Pull Request #2696 · stellar/stellar-cli

Galmanus · 2026-08-22T10:45:05Z

What

tx simulate silently dropped any signature already attached to the incoming envelope — unwrap_envelope_v1 destructures it and the re-wrapped result always carries an empty signature list. It now warns with the discarded count and the correct order of operations (simulate first, then sign).

Why

This is the concrete pain reported in #2549 (the author's follow-up comment): in a multisig flow, collected signatures vanish with no indication. The signatures are genuinely unusable after simulation — it rewrites the fee and Soroban transaction data, which invalidates them — so preserving them would be wrong; the missing piece was telling the user. This PR references #2549 rather than closing it: the issue also asks for repeated --sign-with-key and broader multisig UX, which are larger design decisions.

Testing

New signature_count helper in tx/xdr.rs with a unit test covering signed and unsigned envelopes; cargo test -p soroban-cli --lib tx::xdr::: 7 passed.
cargo clippy and cargo fmt --check clean.

Copilot

Pull request overview

Warns users when tx simulate invalidates and removes existing transaction signatures.

Changes:

Adds a helper to count envelope signatures.
Emits a simulation warning with the discarded count and correct workflow.
Adds unit coverage for signed and unsigned v1 envelopes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
`cmd/soroban-cli/src/commands/tx/xdr.rs`	Adds signature counting and unit tests.
`cmd/soroban-cli/src/commands/tx/simulate.rs`	Warns before dropping signatures during simulation.

Suppressed comments (1)

cmd/soroban-cli/src/commands/tx/simulate.rs:74

Add an integration test that passes a signed envelope through tx simulate and asserts the warning text/count on stderr and an unsigned simulated envelope on stdout. The added unit test only exercises signature_count, so it would still pass if this command never emitted the warning; command-level integration tests already live in cmd/crates/soroban-test/tests/it/integration/tx/general.rs:12-44, and repository guidance requires command behavior changes to be covered there.

 if discarded > 0 {
print.warnln(format!(
"Discarding {discarded} existing signature(s): simulation changes the \
transaction's fee and resources, which invalidates prior signatures. \
Simulate first, then sign the result."

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

`tx simulate` silently dropped any signature already attached to the incoming envelope: `unwrap_envelope_v1` destructures the envelope and the re-wrapped result always carries an empty signature list. The signatures are genuinely unusable — simulation rewrites the fee and Soroban transaction data, invalidating them — but dropping them without a word leaves users of multisig flows wondering where their signatures went. Emit a warning naming the count and the correct order (simulate first, then sign), next to the existing fee-bump warning. Ref stellar#2549

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

+ match tx_env {
+ TransactionEnvelope::TxV0(e) => e.signatures.len(),
+ TransactionEnvelope::Tx(e) => e.signatures.len(),
+ TransactionEnvelope::TxFeeBump(e) => e.signatures.len(),


+ if discarded > 0 {
+ print.warnln(format!(
+ "Discarding {discarded} existing signature(s): simulation changes the \
+ transaction's fee and resources, which invalidates prior signatures. \
+ Simulate first, then sign the result."


Galmanus · 2026-08-22T10:45:05Z

What

tx simulate silently dropped any signature already attached to the incoming envelope — unwrap_envelope_v1 destructures it and the re-wrapped result always carries an empty signature list. It now warns with the discarded count and the correct order of operations (simulate first, then sign).

Why

This is the concrete pain reported in #2549 (the author's follow-up comment): in a multisig flow, collected signatures vanish with no indication. The signatures are genuinely unusable after simulation — it rewrites the fee and Soroban transaction data, which invalidates them — so preserving them would be wrong; the missing piece was telling the user. This PR references #2549 rather than closing it: the issue also asks for repeated --sign-with-key and broader multisig UX, which are larger design decisions.

Testing

New signature_count helper in tx/xdr.rs with a unit test covering signed and unsigned envelopes; cargo test -p soroban-cli --lib tx::xdr::: 7 passed.
cargo clippy and cargo fmt --check clean.

Copilot

Pull request overview

Warns users when tx simulate invalidates and removes existing transaction signatures.

Changes:

Adds a helper to count envelope signatures.
Emits a simulation warning with the discarded count and correct workflow.
Adds unit coverage for signed and unsigned v1 envelopes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
`cmd/soroban-cli/src/commands/tx/xdr.rs`	Adds signature counting and unit tests.
`cmd/soroban-cli/src/commands/tx/simulate.rs`	Warns before dropping signatures during simulation.

Suppressed comments (1)

cmd/soroban-cli/src/commands/tx/simulate.rs:74

Add an integration test that passes a signed envelope through tx simulate and asserts the warning text/count on stderr and an unsigned simulated envelope on stdout. The added unit test only exercises signature_count, so it would still pass if this command never emitted the warning; command-level integration tests already live in cmd/crates/soroban-test/tests/it/integration/tx/general.rs:12-44, and repository guidance requires command behavior changes to be covered there.

 if discarded > 0 {
print.warnln(format!(
"Discarding {discarded} existing signature(s): simulation changes the \
transaction's fee and resources, which invalidates prior signatures. \
Simulate first, then sign the result."

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

`tx simulate` silently dropped any signature already attached to the incoming envelope: `unwrap_envelope_v1` destructures the envelope and the re-wrapped result always carries an empty signature list. The signatures are genuinely unusable — simulation rewrites the fee and Soroban transaction data, invalidating them — but dropping them without a word leaves users of multisig flows wondering where their signatures went. Emit a warning naming the count and the correct order (simulate first, then sign), next to the existing fee-bump warning. Ref stellar#2549

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

+ match tx_env {
+ TransactionEnvelope::TxV0(e) => e.signatures.len(),
+ TransactionEnvelope::Tx(e) => e.signatures.len(),
+ TransactionEnvelope::TxFeeBump(e) => e.signatures.len(),


+ if discarded > 0 {
+ print.warnln(format!(
+ "Discarding {discarded} existing signature(s): simulation changes the \
+ transaction's fee and resources, which invalidates prior signatures. \
+ Simulate first, then sign the result."


Galmanus · 2026-08-22T10:45:05Z

What

tx simulate silently dropped any signature already attached to the incoming envelope — unwrap_envelope_v1 destructures it and the re-wrapped result always carries an empty signature list. It now warns with the discarded count and the correct order of operations (simulate first, then sign).

Why

This is the concrete pain reported in #2549 (the author's follow-up comment): in a multisig flow, collected signatures vanish with no indication. The signatures are genuinely unusable after simulation — it rewrites the fee and Soroban transaction data, which invalidates them — so preserving them would be wrong; the missing piece was telling the user. This PR references #2549 rather than closing it: the issue also asks for repeated --sign-with-key and broader multisig UX, which are larger design decisions.

Testing

New signature_count helper in tx/xdr.rs with a unit test covering signed and unsigned envelopes; cargo test -p soroban-cli --lib tx::xdr::: 7 passed.
cargo clippy and cargo fmt --check clean.

Copilot

Pull request overview

Warns users when tx simulate invalidates and removes existing transaction signatures.

Changes:

Adds a helper to count envelope signatures.
Emits a simulation warning with the discarded count and correct workflow.
Adds unit coverage for signed and unsigned v1 envelopes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
`cmd/soroban-cli/src/commands/tx/xdr.rs`	Adds signature counting and unit tests.
`cmd/soroban-cli/src/commands/tx/simulate.rs`	Warns before dropping signatures during simulation.

Suppressed comments (1)

cmd/soroban-cli/src/commands/tx/simulate.rs:74

Add an integration test that passes a signed envelope through tx simulate and asserts the warning text/count on stderr and an unsigned simulated envelope on stdout. The added unit test only exercises signature_count, so it would still pass if this command never emitted the warning; command-level integration tests already live in cmd/crates/soroban-test/tests/it/integration/tx/general.rs:12-44, and repository guidance requires command behavior changes to be covered there.

 if discarded > 0 {
print.warnln(format!(
"Discarding {discarded} existing signature(s): simulation changes the \
transaction's fee and resources, which invalidates prior signatures. \
Simulate first, then sign the result."

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

`tx simulate` silently dropped any signature already attached to the incoming envelope: `unwrap_envelope_v1` destructures the envelope and the re-wrapped result always carries an empty signature list. The signatures are genuinely unusable — simulation rewrites the fee and Soroban transaction data, invalidating them — but dropping them without a word leaves users of multisig flows wondering where their signatures went. Emit a warning naming the count and the correct order (simulate first, then sign), next to the existing fee-bump warning. Ref stellar#2549

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

+ match tx_env {
+ TransactionEnvelope::TxV0(e) => e.signatures.len(),
+ TransactionEnvelope::Tx(e) => e.signatures.len(),
+ TransactionEnvelope::TxFeeBump(e) => e.signatures.len(),


+ if discarded > 0 {
+ print.warnln(format!(
+ "Discarding {discarded} existing signature(s): simulation changes the \
+ transaction's fee and resources, which invalidates prior signatures. \
+ Simulate first, then sign the result."


Galmanus · 2026-08-22T10:45:05Z

What

tx simulate silently dropped any signature already attached to the incoming envelope — unwrap_envelope_v1 destructures it and the re-wrapped result always carries an empty signature list. It now warns with the discarded count and the correct order of operations (simulate first, then sign).

Why

This is the concrete pain reported in #2549 (the author's follow-up comment): in a multisig flow, collected signatures vanish with no indication. The signatures are genuinely unusable after simulation — it rewrites the fee and Soroban transaction data, which invalidates them — so preserving them would be wrong; the missing piece was telling the user. This PR references #2549 rather than closing it: the issue also asks for repeated --sign-with-key and broader multisig UX, which are larger design decisions.

Testing

New signature_count helper in tx/xdr.rs with a unit test covering signed and unsigned envelopes; cargo test -p soroban-cli --lib tx::xdr::: 7 passed.
cargo clippy and cargo fmt --check clean.

Copilot

Pull request overview

Warns users when tx simulate invalidates and removes existing transaction signatures.

Changes:

Adds a helper to count envelope signatures.
Emits a simulation warning with the discarded count and correct workflow.
Adds unit coverage for signed and unsigned v1 envelopes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
`cmd/soroban-cli/src/commands/tx/xdr.rs`	Adds signature counting and unit tests.
`cmd/soroban-cli/src/commands/tx/simulate.rs`	Warns before dropping signatures during simulation.

Suppressed comments (1)

cmd/soroban-cli/src/commands/tx/simulate.rs:74

Add an integration test that passes a signed envelope through tx simulate and asserts the warning text/count on stderr and an unsigned simulated envelope on stdout. The added unit test only exercises signature_count, so it would still pass if this command never emitted the warning; command-level integration tests already live in cmd/crates/soroban-test/tests/it/integration/tx/general.rs:12-44, and repository guidance requires command behavior changes to be covered there.

 if discarded > 0 {
print.warnln(format!(
"Discarding {discarded} existing signature(s): simulation changes the \
transaction's fee and resources, which invalidates prior signatures. \
Simulate first, then sign the result."

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

`tx simulate` silently dropped any signature already attached to the incoming envelope: `unwrap_envelope_v1` destructures the envelope and the re-wrapped result always carries an empty signature list. The signatures are genuinely unusable — simulation rewrites the fee and Soroban transaction data, invalidating them — but dropping them without a word leaves users of multisig flows wondering where their signatures went. Emit a warning naming the count and the correct order (simulate first, then sign), next to the existing fee-bump warning. Ref stellar#2549

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

+ match tx_env {
+ TransactionEnvelope::TxV0(e) => e.signatures.len(),
+ TransactionEnvelope::Tx(e) => e.signatures.len(),
+ TransactionEnvelope::TxFeeBump(e) => e.signatures.len(),


+ if discarded > 0 {
+ print.warnln(format!(
+ "Discarding {discarded} existing signature(s): simulation changes the \
+ transaction's fee and resources, which invalidates prior signatures. \
+ Simulate first, then sign the result."


Galmanus · 2026-08-22T10:45:05Z

What

tx simulate silently dropped any signature already attached to the incoming envelope — unwrap_envelope_v1 destructures it and the re-wrapped result always carries an empty signature list. It now warns with the discarded count and the correct order of operations (simulate first, then sign).

Why

This is the concrete pain reported in #2549 (the author's follow-up comment): in a multisig flow, collected signatures vanish with no indication. The signatures are genuinely unusable after simulation — it rewrites the fee and Soroban transaction data, which invalidates them — so preserving them would be wrong; the missing piece was telling the user. This PR references #2549 rather than closing it: the issue also asks for repeated --sign-with-key and broader multisig UX, which are larger design decisions.

Testing

New signature_count helper in tx/xdr.rs with a unit test covering signed and unsigned envelopes; cargo test -p soroban-cli --lib tx::xdr::: 7 passed.
cargo clippy and cargo fmt --check clean.

Copilot

Pull request overview

Warns users when tx simulate invalidates and removes existing transaction signatures.

Changes:

Adds a helper to count envelope signatures.
Emits a simulation warning with the discarded count and correct workflow.
Adds unit coverage for signed and unsigned v1 envelopes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
`cmd/soroban-cli/src/commands/tx/xdr.rs`	Adds signature counting and unit tests.
`cmd/soroban-cli/src/commands/tx/simulate.rs`	Warns before dropping signatures during simulation.

Suppressed comments (1)

cmd/soroban-cli/src/commands/tx/simulate.rs:74

Add an integration test that passes a signed envelope through tx simulate and asserts the warning text/count on stderr and an unsigned simulated envelope on stdout. The added unit test only exercises signature_count, so it would still pass if this command never emitted the warning; command-level integration tests already live in cmd/crates/soroban-test/tests/it/integration/tx/general.rs:12-44, and repository guidance requires command behavior changes to be covered there.

 if discarded > 0 {
print.warnln(format!(
"Discarding {discarded} existing signature(s): simulation changes the \
transaction's fee and resources, which invalidates prior signatures. \
Simulate first, then sign the result."

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

`tx simulate` silently dropped any signature already attached to the incoming envelope: `unwrap_envelope_v1` destructures the envelope and the re-wrapped result always carries an empty signature list. The signatures are genuinely unusable — simulation rewrites the fee and Soroban transaction data, invalidating them — but dropping them without a word leaves users of multisig flows wondering where their signatures went. Emit a warning naming the count and the correct order (simulate first, then sign), next to the existing fee-bump warning. Ref stellar#2549

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

+ match tx_env {
+ TransactionEnvelope::TxV0(e) => e.signatures.len(),
+ TransactionEnvelope::Tx(e) => e.signatures.len(),
+ TransactionEnvelope::TxFeeBump(e) => e.signatures.len(),


+ if discarded > 0 {
+ print.warnln(format!(
+ "Discarding {discarded} existing signature(s): simulation changes the \
+ transaction's fee and resources, which invalidates prior signatures. \
+ Simulate first, then sign the result."


Galmanus · 2026-08-22T10:45:05Z

What

tx simulate silently dropped any signature already attached to the incoming envelope — unwrap_envelope_v1 destructures it and the re-wrapped result always carries an empty signature list. It now warns with the discarded count and the correct order of operations (simulate first, then sign).

Why

This is the concrete pain reported in #2549 (the author's follow-up comment): in a multisig flow, collected signatures vanish with no indication. The signatures are genuinely unusable after simulation — it rewrites the fee and Soroban transaction data, which invalidates them — so preserving them would be wrong; the missing piece was telling the user. This PR references #2549 rather than closing it: the issue also asks for repeated --sign-with-key and broader multisig UX, which are larger design decisions.

Testing

New signature_count helper in tx/xdr.rs with a unit test covering signed and unsigned envelopes; cargo test -p soroban-cli --lib tx::xdr::: 7 passed.
cargo clippy and cargo fmt --check clean.

Copilot

Pull request overview

Warns users when tx simulate invalidates and removes existing transaction signatures.

Changes:

Adds a helper to count envelope signatures.
Emits a simulation warning with the discarded count and correct workflow.
Adds unit coverage for signed and unsigned v1 envelopes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
`cmd/soroban-cli/src/commands/tx/xdr.rs`	Adds signature counting and unit tests.
`cmd/soroban-cli/src/commands/tx/simulate.rs`	Warns before dropping signatures during simulation.

Suppressed comments (1)

cmd/soroban-cli/src/commands/tx/simulate.rs:74

Add an integration test that passes a signed envelope through tx simulate and asserts the warning text/count on stderr and an unsigned simulated envelope on stdout. The added unit test only exercises signature_count, so it would still pass if this command never emitted the warning; command-level integration tests already live in cmd/crates/soroban-test/tests/it/integration/tx/general.rs:12-44, and repository guidance requires command behavior changes to be covered there.

 if discarded > 0 {
print.warnln(format!(
"Discarding {discarded} existing signature(s): simulation changes the \
transaction's fee and resources, which invalidates prior signatures. \
Simulate first, then sign the result."

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

`tx simulate` silently dropped any signature already attached to the incoming envelope: `unwrap_envelope_v1` destructures the envelope and the re-wrapped result always carries an empty signature list. The signatures are genuinely unusable — simulation rewrites the fee and Soroban transaction data, invalidating them — but dropping them without a word leaves users of multisig flows wondering where their signatures went. Emit a warning naming the count and the correct order (simulate first, then sign), next to the existing fee-bump warning. Ref stellar#2549

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

+ match tx_env {
+ TransactionEnvelope::TxV0(e) => e.signatures.len(),
+ TransactionEnvelope::Tx(e) => e.signatures.len(),
+ TransactionEnvelope::TxFeeBump(e) => e.signatures.len(),


+ if discarded > 0 {
+ print.warnln(format!(
+ "Discarding {discarded} existing signature(s): simulation changes the \
+ transaction's fee and resources, which invalidates prior signatures. \
+ Simulate first, then sign the result."


Galmanus · 2026-08-22T10:45:05Z

What

tx simulate silently dropped any signature already attached to the incoming envelope — unwrap_envelope_v1 destructures it and the re-wrapped result always carries an empty signature list. It now warns with the discarded count and the correct order of operations (simulate first, then sign).

Why

This is the concrete pain reported in #2549 (the author's follow-up comment): in a multisig flow, collected signatures vanish with no indication. The signatures are genuinely unusable after simulation — it rewrites the fee and Soroban transaction data, which invalidates them — so preserving them would be wrong; the missing piece was telling the user. This PR references #2549 rather than closing it: the issue also asks for repeated --sign-with-key and broader multisig UX, which are larger design decisions.

Testing

New signature_count helper in tx/xdr.rs with a unit test covering signed and unsigned envelopes; cargo test -p soroban-cli --lib tx::xdr::: 7 passed.
cargo clippy and cargo fmt --check clean.

Copilot

Pull request overview

Warns users when tx simulate invalidates and removes existing transaction signatures.

Changes:

Adds a helper to count envelope signatures.
Emits a simulation warning with the discarded count and correct workflow.
Adds unit coverage for signed and unsigned v1 envelopes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
`cmd/soroban-cli/src/commands/tx/xdr.rs`	Adds signature counting and unit tests.
`cmd/soroban-cli/src/commands/tx/simulate.rs`	Warns before dropping signatures during simulation.

Suppressed comments (1)

cmd/soroban-cli/src/commands/tx/simulate.rs:74

Add an integration test that passes a signed envelope through tx simulate and asserts the warning text/count on stderr and an unsigned simulated envelope on stdout. The added unit test only exercises signature_count, so it would still pass if this command never emitted the warning; command-level integration tests already live in cmd/crates/soroban-test/tests/it/integration/tx/general.rs:12-44, and repository guidance requires command behavior changes to be covered there.

 if discarded > 0 {
print.warnln(format!(
"Discarding {discarded} existing signature(s): simulation changes the \
transaction's fee and resources, which invalidates prior signatures. \
Simulate first, then sign the result."

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

`tx simulate` silently dropped any signature already attached to the incoming envelope: `unwrap_envelope_v1` destructures the envelope and the re-wrapped result always carries an empty signature list. The signatures are genuinely unusable — simulation rewrites the fee and Soroban transaction data, invalidating them — but dropping them without a word leaves users of multisig flows wondering where their signatures went. Emit a warning naming the count and the correct order (simulate first, then sign), next to the existing fee-bump warning. Ref stellar#2549

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

+ match tx_env {
+ TransactionEnvelope::TxV0(e) => e.signatures.len(),
+ TransactionEnvelope::Tx(e) => e.signatures.len(),
+ TransactionEnvelope::TxFeeBump(e) => e.signatures.len(),


+ if discarded > 0 {
+ print.warnln(format!(
+ "Discarding {discarded} existing signature(s): simulation changes the \
+ transaction's fee and resources, which invalidates prior signatures. \
+ Simulate first, then sign the result."


Galmanus · 2026-08-22T10:45:05Z

What

tx simulate silently dropped any signature already attached to the incoming envelope — unwrap_envelope_v1 destructures it and the re-wrapped result always carries an empty signature list. It now warns with the discarded count and the correct order of operations (simulate first, then sign).

Why

This is the concrete pain reported in #2549 (the author's follow-up comment): in a multisig flow, collected signatures vanish with no indication. The signatures are genuinely unusable after simulation — it rewrites the fee and Soroban transaction data, which invalidates them — so preserving them would be wrong; the missing piece was telling the user. This PR references #2549 rather than closing it: the issue also asks for repeated --sign-with-key and broader multisig UX, which are larger design decisions.

Testing

New signature_count helper in tx/xdr.rs with a unit test covering signed and unsigned envelopes; cargo test -p soroban-cli --lib tx::xdr::: 7 passed.
cargo clippy and cargo fmt --check clean.

Copilot

Pull request overview

Warns users when tx simulate invalidates and removes existing transaction signatures.

Changes:

Adds a helper to count envelope signatures.
Emits a simulation warning with the discarded count and correct workflow.
Adds unit coverage for signed and unsigned v1 envelopes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
`cmd/soroban-cli/src/commands/tx/xdr.rs`	Adds signature counting and unit tests.
`cmd/soroban-cli/src/commands/tx/simulate.rs`	Warns before dropping signatures during simulation.

Suppressed comments (1)

cmd/soroban-cli/src/commands/tx/simulate.rs:74

Add an integration test that passes a signed envelope through tx simulate and asserts the warning text/count on stderr and an unsigned simulated envelope on stdout. The added unit test only exercises signature_count, so it would still pass if this command never emitted the warning; command-level integration tests already live in cmd/crates/soroban-test/tests/it/integration/tx/general.rs:12-44, and repository guidance requires command behavior changes to be covered there.

 if discarded > 0 {
print.warnln(format!(
"Discarding {discarded} existing signature(s): simulation changes the \
transaction's fee and resources, which invalidates prior signatures. \
Simulate first, then sign the result."

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

`tx simulate` silently dropped any signature already attached to the incoming envelope: `unwrap_envelope_v1` destructures the envelope and the re-wrapped result always carries an empty signature list. The signatures are genuinely unusable — simulation rewrites the fee and Soroban transaction data, invalidating them — but dropping them without a word leaves users of multisig flows wondering where their signatures went. Emit a warning naming the count and the correct order (simulate first, then sign), next to the existing fee-bump warning. Ref stellar#2549

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

+ match tx_env {
+ TransactionEnvelope::TxV0(e) => e.signatures.len(),
+ TransactionEnvelope::Tx(e) => e.signatures.len(),
+ TransactionEnvelope::TxFeeBump(e) => e.signatures.len(),


+ if discarded > 0 {
+ print.warnln(format!(
+ "Discarding {discarded} existing signature(s): simulation changes the \
+ transaction's fee and resources, which invalidates prior signatures. \
+ Simulate first, then sign the result."


CopilotAI balanced review requested due to automatic review settings August 22, 2026 10:45

github-project-automationBot added this to DevX Aug 22, 2026

github-project-automationBot moved this to Backlog (Not Ready) in DevX Aug 22, 2026

Copilotstarted reviewing on behalf of Galmanus August 22, 2026 10:45 View session

CopilotAI reviewed Aug 22, 2026
View reviewed changes

Comment threadcmd/soroban-cli/src/commands/tx/simulate.rs Outdated

Galmanus added 2 commits September 1, 2026 17:58

fix: only warn about discarded signatures for v1 tx envelopes
341ea84

CopilotAI review requested due to automatic review settings September 1, 2026 23:05

Galmanus force-pushed the fix/2549-simulate-drops-signatures branch from 19aab5a to 341ea84Compare September 1, 2026 23:05

Copilotstarted reviewing on behalf of Galmanus September 1, 2026 23:06 View session

CopilotAI reviewed Sep 1, 2026
View reviewed changes

CopilotAI balanced review requested due to automatic review settings August 22, 2026 10:45

github-project-automationBot added this to DevX Aug 22, 2026

github-project-automationBot moved this to Backlog (Not Ready) in DevX Aug 22, 2026

Copilotstarted reviewing on behalf of Galmanus August 22, 2026 10:45 View session

CopilotAI reviewed Aug 22, 2026
View reviewed changes

Comment threadcmd/soroban-cli/src/commands/tx/simulate.rs Outdated

Galmanus added 2 commits September 1, 2026 17:58

fix: only warn about discarded signatures for v1 tx envelopes
341ea84

CopilotAI review requested due to automatic review settings September 1, 2026 23:05

Galmanus force-pushed the fix/2549-simulate-drops-signatures branch from 19aab5a to 341ea84Compare September 1, 2026 23:05

Copilotstarted reviewing on behalf of Galmanus September 1, 2026 23:06 View session

CopilotAI reviewed Sep 1, 2026
View reviewed changes

CopilotAI balanced review requested due to automatic review settings August 22, 2026 10:45

github-project-automationBot added this to DevX Aug 22, 2026

github-project-automationBot moved this to Backlog (Not Ready) in DevX Aug 22, 2026

Copilotstarted reviewing on behalf of Galmanus August 22, 2026 10:45 View session

CopilotAI reviewed Aug 22, 2026
View reviewed changes

Comment threadcmd/soroban-cli/src/commands/tx/simulate.rs Outdated

Galmanus added 2 commits September 1, 2026 17:58

fix: only warn about discarded signatures for v1 tx envelopes
341ea84

CopilotAI review requested due to automatic review settings September 1, 2026 23:05

Galmanus force-pushed the fix/2549-simulate-drops-signatures branch from 19aab5a to 341ea84Compare September 1, 2026 23:05

Copilotstarted reviewing on behalf of Galmanus September 1, 2026 23:06 View session

CopilotAI reviewed Sep 1, 2026
View reviewed changes

CopilotAI balanced review requested due to automatic review settings August 22, 2026 10:45

github-project-automationBot added this to DevX Aug 22, 2026

github-project-automationBot moved this to Backlog (Not Ready) in DevX Aug 22, 2026

Copilotstarted reviewing on behalf of Galmanus August 22, 2026 10:45 View session

CopilotAI reviewed Aug 22, 2026
View reviewed changes

Comment threadcmd/soroban-cli/src/commands/tx/simulate.rs Outdated

Galmanus added 2 commits September 1, 2026 17:58

fix: only warn about discarded signatures for v1 tx envelopes
341ea84

CopilotAI review requested due to automatic review settings September 1, 2026 23:05

Galmanus force-pushed the fix/2549-simulate-drops-signatures branch from 19aab5a to 341ea84Compare September 1, 2026 23:05

Copilotstarted reviewing on behalf of Galmanus September 1, 2026 23:06 View session

CopilotAI reviewed Sep 1, 2026
View reviewed changes

CopilotAI balanced review requested due to automatic review settings August 22, 2026 10:45

github-project-automationBot added this to DevX Aug 22, 2026

github-project-automationBot moved this to Backlog (Not Ready) in DevX Aug 22, 2026

Copilotstarted reviewing on behalf of Galmanus August 22, 2026 10:45 View session

CopilotAI reviewed Aug 22, 2026
View reviewed changes

Comment threadcmd/soroban-cli/src/commands/tx/simulate.rs Outdated

Galmanus added 2 commits September 1, 2026 17:58

fix: only warn about discarded signatures for v1 tx envelopes
341ea84

CopilotAI review requested due to automatic review settings September 1, 2026 23:05

Galmanus force-pushed the fix/2549-simulate-drops-signatures branch from 19aab5a to 341ea84Compare September 1, 2026 23:05

Copilotstarted reviewing on behalf of Galmanus September 1, 2026 23:06 View session

CopilotAI reviewed Sep 1, 2026
View reviewed changes

CopilotAI balanced review requested due to automatic review settings August 22, 2026 10:45

github-project-automationBot added this to DevX Aug 22, 2026

github-project-automationBot moved this to Backlog (Not Ready) in DevX Aug 22, 2026

Copilotstarted reviewing on behalf of Galmanus August 22, 2026 10:45 View session

CopilotAI reviewed Aug 22, 2026
View reviewed changes

Comment threadcmd/soroban-cli/src/commands/tx/simulate.rs Outdated

Galmanus added 2 commits September 1, 2026 17:58

fix: only warn about discarded signatures for v1 tx envelopes
341ea84

CopilotAI review requested due to automatic review settings September 1, 2026 23:05

Galmanus force-pushed the fix/2549-simulate-drops-signatures branch from 19aab5a to 341ea84Compare September 1, 2026 23:05

Copilotstarted reviewing on behalf of Galmanus September 1, 2026 23:06 View session

CopilotAI reviewed Sep 1, 2026
View reviewed changes

CopilotAI balanced review requested due to automatic review settings August 22, 2026 10:45

github-project-automationBot added this to DevX Aug 22, 2026

github-project-automationBot moved this to Backlog (Not Ready) in DevX Aug 22, 2026

Copilotstarted reviewing on behalf of Galmanus August 22, 2026 10:45 View session

CopilotAI reviewed Aug 22, 2026
View reviewed changes

Comment threadcmd/soroban-cli/src/commands/tx/simulate.rs Outdated

Galmanus added 2 commits September 1, 2026 17:58

fix: only warn about discarded signatures for v1 tx envelopes
341ea84

CopilotAI review requested due to automatic review settings September 1, 2026 23:05

Galmanus force-pushed the fix/2549-simulate-drops-signatures branch from 19aab5a to 341ea84Compare September 1, 2026 23:05

Copilotstarted reviewing on behalf of Galmanus September 1, 2026 23:06 View session

CopilotAI reviewed Sep 1, 2026
View reviewed changes

CopilotAI balanced review requested due to automatic review settings August 22, 2026 10:45

github-project-automationBot added this to DevX Aug 22, 2026

github-project-automationBot moved this to Backlog (Not Ready) in DevX Aug 22, 2026

Copilotstarted reviewing on behalf of Galmanus August 22, 2026 10:45 View session

CopilotAI reviewed Aug 22, 2026
View reviewed changes

Comment threadcmd/soroban-cli/src/commands/tx/simulate.rs Outdated

Galmanus added 2 commits September 1, 2026 17:58

fix: only warn about discarded signatures for v1 tx envelopes
341ea84

CopilotAI review requested due to automatic review settings September 1, 2026 23:05

Galmanus force-pushed the fix/2549-simulate-drops-signatures branch from 19aab5a to 341ea84Compare September 1, 2026 23:05

Copilotstarted reviewing on behalf of Galmanus September 1, 2026 23:06 View session

CopilotAI reviewed Sep 1, 2026
View reviewed changes

Uh oh!

Conversation

Galmanus commented Aug 22, 2026

What

Why

Testing

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Galmanus commented Aug 22, 2026

What

Why

Testing

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Galmanus commented Aug 22, 2026

What

Why

Testing

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Galmanus commented Aug 22, 2026

What

Why