Conversation
sisuresh
approved these changes
Aug 15, 2024
Jonathan-Eid
added a commit
to Jonathan-Eid/supercluster
that referenced
this pull request
Aug 27, 2026
The reserve was subtracted from the idle pool alone, but `outstanding` counts in-progress jobs too, and those already have a worker each. With 1000 workers, 700 busy and 700 jobs outstanding, the surplus came out as 300 - 700 and nothing was marked at all: 300 idle workers were held to cover work that was already being served. Counting the surplus against every unmarked worker gives 1000 - 700 = 300, and those 300 idle workers are marked. Only idle workers are ever marked, and the reserve still keeps `max outstanding minUnmarkedWorkers` workers unmarked, so a requeued job still has somewhere to go -- an unmarked busy worker becomes claimable as soon as it finishes. Run stellar#192 never sat in that state: in-progress fell from 1022 to 80 in three minutes, so the largest instantaneous gap was about 80 workers and retirement was capped at 32 a pass throughout. A run whose ranges vary enough for in-progress to decay gradually would sit there and mark nothing.
Jonathan-Eid
added a commit
to Jonathan-Eid/supercluster
that referenced
this pull request
Aug 27, 2026
Per-worker StatefulSets renamed pods to <release>-stellar-core-<i>-0, so the last hyphen-separated segment is the StatefulSet's own -0 suffix rather than the worker index. Every metrics record in run stellar#192 reported core_id 0. Nothing consumes the field -- the monitor discards it and keeps only the two durations -- but a value that is always 0 reads as real data, so pass the index the chart already has.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.