Skip to content

feat(aiagents): detect package install in compound shell commands#89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raysubham wants to merge 1 commit into
base:main
Choose a base branch
from
Open

feat(aiagents): detect package install in compound shell commands #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 102 additions & 0 deletions internal/aiagents/enrich/npm/detect.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -29,7 +29,28 @@ type Detection struct {
}

// Detect parses cmd and returns the package-manager classification, or nil.
// Compound shell commands joined by &&, ||, ;, |, &, or newline are split into
// segments and each is classified independently; the strongest detection wins
// (install > uninstall > publish > audit > exec > other).
func Detect(cmd string) *Detection {
segments := splitShellSegments(cmd)
if len(segments) == 0 {
segments = []string{cmd}
}
var best *Detection
for _, seg := range segments {
d := detectSegment(seg)
if d == nil {
continue
}
if best == nil || kindRank(d.CommandKind) > kindRank(best.CommandKind) {
best = d
}
}
return best
}

func detectSegment(cmd string) *Detection {
tokens, err := shlex.Split(cmd)
if err != nil || len(tokens) == 0 {
// Fall back to whitespace split; shlex fails on unbalanced quotes.
Expand DownExpand Up@@ -60,6 +81,87 @@ func Detect(cmd string) *Detection {
}
}

// splitShellSegments splits cmd at unquoted shell control operators
// (&&, ||, ;, |, &, newline). Single and double quotes are respected;
// backslash escapes the next byte outside single quotes.
func splitShellSegments(cmd string) []string {
var (
segments []string
cur strings.Builder
inSingle bool
inDouble bool
)
flush := func() {
s := strings.TrimSpace(cur.String())
if s != "" {
segments = append(segments, s)
}
cur.Reset()
}
for i := 0; i < len(cmd); i++ {
c := cmd[i]
if !inSingle && c == '\\' && i+1 < len(cmd) {
cur.WriteByte(c)
cur.WriteByte(cmd[i+1])
i++
continue
}
if !inDouble && c == '\'' {
inSingle = !inSingle
cur.WriteByte(c)
continue
}
if !inSingle && c == '"' {
inDouble = !inDouble
cur.WriteByte(c)
continue
}
if !inSingle && !inDouble {
switch c {
case '\n', ';':
flush()
continue
case '&':
if i+1 < len(cmd) && cmd[i+1] == '&' {
flush()
i++
continue
}
flush()
continue
case '|':
if i+1 < len(cmd) && cmd[i+1] == '|' {
flush()
i++
continue
}
flush()
continue
}
}
cur.WriteByte(c)
}
flush()
return segments
}

func kindRank(kind string) int {
switch kind {
case "install":
return 6
case "uninstall":
return 5
case "publish":
return 4
case "audit":
return 3
case "exec":
return 2
default:
return 1
}
}

func managerFromBinary(bin string) (Manager, bool) {
switch bin {
case "npm":
Expand Down
51 changes: 51 additions & 0 deletions internal/aiagents/enrich/npm/detect_test.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -67,6 +67,57 @@ func TestDetectIgnoresUnrelatedCommands(t *testing.T) {
}
}

func TestDetectCompoundCommands(t *testing.T) {
cases := []struct {
cmd string
want Manager
kind string
}{
{"cd /tmp/app && pnpm install && pnpm run build", PNPM, "install"},
{"cd /tmp/app && pnpm install", PNPM, "install"},
{"npm ci && npm run build", NPM, "install"},
{"pnpm run build && pnpm install", PNPM, "install"},
{"npx -y create-vite my-app && cd my-app && pnpm install", PNPM, "install"},
{"echo hi; yarn add lodash", Yarn, "install"},
{"pnpm install || echo failed", PNPM, "install"},
{"cat package.json | jq . && pnpm i", PNPM, "install"},
{"cd /tmp && pnpm install &", PNPM, "install"},
{"pnpm install\npnpm run build", PNPM, "install"},
{"cd /tmp && echo 'foo && bar' && pnpm add zod", PNPM, "install"},
{"cd /tmp && echo \"foo; bar\" && yarn install", Yarn, "install"},
{"pnpm remove react && pnpm install", PNPM, "install"},
{"pnpm run build && pnpm publish", PNPM, "publish"},
{"pnpm audit && pnpm run build", PNPM, "audit"},
{"npx create-react-app foo && cd foo", NPX, "exec"},
}
for _, tc := range cases {
t.Run(tc.cmd, func(t *testing.T) {
d := Detect(tc.cmd)
if d == nil {
t.Fatalf("expected detection for %q", tc.cmd)
}
if d.Manager != tc.want {
t.Fatalf("manager: got %s want %s", d.Manager, tc.want)
}
if d.CommandKind != tc.kind {
t.Fatalf("kind: got %s want %s", d.CommandKind, tc.kind)
}
})
}
}

func TestDetectCompoundIgnoresUnrelated(t *testing.T) {
for _, cmd := range []string{
"cd /tmp && ls",
"git pull && cargo build",
"echo hi; echo bye",
} {
if d := Detect(cmd); d != nil {
t.Errorf("expected nil for %q, got %+v", cmd, d)
}
}
}

func TestConfidenceLabels(t *testing.T) {
if got := confidence(NPM); got != "high" {
t.Errorf("npm confidence: %s", got)
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat(aiagents): detect package install in compound shell commands by raysubham · Pull Request #89 · step-security/dev-machine-guard · GitHub
Skip to content
feat(aiagents): detect package install in compound shell commands#89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

raysubham
wants to merge
1
commit into

base:main
Choose a base branch

from

 Open


feat(aiagents): detect package install in compound shell commands
#89
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


102 changes: 102 additions & 0 deletions
internal/aiagents/enrich/npm/detect.go

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,7 +29,28 @@ type Detection struct {
}

// Detect parses cmd and returns the package-manager classification, or nil.
// Compound shell commands joined by &&, ||, ;, |, &, or newline are split into
// segments and each is classified independently; the strongest detection wins
// (install > uninstall > publish > audit > exec > other).
func Detect(cmd string) *Detection {
	segments := splitShellSegments(cmd)
	if len(segments) == 0 {
 segments = []string{cmd}
	}
	var best *Detection
	for _, seg := range segments {
 d := detectSegment(seg)
 if d == nil {
 continue
 }
 if best == nil || kindRank(d.CommandKind) > kindRank(best.CommandKind) {
 best = d
 }
	}
	return best
}

func detectSegment(cmd string) *Detection {
	tokens, err := shlex.Split(cmd)
	if err != nil || len(tokens) == 0 {
 // Fall back to whitespace split; shlex fails on unbalanced quotes.
Expand DownExpand Up@@ -60,6 +81,87 @@ func Detect(cmd string) *Detection {
	}
}

// splitShellSegments splits cmd at unquoted shell control operators
// (&&, ||, ;, |, &, newline). Single and double quotes are respected;
// backslash escapes the next byte outside single quotes.
func splitShellSegments(cmd string) []string {
	var (
 segments []string
 cur strings.Builder
 inSingle bool
 inDouble bool
	)
	flush := func() {
 s := strings.TrimSpace(cur.String())
 if s != "" {
 segments = append(segments, s)
 }
 cur.Reset()
	}
	for i := 0; i < len(cmd); i++ {
 c := cmd[i]
 if !inSingle && c == '\\' && i+1 < len(cmd) {
 cur.WriteByte(c)
 cur.WriteByte(cmd[i+1])
 i++
 continue
 }
 if !inDouble && c == '\'' {
 inSingle = !inSingle
 cur.WriteByte(c)
 continue
 }
 if !inSingle && c == '"' {
 inDouble = !inDouble
 cur.WriteByte(c)
 continue
 }
 if !inSingle && !inDouble {
 switch c {
 case '\n', ';':
 flush()
 continue
 case '&':
 if i+1 < len(cmd) && cmd[i+1] == '&' {
 flush()
 i++
 continue
 }
 flush()
 continue
 case '|':
 if i+1 < len(cmd) && cmd[i+1] == '|' {
 flush()
 i++
 continue
 }
 flush()
 continue
 }
 }
 cur.WriteByte(c)
	}
	flush()
	return segments
}

func kindRank(kind string) int {
	switch kind {
	case "install":
 return 6
	case "uninstall":
 return 5
	case "publish":
 return 4
	case "audit":
 return 3
	case "exec":
 return 2
	default:
 return 1
	}
}

func managerFromBinary(bin string) (Manager, bool) {
	switch bin {
	case "npm":
Expand Down

51 changes: 51 additions & 0 deletions
internal/aiagents/enrich/npm/detect_test.go

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -67,6 +67,57 @@ func TestDetectIgnoresUnrelatedCommands(t *testing.T) {
	}
}

func TestDetectCompoundCommands(t *testing.T) {
	cases := []struct {
 cmd string
 want Manager
 kind string
	}{
 {"cd /tmp/app && pnpm install && pnpm run build", PNPM, "install"},
 {"cd /tmp/app && pnpm install", PNPM, "install"},
 {"npm ci && npm run build", NPM, "install"},
 {"pnpm run build && pnpm install", PNPM, "install"},
 {"npx -y create-vite my-app && cd my-app && pnpm install", PNPM, "install"},
 {"echo hi; yarn add lodash", Yarn, "install"},
 {"pnpm install || echo failed", PNPM, "install"},
 {"cat package.json | jq . && pnpm i", PNPM, "install"},
 {"cd /tmp && pnpm install &", PNPM, "install"},
 {"pnpm install\npnpm run build", PNPM, "install"},
 {"cd /tmp && echo 'foo && bar' && pnpm add zod", PNPM, "install"},
 {"cd /tmp && echo \"foo; bar\" && yarn install", Yarn, "install"},
 {"pnpm remove react && pnpm install", PNPM, "install"},
 {"pnpm run build && pnpm publish", PNPM, "publish"},
 {"pnpm audit && pnpm run build", PNPM, "audit"},
 {"npx create-react-app foo && cd foo", NPX, "exec"},
	}
	for _, tc := range cases {
 t.Run(tc.cmd, func(t *testing.T) {
 d := Detect(tc.cmd)
 if d == nil {
 t.Fatalf("expected detection for %q", tc.cmd)
 }
 if d.Manager != tc.want {
 t.Fatalf("manager: got %s want %s", d.Manager, tc.want)
 }
 if d.CommandKind != tc.kind {
 t.Fatalf("kind: got %s want %s", d.CommandKind, tc.kind)
 }
 })
	}
}

func TestDetectCompoundIgnoresUnrelated(t *testing.T) {
	for _, cmd := range []string{
 "cd /tmp && ls",
 "git pull && cargo build",
 "echo hi; echo bye",
	} {
 if d := Detect(cmd); d != nil {
 t.Errorf("expected nil for %q, got %+v", cmd, d)
 }
	}
}

func TestConfidenceLabels(t *testing.T) {
	if got := confidence(NPM); got != "high" {
 t.Errorf("npm confidence: %s", got)
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(aiagents): detect package install in compound shell commands by raysubham · Pull Request #89 · step-security/dev-machine-guard · GitHub
Skip to content
feat(aiagents): detect package install in compound shell commands#89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

raysubham
wants to merge
1
commit into

base:main
Choose a base branch

from

 Open


feat(aiagents): detect package install in compound shell commands
#89
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


102 changes: 102 additions & 0 deletions
internal/aiagents/enrich/npm/detect.go

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,7 +29,28 @@ type Detection struct {
}

// Detect parses cmd and returns the package-manager classification, or nil.
// Compound shell commands joined by &&, ||, ;, |, &, or newline are split into
// segments and each is classified independently; the strongest detection wins
// (install > uninstall > publish > audit > exec > other).
func Detect(cmd string) *Detection {
	segments := splitShellSegments(cmd)
	if len(segments) == 0 {
 segments = []string{cmd}
	}
	var best *Detection
	for _, seg := range segments {
 d := detectSegment(seg)
 if d == nil {
 continue
 }
 if best == nil || kindRank(d.CommandKind) > kindRank(best.CommandKind) {
 best = d
 }
	}
	return best
}

func detectSegment(cmd string) *Detection {
	tokens, err := shlex.Split(cmd)
	if err != nil || len(tokens) == 0 {
 // Fall back to whitespace split; shlex fails on unbalanced quotes.
Expand DownExpand Up@@ -60,6 +81,87 @@ func Detect(cmd string) *Detection {
	}
}

// splitShellSegments splits cmd at unquoted shell control operators
// (&&, ||, ;, |, &, newline). Single and double quotes are respected;
// backslash escapes the next byte outside single quotes.
func splitShellSegments(cmd string) []string {
	var (
 segments []string
 cur strings.Builder
 inSingle bool
 inDouble bool
	)
	flush := func() {
 s := strings.TrimSpace(cur.String())
 if s != "" {
 segments = append(segments, s)
 }
 cur.Reset()
	}
	for i := 0; i < len(cmd); i++ {
 c := cmd[i]
 if !inSingle && c == '\\' && i+1 < len(cmd) {
 cur.WriteByte(c)
 cur.WriteByte(cmd[i+1])
 i++
 continue
 }
 if !inDouble && c == '\'' {
 inSingle = !inSingle
 cur.WriteByte(c)
 continue
 }
 if !inSingle && c == '"' {
 inDouble = !inDouble
 cur.WriteByte(c)
 continue
 }
 if !inSingle && !inDouble {
 switch c {
 case '\n', ';':
 flush()
 continue
 case '&':
 if i+1 < len(cmd) && cmd[i+1] == '&' {
 flush()
 i++
 continue
 }
 flush()
 continue
 case '|':
 if i+1 < len(cmd) && cmd[i+1] == '|' {
 flush()
 i++
 continue
 }
 flush()
 continue
 }
 }
 cur.WriteByte(c)
	}
	flush()
	return segments
}

func kindRank(kind string) int {
	switch kind {
	case "install":
 return 6
	case "uninstall":
 return 5
	case "publish":
 return 4
	case "audit":
 return 3
	case "exec":
 return 2
	default:
 return 1
	}
}

func managerFromBinary(bin string) (Manager, bool) {
	switch bin {
	case "npm":
Expand Down

51 changes: 51 additions & 0 deletions
internal/aiagents/enrich/npm/detect_test.go

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -67,6 +67,57 @@ func TestDetectIgnoresUnrelatedCommands(t *testing.T) {
	}
}

func TestDetectCompoundCommands(t *testing.T) {
	cases := []struct {
 cmd string
 want Manager
 kind string
	}{
 {"cd /tmp/app && pnpm install && pnpm run build", PNPM, "install"},
 {"cd /tmp/app && pnpm install", PNPM, "install"},
 {"npm ci && npm run build", NPM, "install"},
 {"pnpm run build && pnpm install", PNPM, "install"},
 {"npx -y create-vite my-app && cd my-app && pnpm install", PNPM, "install"},
 {"echo hi; yarn add lodash", Yarn, "install"},
 {"pnpm install || echo failed", PNPM, "install"},
 {"cat package.json | jq . && pnpm i", PNPM, "install"},
 {"cd /tmp && pnpm install &", PNPM, "install"},
 {"pnpm install\npnpm run build", PNPM, "install"},
 {"cd /tmp && echo 'foo && bar' && pnpm add zod", PNPM, "install"},
 {"cd /tmp && echo \"foo; bar\" && yarn install", Yarn, "install"},
 {"pnpm remove react && pnpm install", PNPM, "install"},
 {"pnpm run build && pnpm publish", PNPM, "publish"},
 {"pnpm audit && pnpm run build", PNPM, "audit"},
 {"npx create-react-app foo && cd foo", NPX, "exec"},
	}
	for _, tc := range cases {
 t.Run(tc.cmd, func(t *testing.T) {
 d := Detect(tc.cmd)
 if d == nil {
 t.Fatalf("expected detection for %q", tc.cmd)
 }
 if d.Manager != tc.want {
 t.Fatalf("manager: got %s want %s", d.Manager, tc.want)
 }
 if d.CommandKind != tc.kind {
 t.Fatalf("kind: got %s want %s", d.CommandKind, tc.kind)
 }
 })
	}
}

func TestDetectCompoundIgnoresUnrelated(t *testing.T) {
	for _, cmd := range []string{
 "cd /tmp && ls",
 "git pull && cargo build",
 "echo hi; echo bye",
	} {
 if d := Detect(cmd); d != nil {
 t.Errorf("expected nil for %q, got %+v", cmd, d)
 }
	}
}

func TestConfidenceLabels(t *testing.T) {
	if got := confidence(NPM); got != "high" {
 t.Errorf("npm confidence: %s", got)
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(aiagents): detect package install in compound shell commands by raysubham · Pull Request #89 · step-security/dev-machine-guard · GitHub
Skip to content
feat(aiagents): detect package install in compound shell commands#89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

raysubham
wants to merge
1
commit into

base:main
Choose a base branch

from

 Open


feat(aiagents): detect package install in compound shell commands
#89
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


102 changes: 102 additions & 0 deletions
internal/aiagents/enrich/npm/detect.go

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,7 +29,28 @@ type Detection struct {
}

// Detect parses cmd and returns the package-manager classification, or nil.
// Compound shell commands joined by &&, ||, ;, |, &, or newline are split into
// segments and each is classified independently; the strongest detection wins
// (install > uninstall > publish > audit > exec > other).
func Detect(cmd string) *Detection {
	segments := splitShellSegments(cmd)
	if len(segments) == 0 {
 segments = []string{cmd}
	}
	var best *Detection
	for _, seg := range segments {
 d := detectSegment(seg)
 if d == nil {
 continue
 }
 if best == nil || kindRank(d.CommandKind) > kindRank(best.CommandKind) {
 best = d
 }
	}
	return best
}

func detectSegment(cmd string) *Detection {
	tokens, err := shlex.Split(cmd)
	if err != nil || len(tokens) == 0 {
 // Fall back to whitespace split; shlex fails on unbalanced quotes.
Expand DownExpand Up@@ -60,6 +81,87 @@ func Detect(cmd string) *Detection {
	}
}

// splitShellSegments splits cmd at unquoted shell control operators
// (&&, ||, ;, |, &, newline). Single and double quotes are respected;
// backslash escapes the next byte outside single quotes.
func splitShellSegments(cmd string) []string {
	var (
 segments []string
 cur strings.Builder
 inSingle bool
 inDouble bool
	)
	flush := func() {
 s := strings.TrimSpace(cur.String())
 if s != "" {
 segments = append(segments, s)
 }
 cur.Reset()
	}
	for i := 0; i < len(cmd); i++ {
 c := cmd[i]
 if !inSingle && c == '\\' && i+1 < len(cmd) {
 cur.WriteByte(c)
 cur.WriteByte(cmd[i+1])
 i++
 continue
 }
 if !inDouble && c == '\'' {
 inSingle = !inSingle
 cur.WriteByte(c)
 continue
 }
 if !inSingle && c == '"' {
 inDouble = !inDouble
 cur.WriteByte(c)
 continue
 }
 if !inSingle && !inDouble {
 switch c {
 case '\n', ';':
 flush()
 continue
 case '&':
 if i+1 < len(cmd) && cmd[i+1] == '&' {
 flush()
 i++
 continue
 }
 flush()
 continue
 case '|':
 if i+1 < len(cmd) && cmd[i+1] == '|' {
 flush()
 i++
 continue
 }
 flush()
 continue
 }
 }
 cur.WriteByte(c)
	}
	flush()
	return segments
}

func kindRank(kind string) int {
	switch kind {
	case "install":
 return 6
	case "uninstall":
 return 5
	case "publish":
 return 4
	case "audit":
 return 3
	case "exec":
 return 2
	default:
 return 1
	}
}

func managerFromBinary(bin string) (Manager, bool) {
	switch bin {
	case "npm":
Expand Down

51 changes: 51 additions & 0 deletions
internal/aiagents/enrich/npm/detect_test.go

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -67,6 +67,57 @@ func TestDetectIgnoresUnrelatedCommands(t *testing.T) {
	}
}

func TestDetectCompoundCommands(t *testing.T) {
	cases := []struct {
 cmd string
 want Manager
 kind string
	}{
 {"cd /tmp/app && pnpm install && pnpm run build", PNPM, "install"},
 {"cd /tmp/app && pnpm install", PNPM, "install"},
 {"npm ci && npm run build", NPM, "install"},
 {"pnpm run build && pnpm install", PNPM, "install"},
 {"npx -y create-vite my-app && cd my-app && pnpm install", PNPM, "install"},
 {"echo hi; yarn add lodash", Yarn, "install"},
 {"pnpm install || echo failed", PNPM, "install"},
 {"cat package.json | jq . && pnpm i", PNPM, "install"},
 {"cd /tmp && pnpm install &", PNPM, "install"},
 {"pnpm install\npnpm run build", PNPM, "install"},
 {"cd /tmp && echo 'foo && bar' && pnpm add zod", PNPM, "install"},
 {"cd /tmp && echo \"foo; bar\" && yarn install", Yarn, "install"},
 {"pnpm remove react && pnpm install", PNPM, "install"},
 {"pnpm run build && pnpm publish", PNPM, "publish"},
 {"pnpm audit && pnpm run build", PNPM, "audit"},
 {"npx create-react-app foo && cd foo", NPX, "exec"},
	}
	for _, tc := range cases {
 t.Run(tc.cmd, func(t *testing.T) {
 d := Detect(tc.cmd)
 if d == nil {
 t.Fatalf("expected detection for %q", tc.cmd)
 }
 if d.Manager != tc.want {
 t.Fatalf("manager: got %s want %s", d.Manager, tc.want)
 }
 if d.CommandKind != tc.kind {
 t.Fatalf("kind: got %s want %s", d.CommandKind, tc.kind)
 }
 })
	}
}

func TestDetectCompoundIgnoresUnrelated(t *testing.T) {
	for _, cmd := range []string{
 "cd /tmp && ls",
 "git pull && cargo build",
 "echo hi; echo bye",
	} {
 if d := Detect(cmd); d != nil {
 t.Errorf("expected nil for %q, got %+v", cmd, d)
 }
	}
}

func TestConfidenceLabels(t *testing.T) {
	if got := confidence(NPM); got != "high" {
 t.Errorf("npm confidence: %s", got)
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
feat(aiagents): detect package install in compound shell commands by raysubham · Pull Request #89 · step-security/dev-machine-guard · GitHub
Skip to content
feat(aiagents): detect package install in compound shell commands#89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

raysubham
wants to merge
1
commit into

base:main
Choose a base branch

from

 Open


feat(aiagents): detect package install in compound shell commands
#89
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


102 changes: 102 additions & 0 deletions
internal/aiagents/enrich/npm/detect.go

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,7 +29,28 @@ type Detection struct {
}

// Detect parses cmd and returns the package-manager classification, or nil.
// Compound shell commands joined by &&, ||, ;, |, &, or newline are split into
// segments and each is classified independently; the strongest detection wins
// (install > uninstall > publish > audit > exec > other).
func Detect(cmd string) *Detection {
	segments := splitShellSegments(cmd)
	if len(segments) == 0 {
 segments = []string{cmd}
	}
	var best *Detection
	for _, seg := range segments {
 d := detectSegment(seg)
 if d == nil {
 continue
 }
 if best == nil || kindRank(d.CommandKind) > kindRank(best.CommandKind) {
 best = d
 }
	}
	return best
}

func detectSegment(cmd string) *Detection {
	tokens, err := shlex.Split(cmd)
	if err != nil || len(tokens) == 0 {
 // Fall back to whitespace split; shlex fails on unbalanced quotes.
Expand DownExpand Up@@ -60,6 +81,87 @@ func Detect(cmd string) *Detection {
	}
}

// splitShellSegments splits cmd at unquoted shell control operators
// (&&, ||, ;, |, &, newline). Single and double quotes are respected;
// backslash escapes the next byte outside single quotes.
func splitShellSegments(cmd string) []string {
	var (
 segments []string
 cur strings.Builder
 inSingle bool
 inDouble bool
	)
	flush := func() {
 s := strings.TrimSpace(cur.String())
 if s != "" {
 segments = append(segments, s)
 }
 cur.Reset()
	}
	for i := 0; i < len(cmd); i++ {
 c := cmd[i]
 if !inSingle && c == '\\' && i+1 < len(cmd) {
 cur.WriteByte(c)
 cur.WriteByte(cmd[i+1])
 i++
 continue
 }
 if !inDouble && c == '\'' {
 inSingle = !inSingle
 cur.WriteByte(c)
 continue
 }
 if !inSingle && c == '"' {
 inDouble = !inDouble
 cur.WriteByte(c)
 continue
 }
 if !inSingle && !inDouble {
 switch c {
 case '\n', ';':
 flush()
 continue
 case '&':
 if i+1 < len(cmd) && cmd[i+1] == '&' {
 flush()
 i++
 continue
 }
 flush()
 continue
 case '|':
 if i+1 < len(cmd) && cmd[i+1] == '|' {
 flush()
 i++
 continue
 }
 flush()
 continue
 }
 }
 cur.WriteByte(c)
	}
	flush()
	return segments
}

func kindRank(kind string) int {
	switch kind {
	case "install":
 return 6
	case "uninstall":
 return 5
	case "publish":
 return 4
	case "audit":
 return 3
	case "exec":
 return 2
	default:
 return 1
	}
}

func managerFromBinary(bin string) (Manager, bool) {
	switch bin {
	case "npm":
Expand Down

51 changes: 51 additions & 0 deletions
internal/aiagents/enrich/npm/detect_test.go

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -67,6 +67,57 @@ func TestDetectIgnoresUnrelatedCommands(t *testing.T) {
	}
}

func TestDetectCompoundCommands(t *testing.T) {
	cases := []struct {
 cmd string
 want Manager
 kind string
	}{
 {"cd /tmp/app && pnpm install && pnpm run build", PNPM, "install"},
 {"cd /tmp/app && pnpm install", PNPM, "install"},
 {"npm ci && npm run build", NPM, "install"},
 {"pnpm run build && pnpm install", PNPM, "install"},
 {"npx -y create-vite my-app && cd my-app && pnpm install", PNPM, "install"},
 {"echo hi; yarn add lodash", Yarn, "install"},
 {"pnpm install || echo failed", PNPM, "install"},
 {"cat package.json | jq . && pnpm i", PNPM, "install"},
 {"cd /tmp && pnpm install &", PNPM, "install"},
 {"pnpm install\npnpm run build", PNPM, "install"},
 {"cd /tmp && echo 'foo && bar' && pnpm add zod", PNPM, "install"},
 {"cd /tmp && echo \"foo; bar\" && yarn install", Yarn, "install"},
 {"pnpm remove react && pnpm install", PNPM, "install"},
 {"pnpm run build && pnpm publish", PNPM, "publish"},
 {"pnpm audit && pnpm run build", PNPM, "audit"},
 {"npx create-react-app foo && cd foo", NPX, "exec"},
	}
	for _, tc := range cases {
 t.Run(tc.cmd, func(t *testing.T) {
 d := Detect(tc.cmd)
 if d == nil {
 t.Fatalf("expected detection for %q", tc.cmd)
 }
 if d.Manager != tc.want {
 t.Fatalf("manager: got %s want %s", d.Manager, tc.want)
 }
 if d.CommandKind != tc.kind {
 t.Fatalf("kind: got %s want %s", d.CommandKind, tc.kind)
 }
 })
	}
}

func TestDetectCompoundIgnoresUnrelated(t *testing.T) {
	for _, cmd := range []string{
 "cd /tmp && ls",
 "git pull && cargo build",
 "echo hi; echo bye",
	} {
 if d := Detect(cmd); d != nil {
 t.Errorf("expected nil for %q, got %+v", cmd, d)
 }
	}
}

func TestConfidenceLabels(t *testing.T) {
	if got := confidence(NPM); got != "high" {
 t.Errorf("npm confidence: %s", got)
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(aiagents): detect package install in compound shell commands by raysubham · Pull Request #89 · step-security/dev-machine-guard · GitHub
Skip to content
feat(aiagents): detect package install in compound shell commands#89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

raysubham
wants to merge
1
commit into

base:main
Choose a base branch

from

 Open


feat(aiagents): detect package install in compound shell commands
#89
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


102 changes: 102 additions & 0 deletions
internal/aiagents/enrich/npm/detect.go

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,7 +29,28 @@ type Detection struct {
}

// Detect parses cmd and returns the package-manager classification, or nil.
// Compound shell commands joined by &&, ||, ;, |, &, or newline are split into
// segments and each is classified independently; the strongest detection wins
// (install > uninstall > publish > audit > exec > other).
func Detect(cmd string) *Detection {
	segments := splitShellSegments(cmd)
	if len(segments) == 0 {
 segments = []string{cmd}
	}
	var best *Detection
	for _, seg := range segments {
 d := detectSegment(seg)
 if d == nil {
 continue
 }
 if best == nil || kindRank(d.CommandKind) > kindRank(best.CommandKind) {
 best = d
 }
	}
	return best
}

func detectSegment(cmd string) *Detection {
	tokens, err := shlex.Split(cmd)
	if err != nil || len(tokens) == 0 {
 // Fall back to whitespace split; shlex fails on unbalanced quotes.
Expand DownExpand Up@@ -60,6 +81,87 @@ func Detect(cmd string) *Detection {
	}
}

// splitShellSegments splits cmd at unquoted shell control operators
// (&&, ||, ;, |, &, newline). Single and double quotes are respected;
// backslash escapes the next byte outside single quotes.
func splitShellSegments(cmd string) []string {
	var (
 segments []string
 cur strings.Builder
 inSingle bool
 inDouble bool
	)
	flush := func() {
 s := strings.TrimSpace(cur.String())
 if s != "" {
 segments = append(segments, s)
 }
 cur.Reset()
	}
	for i := 0; i < len(cmd); i++ {
 c := cmd[i]
 if !inSingle && c == '\\' && i+1 < len(cmd) {
 cur.WriteByte(c)
 cur.WriteByte(cmd[i+1])
 i++
 continue
 }
 if !inDouble && c == '\'' {
 inSingle = !inSingle
 cur.WriteByte(c)
 continue
 }
 if !inSingle && c == '"' {
 inDouble = !inDouble
 cur.WriteByte(c)
 continue
 }
 if !inSingle && !inDouble {
 switch c {
 case '\n', ';':
 flush()
 continue
 case '&':
 if i+1 < len(cmd) && cmd[i+1] == '&' {
 flush()
 i++
 continue
 }
 flush()
 continue
 case '|':
 if i+1 < len(cmd) && cmd[i+1] == '|' {
 flush()
 i++
 continue
 }
 flush()
 continue
 }
 }
 cur.WriteByte(c)
	}
	flush()
	return segments
}

func kindRank(kind string) int {
	switch kind {
	case "install":
 return 6
	case "uninstall":
 return 5
	case "publish":
 return 4
	case "audit":
 return 3
	case "exec":
 return 2
	default:
 return 1
	}
}

func managerFromBinary(bin string) (Manager, bool) {
	switch bin {
	case "npm":
Expand Down

51 changes: 51 additions & 0 deletions
internal/aiagents/enrich/npm/detect_test.go

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -67,6 +67,57 @@ func TestDetectIgnoresUnrelatedCommands(t *testing.T) {
	}
}

func TestDetectCompoundCommands(t *testing.T) {
	cases := []struct {
 cmd string
 want Manager
 kind string
	}{
 {"cd /tmp/app && pnpm install && pnpm run build", PNPM, "install"},
 {"cd /tmp/app && pnpm install", PNPM, "install"},
 {"npm ci && npm run build", NPM, "install"},
 {"pnpm run build && pnpm install", PNPM, "install"},
 {"npx -y create-vite my-app && cd my-app && pnpm install", PNPM, "install"},
 {"echo hi; yarn add lodash", Yarn, "install"},
 {"pnpm install || echo failed", PNPM, "install"},
 {"cat package.json | jq . && pnpm i", PNPM, "install"},
 {"cd /tmp && pnpm install &", PNPM, "install"},
 {"pnpm install\npnpm run build", PNPM, "install"},
 {"cd /tmp && echo 'foo && bar' && pnpm add zod", PNPM, "install"},
 {"cd /tmp && echo \"foo; bar\" && yarn install", Yarn, "install"},
 {"pnpm remove react && pnpm install", PNPM, "install"},
 {"pnpm run build && pnpm publish", PNPM, "publish"},
 {"pnpm audit && pnpm run build", PNPM, "audit"},
 {"npx create-react-app foo && cd foo", NPX, "exec"},
	}
	for _, tc := range cases {
 t.Run(tc.cmd, func(t *testing.T) {
 d := Detect(tc.cmd)
 if d == nil {
 t.Fatalf("expected detection for %q", tc.cmd)
 }
 if d.Manager != tc.want {
 t.Fatalf("manager: got %s want %s", d.Manager, tc.want)
 }
 if d.CommandKind != tc.kind {
 t.Fatalf("kind: got %s want %s", d.CommandKind, tc.kind)
 }
 })
	}
}

func TestDetectCompoundIgnoresUnrelated(t *testing.T) {
	for _, cmd := range []string{
 "cd /tmp && ls",
 "git pull && cargo build",
 "echo hi; echo bye",
	} {
 if d := Detect(cmd); d != nil {
 t.Errorf("expected nil for %q, got %+v", cmd, d)
 }
	}
}

func TestConfidenceLabels(t *testing.T) {
	if got := confidence(NPM); got != "high" {
 t.Errorf("npm confidence: %s", got)
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(aiagents): detect package install in compound shell commands by raysubham · Pull Request #89 · step-security/dev-machine-guard · GitHub
Skip to content
feat(aiagents): detect package install in compound shell commands#89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

raysubham
wants to merge
1
commit into

base:main
Choose a base branch

from

 Open


feat(aiagents): detect package install in compound shell commands
#89
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


102 changes: 102 additions & 0 deletions
internal/aiagents/enrich/npm/detect.go

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,7 +29,28 @@ type Detection struct {
}

// Detect parses cmd and returns the package-manager classification, or nil.
// Compound shell commands joined by &&, ||, ;, |, &, or newline are split into
// segments and each is classified independently; the strongest detection wins
// (install > uninstall > publish > audit > exec > other).
func Detect(cmd string) *Detection {
	segments := splitShellSegments(cmd)
	if len(segments) == 0 {
 segments = []string{cmd}
	}
	var best *Detection
	for _, seg := range segments {
 d := detectSegment(seg)
 if d == nil {
 continue
 }
 if best == nil || kindRank(d.CommandKind) > kindRank(best.CommandKind) {
 best = d
 }
	}
	return best
}

func detectSegment(cmd string) *Detection {
	tokens, err := shlex.Split(cmd)
	if err != nil || len(tokens) == 0 {
 // Fall back to whitespace split; shlex fails on unbalanced quotes.
Expand DownExpand Up@@ -60,6 +81,87 @@ func Detect(cmd string) *Detection {
	}
}

// splitShellSegments splits cmd at unquoted shell control operators
// (&&, ||, ;, |, &, newline). Single and double quotes are respected;
// backslash escapes the next byte outside single quotes.
func splitShellSegments(cmd string) []string {
	var (
 segments []string
 cur strings.Builder
 inSingle bool
 inDouble bool
	)
	flush := func() {
 s := strings.TrimSpace(cur.String())
 if s != "" {
 segments = append(segments, s)
 }
 cur.Reset()
	}
	for i := 0; i < len(cmd); i++ {
 c := cmd[i]
 if !inSingle && c == '\\' && i+1 < len(cmd) {
 cur.WriteByte(c)
 cur.WriteByte(cmd[i+1])
 i++
 continue
 }
 if !inDouble && c == '\'' {
 inSingle = !inSingle
 cur.WriteByte(c)
 continue
 }
 if !inSingle && c == '"' {
 inDouble = !inDouble
 cur.WriteByte(c)
 continue
 }
 if !inSingle && !inDouble {
 switch c {
 case '\n', ';':
 flush()
 continue
 case '&':
 if i+1 < len(cmd) && cmd[i+1] == '&' {
 flush()
 i++
 continue
 }
 flush()
 continue
 case '|':
 if i+1 < len(cmd) && cmd[i+1] == '|' {
 flush()
 i++
 continue
 }
 flush()
 continue
 }
 }
 cur.WriteByte(c)
	}
	flush()
	return segments
}

func kindRank(kind string) int {
	switch kind {
	case "install":
 return 6
	case "uninstall":
 return 5
	case "publish":
 return 4
	case "audit":
 return 3
	case "exec":
 return 2
	default:
 return 1
	}
}

func managerFromBinary(bin string) (Manager, bool) {
	switch bin {
	case "npm":
Expand Down

51 changes: 51 additions & 0 deletions
internal/aiagents/enrich/npm/detect_test.go

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -67,6 +67,57 @@ func TestDetectIgnoresUnrelatedCommands(t *testing.T) {
	}
}

func TestDetectCompoundCommands(t *testing.T) {
	cases := []struct {
 cmd string
 want Manager
 kind string
	}{
 {"cd /tmp/app && pnpm install && pnpm run build", PNPM, "install"},
 {"cd /tmp/app && pnpm install", PNPM, "install"},
 {"npm ci && npm run build", NPM, "install"},
 {"pnpm run build && pnpm install", PNPM, "install"},
 {"npx -y create-vite my-app && cd my-app && pnpm install", PNPM, "install"},
 {"echo hi; yarn add lodash", Yarn, "install"},
 {"pnpm install || echo failed", PNPM, "install"},
 {"cat package.json | jq . && pnpm i", PNPM, "install"},
 {"cd /tmp && pnpm install &", PNPM, "install"},
 {"pnpm install\npnpm run build", PNPM, "install"},
 {"cd /tmp && echo 'foo && bar' && pnpm add zod", PNPM, "install"},
 {"cd /tmp && echo \"foo; bar\" && yarn install", Yarn, "install"},
 {"pnpm remove react && pnpm install", PNPM, "install"},
 {"pnpm run build && pnpm publish", PNPM, "publish"},
 {"pnpm audit && pnpm run build", PNPM, "audit"},
 {"npx create-react-app foo && cd foo", NPX, "exec"},
	}
	for _, tc := range cases {
 t.Run(tc.cmd, func(t *testing.T) {
 d := Detect(tc.cmd)
 if d == nil {
 t.Fatalf("expected detection for %q", tc.cmd)
 }
 if d.Manager != tc.want {
 t.Fatalf("manager: got %s want %s", d.Manager, tc.want)
 }
 if d.CommandKind != tc.kind {
 t.Fatalf("kind: got %s want %s", d.CommandKind, tc.kind)
 }
 })
	}
}

func TestDetectCompoundIgnoresUnrelated(t *testing.T) {
	for _, cmd := range []string{
 "cd /tmp && ls",
 "git pull && cargo build",
 "echo hi; echo bye",
	} {
 if d := Detect(cmd); d != nil {
 t.Errorf("expected nil for %q, got %+v", cmd, d)
 }
	}
}

func TestConfidenceLabels(t *testing.T) {
	if got := confidence(NPM); got != "high" {
 t.Errorf("npm confidence: %s", got)
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
feat(aiagents): detect package install in compound shell commands by raysubham · Pull Request #89 · step-security/dev-machine-guard · GitHub
Skip to content
feat(aiagents): detect package install in compound shell commands#89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

raysubham
wants to merge
1
commit into

base:main
Choose a base branch

from

 Open


feat(aiagents): detect package install in compound shell commands
#89
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


102 changes: 102 additions & 0 deletions
internal/aiagents/enrich/npm/detect.go

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,7 +29,28 @@ type Detection struct {
}

// Detect parses cmd and returns the package-manager classification, or nil.
// Compound shell commands joined by &&, ||, ;, |, &, or newline are split into
// segments and each is classified independently; the strongest detection wins
// (install > uninstall > publish > audit > exec > other).
func Detect(cmd string) *Detection {
	segments := splitShellSegments(cmd)
	if len(segments) == 0 {
 segments = []string{cmd}
	}
	var best *Detection
	for _, seg := range segments {
 d := detectSegment(seg)
 if d == nil {
 continue
 }
 if best == nil || kindRank(d.CommandKind) > kindRank(best.CommandKind) {
 best = d
 }
	}
	return best
}

func detectSegment(cmd string) *Detection {
	tokens, err := shlex.Split(cmd)
	if err != nil || len(tokens) == 0 {
 // Fall back to whitespace split; shlex fails on unbalanced quotes.
Expand DownExpand Up@@ -60,6 +81,87 @@ func Detect(cmd string) *Detection {
	}
}

// splitShellSegments splits cmd at unquoted shell control operators
// (&&, ||, ;, |, &, newline). Single and double quotes are respected;
// backslash escapes the next byte outside single quotes.
func splitShellSegments(cmd string) []string {
	var (
 segments []string
 cur strings.Builder
 inSingle bool
 inDouble bool
	)
	flush := func() {
 s := strings.TrimSpace(cur.String())
 if s != "" {
 segments = append(segments, s)
 }
 cur.Reset()
	}
	for i := 0; i < len(cmd); i++ {
 c := cmd[i]
 if !inSingle && c == '\\' && i+1 < len(cmd) {
 cur.WriteByte(c)
 cur.WriteByte(cmd[i+1])
 i++
 continue
 }
 if !inDouble && c == '\'' {
 inSingle = !inSingle
 cur.WriteByte(c)
 continue
 }
 if !inSingle && c == '"' {
 inDouble = !inDouble
 cur.WriteByte(c)
 continue
 }
 if !inSingle && !inDouble {
 switch c {
 case '\n', ';':
 flush()
 continue
 case '&':
 if i+1 < len(cmd) && cmd[i+1] == '&' {
 flush()
 i++
 continue
 }
 flush()
 continue
 case '|':
 if i+1 < len(cmd) && cmd[i+1] == '|' {
 flush()
 i++
 continue
 }
 flush()
 continue
 }
 }
 cur.WriteByte(c)
	}
	flush()
	return segments
}

func kindRank(kind string) int {
	switch kind {
	case "install":
 return 6
	case "uninstall":
 return 5
	case "publish":
 return 4
	case "audit":
 return 3
	case "exec":
 return 2
	default:
 return 1
	}
}

func managerFromBinary(bin string) (Manager, bool) {
	switch bin {
	case "npm":
Expand Down

51 changes: 51 additions & 0 deletions
internal/aiagents/enrich/npm/detect_test.go

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -67,6 +67,57 @@ func TestDetectIgnoresUnrelatedCommands(t *testing.T) {
	}
}

func TestDetectCompoundCommands(t *testing.T) {
	cases := []struct {
 cmd string
 want Manager
 kind string
	}{
 {"cd /tmp/app && pnpm install && pnpm run build", PNPM, "install"},
 {"cd /tmp/app && pnpm install", PNPM, "install"},
 {"npm ci && npm run build", NPM, "install"},
 {"pnpm run build && pnpm install", PNPM, "install"},
 {"npx -y create-vite my-app && cd my-app && pnpm install", PNPM, "install"},
 {"echo hi; yarn add lodash", Yarn, "install"},
 {"pnpm install || echo failed", PNPM, "install"},
 {"cat package.json | jq . && pnpm i", PNPM, "install"},
 {"cd /tmp && pnpm install &", PNPM, "install"},
 {"pnpm install\npnpm run build", PNPM, "install"},
 {"cd /tmp && echo 'foo && bar' && pnpm add zod", PNPM, "install"},
 {"cd /tmp && echo \"foo; bar\" && yarn install", Yarn, "install"},
 {"pnpm remove react && pnpm install", PNPM, "install"},
 {"pnpm run build && pnpm publish", PNPM, "publish"},
 {"pnpm audit && pnpm run build", PNPM, "audit"},
 {"npx create-react-app foo && cd foo", NPX, "exec"},
	}
	for _, tc := range cases {
 t.Run(tc.cmd, func(t *testing.T) {
 d := Detect(tc.cmd)
 if d == nil {
 t.Fatalf("expected detection for %q", tc.cmd)
 }
 if d.Manager != tc.want {
 t.Fatalf("manager: got %s want %s", d.Manager, tc.want)
 }
 if d.CommandKind != tc.kind {
 t.Fatalf("kind: got %s want %s", d.CommandKind, tc.kind)
 }
 })
	}
}

func TestDetectCompoundIgnoresUnrelated(t *testing.T) {
	for _, cmd := range []string{
 "cd /tmp && ls",
 "git pull && cargo build",
 "echo hi; echo bye",
	} {
 if d := Detect(cmd); d != nil {
 t.Errorf("expected nil for %q, got %+v", cmd, d)
 }
	}
}

func TestConfidenceLabels(t *testing.T) {
	if got := confidence(NPM); got != "high" {
 t.Errorf("npm confidence: %s", got)
Expand Down
Loading